[PATCH] common: Fix parsing SS control string

It's not possible to be both greater than '9' and less than '0'. This would lead to accepting things like #$33# as activation and *$33# as deactivation, even though the string makes no sense. --- src/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common.c

Re: [PATCH] common: Fix parsing SS control string

On Wed, May 22, 2013 at 6:28 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: It's not possible to be both greater than '9' and less than '0'. This would lead to accepting things like #$33# as activation and *$33# as deactivation, even though the string makes no sense. --- src

[PATCH 2/2] gitignore: Ignore file generated by Automake 1.13

Automake = 1.13 enables parallel-tests option by default which uses a test-driver script (copied by automake). Ignore this file and the files generated by this script. --- .gitignore | 4 1 file changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index 91668c7..b9c23a0 100644 ---

[PATCH 1/2] stk: Fix sizeof on memcpy

src/stk.c: In function ‘__ofono_cbs_sim_download’: src/stk.c:283:45: error: argument to ‘sizeof’ in ‘memcpy’ call is the same expression as the source; did you mean to dereference it? [-Werror=sizeof-pointer-memaccess] memcpy(e.cbs_pp_download.page, msg, sizeof(msg));

[PATCH mmsd 2/3] build: Do not use deprecated AM_CONFIG_HEADER

The long-obsoleted AM_CONFIG_HEADER macro was removed in automake 1.13. Use AC_CONFIG_HEADERS instead. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6b5e1b1..dd8e93a 100644 --- a/configure.ac +++ b/configure.ac @@ -2,7 +2,7

[PATCH mmsd 3/3] build: Use AM_CPPFLAGS instead of INCLUDES

Makefile.am:49: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index f802388..ee2c715 100644 --- a/Makefile.am +++ b/Makefile.am @@ -46,7 +46,7 @@ AM_CFLAGS =

[PATCH 1/3] build: Do not use deprecated AM_CONFIG_HEADER

The long-obsoleted AM_CONFIG_HEADER macro was removed in automake 1.13. Use AC_CONFIG_HEADERS instead. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 7db4198..a4a350f 100644 --- a/configure.ac +++ b/configure.ac @@ -2,7 +2,7

[PATCH 2/3] build: Use AM_CPPFLAGS instead of INCLUDES

Makefile.am:518: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index ad12c0f..f24cac7 100644 --- a/Makefile.am +++ b/Makefile.am @@ -528,7 +528,7 @@ AM_CFLAGS =

[PATCH 3/3] storage: Include sys/types.h for ssize_t

src/storage.h:32:1: error: unknown type name 'ssize_t' src/storage.h:36:1: error: unknown type name 'ssize_t' --- src/storage.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/storage.h b/src/storage.h index c455bae..70446ad 100644 --- a/src/storage.h +++ b/src/storage.h @@ -26,6 +26,7 @@

[PATCH mmsd 1/3] README: add information about mailing list

--- README | 6 ++ 1 file changed, 6 insertions(+) diff --git a/README b/README index e33be69..fdfeafb 100644 --- a/README +++ b/README @@ -19,3 +19,9 @@ Configure automatically searches for all required components and packages. To compile and install run: make make install +

[PATCH mmsd 2/3] build: Do not use deprecated AM_CONFIG_HEADER

The long-obsoleted AM_CONFIG_HEADER macro was removed in automake 1.13. Use AC_CONFIG_HEADERS instead. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 6b5e1b1..dd8e93a 100644 --- a/configure.ac +++ b/configure.ac @@ -2,7 +2,7

[PATCH mmsd 3/3] build: Use AM_CPPFLAGS instead of INCLUDES

Makefile.am:49: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index f802388..ee2c715 100644 --- a/Makefile.am +++ b/Makefile.am @@ -46,7 +46,7 @@ AM_CFLAGS =

[PATCH 1/4] build: Do not use deprecated AM_CONFIG_HEADER

The long-obsoleted AM_CONFIG_HEADER macro was removed in automake 1.13. Use AC_CONFIG_HEADERS instead. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 2d6247d..badbf9b 100644 --- a/configure.ac +++ b/configure.ac @@ -2,7 +2,7

[PATCH 2/4] build: Do not use the deprecated AM_PROG_MKDIR_P

configure.ac:25: warning: The 'AM_PROG_MKDIR_P' macro is deprecated, and will soon be removed. configure.ac:25: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead, configure.ac:25: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files. We were already using

[PATCH 3/4] build: Use AM_CPPFLAGS instead of INCLUDES

Makefile.am:518: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 40a83dc..86a1f30 100644 --- a/Makefile.am +++ b/Makefile.am @@ -515,7 +515,7 @@ AM_CFLAGS =

[PATCH 4/4] storage: Include sys/types.h for ssize_t

src/storage.h:32:1: error: unknown type name 'ssize_t' src/storage.h:36:1: error: unknown type name 'ssize_t' --- src/storage.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/storage.h b/src/storage.h index c455bae..70446ad 100644 --- a/src/storage.h +++ b/src/storage.h @@ -26,6 +26,7 @@

[PATCH 0/3] gdbus patches

These patches were applied to BlueZ repository. Please, have a look and apply them on other projects. Johan Hedberg (1): gdbus: Fix crash when getting disconnected from the bus Lucas De Marchi (2): gdbus: Fix wrong signal handler match gdbus: Refactor filter_data_find() gdbus/mainloop.c

[PATCH 1/3] gdbus: Fix crash when getting disconnected from the bus

From: Johan Hedberg johan.hedb...@intel.com When getting disconnected from the bus sometimes (maybe always?) dbus_watch_handle() can cause the info context to be free'd meaning that we should not try to access it after the call. The only member we need access to is the connection pointer and as

[PATCH 2/3] gdbus: Fix wrong signal handler match

When we add a signal handler with g_dbus_add_signal_watch(), this function tries to multiplex the matches added in libdbus by checking if there's a previous filter_data with the same fields. However, if the field is NULL it accepts as being the same. The result is that the following watches will

[PATCH 3/3] gdbus: Refactor filter_data_find()

Now this function is only used for searching the listeners of a connection and the other parameters are not needed anymore. --- gdbus/watch.c | 43 +-- 1 file changed, 5 insertions(+), 38 deletions(-) diff --git a/gdbus/watch.c b/gdbus/watch.c index

Re: [RFC] HFP support into oFono and BlueZ

to this list. Applications developers don't have to parse the AT commands by themselves but rather use a telephony stack that implements the DBus APIs. This is kind of an agent (as in the pairing process) that anyone could implement. oFono implements it, so it's 1 option. Lucas De Marchi

[PATCH 3/4] stemgr: watch for signals only on MGR_SERVICE

--- plugins/stemgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/stemgr.c b/plugins/stemgr.c index 126ec4e..7e434d3 100644 --- a/plugins/stemgr.c +++ b/plugins/stemgr.c @@ -337,8 +337,8 @@ static gboolean property_changed(DBusConnection *connection, static

[PATCH 0/4] Add bus name to signal watches

First patch is just one that was still pending locally. The other ones fix the calls to g_dbus_add_signal_watch() to actually watch only the desired bus. It depends on previous patch for gdbus to be applied first, otherwise libdbus may call abort() when we exit. Lucas De Marchi (4): README: add

[PATCH 2/4] bluetooth: watch for signals only on BLUEZ_SERVICE

--- plugins/bluetooth.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c index cb5fe24..91c8d18 100644 --- a/plugins/bluetooth.c +++ b/plugins/bluetooth.c @@ -840,22 +840,25 @@ static void bluetooth_ref(void)

Re: [PATCH 3/3] doc: Add new D-Bus methods to service interface

) Could we mark these as [TODO], so we don't get confused while reading the doc + code and realizing they don't match? Lucas De Marchi ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH 01/12] Constify GDBus method tables

From: Henrique Dante de Almeida hda...@profusion.mobi Constify method tables with the following command: find . -name '*.[ch]' -exec \ sed -i 's/\(GDBusMethodTable .* =\)/const \1/g' {} \; --- plugins/hfp_hf.c|2 +- plugins/push-notification.c |2 +-

[PATCH 02/12] Constify GDBus signal tables

From: Henrique Dante de Almeida hda...@profusion.mobi Constify signal tables with the following command: find . -name '*.[ch]' -exec \ sed -i 's/\(GDBusSignalTable .* =\)/const \1/g' {} \; --- src/audio-settings.c |2 +- src/call-barring.c |2 +-

[PATCH 03/12] gdbus: add argument info to methods and signals

--- gdbus/gdbus.h |8 1 file changed, 8 insertions(+) diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h index a0583e6..e5e7938 100644 --- a/gdbus/gdbus.h +++ b/gdbus/gdbus.h @@ -85,16 +85,24 @@ typedef enum { typedef struct { const char *name; const char *signature; +}

[PATCH 05/12] Convert GDBus methods to use macro helpers

With these macro helpers we can separate in/out arguments and use their own vector. --- plugins/hfp_hf.c|9 +++-- plugins/push-notification.c |8 +++- plugins/smart-messaging.c | 21 +++--- src/audio-settings.c|8 ++-- src/call-barring.c | 34

[PATCH 06/12] gdbus: use GDBusArgInfo to generate introspection

By using GDBusArgInfo in methods and signals, the introspection generation is much simpler and we can add each argument name. --- gdbus/object.c | 75 +++- 1 file changed, 14 insertions(+), 61 deletions(-) diff --git a/gdbus/object.c

[PATCH 07/12] gdbus: loop over args to check message signature

--- gdbus/object.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/gdbus/object.c b/gdbus/object.c index 3ac6a0b..b187bb5 100644 --- a/gdbus/object.c +++ b/gdbus/object.c @@ -374,6 +374,27 @@ static struct interface_data

[PATCH 09/12] gdbus: remove signature and reply from tables

--- gdbus/gdbus.h | 60 gdbus/object.c |2 +- 2 files changed, 1 insertion(+), 61 deletions(-) diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h index 868c8d5..0a8a27c 100644 --- a/gdbus/gdbus.h +++ b/gdbus/gdbus.h @@ -89,8 +89,6 @@

[PATCH 11/12] gdbus: add Method.NoReply annotation in introspection

--- gdbus/object.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gdbus/object.c b/gdbus/object.c index 95947f3..dacbe58 100644 --- a/gdbus/object.c +++ b/gdbus/object.c @@ -84,8 +84,10 @@ static void generate_interface_xml(GString *gstr, struct interface_data

[PATCH 12/12] gdbus: do not check signature twice

Message signature is already checked in generic_message(), so there's no need to check again in the callback. --- gdbus/object.c |5 - 1 file changed, 5 deletions(-) diff --git a/gdbus/object.c b/gdbus/object.c index dacbe58..2dd7c0e 100644 --- a/gdbus/object.c +++ b/gdbus/object.c @@

[PATCH mmsd 02/12] gdbus: add argument info to methods and signals

--- gdbus/gdbus.h |8 1 file changed, 8 insertions(+) diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h index a0583e6..e5e7938 100644 --- a/gdbus/gdbus.h +++ b/gdbus/gdbus.h @@ -85,16 +85,24 @@ typedef enum { typedef struct { const char *name; const char *signature; +}

[PATCH mmsd 04/12] gdbus: add macro for methods marked as NOREPLY

--- gdbus/gdbus.h | 16 1 file changed, 16 insertions(+) diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h index 8354633..868c8d5 100644 --- a/gdbus/gdbus.h +++ b/gdbus/gdbus.h @@ -155,6 +155,15 @@ typedef struct { .function = _function, \ .flags =

[PATCH mmsd 05/12] Convert GDBus methods to use macro helpers

With these macro helpers we can separate in/out arguments and use their own vector. --- plugins/ofono.c |8 +--- src/service.c | 40 +--- 2 files changed, 34 insertions(+), 14 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index

[PATCH mmsd 07/12] gdbus: loop over args to check message signature

--- gdbus/object.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/gdbus/object.c b/gdbus/object.c index 3ac6a0b..b187bb5 100644 --- a/gdbus/object.c +++ b/gdbus/object.c @@ -374,6 +374,27 @@ static struct interface_data

[PATCH mmsd 08/12] Do not set signature and reply in GDBus tables

Use GDBUS_* macros, so signature and reply fields are not set in each method/signal. --- plugins/ofono.c |4 ++-- src/service.c | 25 +++-- 2 files changed, 13 insertions(+), 16 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index fcdb228..45fac91 100644

[PATCH mmsd 09/12] gdbus: remove signature and reply from tables

--- gdbus/gdbus.h | 60 gdbus/object.c |2 +- 2 files changed, 1 insertion(+), 61 deletions(-) diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h index 868c8d5..0a8a27c 100644 --- a/gdbus/gdbus.h +++ b/gdbus/gdbus.h @@ -89,8 +89,6 @@

[PATCH mmsd 10/12] gdbus: add Deprecated annotation in introspection

--- gdbus/object.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/gdbus/object.c b/gdbus/object.c index fcdd6ec..95947f3 100644 --- a/gdbus/object.c +++ b/gdbus/object.c @@ -82,7 +82,11 @@ static void generate_interface_xml(GString *gstr, struct

[PATCH mmsd 11/12] gdbus: add Method.NoReply annotation in introspection

--- gdbus/object.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gdbus/object.c b/gdbus/object.c index 95947f3..dacbe58 100644 --- a/gdbus/object.c +++ b/gdbus/object.c @@ -84,8 +84,10 @@ static void generate_interface_xml(GString *gstr, struct interface_data

[PATCH mmsd 12/12] gdbus: do not check signature twice

Message signature is already checked in generic_message(), so there's no need to check again in the callback. --- gdbus/object.c |5 - 1 file changed, 5 deletions(-) diff --git a/gdbus/object.c b/gdbus/object.c index dacbe58..2dd7c0e 100644 --- a/gdbus/object.c +++ b/gdbus/object.c @@

[PATCH mmsd 01/12] Constify GDBus tables

Constify method tables with the following commands: find . -name '*.[ch]' -exec sed -i \ 's/\(c\)\(GDBusSignalTable .* =\)/\1 const \2/g' {} \; find . -name '*.[ch]' -exec sed -i \ 's/\(c\)\(GDBusMethodTable .* =\)/\1 const \2/g' {} \; --- plugins/ofono.c |2 +-

[PATCH mmsd 02/12] gdbus: add argument info to methods and signals

--- gdbus/gdbus.h |8 1 file changed, 8 insertions(+) diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h index a0583e6..e5e7938 100644 --- a/gdbus/gdbus.h +++ b/gdbus/gdbus.h @@ -85,16 +85,24 @@ typedef enum { typedef struct { const char *name; const char *signature; +}

[PATCH mmsd 03/12] gdbus: add and use helpers for table declarations

--- gdbus/gdbus.h | 86 gdbus/object.c |3 +- 2 files changed, 88 insertions(+), 1 deletion(-) diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h index e5e7938..8354633 100644 --- a/gdbus/gdbus.h +++ b/gdbus/gdbus.h @@ -118,6 +118,92 @@

[PATCH mmsd 04/12] gdbus: add macro for methods marked as NOREPLY

--- gdbus/gdbus.h | 16 1 file changed, 16 insertions(+) diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h index 8354633..868c8d5 100644 --- a/gdbus/gdbus.h +++ b/gdbus/gdbus.h @@ -155,6 +155,15 @@ typedef struct { .function = _function, \ .flags =

[PATCH mmsd 05/12] Convert GDBus methods to use macro helpers

With these macro helpers we can separate in/out arguments and use their own vector. --- plugins/ofono.c |8 +--- src/service.c | 40 +--- 2 files changed, 34 insertions(+), 14 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index

[PATCH mmsd 06/12] gdbus: use GDBusArgInfo to generate introspection

By using GDBusArgInfo in methods and signals, the introspection generation is much simpler and we can add each argument name. --- gdbus/object.c | 75 +++- 1 file changed, 14 insertions(+), 61 deletions(-) diff --git a/gdbus/object.c

[PATCH mmsd 07/12] gdbus: loop over args to check message signature

--- gdbus/object.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/gdbus/object.c b/gdbus/object.c index 3ac6a0b..b187bb5 100644 --- a/gdbus/object.c +++ b/gdbus/object.c @@ -374,6 +374,27 @@ static struct interface_data

[PATCH mmsd 08/12] Do not set signature and reply in GDBus tables

Use GDBUS_* macros, so signature and reply fields are not set in each method/signal. --- plugins/ofono.c |4 ++-- src/service.c | 25 +++-- 2 files changed, 13 insertions(+), 16 deletions(-) diff --git a/plugins/ofono.c b/plugins/ofono.c index fcdb228..45fac91 100644

[PATCH mmsd 11/12] gdbus: add Method.NoReply annotation in introspection

--- gdbus/object.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/gdbus/object.c b/gdbus/object.c index 95947f3..dacbe58 100644 --- a/gdbus/object.c +++ b/gdbus/object.c @@ -84,8 +84,10 @@ static void generate_interface_xml(GString *gstr, struct interface_data

Re: buildroot

are using the git repository, you need to run './bootstrap ./configure' first. Then you'll have a Makefile. regards, Lucas De Marchi ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH] voicecall: allow pause to be sent through SendTones()

manager_tone() converts all tone chars to uppercase. Since everywhere we check for both 'p' and 'P' for a pause, tone_queue() should also check both before claiming the string is invalid. --- src/voicecall.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH] TODO: mark 'GPS power control atom' task as done

--- TODO | 11 --- doc/features.txt |8 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/TODO b/TODO index c432cba..9db9e0b 100644 --- a/TODO +++ b/TODO @@ -444,17 +444,6 @@ Miscellaneous Complexity: C8 Owner: Jukka Saunamäki

[PATCH 2/2] mbmmodem: do not check for NULL pointer

cb_data_new() uses g_new0(), hence there's no need to check the return value being NULL. --- drivers/mbmmodem/location-reporting.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/mbmmodem/location-reporting.c b/drivers/mbmmodem/location-reporting.c index

[PATCH 1/2] huawei: do not check for NULL pointer

cb_data_new() uses g_new0(), hence there's no need to check the return value being NULL. --- plugins/huawei.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 6f05677..afa804d 100644 --- a/plugins/huawei.c +++ b/plugins/huawei.c

[PATCH] mbmmodem: don't let chat open after fd is sent

async calls. Hence the use of an idle callback. regards, Lucas De Marchi drivers/mbmmodem/location-reporting.c | 105 +++-- 1 files changed, 60 insertions(+), 45 deletions(-) diff --git a/drivers/mbmmodem/location-reporting.c b/drivers/mbmmodem/location-reporting.c

Re: [PATCH] mbmmodem: don't let chat open after fd is sent

; +             ofono_location_reporting_enable_cb_t cb; +             void *cb_data; +     } stream;  }; why do you bother with the struct in struct here? Just to group these related fields. regards, Lucas De Marchi ___ ofono mailing list ofono@ofono.org http

[PATCH] mbmmodem: don't let chat open after fd is sent

Instead of using a GAtChat, just use a GIOChannel and close it as soon as its fd is sent to core. --- drivers/mbmmodem/location-reporting.c | 32 +++- 1 files changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/mbmmodem/location-reporting.c

[PATCH 1/3] mbmmodem: close chat before sending fd

--- drivers/mbmmodem/location-reporting.c | 44 ++--- 1 files changed, 24 insertions(+), 20 deletions(-) diff --git a/drivers/mbmmodem/location-reporting.c b/drivers/mbmmodem/location-reporting.c index 941fac4..b671d71 100644 ---

[PATCH 2/3] location-reporting: don't add client-exit watch too early

Wait until driver gives us a file descriptor to start watching for client exit. This fixes a race when client exits before the driver calls location_reporting_enable_cb(). --- src/location-reporting.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git

[PATCH 3/3] mbmmodem: ensure we close fd when ofono exits

--- drivers/mbmmodem/location-reporting.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drivers/mbmmodem/location-reporting.c b/drivers/mbmmodem/location-reporting.c index b671d71..24ff4b8 100644 --- a/drivers/mbmmodem/location-reporting.c +++

[PATCH] tools: add client to receive location reporting

As of now there's no support for fd-passing in D-Bus Python bindings, hence a small C client is needed in order to test location-reporting atom. --- Makefile.am |5 +- tools/get-location.c | 259 ++ 2 files changed, 263 insertions(+),

Re: [PATCH] tools: add client to receive location reporting

Hi all, On Wed, Feb 23, 2011 at 3:47 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: As of now there's no support for fd-passing in D-Bus Python bindings, hence a small C client is needed in order to test location-reporting atom. ---  Makefile.am          |    5 +-  tools/get

[PATCH v2] tools: add client to receive location reporting

As of now there's no support for fd-passing in D-Bus Python bindings, hence a small C client is needed in order to test location-reporting atom. --- Makefile.am |5 +- tools/get-location.c | 259 ++ 2 files changed, 263 insertions(+),

Re: [PATCH v4 3/6] mbmmodem: add location-reporting driver implementation

(). Otherwise, isn't the Release() method superfluous? regards, Lucas De Marchi ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH v2] tools: add client to receive location reporting

Hi Denis On Wed, Feb 23, 2011 at 9:58 PM, Denis Kenzior denk...@gmail.com wrote: Hi Lucas, On 02/23/2011 01:49 PM, Lucas De Marchi wrote: As of now there's no support for fd-passing in D-Bus Python bindings, hence a small C client is needed in order to test location-reporting atom

[PATCH v4 0/6] Add location-reporting atom

From: Lucas De Marchi lucas.de.mar...@gmail.com This is the 4th version of the location-reporting patches (previous title was Add GPS atom). I worked with Rafael Ignacio Zurita to implement this last version, making some changes in order to fit the new design as discussed on irc. Now when

[PATCH v4 1/6] location-reporting: add public header

From: Rafael Ignacio Zurita rafael.zur...@profusion.mobi --- Makefile.am |3 +- include/location-reporting.h | 81 ++ 2 files changed, 83 insertions(+), 1 deletions(-) create mode 100644 include/location-reporting.h diff --git

[PATCH v4 3/6] mbmmodem: add location-reporting driver implementation

From: Rafael Ignacio Zurita rafael.zur...@profusion.mobi --- Makefile.am |3 +- drivers/mbmmodem/location-reporting.c | 247 + drivers/mbmmodem/mbmmodem.c |2 + drivers/mbmmodem/mbmmodem.h |3 + 4 files

[PATCH v4 4/6] mbm: add location-reporting atom

From: Rafael Ignacio Zurita rafael.zur...@profusion.mobi --- plugins/mbm.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/plugins/mbm.c b/plugins/mbm.c index 2ab80b4..105843f 100644 --- a/plugins/mbm.c +++ b/plugins/mbm.c @@ -46,6 +46,7 @@ #include

[PATCH v4 5/6] udev: add location-reporting device to mbm

From: Rafael Ignacio Zurita rafael.zur...@profusion.mobi --- plugins/udev.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/plugins/udev.c b/plugins/udev.c index 84478d7..aa5702e 100644 --- a/plugins/udev.c +++ b/plugins/udev.c @@ -105,7 +105,7 @@ static void

[PATCH v4 6/6] location-reporting: add documentation

From: Rafael Ignacio Zurita rafael.zur...@profusion.mobi --- Makefile.am|3 ++- doc/location-reporting-api.txt | 39 +++ 2 files changed, 41 insertions(+), 1 deletions(-) create mode 100644 doc/location-reporting-api.txt diff --git

[PATCH v4 2/6] location-reporting: add atom implementation

From: Rafael Ignacio Zurita rafael.zur...@profusion.mobi --- Makefile.am |2 +- src/location-reporting.c | 393 ++ src/ofono.h |2 + 3 files changed, 396 insertions(+), 1 deletions(-) create mode 100644

[PATCH 0/7] sms: Cancel pending message

refactors needed to accommodate this feature, that has been added on 5th patch. Lucas De Marchi (7): history: add cancelled status examples: handle cancelled history status message: add cancelled state sms: factor out 'remove entry' from tx_finished() sms: allow message submission

[PATCH 2/7] examples: handle cancelled history status

--- examples/history.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/examples/history.c b/examples/history.c index 0a1e8d7..21668ec 100644 --- a/examples/history.c +++ b/examples/history.c @@ -172,6 +172,11 @@ static void example_history_sms_send_status(

[PATCH 3/7] message: add cancelled state

Based on patch from Yang Gu gya...@gmail.com --- src/message.c |2 ++ src/message.h |3 ++- 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/message.c b/src/message.c index eb85adf..668a693 100644 --- a/src/message.c +++ b/src/message.c @@ -46,6 +46,8 @@ static const

[PATCH 1/7] history: add cancelled status

Based on patch from Yang Gu gya...@gmail.com --- include/history.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/history.h b/include/history.h index c1c4aa1..756097e 100644 --- a/include/history.h +++ b/include/history.h @@ -35,6 +35,7 @@ enum

[PATCH 4/7] sms: factor out 'remove entry' from tx_finished()

Refactor tx_finished() and create a function to remove an entry from the tx queue. This function will be used also when a message is cancelled. Thus, handle the case in which state is MESSAGE_STATE_CANCELLED as well. Based on patch from Yang Gu gya...@gmail.com --- src/sms.c | 99

[PATCH 6/7] doc: add CancelMessage to MessageManager

--- doc/messagemanager-api.txt | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/doc/messagemanager-api.txt b/doc/messagemanager-api.txt index 0723e9c..3d66193 100644 --- a/doc/messagemanager-api.txt +++ b/doc/messagemanager-api.txt @@ -32,6 +32,16 @@ Methods

[PATCH 7/7] TODO: mark task 'cancel pending SMS' as done

--- TODO |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/TODO b/TODO index 13a6baa..8790209 100644 --- a/TODO +++ b/TODO @@ -31,15 +31,6 @@ SMS Priority: Low Complexity: C8 -- See / Cancel pending SMS messages over DBus. When oFono sends SMS messages -

[PATCH 5/7] sms: allow message submission to be cancelled

Based on patch from Yang Gu gya...@gmail.com --- src/sms.c | 82 + 1 files changed, 82 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index 7db91cb..91b0a31 100644 --- a/src/sms.c +++ b/src/sms.c @@ -685,6 +685,8 @@

Re: [PATCH 5/7] sms: allow message submission to be cancelled

Hi Andrzej, On Fri, Feb 4, 2011 at 1:58 PM, andrzej zaborowski balr...@gmail.com wrote: Hi, On 4 February 2011 16:02, Lucas De Marchi lucas.demar...@profusion.mobi wrote: Based on patch from Yang Gu gya...@gmail.com ---  src/sms.c |   82

[PATCH v2 1/8] history: add cancelled status

Based on patch from Yang Gu gya...@gmail.com --- include/history.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/history.h b/include/history.h index c1c4aa1..756097e 100644 --- a/include/history.h +++ b/include/history.h @@ -35,6 +35,7 @@ enum

[PATCH v2 2/8] examples: handle cancelled history status

--- examples/history.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/examples/history.c b/examples/history.c index 0a1e8d7..21668ec 100644 --- a/examples/history.c +++ b/examples/history.c @@ -172,6 +172,11 @@ static void example_history_sms_send_status(

[PATCH v2 3/8] message: add cancelled state

Based on patch from Yang Gu gya...@gmail.com --- src/message.c |2 ++ src/message.h |3 ++- 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/message.c b/src/message.c index eb85adf..668a693 100644 --- a/src/message.c +++ b/src/message.c @@ -46,6 +46,8 @@ static const

[PATCH v2 4/8] sms: factor out 'remove entry' from tx_finished()

Refactor tx_finished() and create a function to remove an entry from the tx queue. This function will be used also when a message is cancelled. Thus, handle the case in which state is MESSAGE_STATE_CANCELLED as well. Based on patch from Yang Gu gya...@gmail.com --- src/sms.c | 105

[PATCH v2 5/8] sms: allow message submission to be cancelled

Based on patch from Yang Gu gya...@gmail.com --- src/sms.c | 88 + 1 files changed, 88 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index dfec456..212a470 100644 --- a/src/sms.c +++ b/src/sms.c @@ -685,6 +685,8 @@

[PATCH v2 7/8] TODO: mark task 'cancel pending SMS' as done

--- TODO |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/TODO b/TODO index 13a6baa..8790209 100644 --- a/TODO +++ b/TODO @@ -31,15 +31,6 @@ SMS Priority: Low Complexity: C8 -- See / Cancel pending SMS messages over DBus. When oFono sends SMS messages -

[PATCH v2 6/8] doc: add CancelMessage to MessageManager

--- doc/messagemanager-api.txt | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/doc/messagemanager-api.txt b/doc/messagemanager-api.txt index 0723e9c..29453c3 100644 --- a/doc/messagemanager-api.txt +++ b/doc/messagemanager-api.txt @@ -32,6 +32,18 @@ Methods

[PATCH v2 8/8] sms: remove check for impossible NULL condition

tx_next() must never be called with entry == NULL and currently it was already being dereferenced before making this check. Thus just remove it. --- src/sms.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/sms.c b/src/sms.c index 212a470..be7132a5 100644 ---

[PATCH] smart-messaging: set agent to NULL after free

If agent is not set to NULL after it's freed, the following situation would not work: smart_messaging_register_agent() smart_messaging_unregister_agent() smart_messaging_register_agent() And this one could potentially crash oFono: smart_messaging_register_agent()

[PATCH 2/9] common: implement initializer for ofono_call

--- src/common.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/common.c b/src/common.c index 8bf9dbb..f25f105 100644 --- a/src/common.c +++ b/src/common.c @@ -762,3 +762,10 @@ const char *ofono_uuid_to_str(const struct ofono_uuid *uuid) return

[PATCH 4/9] calypsomodem: use ofono_call initializer

--- drivers/calypsomodem/voicecall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/calypsomodem/voicecall.c b/drivers/calypsomodem/voicecall.c index 01be990..fed442c 100644 --- a/drivers/calypsomodem/voicecall.c +++ b/drivers/calypsomodem/voicecall.c @@ -314,7

[PATCH 6/9] huaweimodem: use ofono_call initializer

--- drivers/huaweimodem/voicecall.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/huaweimodem/voicecall.c b/drivers/huaweimodem/voicecall.c index a30513a..53377d9 100644 --- a/drivers/huaweimodem/voicecall.c +++ b/drivers/huaweimodem/voicecall.c @@ -56,10

[PATCH 7/9] ifxmodem: use ofono_call initializer

--- drivers/ifxmodem/voicecall.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c index 716652c..e7f72fc 100644 --- a/drivers/ifxmodem/voicecall.c +++ b/drivers/ifxmodem/voicecall.c @@ -87,10 +87,12 @@ static

[PATCH 2/5] doc: fix misspelling

--- doc/sim-api.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/doc/sim-api.txt b/doc/sim-api.txt index 65c920d..c8091f7 100644 --- a/doc/sim-api.txt +++ b/doc/sim-api.txt @@ -129,7 +129,7 @@ Properties boolean Present [readonly] string

[PATCH v2 0/3] Persist TX SMS messages

(1) in some places to simulate crashes. The pending sms messages were correctly sent once oFono was up again. Lucas De Marchi (3): sms: store pending tx pdus on disk sms: delete sent sms messages from backup sms: restore pending tx messages from backup src/ofono.h |1 + src/sms.c

[PATCH v2 3/3] sms: restore pending tx messages from backup

Based on patch from: Kristen Carlson Accardi kris...@linux.intel.com --- src/ofono.h |1 + src/sms.c | 67 + src/smsutil.c | 185 + src/smsutil.h |8 +++ 4 files changed, 261 insertions(+), 0 deletions(-)

  1   2   3   >