[PATCH v4 1/2] dbus: Add Terminated error

2012-09-06 Thread Philippe Nunes
--- src/dbus.c |8 src/ofono.h |1 + 2 files changed, 9 insertions(+) diff --git a/src/dbus.c b/src/dbus.c index 3f5c12d..1f9f9ba 100644 --- a/src/dbus.c +++ b/src/dbus.c @@ -409,6 +409,14 @@ DBusMessage *__ofono_error_not_recognized(DBusMessage *msg)

[PATCH v4 2/2] ussd: Recover idle state after a transaction error

2012-09-06 Thread Philippe Nunes
The USSD terminated by network notification is handled to recover the idle state in case of USSD transaction error. --- src/ussd.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/ussd.c b/src/ussd.c index 74888b2..60b1f6b 100644 --- a/src/ussd.c +++ b/src/ussd.c @@ -414,6

[PATCH v2 2/2] stk: AID shall not be displayed in case of self explanatory icon

2012-09-06 Thread Philippe Nunes
--- src/stk.c | 12 1 file changed, 12 insertions(+) diff --git a/src/stk.c b/src/stk.c index 0a279bf..87b8465 100644 --- a/src/stk.c +++ b/src/stk.c @@ -539,6 +539,18 @@ static gboolean stk_alpha_id_set(struct ofono_stk *stk, if (stk-current_agent == NULL)

[PATCH v2 1/2] stk: convert to phone number format and remove DTMF string

2012-09-06 Thread Philippe Nunes
The dialing number provided by the Setup Call proactive command may contain pause and DTMF characters. --- src/stk.c | 58 +++--- 1 file changed, 43 insertions(+), 15 deletions(-) diff --git a/src/stk.c b/src/stk.c index 19cb0eb..0a279bf

[PATCH 1/3] test: Update with RequestQuickDigit API

2012-09-06 Thread Philippe Nunes
--- test/test-stk-menu | 14 ++ 1 file changed, 14 insertions(+) diff --git a/test/test-stk-menu b/test/test-stk-menu index a9f92e8..6e7f7b7 100755 --- a/test/test-stk-menu +++ b/test/test-stk-menu @@ -127,6 +127,20 @@ class StkAgent(dbus.service.Object):

[PATCH 3/3] test: iconId value is not a printable character

2012-09-06 Thread Philippe Nunes
--- test/list-calls |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/list-calls b/test/list-calls index 53124dc..2332b50 100755 --- a/test/list-calls +++ b/test/list-calls @@ -24,7 +24,8 @@ for path, properties in modems: print [ %s ] %

[PATCH 2/3] test: playtone waits for single tone playback

2012-09-06 Thread Philippe Nunes
To simulate the single tone playback (avoiding the stkagent method to return immediately), a timeout is started (5 seconds). During this time, the user can terminate the session. --- test/test-stk-menu | 18 ++ 1 file changed, 18 insertions(+) diff --git a/test/test-stk-menu

[PATCH v2] phonesim: Extend STK conformance menu with Setup Call items

2012-09-06 Thread Philippe Nunes
--- src/conformancesimapplication.cpp | 247 + src/simapplication.h |2 + 2 files changed, 249 insertions(+) diff --git a/src/conformancesimapplication.cpp b/src/conformancesimapplication.cpp index a2bd3af..fd146f4 100644 ---

[PATCH v3 2/4] call-forwarding: SS query is done according the class given by SS code

2012-09-05 Thread Philippe Nunes
GCF test cases 31.2.1.6.1/2 are asking to make a query according a specific class. The default class is applied in the query form when no class is specified in the SS code. --- src/call-forwarding.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git

[PATCH v3 1/4] ussd: Recover idle state after a transaction error

2012-09-05 Thread Philippe Nunes
The USSD terminated by network notification is handled to recover the idle state in case of USSD transaction error. --- src/ussd.c | 12 1 file changed, 12 insertions(+) diff --git a/src/ussd.c b/src/ussd.c index 74888b2..a35f172 100644 --- a/src/ussd.c +++ b/src/ussd.c @@ -414,6

[PATCH v3 3/4] call-barring: SS query is done according the class given by SS code

2012-09-05 Thread Philippe Nunes
The default class is applied in the query form when no class is specified in the SS code. --- src/call-barring.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/call-barring.c b/src/call-barring.c index 68533c2..845cbc3 100644 --- a/src/call-barring.c +++

[PATCH v3 4/4] atmodem: specify class for call barring query

2012-09-05 Thread Philippe Nunes
class is specified when querying the call barring status if the class is not the default (7 - voice, data and fax) --- drivers/atmodem/call-barring.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/atmodem/call-barring.c b/drivers/atmodem/call-barring.c index

[PATCH 2/4] common: Accept pause character in the dialing number

2012-09-05 Thread Philippe Nunes
--- src/common.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common.c b/src/common.c index 94d70dd..de1ad26 100644 --- a/src/common.c +++ b/src/common.c @@ -257,7 +257,7 @@ gboolean valid_number_format(const char *number, int length) if (number[i] =

[PATCH 3/4] voicecall: Accept long phone number format for STK

2012-09-05 Thread Philippe Nunes
--- src/voicecall.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/voicecall.c b/src/voicecall.c index 12e5d4e..45dfac2 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -3675,7 +3675,7 @@ int __ofono_voicecall_dial(struct ofono_voicecall *vc, { struct

[PATCH 4/4] stk: AID shall not be displayed in case of self explanatory icon

2012-09-05 Thread Philippe Nunes
--- src/stk.c |5 + 1 file changed, 5 insertions(+) diff --git a/src/stk.c b/src/stk.c index 5c79183..e242bf5 100644 --- a/src/stk.c +++ b/src/stk.c @@ -539,6 +539,11 @@ static gboolean stk_alpha_id_set(struct ofono_stk *stk, if (stk-current_agent == NULL) return

[PATCH 1/3] phonesim: Extend conformance menu with Setup Call items

2012-09-05 Thread Philippe Nunes
--- src/conformancesimapplication.cpp | 247 + src/simapplication.h |2 + 2 files changed, 249 insertions(+) diff --git a/src/conformancesimapplication.cpp b/src/conformancesimapplication.cpp index a2bd3af..11265a5 100644 ---

[PATCH 2/3] phonesim: Add text for PlayTone and Send SS

2012-09-05 Thread Philippe Nunes
--- src/simapplication.cpp |6 ++ 1 file changed, 6 insertions(+) diff --git a/src/simapplication.cpp b/src/simapplication.cpp index bede410..d79e8ca 100644 --- a/src/simapplication.cpp +++ b/src/simapplication.cpp @@ -956,6 +956,7 @@ void DemoSimApplication::toneMenu( const

[PATCH 3/3] phonesim: Reject specific outgoing call for SAT test purpose

2012-09-05 Thread Philippe Nunes
--- src/callmanager.cpp |7 +++ 1 file changed, 7 insertions(+) diff --git a/src/callmanager.cpp b/src/callmanager.cpp index 4567548..1995c6d 100644 --- a/src/callmanager.cpp +++ b/src/callmanager.cpp @@ -79,6 +79,13 @@ bool CallManager::command( const QString cmd ) return

[PATCH v4 1/3] smsutil: Fix style issues

2012-08-31 Thread Philippe Nunes
--- src/smsutil.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index a541964..b4d129f 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -81,11 +81,11 @@ void extract_bcd_number(const unsigned char *buf, int len,

[PATCH v4 2/3] smsutil: CR is not necessarily a CBS padding character

2012-08-31 Thread Philippe Nunes
--- src/smsutil.c | 36 +--- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index b4d129f..7569c63 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -4090,7 +4090,7 @@ char *cbs_decode_text(GSList *cbs_list, char

[PATCH v4 3/3] unit: Add test to check CBS padding character

2012-08-31 Thread Philippe Nunes
From: Guillaume Zajac guillaume.za...@linux.intel.com This CBS unit test is used to check that the CR character can be interpreted as a wanted carriage return and not necessarily as a padding character. --- unit/test-sms.c | 59 +++ 1 file

[PATCH] stk: Check if an agent is registered when UI is required

2012-08-30 Thread Philippe Nunes
In case of unsolicited proactive command, we could have a crash when no agent was registered. --- src/stk.c |9 + 1 file changed, 9 insertions(+) diff --git a/src/stk.c b/src/stk.c index 18a8eaf..4c24abb 100644 --- a/src/stk.c +++ b/src/stk.c @@ -515,6 +515,9 @@ static gboolean

[PATCH] sms: Fix to find SMS entry posted by STK

2012-08-30 Thread Philippe Nunes
SMS initiated by proactive command are not exposed on D-BUS. Therefore, there is no message associated with the entry created from STK. --- src/sms.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/sms.c b/src/sms.c index acfc39b..743f725 100644 ---

[PATCH v2 0/4] Immediate digit response

2012-08-28 Thread Philippe Nunes
Introduce a new STK method to get digit response on single key press. This method asks to not display the entered digit and does not accept the character '+'. Philippe Nunes (4): doc: Add new STK Agent API to get digit response on single key press stkagent: Add new API to get digit response

[PATCH v2 1/4] doc: Add new STK Agent API to get digit response on single key press

2012-08-28 Thread Philippe Nunes
--- doc/stk-api.txt |9 + 1 file changed, 9 insertions(+) diff --git a/doc/stk-api.txt b/doc/stk-api.txt index 471e5d6..6875354 100644 --- a/doc/stk-api.txt +++ b/doc/stk-api.txt @@ -193,6 +193,15 @@ Methodsbyte RequestSelection(string title, byte icon_id,

[PATCH v2 3/4] stk: Ask for immediate digit response if specified by command qualifier

2012-08-28 Thread Philippe Nunes
--- src/stk.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/stk.c b/src/stk.c index 7a7bd75..38f2e18 100644 --- a/src/stk.c +++ b/src/stk.c @@ -1519,9 +1519,9 @@ static gboolean handle_command_get_inkey(const struct stk_command *cmd, gboolean

[PATCH v2 4/4] test: Update with RequestQuickDigit API

2012-08-28 Thread Philippe Nunes
--- test/test-stk-menu | 37 + 1 file changed, 37 insertions(+) diff --git a/test/test-stk-menu b/test/test-stk-menu index a9f92e8..476d949 100755 --- a/test/test-stk-menu +++ b/test/test-stk-menu @@ -7,6 +7,27 @@ import dbus import dbus.service import

[PATCH v2 1/2] phonesim: Add methods to handle the 'immediate digit response' flag

2012-08-28 Thread Philippe Nunes
--- src/qsimcommand.cpp | 30 ++ src/qsimcommand.h |3 +++ 2 files changed, 33 insertions(+) diff --git a/src/qsimcommand.cpp b/src/qsimcommand.cpp index f5dbdf2..97e0b28 100644 --- a/src/qsimcommand.cpp +++ b/src/qsimcommand.cpp @@ -1312,6 +1312,36 @@ void

[PATCH v2 2/2] phonesim: Add GET_INPUT test case

2012-08-28 Thread Philippe Nunes
This test case is used to check the immediate digit response flag. --- src/conformancesimapplication.cpp | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/src/conformancesimapplication.cpp b/src/conformancesimapplication.cpp index baf3538..a2bd3af

[PATCH] stkagent: Sanitize any output from the agent

2012-08-28 Thread Philippe Nunes
--- src/stkagent.c | 56 +--- 1 file changed, 53 insertions(+), 3 deletions(-) diff --git a/src/stkagent.c b/src/stkagent.c index 63b82f3..dbcc962 100644 --- a/src/stkagent.c +++ b/src/stkagent.c @@ -59,6 +59,9 @@ struct stk_agent {

[PATCH] stk: Display action information while sending USSD.

2012-08-28 Thread Philippe Nunes
--- src/stk.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/stk.c b/src/stk.c index 38f2e18..18a8eaf 100644 --- a/src/stk.c +++ b/src/stk.c @@ -2026,11 +2026,6 @@ static gboolean handle_command_send_ussd(const struct stk_command *cmd,

Re: [PATCH v2] ussd: Recover idle state in case of response sending failure

2012-08-24 Thread Philippe Nunes
On 08/23/2012 08:03 PM, Denis Kenzior wrote: Hi Philippe, On 08/23/2012 11:27 AM, Philippe Nunes wrote: GCF test case 31.8.1.2.3 is rejecting the user response. Any subsequent USSD notification are not handled because USSD is always in state user-action. --- src/ussd.c | 12 1 file

[PATCH 0/4] Immediate digit response

2012-08-24 Thread Philippe Nunes
For GET-INPUT proactive command, the command qualifier can require to send the response immediately after the user has entered a digit. In this mode, the entered digit shall not be displayed and the character '+' is not allowed for user input. Philippe Nunes (4): stk: check if immediate digit

[PATCH 2/4] stkagent: Add argument to notify when immediate digit response is required

2012-08-24 Thread Philippe Nunes
--- src/stkagent.c |6 -- src/stkagent.h |5 +++-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/stkagent.c b/src/stkagent.c index 7c3f697..ed5d28a 100644 --- a/src/stkagent.c +++ b/src/stkagent.c @@ -554,8 +554,9 @@ static void get_digit_cb(DBusPendingCall *call,

[PATCH 3/4] doc: Update STK API regarding the new argument immediate_response

2012-08-24 Thread Philippe Nunes
--- doc/stk-api.txt | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/doc/stk-api.txt b/doc/stk-api.txt index 471e5d6..0d96246 100644 --- a/doc/stk-api.txt +++ b/doc/stk-api.txt @@ -170,8 +170,9 @@ Methods byte RequestSelection(string title, byte

[PATCH 1/4] stk: check if immediate digit response is requested

2012-08-24 Thread Philippe Nunes
--- src/stk.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/stk.c b/src/stk.c index 7a7bd75..3883d11 100644 --- a/src/stk.c +++ b/src/stk.c @@ -1519,6 +1519,7 @@ static gboolean handle_command_get_inkey(const struct stk_command *cmd, gboolean alphabet =

[PATCH 4/4] test: Print the immediate_response argument for RequestDigit

2012-08-24 Thread Philippe Nunes
--- test/test-stk-menu |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/test-stk-menu b/test/test-stk-menu index a9f92e8..3bd4483 100755 --- a/test/test-stk-menu +++ b/test/test-stk-menu @@ -113,10 +113,11 @@ class StkAgent(dbus.service.Object):

[PATCH] phonesim: Add GET_INPUT test case

2012-08-24 Thread Philippe Nunes
This test case is used to check the immediate digit response flag. --- src/conformancesimapplication.cpp | 25 - src/qsimcommand.cpp | 32 src/qsimcommand.h |3 +++ 3 files changed, 55 insertions(+), 5

Re: [PATCH 1/8] ussd: Recover idle state in case of response sending failure

2012-08-23 Thread Philippe Nunes
Hi Denis, On 08/23/2012 01:02 AM, Denis Kenzior wrote: Hi Philippe, On 08/22/2012 11:18 AM, Philippe Nunes wrote: GCF test case 31.8.1.2.3 is rejecting the user response. Any subsequent USSD notification are not handled because USSD is always in state user-action. --- src/ussd.c | 8

Re: [PATCH 4/8] call-forwarding: class applied is the class given by SS code

2012-08-23 Thread Philippe Nunes
Hi Denis, On 08/23/2012 01:36 AM, Denis Kenzior wrote: Hi Philippe, On 08/22/2012 11:18 AM, Philippe Nunes wrote: GCF test cases 31.2.1.6.1/2 are asking to make a query according a specific class. The default class is applied when no class is specified in the SS code. --- src/call

Re: [PATCH 2/8] stkagent: '+' is considered as a digit

2012-08-23 Thread Philippe Nunes
Hi Denis, On 08/23/2012 12:55 AM, Denis Kenzior wrote: Hi Philippe, On 08/22/2012 11:18 AM, Philippe Nunes wrote: The function 'valid_phone_number_format' does not comply with GCF test cases expectation. For STK, the character '+' should be considered as a whole digit. --- src/stkagent.c | 26

[PATCH v2] call-forwarding: class applied is the class given by SS code

2012-08-23 Thread Philippe Nunes
GCF test cases 31.2.1.6.1/2 are asking to make a query according a specific class. The default class is applied when no class is specified in the SS code. --- src/call-forwarding.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/call-forwarding.c

[PATCH v2] ussd: Recover idle state in case of response sending failure

2012-08-23 Thread Philippe Nunes
GCF test case 31.8.1.2.3 is rejecting the user response. Any subsequent USSD notification are not handled because USSD is always in state user-action. --- src/ussd.c | 12 1 file changed, 12 insertions(+) diff --git a/src/ussd.c b/src/ussd.c index 74888b2..21e0164 100644 ---

[PATCH 1/8] ussd: Recover idle state in case of response sending failure

2012-08-22 Thread Philippe Nunes
GCF test case 31.8.1.2.3 is rejecting the user response. Any subsequent USSD notification are not handled because USSD is always in state user-action. --- src/ussd.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/ussd.c b/src/ussd.c index 74888b2..0ad4f61 100644

[PATCH 2/8] stkagent: '+' is considered as a digit

2012-08-22 Thread Philippe Nunes
The function 'valid_phone_number_format' does not comply with GCF test cases expectation. For STK, the character '+' should be considered as a whole digit. --- src/stkagent.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/src/stkagent.c

[PATCH 3/8] call-forwarding: return specific errors for SS query

2012-08-22 Thread Philippe Nunes
Trace is modified as a CF query is not necessarily done after a CF setting via SS. --- src/call-forwarding.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/call-forwarding.c b/src/call-forwarding.c index 5acbd67..91e34c6 100644 --- a/src/call-forwarding.c +++

[PATCH 4/8] call-forwarding: class applied is the class given by SS code

2012-08-22 Thread Philippe Nunes
GCF test cases 31.2.1.6.1/2 are asking to make a query according a specific class. The default class is applied when no class is specified in the SS code. --- src/call-forwarding.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/call-forwarding.c

[PATCH 5/8] call-barring: Return specific errors for SS query

2012-08-22 Thread Philippe Nunes
Trace is modified as a CB query is not necessarily done after a CB setting via SS. --- src/call-barring.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/call-barring.c b/src/call-barring.c index 53847fb..68533c2 100644 --- a/src/call-barring.c +++

[PATCH 6/8] call-barring: class applied is the class given by SS code

2012-08-22 Thread Philippe Nunes
The default class is applied when no class is specified in the SS code. --- src/call-barring.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/call-barring.c b/src/call-barring.c index 68533c2..a372792 100644 --- a/src/call-barring.c +++ b/src/call-barring.c @@

[PATCH 7/8] call-settings: Return specific errors for SS query

2012-08-22 Thread Philippe Nunes
Trace is modified as clir query is not necessarily done after a clir setting via SS. --- src/call-settings.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/call-settings.c b/src/call-settings.c index 4bfb561..51f96bf 100644 --- a/src/call-settings.c +++

[PATCH 8/8] call-settings: class applied is the class given by SS code.

2012-08-22 Thread Philippe Nunes
The default class is applied when no class is specified by SS code. --- src/call-settings.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/call-settings.c b/src/call-settings.c index 51f96bf..d63d9d8 100644 --- a/src/call-settings.c +++ b/src/call-settings.c

Re: SAT support in oFono

2012-08-21 Thread Philippe Nunes
On 01/24/2011 11:49 AM, Marcel Holtmann wrote: Hi Lasse, I am checking what is the level of SAT/STK support in ofono and have a couple of questions. The current implementation contains support for basic STK commands, like menus, inputs, calls, sms and so on. In TODO, there is only REFRESH

[PATCH] smsutil: CR is not necessarily a padding character in CBS message

2012-07-27 Thread Philippe Nunes
--- src/smsutil.c | 37 ++--- 1 file changed, 30 insertions(+), 7 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index a541964..59eb7b1 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -4090,7 +4090,7 @@ char *cbs_decode_text(GSList *cbs_list, char

Re: Testing Telit GT864-3G compatibility with ofono

2012-07-26 Thread Philippe Nunes
Hi, On 07/25/2012 02:50 PM, Andrea Galbusera wrote: Hi, I'm doing some tests with Telit GT864-3G terminal connected to USB with ofono 1.9. This modem uses UC864-E core. Since ofono provides a driver for UC864-G core, I hope managing it with ofono should be quite straightforward. One difference

Re: Testing Telit GT864-3G compatibility with ofono

2012-07-26 Thread Philippe Nunes
On 07/26/2012 11:53 AM, Andrea Galbusera wrote: Hi Bertrand, Thank you for suggestions: please, see comments below. On Thu, Jul 26, 2012 at 10:06 AM, Aygon, Bertrand bertrand.ay...@intel.com wrote: Hi, I'm doing some tests with Telit GT864-3G terminal connected to USB with ofono 1.9. This

[PATCH] monitor-ofono: Fix to print non-English characters

2012-07-26 Thread Philippe Nunes
The default encoding for a Python bytestring is ASCII. But the SMS/USSD text is encoded in UTF-8. This is why trying to convert non-English characters (Unicode characters beyond 128) produces the error UnicodeEncodeError: 'ascii' codec can't encode character. --- test/monitor-ofono |4 ++-- 1

[PATCH v2] test-ussd becomes send-ussd This script can be used to handle network initiated USSDs

2012-07-26 Thread Philippe Nunes
--- Makefile.am|2 +- test/send-ussd | 57 ++ test/test-ussd | 75 3 files changed, 58 insertions(+), 76 deletions(-) create mode 100755 test/send-ussd delete mode 100755 test/test-ussd

[PATCH 1/2] test-ussd becomes send-ussd

2012-07-02 Thread Philippe Nunes
--- test/send-ussd | 75 test/test-ussd | 75 2 files changed, 75 insertions(+), 75 deletions(-) create mode 100755 test/send-ussd delete mode 100755 test/test-ussd diff --git

[PATCH 2/2] test-ussd: new script more generic

2012-07-02 Thread Philippe Nunes
This script can be used to handle network initiated USSD without preliminary USSD request. --- test/test-ussd | 97 1 file changed, 97 insertions(+) create mode 100755 test/test-ussd diff --git a/test/test-ussd b/test/test-ussd new file

[PATCH v2 0/4] phonesim: CBS/USSD improvments

2012-06-29 Thread Philippe Nunes
by the method 'split'. Philippe Nunes (4): controbase: Remove entries in CBM UI qcbsmessage: apply the same coding scheme for all the pages hardwaremanipulator: Use the best scheme for CBS message hardwaremanipulator: Add multi-page support for CBS message src/control.cpp |9

[PATCH v2 1/4] controbase: Remove entries in CBM UI

2012-06-29 Thread Philippe Nunes
--- src/controlbase.ui | 184 +++- 1 file changed, 67 insertions(+), 117 deletions(-) diff --git a/src/controlbase.ui b/src/controlbase.ui index ce675d2..4eb1355 100644 --- a/src/controlbase.ui +++ b/src/controlbase.ui @@ -393,7 +393,17 @@

[PATCH v2 2/4] qcbsmessage: apply the same coding scheme for all the pages

2012-06-29 Thread Philippe Nunes
--- src/qcbsmessage.cpp | 38 ++ src/qcbsmessage.h |1 - 2 files changed, 14 insertions(+), 25 deletions(-) diff --git a/src/qcbsmessage.cpp b/src/qcbsmessage.cpp index e4403ae..da975dd 100644 --- a/src/qcbsmessage.cpp +++ b/src/qcbsmessage.cpp @@

[PATCH v2 3/4] hardwaremanipulator: Use the best scheme for CBS message

2012-06-29 Thread Philippe Nunes
--- src/control.cpp |9 +++-- src/hardwaremanipulator.cpp | 42 -- src/hardwaremanipulator.h |6 -- 3 files changed, 19 insertions(+), 38 deletions(-) diff --git a/src/control.cpp b/src/control.cpp index 27910c2..9085acd

[PATCH v2 4/4] hardwaremanipulator: Add multi-page support for CBS message

2012-06-29 Thread Philippe Nunes
--- src/hardwaremanipulator.cpp | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/src/hardwaremanipulator.cpp b/src/hardwaremanipulator.cpp index 93a9e02..528f119 100644 --- a/src/hardwaremanipulator.cpp +++ b/src/hardwaremanipulator.cpp @@ -108,8

[PATCH 0/6] phonesim: CBS/USSD improvments

2012-06-27 Thread Philippe Nunes
this is handled internally. -USSD answer and cancellation commands are now supported. Philippe Nunes (6): controbase: Remove entries in CBM UI qcbsmessage: Add bestScheme method in QCBSMessage class hardwaremanipulator: Use the best scheme for CBS message hardwaremanipulator: Add multi-page

[PATCH 1/6] controbase: Remove entries in CBM UI

2012-06-27 Thread Philippe Nunes
--- src/controlbase.ui | 184 +++- 1 file changed, 67 insertions(+), 117 deletions(-) diff --git a/src/controlbase.ui b/src/controlbase.ui index ce675d2..4eb1355 100644 --- a/src/controlbase.ui +++ b/src/controlbase.ui @@ -393,7 +393,17 @@

[PATCH 2/6] qcbsmessage: Add bestScheme method in QCBSMessage class

2012-06-27 Thread Philippe Nunes
--- src/qcbsmessage.cpp | 10 -- src/qcbsmessage.h |1 + 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/qcbsmessage.cpp b/src/qcbsmessage.cpp index 0556cc0..e4403ae 100644 --- a/src/qcbsmessage.cpp +++ b/src/qcbsmessage.cpp @@ -396,9 +396,15 @@ void

[PATCH 3/6] hardwaremanipulator: Use the best scheme for CBS message

2012-06-27 Thread Philippe Nunes
--- src/control.cpp |9 +++ src/hardwaremanipulator.cpp | 61 ++- src/hardwaremanipulator.h |6 +++-- 3 files changed, 38 insertions(+), 38 deletions(-) diff --git a/src/control.cpp b/src/control.cpp index 27910c2..9085acd

[PATCH 4/6] hardwaremanipulator: Add multi-page support for CBS message

2012-06-27 Thread Philippe Nunes
--- src/hardwaremanipulator.cpp | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/hardwaremanipulator.cpp b/src/hardwaremanipulator.cpp index 3d0f54a..6753da1 100644 --- a/src/hardwaremanipulator.cpp +++ b/src/hardwaremanipulator.cpp @@ -127,8 +127,17 @@

[PATCH] test-ussd: USSD request is optional to monitor SS interface

2012-06-27 Thread Philippe Nunes
--- test/test-ussd | 60 ++-- 1 file changed, 41 insertions(+), 19 deletions(-) diff --git a/test/test-ussd b/test/test-ussd index c21f5e3..c8099b0 100755 --- a/test/test-ussd +++ b/test/test-ussd @@ -9,12 +9,28 @@ import dbus.mainloop.glib

[PATCH 1/7] control: Fix empty sender checking

2012-06-25 Thread Philippe Nunes
--- src/control.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/control.cpp b/src/control.cpp index ee1e7d8..27910c2 100644 --- a/src/control.cpp +++ b/src/control.cpp @@ -339,7 +339,7 @@ void ControlWidget::sendCBM() void ControlWidget::sendSMSMessage() { -

[PATCH 0/7] phonesim: Add UCS2 encoding support for CBS/USSD

2012-06-25 Thread Philippe Nunes
scheme) and send all the pages of the CBS message. Philippe Nunes (7): control: Fix empty sender checking controbase: Add combobox for CBS scheme selection qcbsmessage: Extend QCBSMessage class hardwaremanipulator: Add UCS2 encoding support for CBS message hardwaremanipulator: Add multi

[PATCH 3/7] qcbsmessage: Extend QCBSMessage class

2012-06-25 Thread Philippe Nunes
--- src/qcbsmessage.cpp | 140 ++- src/qcbsmessage.h |7 +++ 2 files changed, 146 insertions(+), 1 deletion(-) diff --git a/src/qcbsmessage.cpp b/src/qcbsmessage.cpp index fc17ae0..eb360bc 100644 --- a/src/qcbsmessage.cpp +++

[PATCH 2/7] controbase: Add combobox for CBS scheme selection

2012-06-25 Thread Philippe Nunes
--- src/controlbase.ui | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/src/controlbase.ui b/src/controlbase.ui index ce675d2..b1a9ff1 100644 --- a/src/controlbase.ui +++ b/src/controlbase.ui @@ -531,7 +531,7 @@

[PATCH 4/7] hardwaremanipulator: Add UCS2 encoding support for CBS message

2012-06-25 Thread Philippe Nunes
--- src/control.cpp |6 ++ src/hardwaremanipulator.cpp | 28 +++- src/hardwaremanipulator.h |6 -- 3 files changed, 21 insertions(+), 19 deletions(-) diff --git a/src/control.cpp b/src/control.cpp index 27910c2..89dd294 100644 ---

[PATCH 6/7] sms: Extend CBS message formating to use UCS2 scheme

2012-06-25 Thread Philippe Nunes
--- src/qsmsmessage.cpp | 119 +++ 1 file changed, 111 insertions(+), 8 deletions(-) diff --git a/src/qsmsmessage.cpp b/src/qsmsmessage.cpp index 1e2a317..c2eeb29 100644 --- a/src/qsmsmessage.cpp +++ b/src/qsmsmessage.cpp @@ -20,6 +20,7 @@

[PATCH 5/7] hardwaremanipulator: Add multi-page support for CBS message

2012-06-25 Thread Philippe Nunes
--- src/hardwaremanipulator.cpp | 35 +-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/src/hardwaremanipulator.cpp b/src/hardwaremanipulator.cpp index c19b507..b746229 100644 --- a/src/hardwaremanipulator.cpp +++ b/src/hardwaremanipulator.cpp @@

[PATCH 7/7] hardwaremanipulator: Add USC2 encoding support for USSD.

2012-06-25 Thread Philippe Nunes
--- src/hardwaremanipulator.cpp | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/src/hardwaremanipulator.cpp b/src/hardwaremanipulator.cpp index b746229..056480c 100644 --- a/src/hardwaremanipulator.cpp +++ b/src/hardwaremanipulator.cpp @@

[PATCH v2 2/2] SS: Return specific ofono errors after SS failure

2012-05-30 Thread Philippe Nunes
--- src/call-barring.c| 10 ++ src/call-forwarding.c |5 +++-- src/call-settings.c | 15 +-- 3 files changed, 18 insertions(+), 12 deletions(-) diff --git a/src/call-barring.c b/src/call-barring.c index ddf4c73..53847fb 100644 --- a/src/call-barring.c +++

[PATCH 0/6] Return specific ofono errors after SS transaction

2012-05-29 Thread Philippe Nunes
to map the telephony errors into ofono errors. I extended also the ofono error types to match more closely with the telephony errors. Philippe Nunes (6): common: Fix typos in error strings dbus: Add new error types error-mapping: Add function to map telephony errors into ofono error types

[PATCH 1/6] common: Fix typos in error strings

2012-05-29 Thread Philippe Nunes
--- src/common.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/common.c b/src/common.c index 62f2c5d..50106ac 100644 --- a/src/common.c +++ b/src/common.c @@ -49,13 +49,13 @@ struct error_entry cms_errors[] = { { 10, Call barred },

[PATCH 2/6] dbus: Add new error types

2012-05-29 Thread Philippe Nunes
--- src/dbus.c | 13 + src/ofono.h |2 ++ 2 files changed, 15 insertions(+) diff --git a/src/dbus.c b/src/dbus.c index 52e3a68..532 100644 --- a/src/dbus.c +++ b/src/dbus.c @@ -375,6 +375,19 @@ DBusMessage *__ofono_error_emergency_active(DBusMessage *msg)

[PATCH 3/6] error-mapping: Add function to map telephony errors into ofono error types

2012-05-29 Thread Philippe Nunes
--- src/error-mapping.c | 77 +++ src/error-mapping.h | 25 + 2 files changed, 102 insertions(+) create mode 100644 src/error-mapping.c create mode 100644 src/error-mapping.h diff --git a/src/error-mapping.c

[PATCH 4/6] build: Add error-mapping utility to build

2012-05-29 Thread Philippe Nunes
--- Makefile.am |1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index 19844d9..e1051a2 100644 --- a/Makefile.am +++ b/Makefile.am @@ -445,6 +445,7 @@ src_ofonod_SOURCES = $(gdbus_sources) $(builtin_sources) src/ofono.ver \ src/modem.c

[PATCH 5/6] Return specific ofono errors according telephony errors

2012-05-29 Thread Philippe Nunes
--- src/call-barring.c| 11 +++ src/call-forwarding.c |6 -- src/call-settings.c | 18 ++ 3 files changed, 21 insertions(+), 14 deletions(-) diff --git a/src/call-barring.c b/src/call-barring.c index ddf4c73..c983d90 100644 --- a/src/call-barring.c +++

[PATCH 6/6] Extend the list of ofono error types returned by the method initiate

2012-05-29 Thread Philippe Nunes
--- doc/supplementaryservices-api.txt |6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/supplementaryservices-api.txt b/doc/supplementaryservices-api.txt index e855ead..687a14e 100644 --- a/doc/supplementaryservices-api.txt +++ b/doc/supplementaryservices-api.txt @@ -27,6 +27,12

[PATCH] call-volume.c: Register the call-volume interface just after the +CMUT query

2012-02-16 Thread Philippe Nunes
With this change, the mute status and the volume level are initialised in the call-volume atom. This allows also to expose the call-volume interface even if the command +CLVL is not supported as it is the case for IFX. --- drivers/atmodem/call-volume.c |2 +- 1 files changed, 1 insertions(+),

[PATCH v4 1/6] gatchat: Add g_at_chat_set_slave_qcdm / g_at_chat_get_slave_qcdm

2012-01-18 Thread Philippe Nunes
--- gatchat/gatchat.c | 26 ++ gatchat/gatchat.h |4 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/gatchat/gatchat.c b/gatchat/gatchat.c index 7a0ef35..2fde572 100644 --- a/gatchat/gatchat.c +++ b/gatchat/gatchat.c @@ -35,6 +35,7 @@ #include

[PATCH v4 0/6] Provider name and SID

2012-01-18 Thread Philippe Nunes
to introduce a command queue in the GAtHDLC structure to be able to invoke properly the callbacks. Philippe. Philippe Nunes (6): gatchat: Add g_at_chat_set_slave_qcdm / g_at_chat_get_slave_qcdm huawei: Open qcdm port to fetch network status SID gatqcdm: Add helper functions for QCDM

[PATCH v4 2/6] huawei: Open qcdm port to fetch network status SID

2012-01-18 Thread Philippe Nunes
--- plugins/huawei.c | 44 1 files changed, 44 insertions(+), 0 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 5d8875a..58f8832 100644 --- a/plugins/huawei.c +++ b/plugins/huawei.c @@ -78,6 +78,7 @@ enum { struct huawei_data {

[PATCH v4 3/6] gatqcdm: Add helper functions for QCDM handling

2012-01-18 Thread Philippe Nunes
--- Makefile.am |1 + gatchat/gatqcdm.c | 84 + gatchat/gatqcdm.h | 57 3 files changed, 142 insertions(+), 0 deletions(-) create mode 100644 gatchat/gatqcdm.c create mode 100644

[PATCH v4 5/6] huaweimodem: Add 'serving_system' entry point to get SID

2012-01-18 Thread Philippe Nunes
--- drivers/huaweimodem/cdma-netreg.c | 108 + 1 files changed, 108 insertions(+), 0 deletions(-) diff --git a/drivers/huaweimodem/cdma-netreg.c b/drivers/huaweimodem/cdma-netreg.c index bf48b53..e9dd3e2 100644 --- a/drivers/huaweimodem/cdma-netreg.c +++

[PATCH v4 6/6] udevng: Add a default assignment for Huawei QCDM port

2012-01-18 Thread Philippe Nunes
--- plugins/udevng.c | 30 +- 1 files changed, 21 insertions(+), 9 deletions(-) diff --git a/plugins/udevng.c b/plugins/udevng.c index 2a9200d..7b0d60f 100644 --- a/plugins/udevng.c +++ b/plugins/udevng.c @@ -237,6 +237,7 @@ static gboolean setup_sierra(struct

Re: [PATCH_v0 2/3] huawei: Add modem type detection

2012-01-09 Thread Philippe Nunes
Hi Marcel, On 01/09/2012 02:47 PM, Deng, Ying An wrote: DBG(%p, modem); - ofono_devinfo_create(modem, 0, atmodem, data-pcui); - sim = ofono_sim_create(modem, OFONO_VENDOR_HUAWEI, + if (data-gsm == TRUE) { + ofono_devinfo_create(modem, 0, atmodem,

[PATCH v2 1/2] Add-udev-rules-for-Speedup-dongles

2011-12-21 Thread Philippe Nunes
--- plugins/ofono-speedup.rules | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) create mode 100644 plugins/ofono-speedup.rules diff --git a/plugins/ofono-speedup.rules b/plugins/ofono-speedup.rules new file mode 100644 index 000..f43fc7b --- /dev/null +++

[PATCH v2 2/2] Makefile: Add Speedup udev rules to EXTRA_DIST

2011-12-21 Thread Philippe Nunes
--- Makefile.am |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index 337aeb7..d41f03d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -564,7 +564,8 @@ testdir = $(pkglibdir)/test test_SCRIPTS = $(test_scripts) endif -EXTRA_DIST =

[PATCH 1/2] udevng: Do only label assignment for Speedup dongles

2011-12-20 Thread Philippe Nunes
--- plugins/udevng.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/plugins/udevng.c b/plugins/udevng.c index be87320..2c0633d 100644 --- a/plugins/udevng.c +++ b/plugins/udevng.c @@ -310,13 +310,6 @@ static gboolean setup_speedup(struct modem_info *modem)

[PATCH 2/2] Add udev rules for Speedup dongles

2011-12-20 Thread Philippe Nunes
--- plugins/ofono-speedup.rules | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) create mode 100644 plugins/ofono-speedup.rules diff --git a/plugins/ofono-speedup.rules b/plugins/ofono-speedup.rules new file mode 100644 index 000..f43fc7b --- /dev/null +++

Re: [PATCH 3/5] udevng.c: tty assignment according OFONO_LABEL should take precedence

2011-12-19 Thread Philippe Nunes
Hi Marcel, On 12/19/2011 06:48 AM, Marcel Holtmann wrote: Hi Philippe, plugins/udevng.c | 61 + 1 files changed, 38 insertions(+), 23 deletions(-) diff --git a/plugins/udevng.c b/plugins/udevng.c index be87320..6a3c970 100644 ---

Re: [PATCH 1/5] udev: Add rules to support ZTE MF668 dongle

2011-12-19 Thread Philippe Nunes
Hi Marcel, On 12/19/2011 06:49 AM, Marcel Holtmann wrote: Hi Philippe, plugins/ofono.rules |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/plugins/ofono.rules b/plugins/ofono.rules index 30a1b7e..c7fac57 100644 --- a/plugins/ofono.rules +++

  1   2   3   >