Re: [V3 PATCH 3/3] Huawei: set Huawei EM770W modem device to 00

2011-02-16 Thread Denis Kenzior
Hi Martin,

On 02/15/2011 01:03 AM, Xu, Martin wrote:
 Denis/Marcel:
 -Original Message-
 From: Denis Kenzior [mailto:denk...@gmail.com]
 Sent: Tuesday, February 15, 2011 4:28 AM
 To: ofono@ofono.org
 Cc: Xu, Martin
 Subject: Re: [V3 PATCH 3/3] Huawei: set Huawei EM770W modem device to 00

 Hi Martin,

 On 02/12/2011 03:41 AM, martin...@intel.com wrote:
 From: Martin Xu martin...@intel.com

 Device 00 is ppp port. Setting it as 01, my Huawei EM770W modem PPP
 connection can't work
 ---
  plugins/ofono.rules |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)


 This contradicts commit bb58a729073abcb6c5b0b2fb8b120973dfa42a07.
 I can't quite understand why Dietrich needs to this commit. We formal 
 configure can just make EM770W works.
 Could you help on this?

The Huawei firmware is funny, it can actually reconfigure the modem and
pcui ports (e.g. swap them).  So we might have to be a bit smarter and
figure out which ports are actually being used for what inside the modem
driver.

Talk to Marcel, I believe he has played with the Huawei hardware the
most and might have ideas on how to fix this.

Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [V3 PATCH 3/3] Huawei: set Huawei EM770W modem device to 00

2011-02-16 Thread Marcel Holtmann
Hi Denis,

  This contradicts commit bb58a729073abcb6c5b0b2fb8b120973dfa42a07.
  I can't quite understand why Dietrich needs to this commit. We formal 
  configure can just make EM770W works.
  Could you help on this?
 
 The Huawei firmware is funny, it can actually reconfigure the modem and
 pcui ports (e.g. swap them).  So we might have to be a bit smarter and
 figure out which ports are actually being used for what inside the modem
 driver.

so I did apply this patch now since in the default settings the MDM port
should be on interface 0. All other ones are tempered with.

 Talk to Marcel, I believe he has played with the Huawei hardware the
 most and might have ideas on how to fix this.

And yes, I will add auto-detection for this now. It should be be
possible to figure this out.

ofonod[908]: PCUI:  AT^GETPORTMODE\r
ofonod[908]: PCUI:  
\r\n^getportmode:type:WCDMA:Qualcomm,MDM:0,NDIS:1,DIAG:2,PCUI:3\r\n\r\nOK\r\n

All latest modules support ^GETPORTMODE command and the ones that don't
have only two ports anyway.

Regards

Marcel


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [V3 PATCH 3/3] Huawei: set Huawei EM770W modem device to 00

2011-02-14 Thread Denis Kenzior
Hi Martin,

On 02/12/2011 03:41 AM, martin...@intel.com wrote:
 From: Martin Xu martin...@intel.com
 
 Device 00 is ppp port. Setting it as 01, my Huawei EM770W modem PPP
 connection can't work
 ---
  plugins/ofono.rules |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 

This contradicts commit bb58a729073abcb6c5b0b2fb8b120973dfa42a07.

We really need a proper fix for this.

Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


RE: [V3 PATCH 3/3] Huawei: set Huawei EM770W modem device to 00

2011-02-14 Thread Xu, Martin
Denis/Marcel:
 -Original Message-
 From: Denis Kenzior [mailto:denk...@gmail.com]
 Sent: Tuesday, February 15, 2011 4:28 AM
 To: ofono@ofono.org
 Cc: Xu, Martin
 Subject: Re: [V3 PATCH 3/3] Huawei: set Huawei EM770W modem device to 00
 
 Hi Martin,
 
 On 02/12/2011 03:41 AM, martin...@intel.com wrote:
  From: Martin Xu martin...@intel.com
 
  Device 00 is ppp port. Setting it as 01, my Huawei EM770W modem PPP
  connection can't work
  ---
   plugins/ofono.rules |2 +-
   1 files changed, 1 insertions(+), 1 deletions(-)
 
 
 This contradicts commit bb58a729073abcb6c5b0b2fb8b120973dfa42a07.
I can't quite understand why Dietrich needs to this commit. We formal configure 
can just make EM770W works.
Could you help on this?
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


[V3 PATCH 3/3] Huawei: set Huawei EM770W modem device to 00

2011-02-12 Thread martin . xu
From: Martin Xu martin...@intel.com

Device 00 is ppp port. Setting it as 01, my Huawei EM770W modem PPP
connection can't work
---
 plugins/ofono.rules |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/plugins/ofono.rules b/plugins/ofono.rules
index 111f071..7dec243 100644
--- a/plugins/ofono.rules
+++ b/plugins/ofono.rules
@@ -37,7 +37,7 @@ ATTRS{idVendor}==12d1, ATTRS{idProduct}==1401, 
ENV{OFONO_IFACE_NUM}==02, E
 ATTRS{idVendor}==12d1, ATTRS{idProduct}==1402, ENV{OFONO_IFACE_NUM}==00, 
ENV{OFONO_HUAWEI_TYPE}=Modem
 ATTRS{idVendor}==12d1, ATTRS{idProduct}==1402, ENV{OFONO_IFACE_NUM}==02, 
ENV{OFONO_HUAWEI_TYPE}=Pcui
 
-ATTRS{idVendor}==12d1, ATTRS{idProduct}==1404, ENV{OFONO_IFACE_NUM}==01, 
ENV{OFONO_HUAWEI_TYPE}=Modem
+ATTRS{idVendor}==12d1, ATTRS{idProduct}==1404, ENV{OFONO_IFACE_NUM}==00, 
ENV{OFONO_HUAWEI_TYPE}=Modem
 ATTRS{idVendor}==12d1, ATTRS{idProduct}==1404, ENV{OFONO_IFACE_NUM}==02, 
ENV{OFONO_HUAWEI_TYPE}=Pcui
 ATTRS{idVendor}==12d1, ATTRS{idProduct}==1404, ENV{OFONO_HUAWEI_VOICE}=1
 
-- 
1.6.1.3

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH 3/3] Huawei: set Huawei EM770W modem device to 00

2011-01-20 Thread Lucas De Marchi
Hi Martin

On Thu, Jan 20, 2011 at 3:45 AM,  martin...@intel.com wrote:
 From: Martin Xu martin...@intel.com

 Device 00 is ppp port. Setting it as 01, my Huawei EM770W modem PPP
 connection can't work
 ---
  plugins/ofono.rules |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

We have to decide what to do here. Look at this commit:

commit bb58a729073abcb6c5b0b2fb8b120973dfa42a07
Author: M. Dietrich m...@emdete.de
Date:   Fri Dec 10 19:25:17 2010 +0100

huawei: set huawei em770 modem device to 01

device 00 is ppp capable while 01 is not. 01 does everything
else fine so ofono works with it flawlessly.



regards,
Lucas De Marchi
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


[PATCH 3/3] Huawei: set Huawei EM770W modem device to 00

2011-01-19 Thread martin . xu
From: Martin Xu martin...@intel.com

Device 00 is ppp port. Setting it as 01, my Huawei EM770W modem PPP
connection can't work
---
 plugins/ofono.rules |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/plugins/ofono.rules b/plugins/ofono.rules
index 111f071..7dec243 100644
--- a/plugins/ofono.rules
+++ b/plugins/ofono.rules
@@ -37,7 +37,7 @@ ATTRS{idVendor}==12d1, ATTRS{idProduct}==1401, 
ENV{OFONO_IFACE_NUM}==02, E
 ATTRS{idVendor}==12d1, ATTRS{idProduct}==1402, ENV{OFONO_IFACE_NUM}==00, 
ENV{OFONO_HUAWEI_TYPE}=Modem
 ATTRS{idVendor}==12d1, ATTRS{idProduct}==1402, ENV{OFONO_IFACE_NUM}==02, 
ENV{OFONO_HUAWEI_TYPE}=Pcui
 
-ATTRS{idVendor}==12d1, ATTRS{idProduct}==1404, ENV{OFONO_IFACE_NUM}==01, 
ENV{OFONO_HUAWEI_TYPE}=Modem
+ATTRS{idVendor}==12d1, ATTRS{idProduct}==1404, ENV{OFONO_IFACE_NUM}==00, 
ENV{OFONO_HUAWEI_TYPE}=Modem
 ATTRS{idVendor}==12d1, ATTRS{idProduct}==1404, ENV{OFONO_IFACE_NUM}==02, 
ENV{OFONO_HUAWEI_TYPE}=Pcui
 ATTRS{idVendor}==12d1, ATTRS{idProduct}==1404, ENV{OFONO_HUAWEI_VOICE}=1
 
-- 
1.6.1.3

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono