Re: [RFC] AGPS Support

2010-11-03 Thread Aki Niemi
Hi, 2010/11/3 Sjur Brændeland : > I was previously under the false impression that you wanted oFono API > to export AGPS functionality using dbus types only. Piping the AGPS > XML (or ASN.1 coded data) > through oFono certainly makes the oFono implementation much simpler. > I'm all for that :-) I

Re: [PATCH] isigen: increase offline timeout

2010-11-03 Thread Aki Niemi
Hi Pekka, On Wed, 2010-11-03 at 19:30 +0100, ext Pekka Pessi wrote: > > are you sure you just wanna hardcode it like this and not use a proper > > constant for it? > > I'm not sure. It might depend on modem. Aki? Let's go with a proper constant, and make it sufficiently large. If it turns out th

Re: [PATCH 1/4] gisi: fix crash bug in g_isi_remove_subscription

2010-11-11 Thread Aki Niemi
Hi Mika, 2010/11/10 Mika Liljeberg : > --- >  gisi/client.c |    7 +-- >  1 files changed, 5 insertions(+), 2 deletions(-) Patch has been applied. Thanks. Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 2/4] gisi: return NULL instead of asserting

2010-11-11 Thread Aki Niemi
Hi Mika, 2010/11/10 Mika Liljeberg : > --- >  gisi/pep.c |    6 -- >  1 files changed, 4 insertions(+), 2 deletions(-) Patch has been applied. Thanks. Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 3/4] isimodem: revector GPRS context driver

2010-11-11 Thread Aki Niemi
Hi Mika, 2010/11/10 Mika Liljeberg : > --- >  drivers/isimodem/gprs-context.c |  280 > +-- >  1 files changed, 121 insertions(+), 159 deletions(-) Patch has been applied. Thanks! Cheers, Aki ___ ofono mailing list o

[RFC] Refactoring ISI modem support

2010-11-14 Thread Aki Niemi
Hi All, I've been working on improving the ISI modem support in oFono, mostly concentrating on the gisi library, but also on tweaking the drivers and plugins. You can follow the progress of this 'gisi' branch here: git://gitorious.org/~akiniemi/meego-cellular/ofono-aki.git http://meego.gitorious

Re: [RERESEND] [PATCH 2/2] Update the network documentation

2010-11-23 Thread Aki Niemi
Hi, 2010/11/23 Denis Kenzior : > In fact we were planning to report the current bearer on the > ConnectionManager interface once we figured out the vendor commands that > can actually report this information. Do you mean HSDPA/HSUPA channel allocations, or the tech reported by CGREG? Because thes

[PATCH] TODO: Add a new task for CELL_DCH state indication

2010-11-24 Thread Aki Niemi
purposes as well, i.e., in CELL_DCH state. + + Priority: Medium + Complexity: C4 + Owner: Aki Niemi -- 1.7.1 ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] isi: Fix issue in call forwarding erase response

2010-11-24 Thread Aki Niemi
Hi Jeevaka, 2010/11/24 Jeevaka Badrappan : > --- >  drivers/isimodem/call-forwarding.c |   20 ++-- >  1 files changed, 14 insertions(+), 6 deletions(-) > > diff --git a/drivers/isimodem/call-forwarding.c > b/drivers/isimodem/call-forwarding.c > index 1448451..c364bdf 100644 > ---

RE: How to get the OMA DRM right object file coming from WAP Push?

2010-11-25 Thread Aki Niemi
On Thu, 2010-11-25 at 14:15 +0800, ext Lin, Mengdong wrote: > Can the two methods help me to handle files from WAP push? Yes. You need to implement the PushNotificationAgent interface, and register this object with oFono using the RegisterAgent() method. Cheers, Aki __

Re: [PATCH] Add voice call boolean property for MO/MT distinction

2010-11-30 Thread Aki Niemi
Hi Marcel, 2010/11/30 Marcel Holtmann : > I am getting a bit sick of this secrecy. oFono is for all intense and > purposes open source. So if you want a proper discussion here then > please list the AT command in question. So this patch seems to be to enable reporting call direction as part of re

Re: [PATCH] coding-style M14: parenthesis around sizeof arg

2010-12-03 Thread Aki Niemi
On Fri, 2010-12-03 at 11:05 +0200, ext pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > --- > doc/coding-style.txt | 14 ++ > 1 files changed, 14 insertions(+), 0 deletions(-) Pushed, thanks. Cheers, Aki ___ ofono mailing list ofon

Re: [fix-isi-voicecall PATCHv5 0/4] Call state fixes

2010-12-03 Thread Aki Niemi
On Fri, 2010-12-03 at 10:30 +0200, ext pekka.pe...@nokia.com wrote: > Hi all, > > Here are the isi voicecall patches again, rebased with the NULL fixes. Pushed the lot, thanks. Are these fixes now also in the refactored gisi tree? ;) Cheers, Aki ___

[PATCH] TODO: Add task for NITZ name support in netreg

2010-12-03 Thread Aki Niemi
available. + + Priority: Medium + Complexity: C1 + Owner: Aki Niemi -- 1.7.1 ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH] TODO: Add task for GSMA name list support

2010-12-03 Thread Aki Niemi
--- TODO |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index 457c9a1..b63b834 100644 --- a/TODO +++ b/TODO @@ -507,3 +507,12 @@ Miscellaneous Priority: Medium Complexity: C1 Owner: Aki Niemi + +- Add GSM Association (GSMA) name list support

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-03 Thread Aki Niemi
Hi Antti, 2010/12/3 Antti Paila : > +static GDBusMethodTable nettime_methods[] = { > +       { "GetNetworkTime", "", "a{sv}", nettime_get_time }, > +       { } > +}; > + > +static GDBusSignalTable nettime_signals[] = { > +       { "NetworkTimeChanged", "a{sv}" }, > +       { } > +}; The only thin

Re: [PATCH 2/2] drivers: use %m instead of strerror()

2010-12-03 Thread Aki Niemi
Hi Rémi, 2010/12/3 Rémi Denis-Courmont : > --- >  drivers/isimodem/sim.c |    3 ++- >  1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/isimodem/sim.c b/drivers/isimodem/sim.c > index b79c52a..0b3d2ae 100644 > --- a/drivers/isimodem/sim.c > +++ b/drivers/isimodem/sim.c > @

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-04 Thread Aki Niemi
Hi Marcel, 2010/12/4 Marcel Holtmann : > where is this timed running? I prefer the plugin just send a D-Bus > message to the timed directly instead of a Get/Changed API kind of > thing. AFAIK, timed is in system bus. However, I fail to see how you can make this any simpler. In the end, one of the

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-06 Thread Aki Niemi
Hi Rémi, 2010/12/6 Rémi Denis-Courmont : >> +static struct tm *refresh_nw_time(struct tm *nw_time, >> +                             time_t received) >> +{ >> +     time_t now, new_nw_time; >> + >> +     now = get_monotonic_time(); >> +     new_nw_time = timegm(nw_time) + now - received; >> +     r

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-07 Thread Aki Niemi
Hi Andras, 2010/11/22 Andras Domokos : > Here a proposal for call counters implementation for keeping track > of the total incoming and outgoing call duration counters. Each > established call instance is contributing to either of the call > duration counters. The 2 counters are updated periodical

Re: [RFC PATCH 4/4] voicecall: add emergency call handling

2010-12-07 Thread Aki Niemi
Hi Andras, 2010/11/24 Andras Domokos : > Thanks for the comments, I am going to resend the patch with > the changes I made based on your comments. Can you resend the entire set? At least I've lost track with where each individual patch stands... Cheers, Aki __

Re: [PATCH 1/3] sms: store pending tx pdus on disk

2010-12-07 Thread Aki Niemi
Hi Kristen, 2010/11/25 Kristen Carlson Accardi : > @@ -1923,6 +1928,8 @@ int __ofono_sms_txq_submit(struct ofono_sms *sms, > GSList *list, >                        sms->ref = sms->ref + 1; >        } > > +       entry->id = tx_counter++; > + >        g_queue_push_tail(sms->txq, entry); Can't you

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-08 Thread Aki Niemi
Hi Rémi, On Tue, 2010-12-07 at 18:12 +0200, ext Rémi Denis-Courmont wrote: > More than one second delay over D-Bus is not unheard of, especially on mobile > devices. I don't see the point of sending _both_ the reception timestamp and > the original NITZ value, but I do see the point in sending a

Re: [PATCH 1/3] plugins: Implementation of Network Time plugin

2010-12-08 Thread Aki Niemi
Hi Marcel, 2010/12/8 Marcel Holtmann : >> is timed actually open source and I can have a look at it? > > so what about this? Where is the timed respository? I really wanna have > a look at it and see what it is doing. Knock yourself out: http://meego.gitorious.org/meego-middleware/timed Cheers,

Re: [PATCH 0/5] Call Counters (2nd)

2010-12-08 Thread Aki Niemi
Hi Marcel, 2010/12/8 Marcel Holtmann : > so Denis and I talked about this a little bit and I am not fine with > this at all. Next time, can you invite me to join your little talk? > Lets take this one step and please explain to me what your requirements > and objectives are. I also wanna see a t

Re: [PATCH 1/4] gisi: Changes to prepare for isimodem2.5

2010-12-08 Thread Aki Niemi
Hi, On Wed, 2010-12-08 at 14:17 +0100, ext Jessica Nilsson wrote: > > Also is this in sync with the GISI re-write Aki is doing? > thank you for your comments. > We are studying what Aki is doing and are in contact with him and will > get back to this. One item I can see is missing is the ability

Re: [PATCH 3/4] isimodem2.5: Changes to add isimodem2.5

2010-12-08 Thread Aki Niemi
Hi Jessica, 2010/12/8 Jessica Nilsson : > +static void reset_buf(char *buf, char *buf_2, int buf_len) > +{ > +       memset(buf, '\0', buf_len); > +       memset(buf_2, '\0', buf_len); > +} > + > +static int get_topics_len(const char *topics) > +{ > +       int i = 0; > +       int k = 0; > +    

Re: [PATCH] TODO: Add task for NITZ name support in netreg

2010-12-08 Thread Aki Niemi
Hi Denis, 2010/12/3 Denis Kenzior : > Out of curiosity, how do you plan to support this on AT modems?  I have > yet to see any AT modem report the NITZ network name via a proprietary > command. Are you sure? In my experience, the NITZ name may be received moments after registration, so it would m

Re: [PATCH] TODO: Add task for NITZ name support in netreg

2010-12-09 Thread Aki Niemi
Hi Denis, 2010/12/9 Denis Kenzior : > The NITZ notification does indeed arrive unsolicited.  However, no AT > modem that I know of reports the received NITZ name.  This is only > reported via COPS.  The best you can do is call COPS again after the > driver reports ofono_netreg_time_notify. Then t

Re: oFono release plan?

2010-12-21 Thread Aki Niemi
Hi Marcel, 2010/12/21 Marcel Holtmann : > the upcoming LTE support holds us a little bit back. So Denis and I are > a bit careful about calling it 1.0 just yet. Can you elaborate here? I thought the conclusion of our discussions was that the D-Bus API will see practically no changes due to LTE.

Re: [PATCH 0/4 v2] Network Time plugin

2010-12-21 Thread Aki Niemi
Hi Marcel, 2010/12/21 Marcel Holtmann : > I am still saying that the plugin should monitor the presence of timed > and then just send a D-Bus message to timed. That saves us the problem > with the timestamping. There is no problem. If you still think there is a problem, you need to continue the p

Re: oFono release plan?

2010-12-21 Thread Aki Niemi
Hi Marcel, 2010/12/21 Marcel Holtmann : > we don't know that yet for sure. They might be all internal, but there > might be also D-Bus visible changes. We will see once LTE support lands > in oFono. Well, from my point of view there are some key APIs we know for sure are missing. Off the top of m

Re: [PATCH 0/4 v2] Network Time plugin

2010-12-21 Thread Aki Niemi
Hi Rémi, 2010/12/21 Rémi Denis-Courmont : > On Tuesday 21 December 2010 17:54:53 ext Aki Niemi, you wrote: >>  It might make sense in some platforms, >> especially those that don't have a working monotonic clock... > > That's a stupid requirement. Without a work

Re: [PATCH 0/4 v2] Network Time plugin

2010-12-21 Thread Aki Niemi
Hi Marcel, 2010/12/21 Marcel Holtmann : > true, but as long as you guys are proposing an official org.ofono API it > has to fit in a general context of oFono. We can stuff this under meego.com instead, no problem. > So that got fixed. Is this really enough for you guys to just normalize > the va

Re: [RFC] Refactoring ISI modem support

2010-12-22 Thread Aki Niemi
Hi All, 2010/11/15 Aki Niemi : > I've been working on improving the ISI modem support in oFono, mostly > concentrating on the gisi library, but also on tweaking the drivers > and plugins. You can follow the progress of this 'gisi' branch here: This branch has now be

Re: [RFC PATCH 1/5 v2] cell-info: Atom for ECID info of neighb cells

2010-12-22 Thread Aki Niemi
Hi Antti, On Wed, 2010-12-22 at 11:35 +0200, ext Antti Paila wrote: > --- > src/cell-info.c | 484 > +++ > 1 files changed, 484 insertions(+), 0 deletions(-) > create mode 100644 src/cell-info.c > > diff --git a/src/cell-info.c b/src/cell-in

Re: [RFC PATCH 2/5 v2] cell-info: Header file for cell-info atom

2010-12-22 Thread Aki Niemi
Hi Antti, On Wed, 2010-12-22 at 11:35 +0200, ext Antti Paila wrote: > --- > include/cell-info.h | 133 > +++ > 1 files changed, 133 insertions(+), 0 deletions(-) > create mode 100644 include/cell-info.h > > diff --git a/include/cell-info.h b/inc

Re: [RFC PATCH 5/5 v2] cell-info: Documentation

2010-12-22 Thread Aki Niemi
Hi Antti, On Wed, 2010-12-22 at 11:35 +0200, ext Antti Paila wrote: > --- > doc/cell-info.txt | 110 > + > 1 files changed, 110 insertions(+), 0 deletions(-) > create mode 100644 doc/cell-info.txt > > diff --git a/doc/cell-info.txt b/doc/cel

Re: oFono release plan?

2010-12-23 Thread Aki Niemi
Hi Sankar, On Thu, 2010-12-23 at 15:16 +0530, ext Sankar wrote: > Can you please add more light on what all is planned under the CDMA > support. See under doc the cdma-* files. However, these are proposals still, and code is just being submitted for implementing these. That is not yet 1.0 materi

Re: [PATCH 5/5] cell-info: Documentation

2010-12-29 Thread Aki Niemi
Hi Antti, 2010/12/29 Antti Paila : > The GetProperties was kind of last minute glue-on but it was not without > a reason. This atom is about cell info and hence I implicitly assumed > that when you want to query the properties of a cell you would mean the > cell that is your current serving cell.

Re: [RFC PATCHv2 1/4] Automatic provisioning of GPRS context settings

2011-01-03 Thread Aki Niemi
Moi, On Mon, 2011-01-03 at 10:57 +0200, ext Kalle Valo wrote: > Any particular reason why you can't use the > same format as in mobile-broadband-provider-info? I think reusing the format here makes sense, actually. If not for anything else than to be able to use an existing database for testing.

Re: [RFC PATCHv2 1/4] Automatic provisioning of GPRS context settings

2011-01-03 Thread Aki Niemi
Hi Kalle, On Mon, 2011-01-03 at 13:40 +0200, ext Kalle Valo wrote: > If you want to use XML, why not do it properly? XML parsing can't be > that performance critical. And if it is (to my great surprise), then XML > is not the correct choise for this. Many experts would claim proper use of XML mea

Re: [PATCH 0/4 v2] Network Time plugin

2011-01-04 Thread Aki Niemi
Hi Marcel, On Tue, 2011-01-04 at 01:41 -0800, ext Marcel Holtmann wrote: > > But then it is far simpler to have a D-Bus getter and a D-Bus signal by any > > sane measure of complexity. > > So you did consider the complexity on both sides, ofonod and timed? And > not just looked at one side of pi

Re: [PATCHv2] network: query signal strength

2011-01-05 Thread Aki Niemi
Hi Marit, 2010/12/17 Marit Henriksen : > From: Marit Henriksen > > Signal strength is set to -1 whenever registration status changes > and differs from registered or roaming. When registration status > changes again to registered or roaming, the signal strength needs to > be updated, added query

Re: [RFC PATCH] gprs: add function to handle activated context

2011-01-07 Thread Aki Niemi
Hi, 2011/1/7 Rémi Denis-Courmont : > On Thursday 06 January 2011 02:12:01 ext Marcel Holtmann, you wrote: >> > If such context is not found create a new one with "Internet" type. >> >> I don't really agree that we should create a context if no match is >> found. I think the better sensible strateg

Re: [PATCHv3] network: query signal strength

2011-01-10 Thread Aki Niemi
Hi Marcel, 2011/1/6 Marcel Holtmann : > Aki, since you remove that check originally, please double check that > this does not break for you. This should work ok. Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 1/1] Add voice call boolean property for MO/MT distinction

2011-01-10 Thread Aki Niemi
Hi Rémi, 2011/1/4 Rémi Denis-Courmont : > --- >  doc/voicecall-api.txt |    5 + >  src/voicecall.c       |    6 +- >  2 files changed, 10 insertions(+), 1 deletions(-) > > diff --git a/doc/voicecall-api.txt b/doc/voicecall-api.txt > index 4f38e6a..682b46b 100644 > --- a/doc/voicecall-api.t

Re: [PATCH 3/4] Bearer documentation

2011-01-10 Thread Aki Niemi
Hi Marcel, On Mon, 2011-01-10 at 16:26 -0800, ext Marcel Holtmann wrote: > As Denis said, the vendor commands indicate that it is a global bearer > information. If one context is on HSPA, then others will be as well. So > how does ISI provide this information? Is it globally or per context? I dou

[PATCH] TODO: Add task for main.conf

2011-01-12 Thread Aki Niemi
general + as well as per-atom configuration options that are read and parsed + at startup from a configuration file under /etc/ofono. + + Priority: Medium + Complexity: C1 + Owner: Aki Niemi + CDMA Voicecall == -- 1.7.1 ___ ofono

Re: [PATCH 1/5 v3] nettime: Header file for nettime plugins

2011-01-13 Thread Aki Niemi
Hi Antti, 2011/1/13 Antti Paila : > --- >  include/nettime.h |    4 >  1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/include/nettime.h b/include/nettime.h > index 0f23cc7..2f73e1a 100644 > --- a/include/nettime.h > +++ b/include/nettime.h > @@ -31,6 +31,10 @@ struct ofono_

[PATCH] TODO: Add task for adding EFcsp support

2011-01-13 Thread Aki Niemi
sed on the PLMN mode value, manual network selection needs to either be + enabled or disabled in the netreg atom. Also to accommodate this, there + probably needs to be a new 'forced' mode to indicate that manual network + selection is disabled. + + Priority: Medium + Complexity: C1

Re: [PATCH 3/5 v3] nettime: DBUS and compilation configuration

2011-01-17 Thread Aki Niemi
Hi, 2011/1/17 Denis Kenzior : >> So these are redundant, unless the whole thing is rewritten as: >> >>       > send_interface="org.ofono.SimToolkitAgent"/> >>       > send_interface="org.ofono.PushNotificationAgent"/> >>       > send_interface="org.ofono.SmartMessagingAgent"/> >> > > The agents ar

Re: [PATCH] TODO: Add task for adding EFcsp support

2011-01-17 Thread Aki Niemi
Hi, 2011/1/13 Aki Niemi : > This task will add support for CPHS Customer Service Profile (CSP), > and specifically for the CSP PLMN mode bit therein. > --- >  TODO |   13 + >  1 files changed, 13 insertions(+), 0 deletions(-) Unless there are objections, I will pus

[PATCH 1/5] simutil: Add EFcsp file and service group IDs

2011-01-18 Thread Aki Niemi
--- src/simutil.h | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index 7e386fa..61440a5 100644 --- a/src/simutil.h +++ b/src/simutil.h @@ -26,6 +26,7 @@ enum sim_fileid { SIM_EFLI_FILEID = 0x6F05,

[PATCH 0/5] Implement CPHS CSP support

2011-01-18 Thread Aki Niemi
f a search engine. ;) Aki Niemi (5): simutil: Add EFcsp file and service group IDs netreg: Add CPHS CSP PLMN mode implementation doc: Add documentation for 'forced-mode' doc: Add short mention of CPHS under standards TODO: Remove completed CPHS CSP task TODO

[PATCH 2/5] netreg: Add CPHS CSP PLMN mode implementation

2011-01-18 Thread Aki Niemi
--- src/network.c | 85 - 1 files changed, 84 insertions(+), 1 deletions(-) diff --git a/src/network.c b/src/network.c index ae0f334..927f7ce 100644 --- a/src/network.c +++ b/src/network.c @@ -66,6 +66,7 @@ struct ofono_netreg { in

[PATCH 4/5] doc: Add short mention of CPHS under standards

2011-01-18 Thread Aki Niemi
--- doc/standards.txt |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/doc/standards.txt b/doc/standards.txt index 2b85cb0..35f2a3a 100644 --- a/doc/standards.txt +++ b/doc/standards.txt @@ -166,3 +166,12 @@ Describes the general background and assumption of wirele

[PATCH 5/5] TODO: Remove completed CPHS CSP task

2011-01-18 Thread Aki Niemi
. Also to accommodate this, there - probably needs to be a new 'forced' mode to indicate that manual network - selection is disabled. - - Priority: Medium - Complexity: C1 - Owner: Aki Niemi - Modem Emulator == -- 1.7.1 ___ ofon

[PATCH 3/5] doc: Add documentation for 'forced-mode'

2011-01-18 Thread Aki Niemi
--- doc/network-api.txt | 24 ++-- 1 files changed, 14 insertions(+), 10 deletions(-) diff --git a/doc/network-api.txt b/doc/network-api.txt index c252988..c46e81b 100644 --- a/doc/network-api.txt +++ b/doc/network-api.txt @@ -75,21 +75,25 @@ Properties string Mode [readonl

Re: [PATCH 2/5] netreg: Add CPHS CSP PLMN mode implementation

2011-01-18 Thread Aki Niemi
Hi Marcel, 2011/1/18 Marcel Holtmann : >> +     if (netreg->settings) { >> +             g_key_file_set_boolean(netreg->settings, SETTINGS_GROUP, >> +                                     "ForcedAuto", netreg->forced_auto); >> +             storage_sync(netreg->imsi, SETTINGS_STORE, netreg->setting

Re: [PATCH 2/5] netreg: Add CPHS CSP PLMN mode implementation

2011-01-18 Thread Aki Niemi
Hi Denis, 2011/1/18 Denis Kenzior : >> We read the value always, yes, but storing the last known value rids >> us of a superfluous PropertyChanged signal in the case when last value >> of forced_auto was true, and after reading is still true. This is >> because forced_auto is by default set to fal

Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'

2011-01-18 Thread Aki Niemi
Hi Marcel, 2011/1/18 Marcel Holtmann : >> +                             "auto"         Network registration is >> performed >> +                                            automatically. >> +                             "forced-auto"  Network registration is >> performed >> +                    

Re: [gisi-notify-fix PATCH 1/4] gisi: remove before notify

2011-01-18 Thread Aki Niemi
Hi Pekka, 2011/1/12 : > @@ -192,24 +223,18 @@ static void service_dispatch(GIsiServiceMux *mux, > GIsiMessage *msg, >                        pending_dispatch(pend, msg); > >                } else if (pend->type == GISI_MESSAGE_TYPE_RESP && > -                               !is_indication && pend

Re: [gisi-notify-fix PATCH 4/4] isimodem: fix crash in gprs

2011-01-18 Thread Aki Niemi
Hi Pekka, 2011/1/12 : > From: Pekka Pessi > > There was a crash if gprs was removed while creating context. > --- >  drivers/isimodem/gprs.c |    3 +++ >  1 files changed, 3 insertions(+), 0 deletions(-) Patch was pushed, thanks. Cheers, Aki ___ ofon

Re: [gisi-notify-fix PATCH 2/4] gisi: simplify handling of pending

2011-01-18 Thread Aki Niemi
Hi Pekka, 2011/1/12 : > diff --git a/gisi/modem.h b/gisi/modem.h > index fff1338..91fe3d0 100644 > --- a/gisi/modem.h > +++ b/gisi/modem.h > @@ -109,7 +109,9 @@ int g_isi_response_vsend(GIsiModem *modem, const > GIsiMessage *req, > >  GIsiPending *g_isi_pending_from_msg(const GIsiMessage *msg);

Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'

2011-01-18 Thread Aki Niemi
Hi Marcel, 2011/1/18 Marcel Holtmann : > And while thinking about this, now I have another question. If this flag > is set on the SIM card, are you allowed to deregister from the network? I suppose so. However, you know how I feel about Deregister() to begin with. I think with the Online property

Re: [gisi-notify-fix PATCHv2 1/2] gisi: simplify pending management

2011-01-18 Thread Aki Niemi
Hi Pekka, 2011/1/18 : > From: Pekka Pessi > > Client or server mark their pending objects with > the function g_isi_pending_set_owner(). > > When client or server get destroyed or reset the pending objects are > removed with the function g_isi_remove_pending_by_owner(). As a client > or server a

Re: [gisi-notify-fix PATCHv2 2/2] gisi: remove g_isi_pending_from_msg()

2011-01-18 Thread Aki Niemi
Hi Pekka, 2011/1/18 : > From: Pekka Pessi > > --- >  gisi/modem.c |    9 - >  gisi/modem.h |    2 -- >  2 files changed, 0 insertions(+), 11 deletions(-) Pushed, thanks! Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofono.or

Re: [PATCH 3/5 v3] nettime: DBUS and compilation configuration

2011-01-19 Thread Aki Niemi
Hi Marcel, 2011/1/18 Marcel Holtmann : > please don't implement org.ofono interface in timed. Just implement a > timed specific (com.nokia.time) interface and punch the whole for that > in the timed D-Bus policy. I think there is some disconnect here. The intention is to implement a similar agent

[PATCH] voicecall: Fix emergency number handling

2011-01-19 Thread Aki Niemi
If the SIM is present but doesn't contain any emergency numbers, the set of emergency numbers needs to be reset to the default list. This patch fixes the list shown in the SIM present case by removing numbers from the list that are for the no-SIM case only. --- src/voicecall.c | 19 +

Re: [PATCH] voicecall: Fix emergency number handling

2011-01-19 Thread Aki Niemi
Self, 2011/1/19 Aki Niemi : > @@ -2095,11 +2095,11 @@ static void ecc_g2_read_cb(int ok, int total_length, > int record, >        DBG("%d", ok); > >        if (!ok) > -               return; > +               goto check; > >        if (total_length < 3) {

[PATCHv2] voicecall: Fix emergency number handling

2011-01-19 Thread Aki Niemi
If the SIM is present but doesn't contain any emergency numbers, the set of emergency numbers needs to be reset to the default list. This patch fixes the list shown in the SIM present case by removing numbers from the list any ENs that are for the no-SIM case only. --- src/voicecall.c |7

Re: [PATCH 3/5] doc: Add documentation for 'forced-mode'

2011-01-19 Thread Aki Niemi
Hi Denis, 2011/1/18 Denis Kenzior : > I'm fine with forced-auto, but we might want to add a new error type to > ofono.h (maybe something like ManualRegistrationNotAllowed) and return > that error when trying to use Scan or NetworkOperator.Register. I was reusing the __ofono_error_access_denied(),

[PATCH 0/6] Deprecate the Deregister() method

2011-01-19 Thread Aki Niemi
Hi All, This set of patches removes the Deregister() method from the netreg atom. This method serves no purpose, since the Online property is used to control oFono's radio on/off state. Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofo

[PATCH 2/6] isimodem: Remove deregister implementation

2011-01-19 Thread Aki Niemi
--- drivers/isimodem/network-registration.c |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/drivers/isimodem/network-registration.c b/drivers/isimodem/network-registration.c index 47aaeb1..6518968 100644 --- a/drivers/isimodem/network-registration.c +++ b/drivers/

[PATCH 1/6] netreg: Deprecate the deregister method

2011-01-19 Thread Aki Niemi
--- src/network.c | 37 ++--- 1 files changed, 2 insertions(+), 35 deletions(-) diff --git a/src/network.c b/src/network.c index ae0f334..1f66f34 100644 --- a/src/network.c +++ b/src/network.c @@ -43,8 +43,6 @@ enum network_registration_mode { NETWORK_RE

[PATCH 4/6] api: Remove deregister from modem driver API

2011-01-19 Thread Aki Niemi
--- include/netreg.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/include/netreg.h b/include/netreg.h index a88301d..26a3442 100644 --- a/include/netreg.h +++ b/include/netreg.h @@ -84,8 +84,6 @@ struct ofono_netreg_driver { void (*register_manual)(struct ofono

[PATCH 3/6] atmodem: Remove deregister implementation

2011-01-19 Thread Aki Niemi
--- drivers/atmodem/network-registration.c | 20 1 files changed, 0 insertions(+), 20 deletions(-) diff --git a/drivers/atmodem/network-registration.c b/drivers/atmodem/network-registration.c index e11c974..4b8cc34 100644 --- a/drivers/atmodem/network-registration.c +++ b/

[PATCH 6/6] test: Remove deregister support from test script

2011-01-19 Thread Aki Niemi
--- test/test-network-registration |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/test/test-network-registration b/test/test-network-registration index a8bd141..0c25885 100755 --- a/test/test-network-registration +++ b/test/test-network-registration @@ -18,8 +18,6 @@

[PATCH 5/6] doc: Remove deregister method documentation

2011-01-19 Thread Aki Niemi
--- doc/network-api.txt |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/doc/network-api.txt b/doc/network-api.txt index 3e705e6..75187cd 100644 --- a/doc/network-api.txt +++ b/doc/network-api.txt @@ -30,12 +30,6 @@ Methods dict GetProperties()

Re: [PATCH 2/6] Define packet switched bearers

2011-01-19 Thread Aki Niemi
Hi Rémi, 2011/1/19 Rémi Denis-Courmont : > --- >  src/common.c |   23 +++ >  src/common.h |   13 + >  2 files changed, 36 insertions(+), 0 deletions(-) > > diff --git a/src/common.c b/src/common.c > index d4e567b..2dd0da0 100644 > --- a/src/common.c > +++ b/src/comm

Re: [PATCH 5/6] GPRS: document bearer property

2011-01-20 Thread Aki Niemi
Hi Rémi, 2011/1/19 Rémi Denis-Courmont : > --- >  doc/connman-api.txt |   10 ++ >  1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/doc/connman-api.txt b/doc/connman-api.txt > index 22e02e5..13f622c 100644 > --- a/doc/connman-api.txt > +++ b/doc/connman-api.txt > @@ -77,6

Re: [RFC] TODO: Move signal strength property to separate Agent API.

2011-01-20 Thread Aki Niemi
Hi Marcel, 2011/1/20 Marcel Holtmann : > I don't think is needed. You do not get woken up until you tell D-Bus to > wake you up on that PropertyChanged signal. You can even match the first > parameter of that signal if you desire. I think this is still a worthy optimization, because this way not

[PATCH] core: Always return success to a no-op

2011-01-20 Thread Aki Niemi
A SetProperty that doesn't actually change the Online property's state when no change to that state is pending, should not fail. It should always succeed regardless of the current modem state. --- src/modem.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/modem.c

Re: [PATCH] isimodem: fix issue with user busy release

2011-01-21 Thread Aki Niemi
Hi Jeevaka, 2011/1/21 Jeevaka Badrappan : > when the user rejects the incoming call, hangup_active > will get called on the driver side whereas when the user > rejects the waiting call, set_udub will get called on the > driver side. > --- >  drivers/isimodem/voicecall.c |   13 + >  1 f

Re: [PATCH] isimodem: fix sending DTMF

2011-01-21 Thread Aki Niemi
Hi Kai, 2011/1/20 Kai Vehmanen : > isi_call_dtmf_send_resp() handles the success case incorrectly, and > thus all send_tones attempts fail with bogus error codes. > --- >  drivers/isimodem/voicecall.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) Patch has been pushed, thanks! Ch

Re: SAT support in oFono

2011-01-24 Thread Aki Niemi
Hi Lasse, 2011/1/24 Lasse Kunnasluoto : >> Let us set aside the the merits of the use cases for these features for >> the moment ;)  Implementing Call control by USIM is fairly >> straightforward to do in the core.  However, no modem manufacturer >> currently allows us to have full control over th

Re: [PATCH 1/6] gprs-provision: add driver API header

2011-01-24 Thread Aki Niemi
Hi Jukka, 2011/1/24 Jukka Saunamaki : > Then how about something like this: Lets make provisioning API > synchronous (so that plugins do not need to care about SIM or other > safety). > In stead, if in gprs atom ofono_gprs_register() we notice the need for > provisioning,  ofono_sim_read(SPN) is c

Re: [PATCH 1/6] gprs-provision: add driver API header

2011-01-24 Thread Aki Niemi
Hi Denis, 2011/1/21 Denis Kenzior : > How exactly are you guaranteeing that 'nothing bad should happen'? > There is no cancellation mechanism that I see.  Not to mention that the > current ofono_sim_read API is not even safe either.  For exactly the > same reasons. This is a problem with all user

Re: [PATCH 1/1] isimodem: Adding version isimodem and isimodem2.5

2011-01-25 Thread Aki Niemi
Hi, 2011/1/25 Marcel Holtmann : >> +enum isi_version { >> +     ISI_20 = 0, >> +     ISI_25 = 1 >> +}; >> + > > If we follow the same layout as with all other modem drivers, then the > *modem.h should only contain the prototypes for the init callbacks. > >>  extern struct ofono_modem *isi_modem_by

Re: [PATCH 1/1] isimodem: Adding version isimodem and isimodem2.5

2011-01-25 Thread Aki Niemi
Hi Marcel, 2011/1/25 Marcel Holtmann : > So this clearly then is not suppose to be in isimodem.h and while at it, > someone might wanna cleanup isi_modem_by_interface and move it to a > better location. Done. Moved it to /dev/null. ;-) Cheers, Aki ___

[RFC 0/6] Add configuration support via main.conf

2011-01-26 Thread Aki Niemi
Hi all, This set of patches adds support for oFono configuration settings via main.conf. First three add the file and routines for parsing that file; the following three take a parameter in the sms atom and makes it configurable. Cheers, Aki ___ ofono

[RFC 1/6] main: Add basic support for main.conf

2011-01-26 Thread Aki Niemi
--- src/main.c | 62 ++- src/ofono.h | 11 ++ 2 files changed, 72 insertions(+), 1 deletions(-) diff --git a/src/main.c b/src/main.c index 3db8819..129d36c 100644 --- a/src/main.c +++ b/src/main.c @@ -41,6 +41,7 @@ #define SHUT

[RFC 5/6] main: Enable parsing SMS ref number setting

2011-01-26 Thread Aki Niemi
--- src/main.c | 11 +++ src/ofono.h |1 + 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src/main.c b/src/main.c index 129d36c..e55b6e7 100644 --- a/src/main.c +++ b/src/main.c @@ -116,6 +116,7 @@ static void parse_config(GKeyFile *config) { GError *err =

[RFC 2/6] conf: Add bare bones configuration file

2011-01-26 Thread Aki Niemi
--- src/main.conf |4 1 files changed, 4 insertions(+), 0 deletions(-) create mode 100644 src/main.conf diff --git a/src/main.conf b/src/main.conf new file mode 100644 index 000..facb950 --- /dev/null +++ b/src/main.conf @@ -0,0 +1,4 @@ +[General] + +# List of plugins that should no

[RFC 6/6] sms: Use main configuration for 16bit ref number

2011-01-26 Thread Aki Niemi
--- src/sms.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/sms.c b/src/sms.c index 7224bdf..48d2d81 100644 --- a/src/sms.c +++ b/src/sms.c @@ -842,7 +842,6 @@ static DBusMessage *sms_send_message(DBusConnection *conn, DBusMessage *msg, GSList *msg_list;

[RFC 4/6] conf: Add ref number setting for MessageManager

2011-01-26 Thread Aki Niemi
--- src/main.conf |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/main.conf b/src/main.conf index facb950..0b23998 100644 --- a/src/main.conf +++ b/src/main.conf @@ -2,3 +2,9 @@ # List of plugins that should not be loaded on oFono startup #DisablePlugins = + +

[RFC 3/6] build: Add main.conf to the build

2011-01-26 Thread Aki Niemi
--- Makefile.am |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index f941a19..02ea2cb 100644 --- a/Makefile.am +++ b/Makefile.am @@ -35,7 +35,7 @@ endif confdir = $(sysconfdir)/ofono -conf_DATA = +conf_DATA = src/main.conf statedir = $

[PATCH 0/4] Add support for CPHS customer service profile

2011-01-26 Thread Aki Niemi
Hi all, This series adds support for CPHS CSP PLMN mode into the netreg atom. Cheers, Aki ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH 1/4] simutil: Add EFcsp file and service group IDs

2011-01-26 Thread Aki Niemi
--- src/simutil.h | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/simutil.h b/src/simutil.h index 463540b..a5a683b 100644 --- a/src/simutil.h +++ b/src/simutil.h @@ -37,6 +37,7 @@ enum sim_fileid { SIM_EFIMSI_FILEID = 0x6F07,

  1   2   3   4   >