Re: [PATCH] simfs: fix incorrect math again

Hi Kristen, On 11/02/2010 09:41 AM, Kristen Carlson Accardi wrote: > On Thu, 14 Oct 2010 11:18:00 -0700 > Kristen Carlson Accardi wrote: > >> --- >> src/simfs.c |6 ++ >> 1 files changed, 2 insertions(+), 4 deletions(-) >> >> diff --git a/src/simfs.c b/src/simfs.c >> index fd768ef..bcb6

Re: [PATCH] sim: Check SIM pin status after changing pin.

Hi Marit, On 11/02/2010 10:08 AM, Marit Henriksen wrote: > From: Marit Henriksen > > When changing pin, it is possible to get in a state where the modem requests > puk > (if incorrect pin is entered too many times). Need to check the SIM pin > status > to discover this. > --- > src/sim.c |

Re: [PATCH 2/2] atmodem: Add use of pin event *EPEV after sending PUK.

On 11/02/2010 10:14 AM, Marcel Holtmann wrote: > Hi Marit, > >> The MBM/STE modems send the unsolicited result code *EPEV to report when >> the PIN code has been inserted and accepted. > > I almost thought so, but I was not sure when adapting this for IFX. > >> diff --git a/drivers/atmodem/sim.

Re: [PATCH 1/2] coding_style: Fix enum name

Hi Yang, On 11/02/2010 09:21 AM, Yang Gu wrote: > --- > doc/coding-style.txt |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Both patches have been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.o

Re: [RFC] AGPS Support

Hi Sjur, On 11/02/2010 03:36 PM, Sjur Brændeland wrote: > Hi Denis, > > Fredric wrote: >> On positioning framework side, XML containers encoding/decoding does not >> seem to be yet widely used, while the support of RRC and RRLP framing is >> common, thanks to the support of SUPL. >> >> Using XM

Re: [PATCH] atmodem: Remove at_pin_send_puk_cb, and use at_pin_send_cb instead.

Hi Marit, On 11/03/2010 07:06 AM, Marit Henriksen wrote: > From: Marit Henriksen > > When adding the use of pin event *EPEV also to at_pin_send_puk_cb, > it becomes identical to at_pin_send_cb, and can be removed. > --- > drivers/atmodem/sim.c | 44 +---

Re: [RFC] AGPS Support

Hi Aki, On 11/03/2010 12:40 PM, Aki Niemi wrote: > Hi, > > 2010/11/3 Sjur Brændeland : >> I was previously under the false impression that you wanted oFono API >> to export AGPS functionality using dbus types only. Piping the AGPS >> XML (or ASN.1 coded data) >> through oFono certainly makes the

[ANNOUNCE] oFono 0.34

Hi Everyone, oFono 0.34 is out. This release is a mixed stabilization and development release. The major change in this release is the removal of modemconf plugin. This plugin has been deprecated for some time and we decided it was time to finally remove it. If you were using modemconf along wit

Re: Huawei EM 770 not working properly

Hi Frederic, On 11/04/2010 06:15 AM, Frederic Crozat wrote: > Hi, > > I'm trying to get ofono working properly with integrated 3G card on my > EEE PC. > > Card is Huawei EM 770 (12d1:1001). > > I'm testing with ofono 0.34. > > so far, the modem is correctly detected : > > list-modem returns :

Re: [PATCH] sim: use mask for check of sim file status

Hi Guillaume, On 11/05/2010 08:05 AM, Lucas, GuillaumeX wrote: > From: Guillaume Lucas > > Is' the first bit of the sim file status who indicates if a file > is valid or not. So a mask must be used to check this. > --- > src/sim.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH] todo: ifxmodem apgs support

Hi Robertino, On 11/05/2010 12:55 PM, Robertino Benis wrote: > --- > TODO |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/TODO b/TODO > index a5196f7..7ee7920 100644 > --- a/TODO > +++ b/TODO > @@ -484,3 +484,8 @@ Miscellaneous > >Priority: Low >Comple

Re: [RFC 1/3] doc: addidng documentation for basic assisted gps

Hi Robertino, On 11/05/2010 12:55 PM, Robertino Benis wrote: > --- > doc/assistedgps-manager-api.txt | 114 > +++ > 1 files changed, 114 insertions(+), 0 deletions(-) > create mode 100644 doc/assistedgps-manager-api.txt > > diff --git a/doc/assistedgps-mana

Re: [RFC 2/3] agps: adding agps related functions

Hi Robertino, On 11/05/2010 12:55 PM, Robertino Benis wrote: > --- > include/agps.h | 157 > > 1 files changed, 157 insertions(+), 0 deletions(-) > create mode 100644 include/agps.h > > diff --git a/include/agps.h b/include/agps.h > new

Re: [PATCH] sim: Check SIM pin status after changing pin.

Hi Marit, Just a gentle reminder not to top-post on this mailing list. On 11/05/2010 09:25 AM, Marit Sofie Henriksen wrote: > Hi Denis. > OK, I can see that this approach was rather too simplistic... Maybe > checking the returned CME error would be a better idea? > I’m a bit unsure how (or if) to

Re: [RFC 1/3] doc: addidng documentation for basic assisted gps

Hi Sjur, On 11/05/2010 03:21 PM, Sjur Brændeland wrote: > Hi, >>> So in general I'm currently against introducing this API as oFono >>> official API. I suggest prefixing this with an IFX specific identifier. >>> Maybe modem.ifx.AgpsManager. >> >> I would actually go one step further and call thi

Re: [PATCH] Move DBUS_GSM_ERROR_INTERFACE to OFONO_ERROR_INTERFACE

Hi Gustavo, On 11/08/2010 11:12 AM, Gustavo F. Padovan wrote: > The new name is more generic, which make more sense. > --- > src/dbus.c | 32 > 1 files changed, 16 insertions(+), 16 deletions(-) > Patch has been applied, thanks. Regards, -Denis __

Re: [PATCH] isi: fix handling of incoming calls

Hi Pekka, On 11/08/2010 09:11 AM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > Isimodem driver reports the incoming call as soon as possible, however, > it is not possible to answer to an incoming a call before it is in > "MT-ALERTING" or "WAITING" state. > > Also, report the early inco

Re: [PATCH] zte: use AT+CFUN=1;+CFUN=4 in enable

Hi Pekka, On 11/08/2010 11:46 AM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > Direct +CFUN transition 0 -> 4 gets SIM in inconsistent state. > --- > plugins/zte.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___

Re: [PATCH] gprs: NULL-safe ofono_gprs_context_remove()

Hi Pekka, On 11/08/2010 12:41 PM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > Check for NULL in one place. > --- Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] udev: do not use weird serial with zte

Hi Pekka, On 11/08/2010 12:41 PM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] TODO: Add owner to silent modem reset

Hi Gustavo, On 11/08/2010 12:58 PM, Gustavo F. Padovan wrote: > --- > TODO |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > Patch has been applied, thanks for taking up this task. Regards, -Denis ___ ofono mailing list ofono@ofono.org h

Re: [PATCH] TODO: add owner to TTY support

Hi Lucas, On 11/08/2010 01:07 PM, Lucas De Marchi wrote: > --- > TODO |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > Patch has been applied, thanks for taking up this task. Regards, -Denis ___ ofono mailing list ofono@ofono.org http:/

Re: [RfC][PATCH 1/3] stk: API for SMS Point-to-Point download to UICC

Hi Andrew, On 11/07/2010 11:42 AM, Andrzej Zaborowski wrote: > The callback returns the TP-User-Data element content of the RP-ACK or > RP-ERROR message, returned by the UICC. > --- > src/ofono.h |8 > src/stk.c | 39 +++ > 2 files changed, 47

Re: [PATCH 2/3] sms: Handle "USIM Download" SMS type.

Hi Andrew, On 11/07/2010 11:42 AM, Andrzej Zaborowski wrote: > --- > src/sms.c | 21 - > 1 files changed, 16 insertions(+), 5 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org htt

Re: [PATCH 3/3] Update TODO.

On 11/07/2010 11:42 AM, Andrzej Zaborowski wrote: > --- > TODO | 22 +- > 1 files changed, 13 insertions(+), 9 deletions(-) Patch has been applied. I did break this patch up into two, one marking the task as done and the other adding the new task. Regards, -Denis _

Re: [PATCHv2] isi: fix handling of incoming/waiting calls

Hi Pekka, On 11/08/2010 01:49 PM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > Isimodem driver reports the mobile-terminated call as soon as possible, > however, it is not possible to answer a call before it is in > "MT-ALERTING" or "WAITING" state. > > Also, report the state of an earl

Re: [RFC PATCH 1/3] modem: add modem online-offline watch

Hi Andras, On 11/09/2010 02:59 AM, Andras Domokos wrote: > > Signed-off-by: Andras Domokos As Marcel already mentioned, we do not use Signed-off-by. Otherwise this patch looks good to me. Regards, -Denis ___ ofono mailing list ofono@ofono.org http:/

Re: [RFC PATCH 3/3] voicecall: add emergency call handling

Hi Andras, On 11/09/2010 03:00 AM, Andras Domokos wrote: > > Signed-off-by: Andras Domokos > --- > src/voicecall.c | 101 > ++- > 1 files changed, 100 insertions(+), 1 deletions(-) > > diff --git a/src/voicecall.c b/src/voicecall.c > index

Re: [RFC PATCH 2/3] modem: add EmergencyMode property

Hi Andras, On 11/09/2010 02:59 AM, Andras Domokos wrote: > > Signed-off-by: Andras Domokos > --- > src/modem.c | 53 + > src/ofono.h |4 > 2 files changed, 57 insertions(+), 0 deletions(-) > > diff --git a/src/modem.c b/src/modem.c

Re: [PATCH] Add test/reset-pin

Hi Pekka, On 11/08/2010 02:28 PM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > --- > test/reset-pin | 23 +++ > 1 files changed, 23 insertions(+), 0 deletions(-) > create mode 100755 test/reset-pin > Patch has been applied, thanks. Regards, -Denis _

Re: [PATCH] Added implementation for "ReportVoiceCall", "ReportTextMessage", "Release" methods and related code.Please take a look and give me feedback on the code quality , thinks that need to be ch

On 11/03/2010 06:20 PM, Rajyalakshmi Bommaraju wrote: > --- > Makefile.am |6 + > plugins/history.c | 438 + > plugins/history_agent.c | 453 > +++ > plugins/history_agent.h | 103

Re: [PATCH] Force requirement for filename option in cmd line

Hi Gustavo, On 11/09/2010 12:45 PM, Gustavo F. Padovan wrote: > --- > src/main.cpp |7 ++- > 1 files changed, 6 insertions(+), 1 deletions(-) > This patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http:/

Re: [RFC PATCH 2/3] modem: add EmergencyMode property

Hi Andras, >> So we have to be a bit careful here. You can't simply call >> modem_change_state here. This results in calling the post_online >> method, which populates the atoms that function when the radio is on. >> Instead you need to call the set_online driver method directly. >> >> Also, you

Re: [PATCH] TODO: Add owner to extend the voicecall interface with a property indicating emergency call

Hi John, On 11/10/2010 06:25 AM, John Mathew wrote: > --- > TODO |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/TODO b/TODO > index 84d5aa7..ed37c58 100644 > --- a/TODO > +++ b/TODO > @@ -416,7 +416,7 @@ Emergency Calls > >Priority: High >Complexity: C1

Re: [PATCH] TODO: Check SIM pin status if sim_change_pin fails.

Hi Marit, On 11/10/2010 05:35 AM, Marit Henriksen wrote: > From: Marit Henriksen > > --- > I'm sorry if I gave the impression that I don't want to contribute to > the development of oFono core, I guess I'm just not that familiar with > how things work. > No worries, patch has been applied. T

Re: [PATCH 1/3] sim: Add sim_service_available() for querying EFsst or EFust.

Hi Andrew, On 11/09/2010 09:27 PM, Andrzej Zaborowski wrote: > The function is not public api because the service constants are in > src/simutil.h. > --- Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://list

Re: [PATCH 2/3] sms: SMS-PP download must be enabled in SIM service tables.

Hi Andrew, On 11/09/2010 09:27 PM, Andrzej Zaborowski wrote: > --- > src/sms.c | 13 + > 1 files changed, 13 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://l

Re: [PATCH 3/3] cbs: CB download must be enabled in SIM service tables.

Hi Andrew, On 11/09/2010 09:27 PM, Andrzej Zaborowski wrote: > --- > src/cbs.c | 13 + > 1 files changed, 13 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://l

Re: [PATCH] TODO: Assign Voicecall emergency property task

Hi John, On 11/10/2010 10:09 AM, John Mathew wrote: > --- > TODO |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Applied, thanks for taking up this task. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/li

Re: [PATCH 1/1] isigen: create four gprs contexts

Hi Mika, On 11/11/2010 04:00 AM, Mika Liljeberg wrote: > --- > plugins/isigen.c | 19 ++- > 1 files changed, 14 insertions(+), 5 deletions(-) > > diff --git a/plugins/isigen.c b/plugins/isigen.c > index 838d060..3ea7110 100644 > --- a/plugins/isigen.c > +++ b/plugins/isigen.c >

Re: [PATCH] monitor-ofono: monitor DisconnectReason

Hi Pekka, On 11/11/2010 06:54 AM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > --- > test/monitor-ofono | 11 +++ > 1 files changed, 11 insertions(+), 0 deletions(-) > This patch has been applied, thanks. Regards, -Denis ___ ofono

Re: [PATCH] test/answer-calls: answer waiting calls, too

Hi Pekka, On 11/11/2010 06:54 AM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > --- > test/answer-calls | 20 ++-- > 1 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/test/answer-calls b/test/answer-calls > index 0deb832..1218c66 100755 > --- a/test/a

Re: [PATCH] voicecall: Add EmergencyCall property.

Hi John, > +static gboolean voicecall_isemergency(struct voicecall *v) Please use voicecall_is_emergency > +{ > + struct ofono_call *call = v->call; > + const char *lineid_str; > + > + lineid_str = phone_number_to_string(&call->phone_number); > + > + if (g_slist_find_custom(v->vc

Re: [PATCH 4/4] isigen: make number of PDP contexts configurable

On 11/11/2010 02:16 AM, mika.liljeb...@nokia.com wrote: > Hi Marcel, > >> why to do you bother making this a configurable option? What isthe >> benefit here? > > The maximum context count is a compile time option for the ISI modem. Having > this option in oFono makes it possible to optimize the

Re: [RfC] SIM file watch support.

Hi Andrew, On 11/05/2010 07:13 AM, Andrzej Zaborowski wrote: > In order to support the Refresh STK command we need to implement at > least two types of reset: UICC reset (manufacturer specific) and NAA > application reset. Other types can fall back to application reset > which can be implemented

Re: [PATCH 1/1] isigen: create four gprs contexts

Hi Mika, On 11/11/2010 09:50 AM, Mika Liljeberg wrote: > --- > plugins/isigen.c | 19 +++ > 1 files changed, 15 insertions(+), 4 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org h

Re: PPP disconnected via Huawei modem

Hi Elton, On 11/11/2010 01:14 AM, Chen Yuwei wrote: > Hi, > > I use MeeGo NB 10/26 release to browse some website via Huawei modem, > The PPP connection is disconnected when recieve a PPP event (RXJ-). > Then the PPP can not be connected anymore. Why? > What condition does ofono recieve this eve

Re: [PATCH] doc: Add Location Services API

Hi Sjur and Simon, On 11/11/2010 01:44 PM, Sjur Brændeland wrote: > From: Sjur Brændeland > > As requested, this is our initial proposal for a minimal API > in order to support E911, based on the 27.007 defined AT > commands. > > We've discussed internally different names for this API: > AGNSSM

Re: Can I modify CallingLineRestriction(the Property of CallSetting) value to "disabled" or "enabled"

Hi Pekka, On 11/12/2010 08:19 AM, Pekka Pessi wrote: > Hi, > > 2010/11/11 Gu, Yang : >>> What happens when you make a call? Does call get rejected or do you >>> get some CSSU indications? >> >> Thank you for the comments! >> After setting HideCallerId to "enabled", and making an outgoing call, th

[ANNOUNCE] oFono 0.35

Hi Everyone, oFono 0.35 is out. This release is mostly a development release. We also include a bug fix that precluded 2G sims from working correctly due to FDN/BDN checks. 3G sims were not affected. The first major change in this release is the included support of WAP PUSH notifications. oFo

Re: [PATCH] stkutil: mask the DCS value to keep only the intersting bits

Hi Guillaume, On 11/15/2010 08:17 AM, Lucas, GuillaumeX wrote: > From: Guillaume Lucas > > For SIM tool kit only the bits 2 and 3 are interesting > for the DCS value. The others ones sould be masked. The > masking is necessary because some SIM car set the > upper bits to 1. > --- > src/stkutil.

Re: [PATCH] coding-style: Add exception to M12 rule for external enums

Hi Sjur, On 11/17/2010 01:09 AM, Sjur Brændeland wrote: > From: Sjur Brændeland > > --- > doc/coding-style.txt |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > Patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list

Re: [PATCH] todo: Add Location Service (AGPS) task.

Hi Sjur, On 11/17/2010 01:09 AM, Sjur Brændeland wrote: > From: Sjur Brændeland > > --- > TODO |8 > 1 files changed, 8 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.

Re: [PATCH 1/4] Simplify ofono_modem_set_powered() logic

Hi Gustavo, On 11/16/2010 02:49 PM, Gustavo F. Padovan wrote: > --- > src/modem.c | 47 +-- > 1 files changed, 25 insertions(+), 22 deletions(-) Patch has been applied, thanks. Regards, -Denis ___ ofono ma

Re: [PATCH] util: Remove extra tab

Hi Jeevaka, On 11/17/2010 09:32 AM, Jeevaka Badrappan wrote: > --- > src/util.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.

Re: [PATCH 1/2] stemodem: Create network interfaces statically

Hi Sjur, On 11/18/2010 02:03 AM, Sjur Brændeland wrote: > Hi Denis & Marcel. > >> From: Sjur Brændeland >> >> Changes: >> o Restructure code so interfaces are created statically when probe is called. >> o Removed some of the unnecessary initializations at declaration. >> o No longer reporting "d

Re: [PATCH] stkutil: mask the DCS value to keep only the intersting bits

Hi Guillaume, >>> - switch (dcs) { >>> + switch (dcs & 0x06) { >> >> Do you mean to bitwise and with 0xc here? Otherwise you break the UCS2 >> case. Also do any SIMs use the '' Coding Bits Entry entry from >> 23.038 Section 4? If so, then we need to use sms_dcs_decode to >> retrieve >>

Re: [RFC PATCH 1/2] common: add long dial string support

Hi Andras, On 11/18/2010 05:38 AM, Arun Ravindran wrote: > Hi Denis, Marcel, Andras, > >> include/types.h |2 +- >> src/common.c| 12 ++-- >> 2 files changed, 7 insertions(+), 7 deletions(-) >> >> diff --git a/include/types.h b/include/types.h >> index ba2481f..b3d2247 10064

Re: [PATCH] doc: fix typos

Hi Rémi, On 11/18/2010 09:11 AM, Rémi Denis-Courmont wrote: > --- > doc/voicecallmanager-api.txt |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.or

Re: [PATCH] src: coding style fixes - rule M6

Hi Jeevaka, On 11/19/2010 07:57 AM, Jeevaka Badrappan wrote: > --- > src/audio-settings.c |4 ++-- > src/call-barring.c|4 ++-- > src/call-forwarding.c |4 ++-- > src/call-meter.c |4 ++-- > src/call-settings.c |4 ++-- > src/cbs.c | 10 +- >

Re: [PATCH] build: Update glib version in configure.ac

Hi George, On 11/19/2010 03:18 AM, George Matveev wrote: > function g_mkstemp_full in src/storage.c > requires glib version 2.22 or higher > --- > configure.ac |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > Patch has been applied, thanks. Regards, -Denis

Re: [PATCH 1/3] Add TTY (hearing impaired) support

Hi Lucas, On 11/18/2010 05:30 AM, Lucas De Marchi wrote: > On Thu, Nov 18, 2010 at 9:26 AM, Lucas De Marchi > wrote: >> + Changes the value of the specified property. Only >> + properties that are listed as read-write are > > A minor issue I found with

Re: [isi-voicecall-fix PATCHv3 1/6] voicecall: fix dial result handling

Hi Pekka, On 11/16/2010 11:05 AM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > If there is an existing active call when dialing the existing call will > be automatically put on hold. The dialing result handling depended on > the voicecall driver putting the call on hold before the dial c

Re: [isi-voicecall-fix PATCHv3 2/6] isi/voicecall: fix status reporting

Hi Pekka, On 11/16/2010 11:05 AM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > Report early incoming calls as waiting or incoming, depending on the > state of other calls. > > Report MT_RELEASED or MO_RELEASED via ofono_voicecall_notify(), > TERMINATED calls via ofono_voicecall_disconne

Re: [isi-voicecall-fix PATCHv3 3/6] isi/voicecall: save call id when queueing requests

Hi Pekka, On 11/16/2010 11:05 AM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > --- > drivers/isimodem/voicecall.c | 64 > +++--- > 1 files changed, 41 insertions(+), 23 deletions(-) > > diff --git a/drivers/isimodem/voicecall.c b/drivers/isimodem/

Re: [isi-voicecall-fix PATCHv3 4/6] isi/voicecall: fix answering early incoming calls

Hi Pekka, On 11/16/2010 11:05 AM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > The voicecall driver must wait until the incoming call is mt-alerting or > waiting before answering. > --- > drivers/isimodem/voicecall.c | 49 > +- > 1 files change

Re: [isi-voicecall-fix PATCHv3 5/6] isi/voicecall: release COMING calls with BUSY cause

Hi Pekka, On 11/16/2010 11:05 AM, pekka.pe...@nokia.com wrote: > From: Pekka Pessi > > Very early incoming calls were not released with BUSY cause. > --- > drivers/isimodem/voicecall.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -De

Re: [PATCH] Add responses for TTY commands

Hi Lucas, On 11/17/2010 08:00 PM, Lucas De Marchi wrote: > --- > src/default.xml | 16 > 1 files changed, 16 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org htt

Re: [PATCH] Simulate provide local info command

Hi Yang, On 11/18/2010 04:43 AM, Yang Gu wrote: > --- > src/simapplication.cpp | 263 > > src/simapplication.h |2 + > 2 files changed, 265 insertions(+), 0 deletions(-) > > +#define LocalInfoMenu_Loc 1 > +#define LocalInfoMe

Re: [PATCH 3/4] phonesim: Add Timer Management commands to sim app menu.

Hi Andrew, On 11/21/2010 09:51 AM, Andrzej Zaborowski wrote: > --- > src/qsimcommand.cpp | 83 > src/qsimcommand.h|3 + > src/qsimterminalresponse.cpp | 59 ++ > src/qsimterminalresponse.h |3 + > src/simapplication.cpp |

Re: [PATCH 1/4] phonesim: Add Send Short Message commands to sim app menu.

Hi Andrew, On 11/21/2010 09:51 AM, Andrzej Zaborowski wrote: > --- > src/simapplication.cpp | 148 > +++- > src/simapplication.h |5 ++ > 2 files changed, 152 insertions(+), 1 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___

Re: [PATCH 2/4] phonesim: Add SIM Polling commands to sim app menu.

Hi Andrew, On 11/21/2010 09:51 AM, Andrzej Zaborowski wrote: > --- > src/simapplication.cpp | 66 > > src/simapplication.h |2 + > 3 files changed, 72 insertions(+), 4 deletions(-) > Patch has been applied, thanks. Regards, -Denis _

Re: [RFC PATCH 1/5] history: expand history API include file

Hi Andras, On 11/15/2010 05:50 AM, Andras Domokos wrote: > --- > include/history.h |3 +++ > src/ofono.h |4 > 2 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/include/history.h b/include/history.h > index c1c4aa1..a2490f6 100644 > --- a/include/history.h > ++

Re: [RFC PATCH 4/5] voicecall: add call counters

Hi Andras, On 11/15/2010 05:50 AM, Andras Domokos wrote: > --- > src/callcounters.c | 388 > > 1 files changed, 388 insertions(+), 0 deletions(-) > create mode 100644 src/callcounters.c > > diff --git a/src/callcounters.c b/src/callcounters

Re: [PATCH] Add SIM reset button

Hi Gustavo, On 11/16/2010 02:48 PM, Gustavo F. Padovan wrote: > +CRST now send a reset resquest command > --- > src/control.cpp|6 ++ > src/control.h |1 + > src/controlbase.ui | 40 > 3 files changed, 47 insertions(+), 0 deletions(-

Re: [RFC PATCH 1/4] modem: add modem online-offline watch

Hi Andras, On 11/15/2010 10:57 AM, Andras Domokos wrote: > From: Andras Domokos > > --- > src/modem.c | 46 ++ > src/ofono.h |8 > 2 files changed, 54 insertions(+), 0 deletions(-) > Patch has been applied, but I tweaked style and mad

Re: [isi-voicecall-fix PATCHv3 2/6] isi/voicecall: fix status reporting

something, be explicit, do not prefer. Fair enough, fixed. > > I laud your goal to improve the coding style within oFono - and it > even might be best to do that step-by-step and avoid large patches > just to fix the style - but I'm lazy typist and I usually just kill > and yan

Re: [isi-voicecall-fix PATCHv3 4/6] isi/voicecall: fix answering early incoming calls

Hi Pekka, On 11/22/2010 10:22 AM, Pekka Pessi wrote: > Hi Denis, > > 2010/11/22 Denis Kenzior : >>> +static void isi_wait_incoming(struct isi_call_req_context *irc, int event); >>> + >> >> Why is there a forward declaration for a static function?

Re: [isi-voicecall-fix PATCHv3 1/6] voicecall: fix dial result handling

Hi Pekka, >>> + gboolean dial_result_handled; >>> }; So I'm finally beginning to understand where you're going with this.. >>> >>> struct dial_request { >>> @@ -1096,9 +1097,20 @@ static struct voicecall *dial_handle_result(struct >>> ofono_voicecall *vc, >>> v = l->data; >>

Re: [RFC PATCH 2/4] modem: add EmergencyMode property

Hi Andras, On 11/15/2010 10:57 AM, Andras Domokos wrote: > From: Andras Domokos > > --- > src/modem.c | 134 > +++ > src/ofono.h |4 ++ > 2 files changed, 138 insertions(+), 0 deletions(-) > > diff --git a/src/modem.c b/src/modem.c

Re: [RFC PATCH 4/4] voicecall: add emergency call handling

Hi Andras, On 11/15/2010 10:58 AM, Andras Domokos wrote: > --- > src/voicecall.c | 111 > ++- > 1 files changed, 110 insertions(+), 1 deletions(-) > > diff --git a/src/voicecall.c b/src/voicecall.c > index 3af614b..066cdb9 100644 > --- a/src/

Re: [PATCH] Add modem silent reset button

Hi Gustavo, On 11/22/2010 04:05 PM, Gustavo F. Padovan wrote: > +CRST now send a reset resquest command > --- > src/control.cpp|6 ++ > src/control.h |1 + > src/controlbase.ui | 40 > 3 files changed, 47 insertions(+), 0 deletions(-

Re: [PATCH RESEND] stemodem: Change use of types

Hi Sjur, On 11/21/2010 02:55 PM, Sjur Brændeland wrote: > From: Sjur Brændeland > > Use the type __u32 for sequence counting rather than guint32, > and "void *" instead of gpointer. > Reduce the size of RTNL message buffer from 4096 to 1024, > as this should be sufficient to hold the NEWLINK mes

Re: [PATCH] stk: Handle null Text field.

Hi Andrew, On 11/21/2010 10:43 PM, Andrzej Zaborowski wrote: > Add a NULL check in dbus_apply_text_attributes because in some places > (like DisplayText handler) we call it without checking and we just check > the return value once. > --- > src/stk.c |3 +++ > 1 files changed, 3 insertions(+)

Re: [PATCH] gatchat: make sure to unsubscribe the GAtIO write handler on disconnect.

Hi Andrew, On 11/21/2010 10:43 PM, Andrzej Zaborowski wrote: > There's a small probability that we call chat_wakeup_writer > just before the channel disonnects and for some reason glib then > calls can_write_data after we have unrefed the io and freed all the > resources. Calling at_chat_suspend

Re: [PATCH] TODO: add owner to Frequency Band Selection task

Hi Lucas, On 11/19/2010 08:46 AM, Lucas De Marchi wrote: > --- > TODO |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > Patch has been applied. Thanks for taking up this task. Regards, -Denis ___ ofono mailing list ofono@ofono.org http:

Re: [PATCH -v3 1/3] Add ofono_modem_reset()

Hi Gustavo, On 11/19/2010 03:36 PM, Gustavo F. Padovan wrote: > Some modems can screw up everything and then we will need to do a silent > reset of the modem. This patch take the modem back to the OFFLINE state. > --- > include/modem.h |2 ++ > src/modem.c | 44 +

Re: [PATCH -v3 2/3] phonesim: Add modem reset trigger

Hi Gustavo, On 11/19/2010 03:36 PM, Gustavo F. Padovan wrote: > --- > plugins/phonesim.c | 10 ++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/plugins/phonesim.c b/plugins/phonesim.c > index d2faf42..7426da6 100644 > --- a/plugins/phonesim.c > +++ b/plugins/phon

Re: [PATCH -v3 3/3] modem: add support to restore state when resetting the modem

Hi Gustavo, On 11/19/2010 03:36 PM, Gustavo F. Padovan wrote: > --- > src/modem.c | 74 -- > 1 files changed, 41 insertions(+), 33 deletions(-) > Ah ok, you implement the getting back to online process in this patch. Ignore my previous c

Re: [PATCH 1/3] TODO: Add owner to implement the Lockdown property

Hi Gustavo, On 11/19/2010 03:37 PM, Gustavo F. Padovan wrote: > --- > TODO |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > Patch has been applied. Thanks for taking up this task. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 2/3] Add __ofono_error_access_denied()

Hi Gustavo, On 11/19/2010 03:37 PM, Gustavo F. Padovan wrote: > --- > src/dbus.c |6 ++ > src/ofono.h |1 + > 2 files changed, 7 insertions(+), 0 deletions(-) > Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono

Re: [PATCH] string_to_phone_number: remove redumdant predicate

Hi Rémi, On 11/23/2010 06:40 AM, Rémi Denis-Courmont wrote: > If the first character is a plus sign, then it is not a nul, then > the string length is true anyway. > --- > src/common.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > Patch has been applied, thanks. Regards, -Den

CDMA Support

Hi Everyone, Anyone who has been following the oFono project knows that up until now oFono has been all about solving the GSM telephony stack problem. We wanted to support CDMA, but were simply too busy to do so. We'd like to change that. During the Meego conference several oFono developers hel

Re: [PATCH 3/3] Add Lockdown property to Modem interface

Hi Gustavo, On 11/19/2010 03:37 PM, Gustavo F. Padovan wrote: > Setting Lockdown to TRUE means power down the modem and hold a lock that > only permits the lock's owner power up the modem back. When released > it restores the last state of the modem before holding the lock. > --- > doc/modem-api.

Re: [RERESEND] [PATCH 2/2] Update the network documentation

Hi Remi, > In fact, I have some cases where we'd need know whether HSDPA/HSUPA channels > are actually allocated, not just whether the cell supports them. ISI does > that, but there does not seem to be any standard way to get that informations > out of the modem. In particular, I assume that bo

Re: STK DisplayText changes proposal

Hi Guillaume, On 11/23/2010 09:33 AM, Lucas, GuillaumeX wrote: > Hi, > > According to the 3GPP specifications there is some missing points in the SATK > DisplayText implementation and I want to propose some API changes here. > > 1. clear message after delay / wait for user to clear flag > > Th

Re: [PATCH] SMS character set unit tests.

Hi Oleg, On 11/23/2010 09:21 AM, Oleg Zhurakivskyy wrote: > --- > unit/test-sms.c | 506 > +++ > 1 files changed, 506 insertions(+), 0 deletions(-) > > diff --git a/unit/test-sms.c b/unit/test-sms.c > index c8a9d9c..426d7d3 100644 > --- a/uni

Re: STK DisplayText changes proposal

Hi Andrew, On 11/23/2010 10:55 AM, Andrzej Zaborowski wrote: > Hi, > > On 23 November 2010 17:05, Denis Kenzior wrote: >> On 11/23/2010 09:33 AM, Lucas, GuillaumeX wrote: >>> Hi, >>> >>> According to the 3GPP specifications there is some m

Re: [PATCH 0/3] Long dial string support (2nd)

On 11/22/2010 10:36 AM, Andras Domokos wrote: > Dial strings can now be as long as 120 digits (not counting '+'). This feature > is going to be needed by the FDN feature. > > An FDN may consist of a phone number plus a DTMF string. In order to have the > call succeed when FDN is enabled, both part

Re: [PATCH 3/3] Add Lockdown property to Modem interface

Hi Gustavo, On 11/23/2010 11:53 AM, Gustavo F. Padovan wrote: >>> + boolean Lockdown [readwrite] >>> + >>> + Boolean representing the lock state of the modem. >>> + Setting it to true, makes the calling application hold >>> + the mode

  1   2   3   4   5   6   7   8   9   10   >