Re:

2009-05-26 Thread Denis Kenzior
Hi Minjun, On Tuesday 26 May 2009 19:56:31 Li, Minjun wrote: Hi Folks, I have made a patch for minor bugs in functions of dial_callback and voicecall_busy in /src/voicecall.c. Can you separate this into two patches. And make sure your git user email and name is properly set. I will not

Re: Code standards

2009-05-28 Thread Denis Kenzior
Hi, I am not wondering what the cosmetic style is. I am wondering what parts of the C language are used. Namely many (most?) C programmers claim to use ANSI C a.k.a. C89 even though there are using lots of GNU C and/or C99 extensions. Inline functions, C++-styled comments, non-constant

Re: add a common exit function for interfaces when manager_free and manager_destroy function is called

2009-06-02 Thread Denis Kenzior
Hi Minjun, On Tuesday 02 June 2009 02:02:29 Li, Minjun wrote: Hi Folks, I regenerated the patch. Because I found that manager_destroy function is lack of some exit function calls comparing to manager_free function, I add a common exit function for interfaces when manager_free and

Re: add a common exit function for interfaces when manager_free and manager_destroy function is called

2009-06-02 Thread Denis Kenzior
Hi Minjun, On Tuesday 02 June 2009 20:11:37 Li, Minjun wrote: I regenerated the patch again. Thank denis for good advice. Applied (with a reworded commit description) and pushed upstream. Thanks. Best Regards, Minjun Regards, -Denis ___ ofono

Re: [PATCH] Fix NetworkRegistration test by fixing indentation.

2009-06-18 Thread Denis Kenzior
On Wednesday 17 June 2009 22:44:06 Andrzej Zaborowski wrote: [Sorry if you get this mail or some of the other mails a second time, I sent a copy from an unsubscribed address yesterday]. Patch has been applied, thanks. Regards, -Denis ___ ofono

Re: [PATCH] Change sim_ops plugin interface to allow acces to linear fixed files

2009-06-18 Thread Denis Kenzior
Hi, On Wednesday 17 June 2009 22:44:44 Andrzej Zaborowski wrote: (iow record based files), both read and update access. Implement writing sim files through AT. Depends on [PATCH] Use GET RESPONSE sim command to retrieve EF length. Patch has been applied. Can you also add capability to write

Re: [PATCH] Read own numbers from EFmsisdn instead of AT+CNUM.

2009-06-18 Thread Denis Kenzior
Hi, On Wednesday 17 June 2009 22:44:56 Andrzej Zaborowski wrote: This was found to be more portable. On the other hand this doesn't give the service type or speed information per number. Patch has been applied. The service type and speed information is mostly fudged by the modems anyway.

Re: [PATCH] Move struct ussd_data definition out of the header.

2009-06-18 Thread Denis Kenzior
On Wednesday 17 June 2009 23:04:13 Andrzej Zaborowski wrote: No fuctional change. Patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] Add write/read operations for cyclic files in SIM.

2009-06-22 Thread Denis Kenzior
Patch has been applied. Thanks. ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: Problems with voice call.

2009-07-14 Thread Denis Kenzior
Hi Marko, Hi denkenz, thanks for the reply. I was not sure about the voice call features of the modem. Now when I searched the answer I found out that the modem does not in fact support voice calls. Yes, oFono's current implementation does not understand hardware specifics. The current

Re: [PATCH] Read EF-PNN, EF-OPL and override network names accordingly.

2009-07-14 Thread Denis Kenzior
Hi, Patch has been applied. However, I've completely (juding by 40 or so commits) refactored how SIM filesystem is handled in oFono so I might have introduced some bugs. Could you test to make sure it is working as intended? Can you submit some unit tests with sample PNN/OPL data? Regards,

Re: Problems with voice call.

2009-07-16 Thread Denis Kenzior
Hi Marko, Hi Denis, With Option iCON 225 the SMS service started to work and I was also able to send SMS message with the following command: $ dbus-send --system --print-reply --dest=org.ofono /modem1 org.ofono.SmsManager.SendMessage array:string:+3580 string:ofono test message

Re: [PATCH 2/4] Don't use g_slist_length to check for empty lists.

2009-07-31 Thread Denis Kenzior
Hi, A glib Anti-pattern according to http://www.burtonini.com/blog Patch has been applied. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 3/4] Fix possible memory leak on SIM reading error.

2009-07-31 Thread Denis Kenzior
Hi, This would also stall the SIM op queue if there's a read error for a record other than the first. The other solution would be goto next; (keep reading further records). Patch has been applied. This really shouldn't happen in practice, but if it does, we should also look to see if the

Re: [PATCH] Implement ofono_sim_write.

2009-08-03 Thread Denis Kenzior
Writes use sim-simop_q queue together with reads. Patch has been applied, thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: segment fault in latest version

2009-08-03 Thread Denis Kenzior
Hi, Hi, Does its known issue of segment fault in latest version? I think the version of yesterday is ok Can you post a backtrace as well. Thanks, Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: segment fault in latest version

2009-08-04 Thread Denis Kenzior
Hi #0 sim_eons_pnn_is_empty (eons=0x8088ce0) at simutil.c:253 #1 0x08060dc5 in sim_op_error (modem=0x8088ce0) at sim.c:297 #2 0x08061758 in sim_op_info_cb (error=0xbfffefcc, length=-1, structure=4294967295, record_length=-1, access=0x0, data=0x8088ce0) at sim.c:425 #3 0x0806a4a1

Re: Compile error

2009-08-04 Thread Denis Kenzior
Hi, On Tue, 04 Aug 2009 08:25:09 +0300 Marko Saukko marko.sau...@gmail.com wrote: Hi, I'm getting following error when compiling the latest git version with gcc (Ubuntu 4.3.3-5ubuntu4) 4.3.3. Attached is a patch to fix the errors. Andrew myself have fixed this properly yesterday,

Re: [PATCH 4/4] Add a MessageWaiting interface to track message waiting indications.

2009-08-04 Thread Denis Kenzior
Hi, I've pushed this patch and heavily customized it afterwards to simplify the logic a bit. Can you check that it is still working as intended? Writing of MBDN fields is still missing. Can you send another patch for this? Also one fo writing of MSISDN records in SimManager would be good as

Re: [PATCH] Implement writing EF-MBDN on SetProperty or Enhanced Voicemail IE.

2009-08-05 Thread Denis Kenzior
Hi, 2009/8/5 Andrzej Zaborowski andrew.zaborow...@intel.com: I've not tested this on a real SIM yet. It needs the attached fix since the record numbers passed to the plugin are now 1-based. Patch has been applied. Thanks. Regards, -Denis ___

Re: [PATCH 4/4] Add a MessageWaiting interface to track message waiting indications.

2009-08-05 Thread Denis Kenzior
Hi Andrew, For setting mailbox numbers, a working EF-MBDN is required since the only alternative would be to store them on the filesystem. mw_set_indicator does the right thing, I missed this fact. But when a mailbox number is set or received from network all clients get a

Re: How to dismiss incoming call?

2009-08-06 Thread Denis Kenzior
Hi Marko, When sending Busy with the nokia 6100 the first time it seems to works as it should (Even though CLCC is returning ERROR). When trying second time in a row, without closing ofonod, it also sends busy to the originator, but to the dbus message Error

Re: [PATCH] Reorder statements to make SIM op queue more robust.

2009-08-07 Thread Denis Kenzior
Hi Andrew, This allows ofono_sim_read and ofono_sim_write callbacks to queue new read or write operations. The callback must not be called between removing the operation from queue and checking queue length. Patch has been applied. Thanks. Regards, -Denis

Re: [PATCH 4/4] Add a MessageWaiting interface to track message waiting indications.

2009-08-12 Thread Denis Kenzior
Hi Aki, 2009/8/10 Denis Kenzior denk...@gmail.com: It would make sense for the providers to resend the MWI information everytime subscriber connects the network and then it would be less problematic in case the information couldn't be written to SIM, but I don't know if they ever do

Re: Missing file in repo

2009-08-14 Thread Denis Kenzior
Hi Remi, Seems like a file is missing in GIT: In file included from ../../plugins/example_history.c:33: ../../src/driver.h:22:25: error: ofono/types.h: No such file or directory types.h is a new include that has been added. The current automake magic seems to not handle this case well.

Build Breakage

2009-08-19 Thread Denis Kenzior
The latest gisi changes break the build: pep.c: In function ‘g_isi_pep_create’: pep.c:80: error: ‘SOCK_NONBLOCK’ undeclared (first use in this function) pep.c:80: error: (Each undeclared identifier is reported only once pep.c:80: error: for each function it appears in.) pep.c:80: error:

Re: Expose service dialling numbers stored on SIM through SimManager.

2009-08-25 Thread Denis Kenzior
Hi Andrew, On Wed, Aug 19, 2009 at 3:09 PM, Andrzej Zaborowski andrew.zaborow...@intel.com wrote: --- The ServiceDiallingNumbers property now returns a list of strings (alpha identifiers interleaved with dialling numbers) and this is a little hacky but returning a dictionary would make the

Re: driver callback naming

2009-08-30 Thread Denis Kenzior
Hi Andres, static struct ofono_modem_driver g1_driver = { .name = HTC G1, .probe = g1_probe, .enable = g1_enable, .disable = g1_disable, .remove = g1_remove, .populate = g1_populate, }; So the current intention: .probe - Detect whether

Re: driver callback naming

2009-08-30 Thread Denis Kenzior
Hi Andres, Of course, I'm also wondering why there needs to be two separate layers of calls in the first place. Why not have drivers register everything from within probe, call ofono_set_powered(modem, TRUE) once the device is ready, and be done with it? The reason for this is

Re: driver callback naming

2009-08-30 Thread Denis Kenzior
Hi Aki, 2009/8/30 Denis Kenzior denk...@gmail.com: The reason for this is e.g. airplane mode, where you physically want to turn off the device. Another case is for battery / power reasons, e.g. a netbook with a USB modem that is not being used. For airplane mode, you want to turn off

Re: Decode and encode alpha-identifier fields in EFadn format utils.

2009-08-31 Thread Denis Kenzior
Hi Andrew, Attaching an updated patch. Patch has been applied and pushed. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: Expose service dialling numbers stored on SIM through SimManager.

2009-08-31 Thread Denis Kenzior
Hi Andrew, Hi, 2009/8/25 Denis Kenzior denk...@gmail.com: Please re-base and resubmit this patch, it does not apply cleanly after the latest round of changes. Also, lets return a dictionary. Applications already need to parse GetProperties, which is a dictionary of strings to variants

Re: Write state of SMS assembly to disk and restore on startup.

2009-09-01 Thread Denis Kenzior
Hi Andrew, On Fri, Aug 21, 2009 at 9:40 PM, Andrzej Zaborowski andrew.zaborow...@intel.com wrote: This way we can continue receiving segmented messages over a reset or crash. --- src/common.c | 29 +++ src/common.h | 10 +++ src/sim.c| 34 src/sms.c

Re: [PATCH 1/3] G1: Add initial HTC G1 modem support

2009-09-01 Thread Denis Kenzior
Hi Andres, This series adds support for the HTC G1 phone (that is, the Google phone). G1 plugin is based on generic_at, with a bunch of stuff dropped and simplified. We use AT+CFUN=1 for powering on rather than having a configurable init string. We also manually set the default state

Re: [PATCH 2/3] G1: Add a G1 syntax for parsing

2009-09-01 Thread Denis Kenzior
Hi Andres, This is based on the generic_at parser, with unnecessary stuff removed. The G1 routinely screws up CRLFs, so the parser needs to account for that. This parser ignores leading CRLFs (which is what reference-ril does as well), as well as trailing LFs (which are sometimes left out).

Re: [PATCH 3/3] G1: Add G1-specific SMS support

2009-09-01 Thread Denis Kenzior
Hi Andres, This is based on the atmodem SMS code, with lots of stuff dropped. The G1's modem advertises support for CNMI mode 2, but attempting to set that actually fails. Instead, we _need_ to use mode 1. Along those lines, CNMA doesn't appear to work properly, so we disable it and use

Re: GPRS support for Ofono

2009-09-01 Thread Denis Kenzior
Everyone, So as it happens I had also been brainstorming a GPRS API for the last several days. And somewhat spontaneously a GPRS api discussion happened on IRC between myself, Marcel and Ismo. The following GPRS API proposal is a result of this discussion. I'd like all interested to

Re: GPRS support for Ofono

2009-09-01 Thread Denis Kenzior
Hi Marcel, Service org.ofono Interface org.ofono.DataConnectionManager I think this should be GPRSManager or something to clearly separate between GRPS connections and actual data connection, Two reasons for this: - Purpose of DataConnectionManager is easier to

Re: GPRS support for Ofono

2009-09-02 Thread Denis Kenzior
Hi Ismo, This is a philosophical difference from the provisioning point of view. An operator will likely support multiple configured access points, and the provisioning program should know their purpose from the configuration file (internet/MMS/WAP/...). This metadata is not there in the

Re: GPRS support for Ofono

2009-09-02 Thread Denis Kenzior
Hi Aki, We are not going to expose Attach() or Detach() method. As explained there are global anyway and so pointless to expose. This can be handled in the background without bothering the higher level application with these details. AFAIK, attach status of GPRS has both regulatory

Re: GPRS support for Ofono

2009-09-02 Thread Denis Kenzior
Hi Remi, Le mercredi 2 septembre 2009 18:00:22 Denis Kenzior, vous avez écrit : Actually this one is missing from the API proposal. Marcel already wanted the context type (internet, mms, wap, etc) information. I've updated the proposed API in git. This is not going to work. Depending

Re: GPRS support for Ofono

2009-09-02 Thread Denis Kenzior
Hi Waldo, I know why you want this, but I'm still against the counter being an oFono driver API. There needs to be a proper kernel interface that signals the application when an interface has gone away with the rx/tx details. This way we handle this generically for all modems without

Re: GPRS support for Ofono

2009-09-02 Thread Denis Kenzior
Hi Marcel, The reason is simple, Nokia modems suspend GPRS when scanning (or registering), simply because the operation will take roughly three times as long with GPRS attached. You will find this feature in current phones, too. Then ideally you should have two scan modes,

Re: [PATCH] G1: Add an SMS quirk for CNMI mode

2009-09-03 Thread Denis Kenzior
Hi Waldo, Instead of having vendor checks all over the place, wouldn't it be cleaner if the plugin had a way to provide/fix cnmi_opts? For now we decided to do it this way, since providing arbitrary properties per atom seemed to be too much. The hope is that there are not many modems that

TI Calypso Driver

2009-09-03 Thread Denis Kenzior
Hi guys, I submitted a preliminary driver for TI Calypso based devices (e.g. OpenMoko Freerunner). It works well enough that I can power up / down the modem, register to the network, scan operators, etc. Voice calls SMS features should also work. Simply insert the following lines into

Re: Add support for SMS national language identifiers

2009-09-04 Thread Denis Kenzior
Hi Aki, Hi All, Here is a set of patches to add support for decoding SMSs that have been encoded using national language tables instead of the default GSM 7bit tables. I was planning to push a couple of these patches directly, but the changes turned out a bit more extensive than I

Re: Write state of SMS assembly to disk and restore on startup.

2009-09-08 Thread Denis Kenzior
Hi Andrew, Both patches have been applied. I had to fix up a few things in order to make this actually work. Please review the changes and make sure they're OK with you. Thanks, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] Message Waiting fixes

2009-09-10 Thread Denis Kenzior
Hi, Hi, attached are two more changes to make the message waiting interface functional with notifications from the network (I only properly tested the SIM access part before). Patches have been applied and pushed. Thanks. Regards, -Denis ___

Re: [PATCH] Present list of preferred languages on SimManager interface.

2009-09-14 Thread Denis Kenzior
Hi Andrew, It does not look like the list can be used directly for filtering CBs because for that, the ME should choose one language, if there is one that is supported by the UI (aka MMI). It actually can, since the preferred language list for cell broadcasts can be of any length... And now

Re: [PATCH] Present list of preferred languages on SimManager interface.

2009-09-17 Thread Denis Kenzior
Hi, 2009/9/16 Andrzej Zaborowski andrew.zaborow...@intel.com: So here's another version generated on top of HEAD and with an attempt to detect when the card uses EFlp format instead of EFli. Sorry, I sent the wrong file, here's the *actual* new version. Patch has been applied. I cleaned

Re: [PATCH] [RFC] Do the PIN check in SIMManager

2009-09-23 Thread Denis Kenzior
Hi Andrew, And here's a version that implements most of what's specified in doc/sim-api.txt. There are two caveats: when you re-enable SIM PIN Patch has been applied, thanks. authentication, you have to give the old password from before it was changed to , i.e to disable and enable SIM

Re: [PATCH] Add call-volume interface to allow user adjust speaker and mic volume

2009-09-29 Thread Denis Kenzior
Hi Zhenhua, Your patch has been applied. I refactored much of it afterwards :) Let me know if I have broken something. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] voicecall: allow sending DTMF tones while call is in alerting state

2009-10-08 Thread Denis Kenzior
Hi Pekka, Patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] voicecall: allow P or , within the dial string

2009-10-08 Thread Denis Kenzior
Hi Pekka, 2009/10/8 Denis Kenzior denk...@gmail.com: DTMF control digit separator is used as pause according to GSM 02.07. According to GSM 11.11 it is stored as BCD code 1100 in the SIM card. Nokia modems use 'p' to represent pause. AT commands use ',' to represent pause. Strictly

Re: Subject: RFC Migrate from RFC2822 to ISO8601 for time representations

2009-10-19 Thread Denis Kenzior
Hi Olivier, the format used to represent time in ofono is currently RFC2822 which is complex and a bit deprecated. I think it would be better to move to ISO8601 which is a well used and supported [1] format and simpler to parse. So I don't have a problem with the patch, since RFC822 does

Re: Extend modem.conf

2009-10-21 Thread Denis Kenzior
Hi Ryan, Hello, I was wanting to extend the syntax of the modem.conf file. It is extra work to maintain a different plugin file for each generic AT modem with a different speed, serial settings. I agree that this would be useful. I'm not sure on the best syntax for this. Maybe below

Re: [PATCH] When setting the serial port, the previous settings need to be preserved.

2009-10-21 Thread Denis Kenzior
Hi Ryan, I have attached a small patch which allows gattty.c to enable/disable the read functionality on the serial port. This patch has been applied. Thanks! Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH] Handle right bracket in g_at_result_iter_next_unquoted_string

2009-10-23 Thread Denis Kenzior
Hi Zhenhua, Allow g_at_result_iter_next_unquoted_string to handle the bracket when parsing string like chld (1, 2). Original, it returns '1' and '2)'. Now it returns '1' and '2'. g_at_result_iter_close_list handles the right bracket later. --- Patch has been applied. Thanks. Regards,

Re: [PATCH] Replace Glib type with standard C type

2009-10-23 Thread Denis Kenzior
Hi Zhenhua, Hi, Below patch is to replace Glib type with standard C type in hfpmodem.h, like guint, guint8, etc. Patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [RFC] GPRS context setup and teardown (doc/dataconnectionmanager-api.txt)

2009-10-24 Thread Denis Kenzior
Hi Andrew, in set_registration_status: attached = (status != NETWORK_REGISTRATION_STATUS_REGISTERED status != NETWORK_REGISTRATION_STATUS_ROAMING); if (gprs-attached != (int) attached !(gprs-flags GPRS_FLAG_ATTACHING)) {

Re: [PATCH 1/2] Altered the options for the modem.conf to include more tty options.

2009-10-29 Thread Denis Kenzior
Hi Ryan, The modem.conf patch split into gatchat changes. Patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 2/2] Altered the atgeneric modem to include the added modem.conf options.

2009-10-29 Thread Denis Kenzior
Hi Ryan, The modem.conf options for the driver portion of the patch. Patch has been applied with some refactoring afterward. I know you ran checkpatch.pl, but please make sure you follow the coding standard even for parts which checkpatch.pl does not catch. In particular: +static const

Re: [PATCH 1/2] Added functionality to remove modem from system, if needed.

2009-10-29 Thread Denis Kenzior
Hi Ryan, Yea. I haven't looked at that part of the code, only that AT+CRC is the first command sent (if i remember right). Our modem sends a ^SYSSTART on powerup, what causes ofonod to go back to its initial state? The core has no idea, everything is up to the modem driver. Only the driver

Re: [PATCH 1/1] Create network registration driver for hfpmodem

2009-11-04 Thread Denis Kenzior
Hi Gustavo, This driver handles phone informations about registration status, signal strength and roaming status listening +CIEV commands. It also gets the Network Operator name with +COPS commands. This patch has been applied. I just had to do some _very_ minor cleanups of style.

Re: [PATCH 1/4] add interface property to primary context

2009-11-09 Thread Denis Kenzior
Hi Martin, @@ -37,6 +37,7 @@ struct ofono_gprs_context; struct ofono_gprs_primary_context { unsigned int cid; int direction; + char *interface; char apn[OFONO_GPRS_MAX_APN_LENGTH + 1]; char username[OFONO_GPRS_MAX_USERNAME_LENGTH + 1]; char

Re: [PATCH 2/4] add create/destroy_interface to ofono_gprs_context_driver

2009-11-09 Thread Denis Kenzior
Hi Martin, @@ -57,6 +57,10 @@ struct ofono_gprs_context_driver { void (*deactivate_primary)(struct ofono_gprs_context *gc, unsigned int id, ofono_gprs_context_cb_t cb, void *data); + void

Re: [PATCH 2/2] Add call volume support for hfpmodem

2009-11-10 Thread Denis Kenzior
Hi Zhenhua, Make sure to ofono_call_volume_set_data(cv, NULL) here. I don't see ofono_call_volume_set_data(cv, NULL) or ofono_voicecall_set_data(vc, NULL) from atmodem either. Anyway, I add the code in hfp_call_volume_remove. Then that needs to be fixed. Care to send a patch? In general

Re: [PATCH 1/2] Fix should invoke microphone_volume instead of speaker_volume

2009-11-11 Thread Denis Kenzior
Hi Zhenhua, Patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 4/4] Fix style issue of bit left-shifting

2009-11-11 Thread Denis Kenzior
Hi Zhenhua, Applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 1/3] Add multi calls support for HFP voicecall driver

2009-11-11 Thread Denis Kenzior
Hi Zhenhua, +static void reset_to_single_call(struct voicecall_data *vd) +{ + struct ofono_call *oc = vd-calls-data; + + vd-call = oc; + vd-cind_val[HFP_INDICATOR_CALL] = 1; + + if (oc-direction == 1) + vd-cind_val[HFP_INDICATOR_CALLSETUP] = 1; + else +

Re: [PATCH 2/3] Add parse_clcc into atutil.c

2009-11-12 Thread Denis Kenzior
Hi Zhenhua, Patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: ppp

2009-11-12 Thread Denis Kenzior
Hi Ryan, Hello, We need a ppp interface for our modem. I was told on the chat forum that a tap/tun device was to be used. Has anyone else started with this or thought how to implement this? We're currently working on a userspace ppp implementation that will integrate with GAtChat. The

Re: Patch on unsupported AT command

2009-11-13 Thread Denis Kenzior
Hi Marcel, Hi Denis, I think this might need a GAtChat quirk function where we can add extra terminator responses that will be recognized. And maybe even translated into something meaningful. Originally I had the terminators freely definable on the GAtChat + some hardcoded ones,

Re: [PATCH 1/4] Fix: Handle callsetup=0 when no waiting or dialing call

2009-11-16 Thread Denis Kenzior
Hi Zhenhua, When call=1 and callsetup=0, if no waiting or dialing call, the call is active and no need to notify status change. This one has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: Patch on unsupported AT command

2009-11-17 Thread Denis Kenzior
Hi Yang, Thanks for the comments. I have split the patch to two separate ones. Two problems: +void g_at_chat_add_terminator(GAtChat *chat, const char *terminator, + int len, gboolean success) +{ + struct terminator_info *ti = g_new0(struct

Re: [PATCH 2/5] emit PropertyChanged Settings signal after active/deactive primary context

2009-11-17 Thread Denis Kenzior
Hi Martin, --- src/gprs.c | 115 1 files changed, 115 insertions(+), 0 deletions(-) So I pushed out my own changes inspired by your patch. Let me know how they work. Regards, -Denis

Re: Palm Pre modem plugin

2009-11-21 Thread Denis Kenzior
Hi Niko, As of that I'm able to imagine only few reasons to use ofono instead of fso. Then either you're not thinking hard enough or do not have enough domain experience to really comment. One example: carrier certification. Please examine what oFono APIs cover and what FSO GSM APIs cover.

Re: Palm Pre modem plugin

2009-11-23 Thread Denis Kenzior
Hi Niko, Keep in mind I'm speaking about general developers and their interest, not about organizations, just pointing that *actually* FSO carries more interests on *some* areas. Yes, I believe we completely agree on this point. oFono's intention was never to be an entire application

Re: oFono running on new Freerunner distribution (was: Palm Pre modem plugin)

2009-11-23 Thread Denis Kenzior
Hi Dario, Well, maybe you missed some of my previous email in this list some time ago :) I'm the project leader of a new distribution, called NEOPhysis, for the Openmoko Freerunner and Niko is the UI team leader. We are about 10 people in our team and started from scratch creating a new

Re: oFono running on new Freerunner distribution

2009-11-23 Thread Denis Kenzior
Hi Dario, Do I have to take the git code or these features are already in the current 0.10 version? This change was made after 0.10 was tagged. So you'll need the git version. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: oFono running on new Freerunner distribution

2009-11-23 Thread Denis Kenzior
This seems to be a peculiarity of the Calypso modem. When using ATD on an uninitialized port the ATD returns immediately. This means that dialing/alerting calls can be hung up. However, we use CPI indications and for some reason the ATD behavior changes when this is used. ATD now only

Re: [PATCH] Fix: Add check for register_auto method

2009-11-24 Thread Denis Kenzior
Hi Zhenhua, Add check for register_auto method to avoid crash. HFP backend does not provide implementation for register_auto. Patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org

Re: [PATCH 2/2] Fix: Move CHLD from voicecall driver to plugin

2009-11-24 Thread Denis Kenzior
Hi Zhenhua, The second patch is to move CHLD=? from voicecall.c to plugin. According HFP v1.5 spec, AT+CHLD=? should be a part of SLC connection. So we should not do it after SLC connection is created. Patch has been applied. Thanks. Regards, -Denis

Re: oFono running on new Freerunner distribution

2009-11-26 Thread Denis Kenzior
Hi Dario, Hi Denis, I pushed an experimental fix. Let me know if you can now hangup alerting calls. It did not make it into release 0.11 though. before, I can dial but can't hangup during alerting state. Furthermore Ok, I pushed a few more things that should fix this. At least it does

Re: oFono running on new Freerunner distribution

2009-11-27 Thread Denis Kenzior
Hi Dario, I recompiled from the git and the situation is the same as before; attached are two archives, each containing two log files, one made by oFono with the options above, the second is the console output of the dbus-monitor --system command (in which, at the end of file, I pasted

Re: oFono running on new Freerunner distribution

2009-12-01 Thread Denis Kenzior
Hi Dario, I also noticed a missing line in the plugins/calypso.c file which differs from 0.7 to 0.8-0.11, I added in the 0.11 release but without results, but if it can be useful to debug the line is: ofono_devinfo_create(modem, 0, atmodem, data-dlcs[AUX_DLC]); It isn't missing, it has been

Re: Huawei E220 + Data Connection Manager

2009-12-01 Thread Denis Kenzior
Hi Mitsutaka, so this is the interesting part. We don't wanna use the magic *99* magic and actually use the proper GPRS AT command for connecting the context. Yes. I know dialup call is different in each carrier. Most data connection dial number's are fixed. so I think it needs to add a

Re: [PATCH 1/3] Add hfp_list_calls to get current call list

2009-12-04 Thread Denis Kenzior
Hi Zhenhua, Use AT+CLCC to get current call list. So I did things 'slightly' differently. The new setup should be much simpler for both the plugin and the core. I've tested it on phonesim, but not on HFP. Can you let me know if there are any issues? Regards, -Denis

Re: [PATCH 2/3] Add hfp_send_dtmf to send tones for hfpmodem

2009-12-04 Thread Denis Kenzior
Hi Zhenhua, Patch has been applied. Thanks, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 3/3] Fix release clcc_source when voicecall driver is removed

2009-12-04 Thread Denis Kenzior
Hi Zhenhua, Release the timer to avoid invoking the callback function after voicecall driver is removed. Patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] Fix a crash during isimodem initialization

2009-12-09 Thread Denis Kenzior
Hi Alex, ext Denis Kenzior wrote: While the patch does indeed fix the issue, it does it mostly by accident. To add insult to injury it also has two style issues, all within 4 lines of code. I must be blind. Which are the style issues exactly? We're very pedantic about spacing and blank

Re: [PATCH 4/4] Fix schedule clcc poll in the ring notify

2009-12-09 Thread Denis Kenzior
Hi Zhenhua, All your patches have been applied. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: GPRS support for Ofono

2009-12-09 Thread Denis Kenzior
Hi Rem, That is because 3GPP in their infinite wisdom structured the spec this way. Just because AT commands group both pieces of unrelated data does not mean it is a good idea. I fail to see why the DBus and driver API should do the same mistake as 3GPP 27.007. I already told you I'm

Re: GPRS support for Ofono

2009-12-09 Thread Denis Kenzior
Hi Remi, - Message d'origine - I already told you I'm open to fixing it. However 27.007 is the only standard we have right now. That's easy to fix. Remove those from the GPRS status. The core only reports these attributes, it doesn't actually use them for anything. When

Re: [PATCH] Fix a crash during isimodem initialization

2009-12-10 Thread Denis Kenzior
Hi Alex, We're very pedantic about spacing and blank lines here. There should be no extraneous blank spaces in the code. And all if statements must be preceded by a blank line. Right. Is this documented anywhere, particularly the blank line before if rule? Most of the conventions are

Re: [PATCH 3/4] Add Powered property to CbsManager.

2009-12-16 Thread Denis Kenzior
Hi Andrew, static void cbs_set_topics_cb(const struct ofono_error *error, void *data) { struct ofono_cbs *cbs = data; @@ -320,9 +354,8 @@ static DBusMessage *cbs_set_topics(struct ofono_cbs *cbs, const char *value, DBusMessage *msg) { GSList *topics; - GSList

Re: [PATCH 1/1] set netmask for static ip on mbm

2009-12-16 Thread Denis Kenzior
Hi Martin, --- drivers/mbmmodem/gprs-context.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) Patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH] Fix: Documentation fixes

2009-12-16 Thread Denis Kenzior
Hi Anders, Patch has been applied. Thanks. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 3/4] Add Powered property to CbsManager.

2009-12-17 Thread Denis Kenzior
Hi Andrew, You should still be able to set the topics even if powered=false. Simply store the new list and send it to the modem if powered==true. This is what the code does afaict. Yes you're right, I misread the code. Lets return the reply once the operation has succeeded at the

Re: [PATCH] Support 51.011 EFecc format.

2009-12-17 Thread Denis Kenzior
Hi Andrew, This means that any subsequent reads on a device/sim combination of a different generation will give potentially different results. I'd still like us to cache SIM files according to phase if possible. This seems to be the safest / sanest approach. You're right. Attached

  1   2   3   4   5   6   7   8   9   10   >