Re: [PATCH 3/3] doc: Add SystemPath to Modem interface

2018-02-19 Thread Denis Kenzior

Hi,


+    string SystemPath [readonly, optional]
+
+    String giving a consistent hardware path for the modem
+    device. It will not change in case of reboot of modem
+    or ofono.


Given that many modems are USB devices, I don't think you can actually 
promise this.  I can envision a (slightly pathological) hardware design 
whereby the presence or absence of an _external_ device at startup may 
change the device enumeration order and thereby the syspath...




Right, this can depend on the kernel version also.  I wouldn't claim any 
guarantees at the D-Bus API level as it is outside our control.


If someone chooses to use it as a consistent path, then they do it at 
their own risk.


Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono


Re: [PATCH 3/3] doc: Add SystemPath to Modem interface

2018-02-19 Thread Jonas Bonn

On 02/19/2018 03:57 PM, Christophe Ronco wrote:

---
  doc/modem-api.txt | 8 
  1 file changed, 8 insertions(+)

diff --git a/doc/modem-api.txt b/doc/modem-api.txt
index 89e6191..e03c64a 100644
--- a/doc/modem-api.txt
+++ b/doc/modem-api.txt
@@ -95,6 +95,14 @@ Properties   boolean Powered [readwrite]
String representing the software version number of the
modem device.
  
+		string SystemPath [readonly, optional]

+
+   String giving a consistent hardware path for the modem
+   device. It will not change in case of reboot of modem
+   or ofono.


Given that many modems are USB devices, I don't think you can actually 
promise this.  I can envision a (slightly pathological) hardware design 
whereby the presence or absence of an _external_ device at startup may 
change the device enumeration order and thereby the syspath...


/Jonas


+   For modems detected by udev events, gives modem sysfs
+   path.
+
array{string} Features [readonly]
  
  			List of currently enabled features. It uses simple




___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono


[PATCH 3/3] doc: Add SystemPath to Modem interface

2018-02-19 Thread Christophe Ronco
---
 doc/modem-api.txt | 8 
 1 file changed, 8 insertions(+)

diff --git a/doc/modem-api.txt b/doc/modem-api.txt
index 89e6191..e03c64a 100644
--- a/doc/modem-api.txt
+++ b/doc/modem-api.txt
@@ -95,6 +95,14 @@ Properties   boolean Powered [readwrite]
String representing the software version number of the
modem device.
 
+   string SystemPath [readonly, optional]
+
+   String giving a consistent hardware path for the modem
+   device. It will not change in case of reboot of modem
+   or ofono.
+   For modems detected by udev events, gives modem sysfs
+   path.
+
array{string} Features [readonly]
 
List of currently enabled features. It uses simple
-- 
2.7.4

___
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono