Re: [Ohrrpgce] SVN: james/13137 Attackers doing "unhide" attacks are allowed to ignore the hidden status

2022-10-18 Thread James Paige via Ohrrpgce
Haha! I guess some more clean-up would be good, but mostly I am just glad to have fixed the two most common cases of a simple jump/land chain getting a hero or enemy completely stuck. On Tue, Oct 18, 2022, 9:08 PM Ralph Versteegen via Ohrrpgce < ohrrpgce@lists.motherhamster.org> wrote: > Wow

Re: [Ohrrpgce] SVN: james/13137 Attackers doing "unhide" attacks are allowed to ignore the hidden status

2022-10-18 Thread Ralph Versteegen via Ohrrpgce
Wow there are a huge number of edge cases and special cases here, I regret looking into this... I see the problems were introduced in: r12685 "Fix "Jump" (and the other new hiding attacks) to properly prevent targetting when used by heroes". r12874 "Fix check_for_unhittable_invisible_foe() to

Re: [Ohrrpgce] SVN: james/13137 Attackers doing "unhide" attacks are allowed to ignore the hidden status

2022-10-17 Thread James Paige via Ohrrpgce
This fixes a relatively recent breakage of Jump/Land and Hide/Unhide which is why it isn't mentioned in the whatsnew Although I do think the new changes could have also fixed some old incorrect edge-cases with jump/land, since it is a little more explicit now about allowing land/unhide to ignore

[Ohrrpgce] SVN: james/13137 Attackers doing "unhide" attacks are allowed to ignore the hidden status

2022-10-17 Thread subversion--- via Ohrrpgce
james 2022-10-17 16:09:13 -0700 (Mon, 17 Oct 2022) 188 Attackers doing "unhide" attacks are allowed to ignore the hidden status of their targets. Fixes broken battles when jump/land or hide/unhide chain is self-targeted, or jumping on a jumper --- U wip/bmod.rbas U wip/bmodsubs.bas U