D19123: Added option to search for whole words only

joaonetto edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19123 To: joaonetto, #okular, aacid Cc: davidhurka, yurchor, aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen

D19123: Added option to search for whole words only

joaonetto added a comment. I wasn't initializing m_wholeWords in searchLineEdit, that was causing it. Hope it works now. Also ran ctest, worked fine. Let me know if something is wrong. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19123 To: joaonetto,

D19123: Added option to search for whole words only

joaonetto updated this revision to Diff 55324. joaonetto added a comment. Fixed variable not initalized. Also, now you won't find words split with -, like Oku-\nlar REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19123?vs=53073=55324 BRANCH

D10974: Add option to ignore print margins for non-PDF generators

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I tested it and it worked. :) REPOSITORY R223 Okular BRANCH michaelweghorn/UPDATE_D10974 REVISION DETAIL https://phabricator.kde.org/D10974 To: michaelweghorn, #okular, ngraham

D10974: Add option to ignore print margins for non-PDF generators

ngraham added a comment. Yes, it does! How nice. +1 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10974 To: michaelweghorn, #okular Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, joaonetto, tfella, darcyshen

D10974: Add option to ignore print margins for non-PDF generators

aacid added a comment. The code looks sane from a "i have read it but not tried it" point of view. At this point this is all my stamina allows me to do. If someone wants to test it and approve it and Michael says he'll fix any bug that arises from here i'm happy enough REPOSITORY

D18744: Add action in Edit menu to select the text on current page

ngraham added a comment. I agree that it shouldn't copy automatically. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg, ngraham Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel,

D18744: Add action in Edit menu to select the text on current page

aacid added a comment. In D18744#441906 , @davidhurka wrote: > In D18744#438675 , @shubham wrote: > > > Do not delete area > > > Interestingly, setPageTextSelection() deletes area (without

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn added a comment. In D10974#442381 , @ngraham wrote: > I'm still not thrilled about the {nav Force Rasterization} situation (I think it should be implicitly turned on when the user chooses an option that requires it) but the

D20194: Fix a typo

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R575:e84b53063a5f: Use macOS naming (authored by sander, committed by aacid). CHANGED PRIOR TO COMMIT

D20194: Fix a typo

aacid accepted this revision. REPOSITORY R575 Okular Website (okular.kde.org) REVISION DETAIL https://phabricator.kde.org/D20194 To: sander, #okular, ngraham, aacid Cc: aacid, ngraham, ltoscano, okular-devel, joaonetto, tfella, darcyshen

D20194: Fix a typo

aacid added a comment. For the future, don't touch the translations, it's useless, they're not the primary source. REPOSITORY R575 Okular Website (okular.kde.org) REVISION DETAIL https://phabricator.kde.org/D20194 To: sander, #okular, ngraham Cc: aacid, ngraham, ltoscano, okular-devel,

D20194: Fix a typo

sander updated this revision to Diff 55304. sander added a comment. Changed Mac OS X to macOS everywhere. REPOSITORY R575 Okular Website (okular.kde.org) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20194?vs=55254=55304 REVISION DETAIL https://phabricator.kde.org/D20194

D10974: Add option to ignore print margins for non-PDF generators

ngraham added a comment. FWIW this works well in my testing. I'm still not thrilled about the Force Rasterization situation (I think it should be implicitly turned on when the user chooses an option that requires it) but the combobox is good. @aacid, are you good with this now?

D20194: Fix a typo

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. In D20194#442062 , @ltoscano wrote: > I think that the current name is "macOS" instead of "Mac OS X":

Re: Editing features

> I'd consider operations like separate, unite, reorder, remove, rotate and > maybe even crop still as "light editing". I'd like 'em. Just like gwenview > lets you resize, crop, flip - despite being a viewer. Indeed! I have no ambition to replicate Inkscape/Scribus in Okular. > Would it be

D20194: Fix a typo

ltoscano added a comment. I think that the current name is "macOS" instead of "Mac OS X": https://www.wired.com/2016/06/apple-os-x-dead-long-live-macos/ REPOSITORY R575 Okular Website (okular.kde.org) REVISION DETAIL https://phabricator.kde.org/D20194 To: sander, #okular Cc: ltoscano,

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn added a comment. Is there anything I can still do right now or do I just need to wait for the review? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10974 To: michaelweghorn, #okular Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid,