ahmadsamir added inline comments.
INLINE COMMENTS
> aacid wrote in document.cpp:3920
> don't do const & for basic types, it's cheaper to copy them than to reference
> them
Thanks. Noted.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D25684
To: ahmadsamir, aacid
Cc:
ahmadsamir updated this revision to Diff 70874.
ahmadsamir marked 7 inline comments as done.
ahmadsamir added a comment.
::distanceSqr() is going to be made const, so qAsConst isn't needed
It's cheaper to copy basic types than reference them
qAsConst isn't needed when iterating over member
https://bugs.kde.org/show_bug.cgi?id=396087
Logan Rathbone changed:
What|Removed |Added
CC||popro...@gmail.com
--- Comment #12 from Logan
BUILD SUCCESS
Build URL
https://build.kde.org/job/Applications/job/okular/job/kf5-qt5%20SUSEQt5.12/109/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Tue, 03 Dec 2019 23:48:09 +
Build duration:
10 min and counting
BUILD ARTIFACTS
aacid added a comment.
Thanks for the patch!
Some small comments
INLINE COMMENTS
> annotations.cpp:2094
> double outsideDistance = DBL_MAX;
> -foreach ( const HighlightAnnotation::Quad& quad, m_highlightQuads )
> +for ( const HighlightAnnotation::Quad :
ognarb added a revision: D25714: Port away from deprecated KHtml.
TASK DETAIL
https://phabricator.kde.org/T11542
To: ognarb
Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications,
#frameworks, knauss, davidre, GB_2, ahmadsamir, kpiwowarski, asturmlechner,
cfeck, cullmann,
https://bugs.kde.org/show_bug.cgi?id=414796
Bug ID: 414796
Summary: Order pages in a horizontal layout
Product: okular
Version: unspecified
Platform: Other
OS: Linux
Status: REPORTED
Severity: wishlist
3 грудня 2019, 12:54:09, від "Seb" :
>
> Hi Yuri,
>
>
> >> There is one simple thing that I couldn't find in the docs: is it
> >> possible to tell Okular to open with a certain geometry (width, height,
> >> x- and y-placement)? Usually this is set via a --geometry option, but
> >> Okular
Hi Yuri,
There is one simple thing that I couldn't find in the docs: is it
possible to tell Okular to open with a certain geometry (width, height,
x- and y-placement)? Usually this is set via a --geometry option, but
Okular does not recognize it. Perhaps there is another way?
This does
https://bugs.kde.org/show_bug.cgi?id=414179
Paolo changed:
What|Removed |Added
Status|NEEDSINFO |RESOLVED
Resolution|WAITINGFORINFO
10 matches
Mail list logo