can resume the discussion about possible improvements here.
Thanks,
Peter Grasch
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
://git.reviewboard.kde.org/r/109633/diff/
Testing
---
Tested successfully: Tool selection, deselection, continuous mode.
Thanks,
Peter Grasch
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
tested the annotation objects above and a couple of special cases mentioned
in the IRC.
Thanks,
Peter Grasch
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
the annotation objects above and a couple of special cases mentioned
in the IRC.
Thanks,
Peter Grasch
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
On March 21, 2013, 11:22 p.m., Albert Astals Cid wrote:
core/area.h, line 28
http://git.reviewboard.kde.org/r/109627/diff/1/?file=120762#file120762line28
Don't think this belongs to area.h to be honest
Peter Grasch wrote:
Would you prefer something like this:
bool
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109627/#review29666
---
On March 23, 2013, 7:52 p.m., Peter Grasch wrote
---
On March 21, 2013, 1:26 a.m., Peter Grasch wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109632
-
ui/pageviewannotator.cpp 7bd7496
Diff: http://git.reviewboard.kde.org/r/109625/diff/
Testing
---
Local tests show expected behavior.
Thanks,
Peter Grasch
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman
ui/pageviewannotator.cpp 4615d1c
Diff: http://git.reviewboard.kde.org/r/109633/diff/
Testing
---
Tested successfully: Tool selection, deselection, continuous mode.
Thanks,
Peter Grasch
___
Okular-devel mailing list
Okular-devel@kde.org
, deselection, continuous mode.
Thanks,
Peter Grasch
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109632/#review29738
---
On March 21, 2013, 1:26 a.m., Peter Grasch wrote
---
On March 21, 2013, 1:26 a.m., Peter Grasch wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109632
1db2763
Diff: http://git.reviewboard.kde.org/r/109627/diff/
Testing
---
I tested the annotation objects above and a couple of special cases mentioned
in the IRC.
Thanks,
Peter Grasch
___
Okular-devel mailing list
Okular-devel@kde.org
https
.
I hope we can resume the discussion about possible improvements here.
Thanks,
Peter Grasch
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
this given Okulars architecture.
Diffs
-
ui/pageviewannotator.cpp 7bd7496
ui/pageviewannotator.h 850d887
ui/pageview.cpp e8d481d
Diff: http://git.reviewboard.kde.org/r/109633/diff/
Testing
---
Tested successfully: Tool selection, deselection, continuous mode.
Thanks,
Peter
.
Thanks,
Peter Grasch
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel
https://bugs.kde.org/show_bug.cgi?id=201108
Peter Grasch gra...@simon-listens.org changed:
What|Removed |Added
CC||gra...@simon-listens.org
17 matches
Mail list logo
