D15344: Fix isNull check for RegularArea

2018-09-08 Thread Tobias Deiminger
This revision was automatically updated to reflect the committed changes. Closed by commit R223:0128f33f43eb: Fix isNull check for RegularArea (authored by tobiasdeiminger). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15344?vs=41189=41222 REVISION DETAIL

D15344: Fix isNull check for RegularArea

2018-09-08 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH fix_regulararea_isnull REVISION DETAIL https://phabricator.kde.org/D15344 To: tobiasdeiminger, aacid Cc: okular-devel, ngraham, aacid

D15344: Fix isNull check for RegularArea

2018-09-08 Thread Kai Uwe Broulik
broulik added a reviewer: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15344 To: tobiasdeiminger, aacid Cc: okular-devel, ngraham, aacid

D15344: Fix isNull check for RegularArea

2018-09-08 Thread Tobias Deiminger
tobiasdeiminger created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. tobiasdeiminger requested review of this revision. REVISION SUMMARY First check in RegularArea::isNull sais this: "I'm a QList. If I'm empty, I'm not null". That doesn't make sense,