D8838: Don't request pixmaps twice when opening okular

2018-01-15 Thread Albert Astals Cid
aacid abandoned this revision. aacid added a comment. Abandoning in favor of https://phabricator.kde.org/D9328 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8838 To: aacid Cc: michaelweghorn, rkflx, #okular, gassaf, ngraham, aacid

D8838: Don't request pixmaps twice when opening okular

2017-12-14 Thread Henrik Fehlauer
rkflx added a comment. In https://phabricator.kde.org/D8838#179480, @aacid wrote: > With https://phabricator.kde.org/D9328 we can probably just discard this one Sounds lovely, cannot wait to test. I'm currently backlogged a bit on Okular related things, so it may take a while to

D8838: Don't request pixmaps twice when opening okular

2017-12-14 Thread Albert Astals Cid
aacid added a comment. With https://phabricator.kde.org/D9328 we can probably just discard this one REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8838 To: aacid Cc: rkflx, #okular, michaelweghorn, gassaf, ngraham, aacid

D8838: Don't request pixmaps twice when opening okular

2017-11-27 Thread Henrik Fehlauer
rkflx added a comment. > Another option is just pushing the fix for the second problem and not for the first one After testing again, "patch w/o timer" now gives "M-D-T", i.e. the last M is not there anymore. I suspected I could find a window size or map area to break it again (as

D8838: Don't request pixmaps twice when opening okular

2017-11-23 Thread Henrik Fehlauer
rkflx added a comment. Sorry for the delay, finally could do some testing. First I was quite enthusiastic about what I saw, but then some oddities came up so I cannot draw a conclusion on what I would recommend to do here yet. Any final patch (i.e. not fulfilled by current patch

D8838: Don't request pixmaps twice when opening okular

2017-11-16 Thread Albert Astals Cid
aacid added a comment. Another option is just pushing the fix for the second problem and not for the first one (that introduces the delay) this makes it work "more often" since the delay is a race between how fast your window manager resizes the window and how fast okular opens the file

D8838: Don't request pixmaps twice when opening okular

2017-11-16 Thread Albert Astals Cid
aacid added a comment. After having a second look it does indeed have a noticeable delay for pdf that render *very* fast, with this patch you can see the empty page while without it you always see the rendered page (it also renders twice but since it's so fast you don't really see it).

D8838: Don't request pixmaps twice when opening okular

2017-11-16 Thread Albert Astals Cid
aacid added a comment. Hmmm, this has the side effect that now sometimes the thumbnailbar rendering starts first, need to investigate REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8838 To: aacid Cc: rkflx, #okular, ngraham, aacid

D8838: Don't request pixmaps twice when opening okular

2017-11-16 Thread Albert Astals Cid
aacid added a subscriber: rkflx. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8838 To: aacid Cc: rkflx, #okular, ngraham, aacid

D8838: Don't request pixmaps twice when opening okular

2017-11-16 Thread Albert Astals Cid
aacid created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. REVISION SUMMARY This is very visible if you open a file that will have partial updates and you open it quite zoomed in (so that tiled rendering is in place).