D8838: Don't request pixmaps twice when opening okular

aacid added a comment. Hmmm, this has the side effect that now sometimes the thumbnailbar rendering starts first, need to investigate REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8838 To: aacid Cc: rkflx, #okular, ngraham, aacid

D8838: Don't request pixmaps twice when opening okular

aacid added a comment. After having a second look it does indeed have a noticeable delay for pdf that render *very* fast, with this patch you can see the empty page while without it you always see the rendered page (it also renders twice but since it's so fast you don't really see it).

KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/7/ Project: Applications okular kf5-qt5 SUSEQt5.9 Date of build: Thu, 16 Nov 2017 14:05:53 + Build duration: 5 min 43 sec and counting JUnit Tests

[okular] [Bug 267350] filling out a PDF form saves data to some file i ~/.kde/share/apps/okular/docdata/

https://bugs.kde.org/show_bug.cgi?id=267350 --- Comment #60 from Wren Turkal --- Hi, OP here. I wanted to reach out and thank you for fixing this issue much more comprehensively than I imagined when I originally filled the issue. Thanks, wt -- You are receiving this

KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.9 - Build # 61 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.9/61/ Project: Applications okular kf5-qt5 WindowsMSVCQt5.9 Date of build: Thu, 16 Nov 2017 14:05:53 + Build duration: 3 hr 22 min and counting JUnit

D8642: Rework saving of annotations and form data

aacid removed a reviewer: mlaurent. This revision is now accepted and ready to land. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8642 To: aacid, rkflx Cc: mwolff, rkflx, lueck, mlaurent, michaelweghorn, ngraham, #okular, aacid

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.7 - Build # 41 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.7/41/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 16 Nov 2017 14:03:53 + Build duration: 2 min 47 sec and counting

D8642: Rework saving of annotations and form data

aacid closed this revision. aacid added a reviewer: mlaurent. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8642 To: aacid, rkflx, mlaurent Cc: mwolff, rkflx, lueck, mlaurent, michaelweghorn, ngraham, #okular, aacid

KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 8 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/8/ Project: Applications okular kf5-qt5 SUSEQt5.9 Date of build: Thu, 16 Nov 2017 14:27:03 + Build duration: 9 min 16 sec and counting JUnit Tests

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.7 - Build # 109 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.7/109/ Project: Applications okular kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 16 Nov 2017 14:05:53 + Build duration: 2 min 36 sec and counting CONSOLE OUTPUT

[okular] [Bug 317346] Okular overwrites PDF form data without asking

https://bugs.kde.org/show_bug.cgi?id=317346 Albert Astals Cid changed: What|Removed |Added Status|CONFIRMED |RESOLVED

[okular] [Bug 267350] filling out a PDF form saves data to some file i ~/.kde/share/apps/okular/docdata/

https://bugs.kde.org/show_bug.cgi?id=267350 Albert Astals Cid changed: What|Removed |Added Resolution|--- |FIXED

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 3 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/3/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Thu, 16 Nov 2017 14:03:53 + Build duration: 10 min and counting JUnit Tests

D8838: Don't request pixmaps twice when opening okular

aacid added a comment. Another option is just pushing the fix for the second problem and not for the first one (that introduces the delay) this makes it work "more often" since the delay is a race between how fast your window manager resizes the window and how fast okular opens the file

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.7 - Build # 110 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.7/110/ Project: Applications okular kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 16 Nov 2017 14:27:03 + Build duration: 1 min 24 sec and counting CONSOLE OUTPUT

[okular] [Bug 362996] Okular does not prompt to save form data

https://bugs.kde.org/show_bug.cgi?id=362996 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org

[okular] [Bug 176743] okular review affects different document with same name

https://bugs.kde.org/show_bug.cgi?id=176743 Albert Astals Cid changed: What|Removed |Added Status|CONFIRMED |RESOLVED

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 4 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/4/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Thu, 16 Nov 2017 14:36:43 + Build duration: 7 min 38 sec and counting JUnit

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.7 - Build # 42 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.7/42/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 16 Nov 2017 14:36:43 + Build duration: 6 min 25 sec and counting

KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.9 - Build # 62 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.9/62/ Project: Applications okular kf5-qt5 WindowsMSVCQt5.9 Date of build: Thu, 16 Nov 2017 17:29:08 + Build duration: 2 hr 59 min and counting JUnit

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.7 - Build # 112 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.7/112/ Project: Applications okular kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 17 Nov 2017 04:06:17 + Build duration: 8 min 22 sec and counting CONSOLE OUTPUT

KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/10/ Project: Applications okular kf5-qt5 SUSEQt5.9 Date of build: Fri, 17 Nov 2017 04:06:17 + Build duration: 15 min and counting JUnit Tests Name:

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 5 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/5/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Fri, 17 Nov 2017 04:44:27 + Build duration: 14 min and counting JUnit Tests

D8838: Don't request pixmaps twice when opening okular

aacid created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. REVISION SUMMARY This is very visible if you open a file that will have partial updates and you open it quite zoomed in (so that tiled rendering is in place).

D8838: Don't request pixmaps twice when opening okular

aacid added a subscriber: rkflx. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8838 To: aacid Cc: rkflx, #okular, ngraham, aacid

D8642: Rework saving of annotations and form data

aacid added a comment. Since it happens almost everyone is relatively happy i'll be commiting this to the Applications/17.12 branch in around 6 hours to make it in time for the freeze later tonight. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8642 To: aacid,

D8832: Fix highlight/annotation clipping with Qt scaling

sander added a comment. Thanks for the patch. It seems to solve the problem for me. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8832 To: davidedmundson Cc: sander, ngraham, #okular, aacid

KDE CI: Applications okular kf5-qt5 SUSEQt5.9 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20SUSEQt5.9/9/ Project: Applications okular kf5-qt5 SUSEQt5.9 Date of build: Fri, 17 Nov 2017 02:27:11 + Build duration: 13 min and counting JUnit Tests Name:

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.7 - Build # 111 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.7/111/ Project: Applications okular kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 17 Nov 2017 02:27:11 + Build duration: 3 min 43 sec and counting CONSOLE OUTPUT

KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.9 - Build # 63 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.9/63/ Project: Applications okular kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 17 Nov 2017 02:27:11 + Build duration: 52 min and counting JUnit Tests

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.7 - Build # 43 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.7/43/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 17 Nov 2017 04:44:27 + Build duration: 22 min and counting JUnit

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.7 - Build # 44 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.7/44/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 17 Nov 2017 05:39:12 + Build duration: 12 min and counting JUnit

KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.9 - Build # 64 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.9/64/ Project: Applications okular kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 17 Nov 2017 04:06:17 + Build duration: 2 hr 47 min and counting JUnit

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/6/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Fri, 17 Nov 2017 05:39:12 + Build duration: 13 min and counting JUnit Tests