Re: Better way to make the annotation windows scrollable with the document

Hi Dileep, it is great to see you so motivated to fix Okular annotation bugs. But reading your mails I am wondering whether you picked a good place to start. On the one hand, these scrolling annotation windows seem to be quite difficult to implement. On the other hand, my original bug report

D10792: Raise annotation window when clicking on annotation

aacid added a comment. Do you feel like you can try adding an autotest for this? INLINE COMMENTS > annotwindow.cpp:144 > mousePressPos = me->pos(); > +((QFrame*)parent())->raise(); > break; can you use parentWidget() here and avoid the nasty

Re: Better way to make the annotation windows scrollable with the document

El dilluns, 26 de febrer de 2018, a les 11:50:02 CET, Dileep Sankhla va escriure: > Thank you so much Oliver. Due to lack of insight about the bugs, I'm unable > to categorize them into intermediate and difficult jobs. > I will try my best to find and work on some easier issue. We have some bugs

D10797: Add asterisk when an annotation is associated to non-empty popup

aacid added inline comments. INLINE COMMENTS > annotationmodel.cpp:346 > +{ > +caption.append("*"); > +} i'm not sure this is LTR friendly, basically you always put the work on the translators side so it's them that can do it correctly, so you'd do

D10797: Add asterisk when an annotation is associated to non-empty popup

aacid added a comment. In D10797#214159 , @simgunz wrote: > I agree. Any idea? > > Put the annotations containing a popup note in italic? Not my favorite choice though. > > I would like something subtle. Do any other software has

Re: Better way to make the annotation windows scrollable with the document

Thank you so much Oliver. Due to lack of insight about the bugs, I'm unable to categorize them into intermediate and difficult jobs. I will try my best to find and work on some easier issue. Thanks and Regards Dileep On Feb 26, 2018 14:15, "Oliver Sander" wrote: >

[okular] [Bug 383652] Okular stamp tool's custom image support could be more discoverable

https://bugs.kde.org/show_bug.cgi?id=383652 Andrew Crouthamel changed: What|Removed |Added Ever confirmed|0 |1

D10859: Improve layout of annotation configuraton dialogs

simgunz added a comment. In D10859#214352 , @ngraham wrote: > This change seems sensible on first glance, but will it be effective? IMHO there's more to improve with the current UI than just changing the layouts of the config dialogs. For

D10865: [1/5] Access readOnly state of FormWidgets dynamically

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY This is more of a cleanup patch that removes the obsolete m_canBeEnabled member variable which was a leftover IMO from a time

D10865: [1/5] Access readOnly state of FormWidgets dynamically

aheinecke added a task: T8097: Support for read only changes and checkbox values in scripts. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10865 To: aheinecke, #okular Cc: michaelweghorn, ngraham, aacid

D10867: [3/5] Add support to set read only from scripts

aheinecke added a task: T8097: Support for read only changes and checkbox values in scripts. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10867 To: aheinecke, #okular Cc: michaelweghorn, ngraham, aacid

D10867: [3/5] Add support to set read only from scripts

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY This makes it possible to set the read only state from scripts. Requires Poppler master with the patch attached to the parent

D10859: Improve layout of annotation configuraton dialogs

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This change seems sensible on first glance, but will it be effective? IMHO there's more to improve with the current UI than just changing the layouts of the config dialogs. For

D10864: Poppler: Add read only setter for form fields

aheinecke added a task: T8097: Support for read only changes and checkbox values in scripts. REVISION DETAIL https://phabricator.kde.org/D10864 To: aheinecke, #okular Cc: michaelweghorn, ngraham, aacid

D10864: Poppler: Add read only setter for form fields

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY Read only is modifiable from AcroForm scripts. As such we need to add setting it to the data model of Poppler. - I

D10865: [1/5] Access readOnly state of FormWidgets dynamically

aheinecke added inline comments. INLINE COMMENTS > pageview.cpp:1002 > } > -else > +else if ( !( setupFlags & Okular::DocumentObserver::UrlChanged ) > ) > { Without this change the PartTest::testSaveAsUndoStackForms would segfault because the

D10866: [2/5] Implement generic version of Form Widgets refresh

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY The FormWidgetInterface now has a generic slotRefresh that refreshes what all widgets have in common. This is the read-only

D10866: [2/5] Implement generic version of Form Widgets refresh

aheinecke added a task: T8097: Support for read only changes and checkbox values in scripts. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10866 To: aheinecke, #okular Cc: michaelweghorn, ngraham, aacid

D10868: [4/5] Fix CheckBox script usage

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY This implements setting / getting the value of buttons, which is important for checkboxes in scripts. It also moves the

D10868: [4/5] Fix CheckBox script usage

aheinecke added a task: T8097: Support for read only changes and checkbox values in scripts. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10868 To: aheinecke, #okular Cc: michaelweghorn, ngraham, aacid

D10869: [5/5] Add test for read only set and checkbox calculate

aheinecke created this revision. aheinecke added a reviewer: Okular. aheinecke added a project: Okular. aheinecke requested review of this revision. REVISION SUMMARY It's a real world screnario to have checkboxes that toggle the read only state for other fields. The test is a parttest

D10869: [5/5] Add test for read only set and checkbox calculate

aheinecke added a task: T8097: Support for read only changes and checkbox values in scripts. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10869 To: aheinecke, #okular Cc: michaelweghorn, ngraham, aacid

D10859: Improve layout of annotation configuraton dialogs

simgunz edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10859 To: simgunz, #okular, #vdg Cc: michaelweghorn, ngraham, aacid

D10859: Improve layout of annotation configuraton dialogs

simgunz created this revision. simgunz added reviewers: Okular, VDG. Restricted Application added a project: Okular. simgunz requested review of this revision. REVISION SUMMARY The config dialog of each annotation tool is now a single grid layout without group boxes. Everything is aligned.