aheinecke added inline comments.

INLINE COMMENTS

> pageview.cpp:1002
>              }
> -            else
> +            else if ( !( setupFlags & Okular::DocumentObserver::UrlChanged ) 
> )
>              {

Without this change the PartTest::testSaveAsUndoStackForms would segfault 
because the underlying fields are destroyed but setCanBeFilled now accesses 
them to check for readOnly.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10865

To: aheinecke, #okular
Cc: michaelweghorn, ngraham, aacid

Reply via email to