[okular] [Bug 391460] print dialogue does not show advanced options

2018-03-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=391460 --- Comment #2 from royla...@corplink.com.au --- Created attachment 111212 --> https://bugs.kde.org/attachment.cgi?id=111212=edit Screenshot of advanced properties in Okular no access to colour printing this was available in Fedora 25 -- You are

[okular] [Bug 391460] print dialogue does not show advanced options

2018-03-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=391460 --- Comment #1 from royla...@corplink.com.au --- Created attachment 111211 --> https://bugs.kde.org/attachment.cgi?id=111211=edit Screenshot of advanced properties in Okular Access to colour printing not an available option, -- You are receiving

[okular] [Bug 391460] New: print dialogue does not show advanced options

2018-03-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=391460 Bug ID: 391460 Summary: print dialogue does not show advanced options Product: okular Version: 1.3.1 Platform: Fedora RPMs OS: Linux Status: UNCONFIRMED

[okular] [Bug 391407] Okular cannot display next page with hand tool

2018-03-05 Thread Zakhar
https://bugs.kde.org/show_bug.cgi?id=391407 --- Comment #3 from Zakhar --- Just enabled the consecutive feature and browse tool works as I would expect it to, in consecutive mode. It was so not ovbious it was even there as an option, perhaps it should be reconsidered.

[okular] [Bug 391407] Okular cannot display next page with hand tool

2018-03-05 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=391407 Albert Astals Cid changed: What|Removed |Added Resolution|--- |WAITINGFORINFO

D11074: Fix opening files via a file manager on Mac

2018-03-05 Thread René J . V . Bertin
rjvbb added a comment. > One could try to reimplement this with Objective-C, I do not know whether it makes sense though. No, you'd be doing what Qt already does for you. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11074 To: sbragin Cc: ltoscano, rjvbb,

D11074: Fix opening files via a file manager on Mac

2018-03-05 Thread René J . V . Bertin
rjvbb added a comment. > The legacy argc,argv is handled by QCommandLineParser. Only partly, the annoying bit where you loop over the array to see which options are there. For the rest it only handles Qt-specific arguments, and files to be opened end up in the `positionalArguments()`

D11074: Fix opening files via a file manager on Mac

2018-03-05 Thread Sergio Bragin
sbragin added a comment. In D11074#219505 , @ltoscano wrote: > Does each and every macOS application which would like to open a file via a file manager need to implement the same macapplication.cpp (or so) again and again (which makes use of a

D11075: Make Okular show the list of opened windows in the Dock menu

2018-03-05 Thread Sergio Bragin
sbragin added a dependency: D11074: Fix opening files via a file manager on Mac. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11075 To: sbragin Cc: rjvbb, #okular, michaelweghorn, ngraham, aacid

D11074: Fix opening files via a file manager on Mac

2018-03-05 Thread Sergio Bragin
sbragin added a dependent revision: D11075: Make Okular show the list of opened windows in the Dock menu. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11074 To: sbragin Cc: ltoscano, rjvbb, #okular, michaelweghorn, ngraham, aacid

D11074: Fix opening files via a file manager on Mac

2018-03-05 Thread Luigi Toscano
ltoscano added a comment. In D11074#219504 , @sbragin wrote: > In D11074#219502 , @ltoscano wrote: > > > Let me rephrase: each and every macOS application which needs to open file via a file

D11074: Fix opening files via a file manager on Mac

2018-03-05 Thread Sergio Bragin
sbragin added a comment. In D11074#219502 , @ltoscano wrote: > Let me rephrase: each and every macOS application which needs to open file via a file manager needs to implement this same code? File opening via a file manager is handled

D11074: Fix opening files via a file manager on Mac

2018-03-05 Thread Luigi Toscano
ltoscano added a comment. So each application In D11074#219501 , @rjvbb wrote: > > Isn't this another case of "should be fixed in QApplication or another lower level library"? > > No, not anymore than opening files via the legacy

D11074: Fix opening files via a file manager on Mac

2018-03-05 Thread René J . V . Bertin
rjvbb added a comment. > Isn't this another case of "should be fixed in QApplication or another lower level library"? No, not anymore than opening files via the legacy argc,argv mechanism. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11074 To: sbragin Cc:

D11074: Fix opening files via a file manager on Mac

2018-03-05 Thread Sergio Bragin
sbragin added a comment. In D11074#219475 , @ltoscano wrote: > Isn't this another case of "should be fixed in QApplication or another lower level library"? I do not quite understand, what you mean. I guess dispatching QFileOpenEvent is

D11075: Make Okular show the list of opened windows in the Dock menu

2018-03-05 Thread Sergio Bragin
sbragin created this revision. Restricted Application added a project: Okular. sbragin requested review of this revision. REVISION SUMMARY Qt applications, running on Mac, do not show the list of opened windows in the Dock menu. This patch fixes it by creating a custom menu with the list

D11074: Fix opening files via a file manager on Mac

2018-03-05 Thread Luigi Toscano
ltoscano added a comment. Isn't this another case of "should be fixed in QApplication or another lower level library"? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11074 To: sbragin Cc: ltoscano, rjvbb, #okular, michaelweghorn, ngraham, aacid

D11074: Fix opening files via a file manager on Mac

2018-03-05 Thread Sergio Bragin
sbragin created this revision. Restricted Application added a project: Okular. sbragin requested review of this revision. REVISION SUMMARY On Mac a file open event is sent to the QApplication instance if there is a request from the operating system to open a file. This patch adds a new

[okular] [Bug 389953] okular ignores paper size when printing

2018-03-05 Thread Michael Weghorn
https://bugs.kde.org/show_bug.cgi?id=389953 --- Comment #39 from Michael Weghorn --- Great to hear. Thanks for the update! -- You are receiving this mail because: You are the assignee for the bug.

D10932: Bug 288042 - Option to reset forms (Implemented using FormFields)

2018-03-05 Thread Ahmad Osama
ahmadosama updated this revision to Diff 28717. ahmadosama added a comment. I mistakenly replaced the code with the auto test. I edited the patch now. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10932?vs=28622=28717 REVISION DETAIL

D10869: [5/5] Add test for read only set and checkbox calculate

2018-03-05 Thread Andre Heinecke
aheinecke updated this revision to Diff 28711. aheinecke added a comment. No changes, only updated for context. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10869?vs=28120=28711 REVISION DETAIL https://phabricator.kde.org/D10869 AFFECTED FILES

D10932: Bug 288042 - Option to reset forms (Implemented using FormFields)

2018-03-05 Thread Ahmad Osama
ahmadosama added a comment. I mistakenly replaced the code with the auto test. Here is the previous patch. F5741409: 0001-reimplementing-the-reset-option-using-formfields.patch REPOSITORY R223 Okular REVISION DETAIL

D10868: [4/5] Fix CheckBox script usage

2018-03-05 Thread Andre Heinecke
aheinecke updated this revision to Diff 28710. aheinecke added a comment. No changes, only updated to get context REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10868?vs=28119=28710 REVISION DETAIL https://phabricator.kde.org/D10868 AFFECTED FILES

D10867: [3/5] Add support to set read only from scripts

2018-03-05 Thread Andre Heinecke
aheinecke marked an inline comment as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10867 To: aheinecke, #okular Cc: aacid, michaelweghorn, ngraham

D10867: [3/5] Add support to set read only from scripts

2018-03-05 Thread Andre Heinecke
aheinecke updated this revision to Diff 28708. aheinecke added a comment. Added @since marker to setReadOnly REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10867?vs=28115=28708 REVISION DETAIL https://phabricator.kde.org/D10867 AFFECTED FILES

D10866: [2/5] Implement generic version of Form Widgets refresh

2018-03-05 Thread Andre Heinecke
aheinecke updated this revision to Diff 28707. aheinecke added a comment. Updated without setVisibility implicit handling of isReadOnly REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10866?vs=28114=28707 REVISION DETAIL https://phabricator.kde.org/D10866

D10865: [1/5] Access readOnly state of FormWidgets dynamically

2018-03-05 Thread Andre Heinecke
aheinecke updated this revision to Diff 28706. aheinecke added a comment. Removed implicit readOnly handling in setVisiblitiy and updated callers instead. Also the differential is now published with arcanist ;-) REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D10865: [1/5] Access readOnly state of FormWidgets dynamically

2018-03-05 Thread Andre Heinecke
aheinecke added a comment. In D10865#217744 , @aacid wrote: > BTW next time please use arc so phabricator shows the context of the diff. Apologies, I'll try. While I like phabricator I'm not very skilled with arcanist, yet. :-} INLINE

D11051: Remembering side navigation panel state

2018-03-05 Thread Dileep Sankhla
dileepsankhla updated this revision to Diff 28694. dileepsankhla added a comment. Updating: Remembering side navigation panel state Removed the extra whitespace. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11051?vs=28693=28694 BRANCH master

D11051: Remembering side navigation panel state

2018-03-05 Thread Oliver Sander
sander added inline comments. INLINE COMMENTS > sidebar.cpp:717 > { > + > if ( !item ) Please avoid such white-space changes. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11051 To: dileepsankhla, #okular Cc: sander, #okular, michaelweghorn, ngraham, aacid

[okular] [Bug 344599] Thumbnails sidebar always open when okular starts

2018-03-05 Thread Dileep Sankhla
https://bugs.kde.org/show_bug.cgi?id=344599 Dileep Sankhla changed: What|Removed |Added CC|

D11051: Remembering side navigation panel state

2018-03-05 Thread Dileep Sankhla
dileepsankhla added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11051 To: dileepsankhla, #okular Cc: #okular, michaelweghorn, ngraham, aacid

D11051: Remembering side navigation panel state

2018-03-05 Thread Dileep Sankhla
dileepsankhla created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. dileepsankhla requested review of this revision. REVISION SUMMARY Every time Okular starts, one of the items of the side navigation panel is open. There is no

[okular] [Bug 389953] okular ignores paper size when printing

2018-03-05 Thread Attila
https://bugs.kde.org/show_bug.cgi?id=389953 --- Comment #38 from Attila --- The problem didn't reappear, everything is fine. Thank you very much for your excellent support. -- You are receiving this mail because: You are the assignee for the bug.