D10797: Add asterisk when an annotation is associated to non-empty popup

aacid added a comment. In D10797#241432 , @simgunz wrote: > What is the best way to implement this? Given the call to i18n I guess I cannot just append a suffix to ret. > Should I do for each annotation type something like: > > bool

[okular] [Bug 358061] Improved/consistent mechanism to add/modify inline note

https://bugs.kde.org/show_bug.cgi?id=358061 Christoph Feck changed: What|Removed |Added Summary|[Usability] |Improved/consistent

D10797: Add asterisk when an annotation is associated to non-empty popup

simgunz added a comment. What is the best way to implement this? Given the call to i18n I guess I cannot just append a suffix to ret. Should I do for each annotation type something like: bool hasComment = !ann->contents().isEmpty(); ret = hasComment ? i18n( "Highlight with

D10792: Raise annotation window when clicking on annotation

simgunz added a comment. Thanks to your suggestions I made some progresses. My current autotest looks as in the block below. Problems: 1. If I do not export `AnnotWindow` and call `QVERIFY( part.m_pageView->findChildren().size() == 1 )` it fails, while calling `QVERIFY(

D12001: use correct filepath

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Ouch :D REPOSITORY R223 Okular BRANCH fixWarnings REVISION DETAIL https://phabricator.kde.org/D12001 To: fabiank, #okular, hetzenecker, aacid Cc: aacid, #okular, michaelweghorn,

D12001: use correct filepath

fabiank added reviewers: Okular, hetzenecker. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12001 To: fabiank, #okular, hetzenecker Cc: #okular, michaelweghorn, ngraham, aacid

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 46 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/46/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 06 Apr 2018 23:15:12 + Build duration: 17 min and counting JUnit

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/57/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 06 Apr 2018 23:16:22 + Build duration: 16 min and counting JUnit Tests

D10792: Raise annotation window when clicking on annotation

aacid added a comment. In D10792#241405 , @simgunz wrote: > Thanks to your suggestions I made some progresses. > > My current autotest looks as in the block below. > > Problems: > > 1. If I do not export `AnnotWindow` and call

D12001: use correct filepath

This revision was automatically updated to reflect the committed changes. Closed by commit R223:f8f7a77fedc0: use correct filepath (authored by fabiank). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12001?vs=31528=31534 REVISION DETAIL

D12001: use correct filepath

fabiank created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. fabiank requested review of this revision. REVISION SUMMARY Seems like someone forgot to consistently apply a change. Maybe the path construction should be

[okular] [Bug 389669] Searching within a PDF with Boolean Logic

https://bugs.kde.org/show_bug.cgi?id=389669 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 388081] Save annotation inside pdf by default

https://bugs.kde.org/show_bug.cgi?id=388081 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 179555] Okular doesn't recognize chm files

https://bugs.kde.org/show_bug.cgi?id=179555 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 169511] slide duration files for okular

https://bugs.kde.org/show_bug.cgi?id=169511 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 388511] "Do you want to allow [presentation mode]?" is inaccurate and misleading.

https://bugs.kde.org/show_bug.cgi?id=388511 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 387834] Okular does not display replies to "sticky notes"

https://bugs.kde.org/show_bug.cgi?id=387834 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 389206] Efficiently generate print data when Qt's new "arbitrary pages" feature is used

https://bugs.kde.org/show_bug.cgi?id=389206 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 389385] Crash on closing Okular

https://bugs.kde.org/show_bug.cgi?id=389385 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 388450] Popup-note annotations don't scroll with the document

https://bugs.kde.org/show_bug.cgi?id=388450 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 389142] Save as does not work - it says "... try to save it in another ...", but annotations are not saved

https://bugs.kde.org/show_bug.cgi?id=389142 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 391385] Going to the presentation mode twice closes the document

https://bugs.kde.org/show_bug.cgi?id=391385 --- Comment #4 from Albert Astals Cid --- Can you attach the valgrind log of when you do so anyway? It may contain interesting information still. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 388228] Okular crashes when annotating a piece of text

https://bugs.kde.org/show_bug.cgi?id=388228 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 387639] Annotations are only partially selectable on a hidpi screen

https://bugs.kde.org/show_bug.cgi?id=387639 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 374406] Cannot set print margins to zero - renders Okular useless for printing labels

https://bugs.kde.org/show_bug.cgi?id=374406 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 388458] Wrong size of rectangles around annotation icons (e.g. popup note) for PDF documents

https://bugs.kde.org/show_bug.cgi?id=388458 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 388175] core dump while opening a specific PDF document

https://bugs.kde.org/show_bug.cgi?id=388175 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 388288] some thumbnail of pdf not shown in dolphin, some are shown

https://bugs.kde.org/show_bug.cgi?id=388288 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 315930] Ability to sign a PDF with my scanned signature (i.e. picture file) like in Adobe Acrobat

https://bugs.kde.org/show_bug.cgi?id=315930 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 389090] Okular crashes when scrolling

https://bugs.kde.org/show_bug.cgi?id=389090 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 344645] Printed PDF slides, created with latex beamer class, are empty.

https://bugs.kde.org/show_bug.cgi?id=344645 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 322231] Okular cannot stretch pages smaller than A4 size, to print at A4 size

https://bugs.kde.org/show_bug.cgi?id=322231 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 353401] Feature requst: "typewriter" annotation tool

https://bugs.kde.org/show_bug.cgi?id=353401 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 275371] Stamp annotations are drawn by both poppler and Okular

https://bugs.kde.org/show_bug.cgi?id=275371 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 376459] Add crossout and replace annotations

https://bugs.kde.org/show_bug.cgi?id=376459 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 358061] [Usability] Improved/consistent mechanism to add/modify inline note

https://bugs.kde.org/show_bug.cgi?id=358061 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 325119] Size of inline notes not adjusted to font size and does not respect drawn boundaries

https://bugs.kde.org/show_bug.cgi?id=325119 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 389216] Export Markdown to PDF segfaults

https://bugs.kde.org/show_bug.cgi?id=389216 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 333981] improve annotation movement feedback performance

https://bugs.kde.org/show_bug.cgi?id=333981 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 389332] Okular ignores printer colour settings

https://bugs.kde.org/show_bug.cgi?id=389332 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 56 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/56/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 06 Apr 2018 09:20:59 + Build duration: 16 min and counting JUnit Tests

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 45 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/45/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 06 Apr 2018 09:20:04 + Build duration: 6 min 52 sec and counting

[okular] [Bug 351849] Margins often cut when printing

https://bugs.kde.org/show_bug.cgi?id=351849 --- Comment #21 from Germano Massullo --- Created attachment 111870 --> https://bugs.kde.org/attachment.cgi?id=111870=edit error_log I changed the 'ErrorLog' directive in '/etc/cups/cups-files.conf' to 'ErrorLog

[okular] [Bug 351849] Margins often cut when printing

https://bugs.kde.org/show_bug.cgi?id=351849 Germano Massullo changed: What|Removed |Added Resolution|WAITINGFORINFO |---

[okular] [Bug 389953] okular ignores paper size when printing

https://bugs.kde.org/show_bug.cgi?id=389953 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 391505] Okular doesn't load cups default options for printers

https://bugs.kde.org/show_bug.cgi?id=391505 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 391972] okular slower than evince at rendering a pdf

https://bugs.kde.org/show_bug.cgi?id=391972 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 392106] opening (e)PS files from the commandline

https://bugs.kde.org/show_bug.cgi?id=392106 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 336617] Feature request: disable fit-to-page while printing.

https://bugs.kde.org/show_bug.cgi?id=336617 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 392463] Okular segfaults all the time when used with emacs/latex

https://bugs.kde.org/show_bug.cgi?id=392463 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 173896] Sent-to menu entry or send-via-email menu-entry

https://bugs.kde.org/show_bug.cgi?id=173896 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

https://bugs.kde.org/show_bug.cgi?id=389668 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 391352] Trim margins breaks mouse wheel zoom out

https://bugs.kde.org/show_bug.cgi?id=391352 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 391625] Okular displays blurry images when opening epub files

https://bugs.kde.org/show_bug.cgi?id=391625 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 391894] Zoom out doesn't work when zoom is Fit Width

https://bugs.kde.org/show_bug.cgi?id=391894 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 351849] Margins often cut when printing

https://bugs.kde.org/show_bug.cgi?id=351849 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 392682] Okular ignores umask on save file as

https://bugs.kde.org/show_bug.cgi?id=392682 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 390706] Two-finger touchscreen zoom gesture needs final refresh

https://bugs.kde.org/show_bug.cgi?id=390706 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 342927] More Vim-like shortcuts

https://bugs.kde.org/show_bug.cgi?id=342927 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 373957] okular-17.12.3: Settings dialog default size does not match the content

https://bugs.kde.org/show_bug.cgi?id=373957 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 389947] touchpad scrolling: Okular jumps several lines down first when scrolling after the cursor moves out and back again

https://bugs.kde.org/show_bug.cgi?id=389947 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 346979] Touch control and basic gestures

https://bugs.kde.org/show_bug.cgi?id=346979 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 391407] Okular cannot display next page with hand tool

https://bugs.kde.org/show_bug.cgi?id=391407 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 381328] Okular crashes when editing forms in a PDF that's located inside an archive

https://bugs.kde.org/show_bug.cgi?id=381328 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 201092] Drag to scroll in Okular's text mode and KDE wide

https://bugs.kde.org/show_bug.cgi?id=201092 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 391385] Going to the presentation mode twice closes the document

https://bugs.kde.org/show_bug.cgi?id=391385 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 392806] New: Lock horizontal scroll

https://bugs.kde.org/show_bug.cgi?id=392806 Bug ID: 392806 Summary: Lock horizontal scroll Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal

[okular] [Bug 390356] wrong render for arabic xps

https://bugs.kde.org/show_bug.cgi?id=390356 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 387882] Presentation mode only ever uses non-continuous single page view

https://bugs.kde.org/show_bug.cgi?id=387882 --- Comment #13 from gbod...@gmail.com --- If it's true, the developers won't fix this, it is indeed a tragedy, and no one explained how to remove the borders as posted below. Whoever is responding seems to be of a single mind set, and doesn't

[okular] [Bug 387882] Presentation mode only ever uses non-continuous single page view

https://bugs.kde.org/show_bug.cgi?id=387882 --- Comment #14 from Albert Astals Cid --- This is not a user support channel, i'm sorry you don't know how to read the manual to figure out how to remove the side bar and the page bar. I advise you try to ask in places where we do user

[okular] [Bug 392806] Lock horizontal scroll

https://bugs.kde.org/show_bug.cgi?id=392806 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org