[Okular-devel] Review Request 122752: Fixed change in mouse cursor appearance (when selected Selection tool)

2015-02-28 Thread Pulkit Gupta

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122752/
---

Review request for Okular and Albert Astals Cid.


Bugs: 334798
http://bugs.kde.org/show_bug.cgi?id=334798


Repository: okular


Description
---

Solved the bug where mouse cursor appearance was not changing (when selected 
Selection Tool) when hovering over certain areas in okular.


Diffs
-

  ui/pageview.cpp 2dd8cf1 

Diff: https://git.reviewboard.kde.org/r/122752/diff/


Testing
---


Thanks,

Pulkit Gupta

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 344645] Printed PDF slides, created with latex beamer class, are empty.

2015-02-28 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=344645

--- Comment #7 from Albert Astals Cid aa...@kde.org ---
(In reply to Christux from comment #6)
 (In reply to Albert Astals Cid from comment #5)
  This is very confusing, since it's basically what we do (pdftops+lpr)
 Oh, that's indeed weird. Okular is calling the system tools pdftops+lpr,
 right?

pdftops not directly, but the same library so the behaviour should be the same,
lpr yes.

  
  At this point i have no idea of what can be wrong.
 I downloaded the okular source code, but could not find the printing dialog,
 nor does setting a breakpoint works except at main (Probably the debug
 symbols are missing). What I am locking for is, what code gets executed when
 I press print in the print dialog. If you could point me to the right place
 I will lock into it.
 
 I created the makefiles with the following cmake flags:
 
 cmake ../ -DCMAKE_BUILD_TYPE=debugfull
 -DCMAKE_PREFIX_PATH=/home/SOMEONE/okular 
 
 But not even the kDebug() lines are printed, did I missed something.

Most probably the KDEDIRS part, see end of http://okular.kde.org/download.php

 
 Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 344662] I cannot find highlight pen tool to highlight and edit PDF

2015-02-28 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=344662

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Resolution|--- |INVALID
 CC||aa...@kde.org
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Albert Astals Cid aa...@kde.org ---
Read the manual (or press F6)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 344666] Reflow/Change font size for E-book formats (Epub/...)

2015-02-28 Thread Silvio Frischknecht
https://bugs.kde.org/show_bug.cgi?id=344666

Silvio Frischknecht silvio.fris...@gmail.com changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #2 from Silvio Frischknecht silvio.fris...@gmail.com ---
Thank you. It's a bit unintuitive, and it would be cool if it could be worked
into okulars zoom functionality, but it works for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 344645] Printed PDF slides, created with latex beamer class, are empty.

2015-02-28 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=344645

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Status|NEEDSINFO   |UNCONFIRMED
 Resolution|WAITINGFORINFO  |---

--- Comment #5 from Albert Astals Cid aa...@kde.org ---
  Now can you print that myfile.ps file with lpr?
 Yes, printing with lpr works that way. Printing the pdf with lpr directly 
 works too.
This is very confusing, since it's basically what we do (pdftops+lpr)

At this point i have no idea of what can be wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 344645] Printed PDF slides, created with latex beamer class, are empty.

2015-02-28 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=344645

--- Comment #3 from Albert Astals Cid aa...@kde.org ---
Ok, more testing. Can you do this?

Open a command line:
pdftops myfile.pdf
gs myfile.ps
Does gs show the file correctly?
Now can you print that myfile.ps file with lpr?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 344645] Printed PDF slides, created with latex beamer class, are empty.

2015-02-28 Thread Christux
https://bugs.kde.org/show_bug.cgi?id=344645

--- Comment #4 from Christux c.schwarzgruber...@gmail.com ---
(In reply to Albert Astals Cid from comment #3)
 gs show the file correctly?
Yes it does show the file correctly!

 Now can you print that myfile.ps file with lpr?
Yes, printing with lpr works that way. Printing the pdf with lpr directly works
too.


INFO: Printing the pdf file with a different printer (Epson Stylus Office
BX635FWD) works partly, but misbehaves, as it ignores the landscape setting.
Again printing the pdf with evince on the Epson printer works as supposed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 344645] Printed PDF slides, created with latex beamer class, are empty.

2015-02-28 Thread Christux
https://bugs.kde.org/show_bug.cgi?id=344645

--- Comment #6 from Christux c.schwarzgruber...@gmail.com ---
(In reply to Albert Astals Cid from comment #5)
 This is very confusing, since it's basically what we do (pdftops+lpr)
Oh, that's indeed weird. Okular is calling the system tools pdftops+lpr, right?

 At this point i have no idea of what can be wrong.
I downloaded the okular source code, but could not find the printing dialog,
nor does setting a breakpoint works except at main (Probably the debug symbols
are missing). What I am locking for is, what code gets executed when I press
print in the print dialog. If you could point me to the right place I will lock
into it.

I created the makefiles with the following cmake flags:

cmake ../ -DCMAKE_BUILD_TYPE=debugfull -DCMAKE_PREFIX_PATH=/home/SOMEONE/okular 

But not even the kDebug() lines are printed, did I missed something.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 344666] Reflow/Change font size for E-book formats (Epub/...)

2015-02-28 Thread Yuri Chornoivan
https://bugs.kde.org/show_bug.cgi?id=344666

Yuri Chornoivan yurc...@ukr.net changed:

   What|Removed |Added

 CC||yurc...@ukr.net

--- Comment #1 from Yuri Chornoivan yurc...@ukr.net ---
Can you try Settings - Configure Backends... - EPub then press Change...
button?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 344599] Thumbnails sidebar always open when okular starts

2015-02-28 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=344599

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
 CC||aa...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Pdf files not opening

2015-02-28 Thread Pulkit Gupta
Oh sorry for the sir part :)
I was able to fix the problem, I had to run 'export KDEDIRS' command
each time I open terminal as it doesn't remember it until I write it
directly in bash.
By the way, I was also able to fix a bug and have posted it for a
review at https://git.reviewboard.kde.org/r/122752/
Please review it :D
Regards
Pulkit

On 2/28/15, Albert Astals Cid aa...@kde.org wrote:
 El Divendres, 27 de febrer de 2015, a les 09:58:22, Pulkit Gupta va
 escriure:
 Hello sir,

 We are not a Sir, this is a mailing list where there's lots of people
 subscribed.

 I have good knowledge of C++ and Qt, so I wanted to contribute and
 develop Okular.

 Great :)

 I was able to build and install Okular from the
 source, but whenever I open it, it is not able to show any pdf files.
 When opening Okular in Command prompt, it shows

 okular(8747)/kdecore (trader) KServiceTypeTrader::defaultOffers:
 KServiceTypeTrader: serviceType  okular/Generator  not found

 And when I select a pdf file, it shows

 okular(8747)/kdecore (trader): KMimeTypeTrader: couldn't find service
 type okular/Generator
 Please ensure that the .desktop file for it is installed; then run
 kbuildsycoca4.
 okular(8747)/okular (app) Okular::Document::openDocument: No plugin
 for mimetype 'application/pdf'.

 I have tried to build and install Okular both in ubuntu and Kubuntu. I
 also ran kbuildsycoca4 --noincremental command, but it didn't help. I
 can see a okularGenerator.desktop file in
 /home/pulkit/Okular/install/share/kde4/servicetypes, but still this
 error comes. Also, if I install Okular from Ubuntu software center or
 from Muon, then that works perfectly well but if I build and install
 it from source, it doesn't work. Please help, I really want to start
 developing for Okular.

 Can you attach the summary part of the cmake run? i.e. the parts that say

 The following external packages were located on your system.
 and
 The following OPTIONAL packages could NOT be located on your system.
 ?

 Cheers,
   Albert

 Thanking you,
 Pulkit
 ___
 Okular-devel mailing list
 Okular-devel@kde.org
 https://mail.kde.org/mailman/listinfo/okular-devel

 ___
 Okular-devel mailing list
 Okular-devel@kde.org
 https://mail.kde.org/mailman/listinfo/okular-devel

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 344666] New: Reflow/Change font size for E-book formats (Epub/...)

2015-02-28 Thread Silvio Frischknecht
https://bugs.kde.org/show_bug.cgi?id=344666

Bug ID: 344666
   Summary: Reflow/Change font size for E-book formats (Epub/...)
   Product: okular
   Version: unspecified
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: EPub backend
  Assignee: okular-devel@kde.org
  Reporter: silvio.fris...@gmail.com

Other ebook reader such as calibre or kindle allow the reader to select the
font size and reflow the text. I like to have a big font size so the lines are
short. I'd like to see this feature in okular

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 344662] New: I cannot find highlight pen tool to highlight and edit PDF

2015-02-28 Thread kapila Nishantha
https://bugs.kde.org/show_bug.cgi?id=344662

Bug ID: 344662
   Summary: I cannot find highlight pen tool to highlight and edit
PDF
   Product: okular
   Version: 0.19.1
  Platform: Kubuntu Packages
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: kapilaranasingh...@gmail.com

I want to edit and want to highlight some important words and sentence in the
document.but i cannot find a such a tool . if there is tool like that please
put it as icon .it will easy to find users to that tool. 

Reproducible: Couldn't Reproduce

Steps to Reproduce:
1.search on software tool bar
2.search on settings ,edit menus
3.search on help 

Actual Results:  
never got result 

Expected Results:  
provide such a tool

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 344678] New: Print preview and printing only shows blank pages

2015-02-28 Thread Daniel Green
https://bugs.kde.org/show_bug.cgi?id=344678

Bug ID: 344678
   Summary: Print preview and printing only shows blank pages
   Product: okular
   Version: 0.21.1
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: printing
  Assignee: okular-devel@kde.org
  Reporter: ddgr...@gmail.com

The PDF views fine, but print preview shows all the pages as blank and actually
printing just produces blank pages as well.

Reproducible: Always

Steps to Reproduce:
1. Open PDF
2. Select 'File' - 'Print Preview'

Actual Results:  
Blank pages

Expected Results:  
Pages that look that same as the PDF in the usual view

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 162219] Adjust view to the position where you clicked into the thumbnail

2015-02-28 Thread miklos
https://bugs.kde.org/show_bug.cgi?id=162219

--- Comment #6 from miklos mtm...@freemail.hu ---
The bug is not in the thumbnails IMHO. When a document is reloaded, because the
file was changed, Okular jumps to between the current and the previous page.
The 'jump to page X' operation jumps to X-0.5 instead of X, and thus the border
between the two pages gets to be in the center of the screen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 122570: Update session restore/save to account for multiple tabs

2015-02-28 Thread Jonathan Doman

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122570/
---

(Updated Feb. 28, 2015, 4:41 p.m.)


Review request for Okular.


Changes
---

Add unit test for session restoring. I couldn't figure a way to test the 
realistic full code paths of session restoring, but this should test the 
important parts inside okular. Currently the test just checks that the correct 
number of windows and tabs are restored.

Overall I'm pretty happy with this now.


Bugs: 335852
http://bugs.kde.org/show_bug.cgi?id=335852


Repository: okular


Description
---

New Shell logic loops through each tab and saves URLs and active tab index in 
session config.

Viewport was previously saved in session config, but I opted to remove it 
because:
1. It complicates the restore logic. It would require either using 
QMetaObject::invoke or adding functions to ViewerInterface. Also hard to get 
right since opening a document isn't exactly synchronous.
2. Viewport info is already saved during a graceful shutdown.


Diffs (updated)
-

  part.h 594eb44113ae130a6fefbf2800af32886aa3cbef 
  part.cpp 36438af1cd1036ee954f80b5359a0cab2c019036 
  shell/main.cpp 16289608f0acf299db04258d842bbb87add62c0b 
  shell/shell.h 224acfe023ef8e9cc58b52ddf32068af8937896a 
  shell/shell.cpp f7675fdc8203e90210b8ba82620b19ae69ee43e1 
  tests/mainshelltest.cpp c5d7289d668f8a1ea0250deb068a43c19490edff 

Diff: https://git.reviewboard.kde.org/r/122570/diff/


Testing
---

I was not familiar with session functionality in KDE before working on this 
bug, so my tests may not represent reality. I used the dbus interface to 
trigger a session save (org.kde.KSMServerInterface.saveCurrentSession), and 
then reloaded a session by running `okular --session xyz`, which I think is how 
KDE does it behind the scenes.

- Restore one or more documents in single window with tabs enabled.
- Restore multiple windows, tabs enabled or disabled.
- Restore session config describing multible tabs, even though tabs are disabled


Thanks,

Jonathan Doman

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Review Request 122570: Update session restore/save to account for multiple tabs

2015-02-28 Thread Jonathan Doman

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122570/
---

(Updated Feb. 28, 2015, 4:45 p.m.)


Review request for Okular.


Changes
---

Remove some dev logic


Bugs: 335852
http://bugs.kde.org/show_bug.cgi?id=335852


Repository: okular


Description
---

New Shell logic loops through each tab and saves URLs and active tab index in 
session config.

Viewport was previously saved in session config, but I opted to remove it 
because:
1. It complicates the restore logic. It would require either using 
QMetaObject::invoke or adding functions to ViewerInterface. Also hard to get 
right since opening a document isn't exactly synchronous.
2. Viewport info is already saved during a graceful shutdown.


Diffs (updated)
-

  part.h 594eb44113ae130a6fefbf2800af32886aa3cbef 
  part.cpp 36438af1cd1036ee954f80b5359a0cab2c019036 
  shell/main.cpp 16289608f0acf299db04258d842bbb87add62c0b 
  shell/shell.h 224acfe023ef8e9cc58b52ddf32068af8937896a 
  shell/shell.cpp f7675fdc8203e90210b8ba82620b19ae69ee43e1 
  tests/mainshelltest.cpp c5d7289d668f8a1ea0250deb068a43c19490edff 

Diff: https://git.reviewboard.kde.org/r/122570/diff/


Testing
---

I was not familiar with session functionality in KDE before working on this 
bug, so my tests may not represent reality. I used the dbus interface to 
trigger a session save (org.kde.KSMServerInterface.saveCurrentSession), and 
then reloaded a session by running `okular --session xyz`, which I think is how 
KDE does it behind the scenes.

- Restore one or more documents in single window with tabs enabled.
- Restore multiple windows, tabs enabled or disabled.
- Restore session config describing multible tabs, even though tabs are disabled


Thanks,

Jonathan Doman

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 344678] Print preview and printing only shows blank pages

2015-02-28 Thread Daniel Green
https://bugs.kde.org/show_bug.cgi?id=344678

--- Comment #1 from Daniel Green ddgr...@gmail.com ---
Created attachment 91346
  -- https://bugs.kde.org/attachment.cgi?id=91346action=edit
PDF that shows this problem

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 162219] Adjust view to the position where you clicked into the thumbnail

2015-02-28 Thread Bennett
https://bugs.kde.org/show_bug.cgi?id=162219

Bennett bleveb...@gmail.com changed:

   What|Removed |Added

 CC||bleveb...@gmail.com

--- Comment #5 from Bennett bleveb...@gmail.com ---
I am seeing this as well with 0.19.3 and thought this was fixed in  Bug 201669
- Scrolling in thumbnails view is broken.  In 201669 there were a few things
fixed including what I thought was this behavior.  

I downloaded the source and did a build of 0.21.60 and compared the
ui/thumbnaillist.cpp and the changes from 201669 are there.  This build behaves
the same way as what is described in this bug as well as what was suppose to be
fixed regarding the selection of thumbnails in 201669.

Playing with the mouse event code in thumbnaillist.cpp and rebuilding was not
useful to me, as I am a noob with c++ and not sure what I am doing.  I did
download the okular source from KDE 14.14 (I am on 14.13 installed on ubuntu),
and the thumbnaillist.cpp is exactly the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel