Re: Review Request 130219: Enable background color to be changed from settings

[Albert Freeman]

> On Aug. 9, 2017, 6:24 p.m., Albert Astals Cid wrote:
> > Thanks for contributing to Okular :)
> > 
> > Why would you need a different background color?

I personally much prefer black as a background color.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130219/#review103582
---


On Aug. 11, 2017, 2:50 a.m., Albert Freeman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130219/
> ---
> 
> (Updated Aug. 11, 2017, 2:50 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Enable background color to be changed from settings
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt ab7ad239 
>   conf/dlggeneral.h f363d260 
>   conf/dlggeneral.cpp 964a655b 
>   conf/dlggeneralbase.ui cf4ebca0 
>   conf/okular.kcfg 69ea8cf6 
>   mobile/components/CMakeLists.txt f1af2602 
>   ui/pageview.cpp 3d935a2e 
>   ui/pageviewutils.cpp a57712ca 
> 
> Diff: https://git.reviewboard.kde.org/r/130219/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Freeman
> 
>

Re: Review Request 130219: Enable background color to be changed from settings

[Albert Freeman]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130219/
---

(Updated Aug. 11, 2017, 2:50 a.m.)


Review request for Okular.


Repository: okular


Description
---

Enable background color to be changed from settings


Diffs (updated)
-

  CMakeLists.txt ab7ad239 
  conf/dlggeneral.h f363d260 
  conf/dlggeneral.cpp 964a655b 
  conf/dlggeneralbase.ui cf4ebca0 
  conf/okular.kcfg 69ea8cf6 
  mobile/components/CMakeLists.txt f1af2602 
  ui/pageview.cpp 3d935a2e 
  ui/pageviewutils.cpp a57712ca 

Diff: https://git.reviewboard.kde.org/r/130219/diff/


Testing
---


Thanks,

Albert Freeman

[okular] [Bug 383386] New: Show progress bar while printing to pdf

[Kishore Gopalakrishnan]

https://bugs.kde.org/show_bug.cgi?id=383386

Bug ID: 383386
   Summary: Show progress bar while printing to pdf
   Product: okular
   Version: 1.1.3
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: printing
  Assignee: okular-devel@kde.org
  Reporter: kishor...@gmail.com
  Target Milestone: ---

While printing to PDF, there is no visible indication of whether the print job
is completed, or whether it is still going on. This means one has to manually
check if the printed file is present and openable to find out if the print is
completed and it is safe to close okular.

Either a progress bar, or a dialog box to tell the user that the print job is
successfully completed would be useful.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D7241: Search for Kirigami

[Albert Astals Cid]

aacid edited reviewers, added: mart; removed: aacid.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7241

To: heikobecker, #okular, mart
Cc: aacid

D7241: Search for Kirigami

[Albert Astals Cid]

aacid resigned from this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D7241

To: heikobecker, #okular, aacid
Cc: aacid

D7241: Search for Kirigami

[Heiko Becker]

heikobecker created this revision.
Restricted Application added a project: Okular.

REVISION SUMMARY
  Makes it a bit more obvious that Kirigami is needed at runtime.

TEST PLAN
  Show a nice status message

REPOSITORY
  R223 Okular

BRANCH
  Applications/17.08

REVISION DETAIL
  https://phabricator.kde.org/D7241

AFFECTED FILES
  CMakeLists.txt

To: heikobecker, #okular, aacid
Cc: aacid

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

[Oliver Sander]

> On Aug. 10, 2017, 3:53 p.m., Christoph Feck wrote:
> > generators/poppler/generator_pdf.cpp, line 1086
> > 
> >
> > Coding style issues:
> > - there is a space after '(' but no space before ')'
> > - the code after '{' is not indented

> there is a space after '(' but no space before ')'

I promise to fix that in a later commit

> the code after '{' is not indented

That was intentional.  Indenting it properly would have led to a patch with 
lots of whitespace changes.  For easier reviewing I left the indentation as it 
was.


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130218/#review103593
---


On Aug. 10, 2017, 3:32 p.m., Oliver Sander wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130218/
> ---
> 
> (Updated Aug. 10, 2017, 3:32 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> When the users chooses to print with rasterization and annotations, it is 
> easy to print directly to a QPrinter, rather than converting to PostScript 
> and then using CUPS tools.  The code for it was already there, but it was 
> hidden behind an #ifdef Q_OS_WIN. This patch enables it for all plattforms.  
> If nothing else, it will make an interesting debugging tool, because it 
> allows to bypass the postscript & cups toolchain from the GUI. This may allow 
> to track down some of the numerous my-printer-settings-are-getting-ignored 
> bugs.
> 
> Incidentally, this patch does fix at least one bug for me: Without it, my 
> printer will happily ignore the 'print in grayscale' button.  With the patch, 
> that button is suddenly honoured.
> 
> This patch is a part of https://git.reviewboard.kde.org/r/130055/ .  I post 
> it here separately because I am not sure anymore whether the other stuff in 
> that larger patch is a good idea.
> 
> 
> Diffs
> -
> 
>   generators/poppler/generator_pdf.cpp 42ccb3a26 
> 
> Diff: https://git.reviewboard.kde.org/r/130218/diff/
> 
> 
> Testing
> ---
> 
> Printed a few test sheets, to a printer and a file.
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

[Christoph Feck]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130218/#review103593
---




generators/poppler/generator_pdf.cpp (line 1086)


Coding style issues:
- there is a space after '(' but no space before ')'
- the code after '{' is not indented


- Christoph Feck


On Aug. 10, 2017, 5:32 p.m., Oliver Sander wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130218/
> ---
> 
> (Updated Aug. 10, 2017, 5:32 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> When the users chooses to print with rasterization and annotations, it is 
> easy to print directly to a QPrinter, rather than converting to PostScript 
> and then using CUPS tools.  The code for it was already there, but it was 
> hidden behind an #ifdef Q_OS_WIN. This patch enables it for all plattforms.  
> If nothing else, it will make an interesting debugging tool, because it 
> allows to bypass the postscript & cups toolchain from the GUI. This may allow 
> to track down some of the numerous my-printer-settings-are-getting-ignored 
> bugs.
> 
> Incidentally, this patch does fix at least one bug for me: Without it, my 
> printer will happily ignore the 'print in grayscale' button.  With the patch, 
> that button is suddenly honoured.
> 
> This patch is a part of https://git.reviewboard.kde.org/r/130055/ .  I post 
> it here separately because I am not sure anymore whether the other stuff in 
> that larger patch is a good idea.
> 
> 
> Diffs
> -
> 
>   generators/poppler/generator_pdf.cpp 42ccb3a26 
> 
> Diff: https://git.reviewboard.kde.org/r/130218/diff/
> 
> 
> Testing
> ---
> 
> Printed a few test sheets, to a printer and a file.
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

[Oliver Sander]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130218/
---

(Updated Aug. 10, 2017, 3:32 p.m.)


Status
--

This change has been marked as submitted.


Review request for Okular.


Changes
---

Submitted with commit 0c4c2ddbbc5e509c69b72c99bf6e83a356669eba by Oliver Sander 
to branch master.


Repository: okular


Description
---

When the users chooses to print with rasterization and annotations, it is easy 
to print directly to a QPrinter, rather than converting to PostScript and then 
using CUPS tools.  The code for it was already there, but it was hidden behind 
an #ifdef Q_OS_WIN. This patch enables it for all plattforms.  If nothing else, 
it will make an interesting debugging tool, because it allows to bypass the 
postscript & cups toolchain from the GUI. This may allow to track down some of 
the numerous my-printer-settings-are-getting-ignored bugs.

Incidentally, this patch does fix at least one bug for me: Without it, my 
printer will happily ignore the 'print in grayscale' button.  With the patch, 
that button is suddenly honoured.

This patch is a part of https://git.reviewboard.kde.org/r/130055/ .  I post it 
here separately because I am not sure anymore whether the other stuff in that 
larger patch is a good idea.


Diffs
-

  generators/poppler/generator_pdf.cpp 42ccb3a26 

Diff: https://git.reviewboard.kde.org/r/130218/diff/


Testing
---

Printed a few test sheets, to a printer and a file.


Thanks,

Oliver Sander

Re: Review Request 130218: Print via QPrinter when rasterizing and printing annotations

[Oliver Sander]

> On Aug. 9, 2017, 9:19 p.m., Albert Astals Cid wrote:
> > Ok, you're the printing maintainer now ;)
> > 
> > Good luck!
> > 
> > P.S: I can still try to review your patches if you want :)

Thanks.  I still need lots of help.


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130218/#review103584
---


On Aug. 9, 2017, 8:58 p.m., Oliver Sander wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130218/
> ---
> 
> (Updated Aug. 9, 2017, 8:58 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> When the users chooses to print with rasterization and annotations, it is 
> easy to print directly to a QPrinter, rather than converting to PostScript 
> and then using CUPS tools.  The code for it was already there, but it was 
> hidden behind an #ifdef Q_OS_WIN. This patch enables it for all plattforms.  
> If nothing else, it will make an interesting debugging tool, because it 
> allows to bypass the postscript & cups toolchain from the GUI. This may allow 
> to track down some of the numerous my-printer-settings-are-getting-ignored 
> bugs.
> 
> Incidentally, this patch does fix at least one bug for me: Without it, my 
> printer will happily ignore the 'print in grayscale' button.  With the patch, 
> that button is suddenly honoured.
> 
> This patch is a part of https://git.reviewboard.kde.org/r/130055/ .  I post 
> it here separately because I am not sure anymore whether the other stuff in 
> that larger patch is a good idea.
> 
> 
> Diffs
> -
> 
>   generators/poppler/generator_pdf.cpp 42ccb3a26 
> 
> Diff: https://git.reviewboard.kde.org/r/130218/diff/
> 
> 
> Testing
> ---
> 
> Printed a few test sheets, to a printer and a file.
> 
> 
> Thanks,
> 
> Oliver Sander
> 
>