kossebau added a comment.
@aacid poked me as well to look at this., so I give in, as actually I might
indeed be the one knowing most about this code still. Sadly out of loop with
Calligra & Okular, not even build setups. But what I remember from the time
when I hacked on the Okular plugins o
aacid added a comment.
Builds and runs now :)
INLINE COMMENTS
> converter.cpp:117
> +Okular::BrowseAction *action = new Okular::BrowseAction(
> QUrl( textCharFormat.anchorHref() ) );
> +emit addAction( action, textFragment.position(),
> textFragment.position(
https://bugs.kde.org/show_bug.cgi?id=383915
--- Comment #3 from Albert Astals Cid ---
The infinite F5 crash is probably fixed by https://phabricator.kde.org/D7495
I'm undecided that that would fix anything that happens with "normal use"
though.
--
You are receiving this mail because:
You are t
aacid created this revision.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.
REVISION SUMMARY
If you press and hold https://phabricator.kde.org/F5 we try to reload
multiple times, which isn't a nice idea, let's finish one before starting the
n
https://bugs.kde.org/show_bug.cgi?id=383915
Albert Astals Cid changed:
What|Removed |Added
CC||aa...@kde.org
Resolution|---
https://bugs.kde.org/show_bug.cgi?id=383784
Simon Andric changed:
What|Removed |Added
CC||simonandr...@gmail.com
--
You are receiving thi
https://bugs.kde.org/show_bug.cgi?id=383915
--- Comment #1 from Flupp ---
Created attachment 107481
--> https://bugs.kde.org/attachment.cgi?id=107481&action=edit
An arbitrary pdf file for testing.
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.kde.org/show_bug.cgi?id=383915
Bug ID: 383915
Summary: Okular crashes with a segfault on reload for some
synctex files
Product: okular
Version: unspecified
Platform: Archlinux Packages
OS: Linux
hetzenecker marked 5 inline comments as done.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D6268
To: hetzenecker, davidedmundson, aacid
Cc: sander, anthonyfieroni, #okular, aacid
progwolff updated this revision to Diff 18578.
progwolff added a comment.
- fix typo
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7382?vs=18577&id=18578
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7382
AFFECTED FILES
cmake/modules/F
progwolff updated this revision to Diff 18577.
progwolff added a comment.
- fix build with discount < 2.2.2
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7382?vs=18379&id=18577
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7382
AFFECTED
progwolff added a comment.
In https://phabricator.kde.org/D7382#138593, @aacid wrote:
> It doesn't build on Ubuntu 17.04
In this revision unknown flags are defined to 0. This should allow us to
build with older versions of discount.
I also set the minimum version to 2.
hetzenecker updated this revision to Diff 18574.
hetzenecker marked an inline comment as done.
hetzenecker added a comment.
Addressed the previous comments, change includes in particular:
- shallow copy of pixmaps
- fix for annotation drawing with tilemanager
- HiDPI pixmaps for annota
progwolff added a comment.
In https://phabricator.kde.org/D7431#138583, @aacid wrote:
> Is there actually no code? I.e. is it just loading an exising plugin that
knows how to use rtf but wasn't told about it?
Exactly. The needed filter and converter were already implemented.
REPO
14 matches
Mail list logo
