D7595: Skip reload when another reload is already in progress

aacid added a comment. Please abandon this revision, i commited https://commits.kde.org/okular/a6aea956081e8faac2484ab2283a5ab50f9e0bbe REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7595 To: rkflx, #okular Cc: sander, aacid

D7495: Do not start reloading again if we're reloading

aacid abandoned this revision. aacid added a comment. Got in as https://commits.kde.org/okular/a6aea956081e8faac2484ab2283a5ab50f9e0bbe REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7495 To: aacid Cc: rkflx, #okular, aacid

[okular] [Bug 384142] okular: seg at exit (For multiple input files)

https://bugs.kde.org/show_bug.cgi?id=384142 --- Comment #4 from Dave Gilbert --- Not tested, but Thanks! -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

https://bugs.kde.org/show_bug.cgi?id=384185 --- Comment #3 from Albert Astals Cid --- Yes works for me. HAvne't you destroyed this feature locally while testing patches D7595/D7495 ? -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 380154] Please add "Rulers" option to Okular

https://bugs.kde.org/show_bug.cgi?id=380154 --- Comment #3 from yousifjka...@yahoo.com --- Hi. It is a remainder about this issue. Dear due you will accept to add this feature or not ? If yes, please allow me to add something I forgot in 1st post of this thread: regarding rulers they should

D7241: Search for Kirigami

heikobecker added a comment. Ping? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7241 To: heikobecker, #okular, mart Cc: aacid

[okular] [Bug 315552] Allow save annotations directly to original pdf file

https://bugs.kde.org/show_bug.cgi?id=315552 --- Comment #17 from Christoph Feck --- Bug 151614? -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

https://bugs.kde.org/show_bug.cgi?id=384185 --- Comment #2 from Oliver Sander --- Can you reproduce it? -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 384185] Markdown backend does not reload automatically if the file has changed

https://bugs.kde.org/show_bug.cgi?id=384185 Albert Astals Cid changed: What|Removed |Added Severity|wishlist|normal CC|

[okular] [Bug 384185] New: Markdown backend does not reload automatically if the file has changed

https://bugs.kde.org/show_bug.cgi?id=384185 Bug ID: 384185 Summary: Markdown backend does not reload automatically if the file has changed Product: okular Version: 1.3.70 Platform: Other OS: Linux

[okular] [Bug 288042] Option to reset forms (PDF)

https://bugs.kde.org/show_bug.cgi?id=288042 Gilbert Assaf changed: What|Removed |Added CC||gas...@gmx.de --- Comment #4

Re: Review Request 129893: Implement continuous search

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129893/ --- (Updated Aug. 30, 2017, 2:47 p.m.) Review request for Okular, KDE

D7595: Skip reload when another reload is already in progress

sander added a comment. To be honest, I liked your first patch better. Granted, that definition of reloadLock is elegant, but you need quite a bit of C++ experience to see its beauty. People without that will be scared. But it is really Albert who decides. REPOSITORY R223 Okular

[okular] [Bug 288042] Option to reset forms (PDF)

https://bugs.kde.org/show_bug.cgi?id=288042 francisco navarro morales changed: What|Removed |Added CC|

D7595: Skip reload when another reload is already in progress

rkflx updated this revision to Diff 18960. rkflx edited the summary of this revision. rkflx added a comment. Thanks Oliver, I like compromises. You inspired me to try another way: Out with the `unique_lock`, in with the `unique_ptr`. This way no custom RAII wrapper is needed. OTOH, I'm

D7595: Skip reload when another reload is already in progress

sander added a comment. From merely looking at the patches, I like this one better than Albert's. In Albert's patch, the fact that you have to set m_areWeReloading at every exit of the method slotDoFileDirty does feel like breakage waiting to happen. On the other hand, Albert's

D7594: Update to synctex 1.19

rkflx added a reviewer: Kile. rkflx added a subscriber: mludwig. rkflx added a comment. @mludwig As Kile is also providing synctex functionality, maybe you are interested in looking at this patch, too. In my rather simple tests Kile worked fine, but you might be more familiar how it is

D7495: Do not start reloading again if we're reloading

rkflx added a comment. Yay for reviews finding problems before users do \o/ > majorly unchanged for years, and if someone breaks it, well it'll break and we'll fix it. If we can choose between a good and an improved solution, I'd say we should always pick the latter. Maybe I should

D7595: Skip reload when another reload is already in progress

rkflx added a comment. I guess someone else should judge which is easier to read considering the full picture (I got confused by your `areWeReloading` naming, actually). I admit someone not familiar with `std::mutex` semantics would need to read the comment, but understanding a custom RAII

[okular] [Bug 382011] SyncTeX 2017 upgrade

https://bugs.kde.org/show_bug.cgi?id=382011 Henrik Fehlauer changed: What|Removed |Added CC||rk...@lab12.net --- Comment

D7594: Update to synctex 1.19

rkflx added a comment. Only used bugzilla's quicksearch which omits NEEDSINFO bugs, so I missed this (sorry). There doesn't seem do be any new information though. I'll add a link to this review. When implementing the patch, I had to decide between the version in the texlive svn and