[okular] [Bug 383651] Custom/image stamp annotations are not saved into the PDF file in a way that can be printed or that other readers can see

[Tobias Deiminger]

https://bugs.kde.org/show_bug.cgi?id=383651

Tobias Deiminger  changed:

   What|Removed |Added

 CC||haxti...@posteo.de

--- Comment #6 from Tobias Deiminger  ---
Just had a look into it, this is what I found. Dependent on users choice,
Okular sets the annotation dicts /Name entry to standard names ("Approved",
"Confidential", ... see PDF 32000-1:2008, chapter 12.5.6.12 Rubber Stamp
Annotations, Table 181), but also to non standard names ("okular", "kde",
). Conforming readers implement a representation for
the standard names (may look a bit different as in Okular, but at least
something reasonable is shown). But of course non standard names like "okular",
"kde",  are not understood by other readers. A portable way to
have such custom stamps would be to add an /AP entry with the full icon
representation into the PDF. Unfortunately, Poppler can't generate appearance
streams for stamps yet. Note that Poppler #23108 is a bit different, it is
about hardcoded default appearance streams, not about generating ones for your
custom image.

There's another special thing about stamps. Contrary to most other annotation
types, stamps are not rendered by Poppler, but by Okular itself. Okular first
looks for /Name in ui/data/stamps.svg (contains "approved", "confidential",
"departmental"...). If there's no match, it uses KIconLoader lookup an icon.
Not rendering with Poppler probably introduces special handling when printing,
haven't checked that yet.

I guess an ideal solution for this bug will require aid from Poppler side
(maybe a new API to store raster and vector graphics as appearance stream into
the PDF, and some predefined appearance streams for the standard names so that
stamps without /AP can be rendered).

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10249: Option to exit after printing

[Dileep Sankhla]

dileepsankhla updated this revision to Diff 26550.
dileepsankhla added a comment.


  Updating https://phabricator.kde.org/D10249: Option to exit after printing
  
  local variable to slotPrint function

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10249?vs=26547=26550

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10249

AFFECTED FILES
  autotests/mainshelltest.cpp
  part.cpp
  part.h
  shell/main.cpp
  shell/shell.cpp
  shell/shellutils.cpp
  shell/shellutils.h

To: dileepsankhla, aacid, #okular, ngraham
Cc: ngraham, aacid, #okular, michaelweghorn

D10249: Option to exit after printing

[Albert Astals Cid]

aacid added a comment.


  That's even worse.
  
  I'll give you the answer myself.
  
  Why do you need to have that variable be global at all? It is used *exactly* 
in one function.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10249

To: dileepsankhla, aacid, #okular, ngraham
Cc: ngraham, aacid, #okular, michaelweghorn

D10249: Option to exit after printing

[Dileep Sankhla]

dileepsankhla updated this revision to Diff 26547.
dileepsankhla added a comment.


  Updating https://phabricator.kde.org/D10249: Option to exit after printing
  
  I was trying to get rid of extern keyword while declaring "isError" inside 
the namespace of the header file. Hence I declared it as a class member, my bad.
  I have declared it inside the source file "part.cpp" in the namespace 
definition.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10249?vs=26453=26547

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10249

AFFECTED FILES
  autotests/mainshelltest.cpp
  part.cpp
  part.h
  shell/main.cpp
  shell/shell.cpp
  shell/shellutils.cpp
  shell/shellutils.h

To: dileepsankhla, aacid, #okular, ngraham
Cc: ngraham, aacid, #okular, michaelweghorn

D10313: Option to exit after printing

[Dileep Sankhla]

dileepsankhla created this revision.
dileepsankhla added a reviewer: aacid.
dileepsankhla added a project: Okular.
dileepsankhla requested review of this revision.

REVISION SUMMARY
  When running okular with the parameter --print to directly open the print 
mode, it doesn't exit after acknowledging the print dialog. Hence adding 
--print_and_exit option exits okular
  after ackowledging the print dialog and thus useful for command line batch 
processing or a Dolphin service as the issue suggests.
  
  BUG: 318998
  
  Enter a commit message. # # Changes: # # part.cpp # part.h Option to 
exit after printing
  

  
  Option to exit after printing

TEST PLAN
  1. open a file in Okular using the parameter --print. It will open Okular in 
print mode with the print dialog
  2. Either print the file or cancel the print dialog
  3. You will find that Okular stays open
  4. Now using this patch, see for available options with the --help parameter. 
You will find --print_and_exit option
  5. Now open a file in Okular using the parameter --print_and_exit. It will 
open Okular in print mode with the print dialog
  6. Either print the file or cancel the print dialog
  7. You will find that Okular closes after acknowledging the dialog

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10313

AFFECTED FILES
  autotests/mainshelltest.cpp
  part.cpp
  part.h
  shell/main.cpp
  shell/shell.cpp
  shell/shellutils.cpp
  shell/shellutils.h

To: dileepsankhla, aacid
Cc: aacid, ngraham, #okular, michaelweghorn

D10249: Option to exit after printing

[Albert Astals Cid]

aacid added a comment.


  Why is "isError" a class member variable?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10249

To: dileepsankhla, aacid, #okular, ngraham
Cc: ngraham, aacid, #okular, michaelweghorn

[okular] [Bug 207748] LTR languages searches text backwards

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=207748

--- Comment #18 from Nate Graham  ---
Fahad submitted a patch for this, which I've migrated to Phabricator:

https://phabricator.kde.org/D10298

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10298: Fix searching in RTL PDFs

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10298

To: ngraham, #okular
Cc: ltoscano, michaelweghorn, ngraham, aacid

D10298: Fix searching in RTL PDFs

[Luigi Toscano]

ltoscano resigned from this revision.
ltoscano added a comment.


  Please change "migrated from..." with the proper content from the old 
reviewboard patch, and resubmit it using the original author.
  The note about "this was in reviewboard" should not be in the final commit 
message, but the original content should be.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10298

To: ngraham, #okular
Cc: ltoscano, michaelweghorn, ngraham, aacid

D10298: Fix searching in RTL PDFs

[Nathaniel Graham]

ngraham updated this revision to Diff 26510.
ngraham added a comment.


  Update author

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10298?vs=26509=26510

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10298

AFFECTED FILES
  ui/searchlineedit.cpp

To: ngraham, #okular
Cc: ltoscano, michaelweghorn, ngraham, aacid

Re: Review Request 125442: [okular] fix Arabic & Hebrew search

[Nathaniel Graham]

> On July 21, 2016, 9:19 a.m., Olivier Churlaud wrote:
> > ui/searchlineedit.cpp
> > Lines 219 (patched)
> > 
> >
> > Before submitting patches, check with a `git diff` that you don't add 
> > whitespaces...

I've migrated this patch to Phabricator and cleaned up the whitespace issues.

https://phabricator.kde.org/D10298


- Nathaniel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125442/#review97696
---


On Sept. 29, 2015, 5:42 a.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125442/
> ---
> 
> (Updated Sept. 29, 2015, 5:42 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 207748
> http://bugs.kde.org/show_bug.cgi?id=207748
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Since arabic search does not work properly in all but pdf  backends, this is 
> a quick attempt to fix this problem. I assumed that text in okular document 
> is in the logical order[ it is a bug by itself]. So by mirroring the search 
> text, the search function works again. 
> 
> The limitation:
> - you can not search arabic and english text together.
> 
> Future work:
> we need to check that text generated by poppler is placed in Visual order, so 
> when we copy it and paste it in text editor is still readable.
> 
> 
> Diffs
> -
> 
>   ui/searchlineedit.cpp c736759 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/125442/diff/1/
> 
> 
> Testing
> ---
> 
> Tested in Arabic & Hebrew pdfs and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

D10298: Fix searching in RTL PDFs

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: Okular.
Restricted Application added a project: Okular.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 207748
  
  Migrated this patch from https://git.reviewboard.kde.org/r/125442/ since it 
had whitespace errors and the submitter disappeared.

TEST PLAN
  - Okular compiles and all tests pass (except for parttest, which was already 
failing in master)
  - Don't have any RTL PDFs or the ability to read or write in any RTL 
languages, so unable to test the functionality. But on the reviewboard page, 
folks said it worked, and the diff is the same.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10298

AFFECTED FILES
  ui/searchlineedit.cpp

To: ngraham, #okular
Cc: michaelweghorn, ngraham, aacid

[okular] [Bug 207748] LTR languages searches text backwards

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=207748

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 207748] LTR languages searches text backwards

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=207748

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.