[okular] [Bug 390108] New: wish: right click menu in tabbed interface version for closing other tabs

2018-02-08 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=390108

Bug ID: 390108
   Summary: wish: right click menu in tabbed interface version for
closing other tabs
   Product: okular
   Version: 1.3.1
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: m.w...@web.de
  Target Milestone: ---

I am using the tabbed interface of okular. What I am missing is a right klick
option to close (and occasionally reopen closed tabs), like in browsers.
Specifically I would like to see options to close this tab, close tabs right
and left of the tab and close all the other tabs. Would be great to see this
feature.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-08 Thread Michael Weghorn
https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #19 from Michael Weghorn  ---
(In reply to Attila from comment #15)
> [...]
> Here the error_log, print file and PPD as requested. These files are all
> from the Cups server.

Thanks. I still don't see anything obvious. The file generated by Okular on the
one host is identical to the one on the CUPS server host (which is expected).

For simplification, I suggest to use the following names for the two hosts
involved for now:
* Host A: Computer where Okular is running
* Host B: Computer where the CUPS server is running that the print jobs are
sent to

Can you try the following:

1) print the PDF file from another application on host A, e.g. from Evince and
from the command line using the following command:

lp -d HPM880 -o PageSize=A4 

2) print the PDF file directly on host B using the command line:

lp -d HPM880 -o PageSize=A4 

3) print the file generated by Okular directly via the command line on host B
( is https://bugs.kde.org/attachment.cgi?id=110406):

lp -d HPM880 -o PageSize=A4 

4) print the PDF file from Okular on host A with "Force rasterisation" enabled
in the print dialog under "Options" -> "PDF Options"

5) set up a dummy printer on host B that saves the file that would normally be
sent to the printer into a file instead. On host B, do:

* enable file devices by setting the directive "FileDevice Yes" in
/etc/cups/cups-files.conf
* restart CUPS
* set up the printer with the same PPD file as the printer used previously by
running this command: "sudo lpadmin -p tofile-test -v file:/tmp/tofile-test -P
/etc/cups/ppd/HPM880.ppd"
* make the printer available to the client as well

And then "print" to this printer. A file should be created under
/tmp/tofile-test on host B. Can you attach this one here? (Depending on the
system, you might have to use the option "-v file:$HOME/tofile-test" instead of
the "-v file:/tmp/tofile-test", as it differs a bit where CUPS is allowed to
create files).


Is the result for 1-4 the same as when printing from Okular as before or is it
different (e.g. correct printout on full A4 paper)?

By the way, how are the printers set up on host B made available to host A? Are
they explicitly set up there or are they advertised by host B and
auto-discovered on host A? (An option "cups-browsed" can be seen in the
error_log, which sounds like this might be a queue auto-discovered by
cups-browsed, but I'm not sure.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 388288] some thumbnail of pdf not shown in dolphin, some are shown

2018-02-08 Thread kts
https://bugs.kde.org/show_bug.cgi?id=388288

--- Comment #11 from kts  ---
The attachment provided showed thumbnail with latest KDE. But some other PDFs
did not. I want to email the attachment to someone responsible because it's
above 4MB. Who in this list should I sent it to?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10249: Option to exit after printing

2018-02-08 Thread Dileep Sankhla
dileepsankhla updated this revision to Diff 26778.
dileepsankhla added a comment.


  Updating https://phabricator.kde.org/D10249: Option to exit after printing
  renamed isError variable to success and changed the option with 
-print-and-exit.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10249?vs=26608=26778

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10249

AFFECTED FILES
  autotests/mainshelltest.cpp
  part.cpp
  part.h
  shell/main.cpp
  shell/shell.cpp
  shell/shellutils.cpp
  shell/shellutils.h

To: dileepsankhla, aacid, #okular, ngraham
Cc: ltoscano, ngraham, aacid, #okular, michaelweghorn


[okular] [Bug 389668] Saving a pdf switches from thumbnail view in sidebar to contents view

2018-02-08 Thread Michael D
https://bugs.kde.org/show_bug.cgi?id=389668

--- Comment #7 from Michael D  ---
If I extract pages (e.g. using python-pyPdf) the properties of the original pdf
won't (necessarily) be preserved in the resulting extraction, so I don't think
it will be helpful. I'll try it out using a couple of methods and report back
later.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10050: [PATCH 4/4] Add autotest for AFSimple_Calculate script

2018-02-08 Thread Andre Heinecke
aheinecke updated this revision to Diff 26763.
aheinecke added a comment.


  Updated with a multiplication by zero test.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10050?vs=25818=26763

REVISION DETAIL
  https://phabricator.kde.org/D10050

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/calculatetexttest.cpp
  autotests/data/simpleCalculate.pdf

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham


D10049: [PATCH 3/4] Add initial support for built-in javascript functs

2018-02-08 Thread Andre Heinecke
aheinecke marked an inline comment as done.
aheinecke added inline comments.

INLINE COMMENTS

> aacid wrote in builtin.js:35
> why set ret to 1 if ret is 0? is this because you want to initialize? then 
> you should test i is 0 otherwise 3*0*4 will be 4?

Indeed and nice catch :-). For PRD I wanted to set the start value to 1 and not 
0. I made this more explicit now.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10049

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham


D10049: [PATCH 3/4] Add initial support for built-in javascript functs

2018-02-08 Thread Andre Heinecke
aheinecke updated this revision to Diff 26762.
aheinecke added a comment.


  Fix first grade math error. *blushes*

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10049?vs=25877=26762

REVISION DETAIL
  https://phabricator.kde.org/D10049

AFFECTED FILES
  CMakeLists.txt
  core/script/builtin.js
  core/script/builtin.qrc
  core/scripter.cpp

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham


D10048: [PATCH 2/4] Add refresh widgets if underlying field changes

2018-02-08 Thread Andre Heinecke
aheinecke added a comment.


  In https://phabricator.kde.org/D10048#202922, @aheinecke wrote:
  
  > Thanks. Still with current master this does not work for me as in the 
video. When I zoom in and out it works but not automatically through the 
refresh-pixmaps in the field setter. With current master its: F5698356: 
refresh-pixmaps.gif  Maybe that one is 
optimized out somehow? I'll try to fix this with this change, too.
  
  
  The reason for this was a very recent regression as noted in: 
https://phabricator.kde.org/R223:2d8b2c7e95927db1633ecb871ed4100c3e7e3833#inline-968
  
  With the fix from that comment both my sample and your sample work nicely.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10048

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham


[okular] [Bug 389947] touchpad scrolling: Okular jumps several lines down first when scrolling after the cursor moves out and back again

2018-02-08 Thread Michael Weghorn
https://bugs.kde.org/show_bug.cgi?id=389947

Michael Weghorn  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 CC||m.wegh...@posteo.de

--- Comment #4 from Michael Weghorn  ---
Thanks for the update.
Since you mention it's an upstream Qt issue, I'm closing this Okular-specific
bug report.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10048: [PATCH 2/4] Add refresh widgets if underlying field changes

2018-02-08 Thread Andre Heinecke
aheinecke updated this revision to Diff 26761.
aheinecke retitled this revision from " [PATCH 2/4] Communicate calculate text 
change to formwidgets" to "[PATCH 2/4] Add refresh widgets if underlying field 
changes".
aheinecke edited the summary of this revision.
aheinecke added a comment.


  Proper refreshPixmap handling and a new "refreshWidget" signal instead of a 
very specialized signal name. Value is updated from poppler field and not 
carried by the signal.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10048?vs=25875=26761

REVISION DETAIL
  https://phabricator.kde.org/D10048

AFFECTED FILES
  core/document.cpp
  core/document.h
  core/script/kjs_field.cpp
  ui/formwidgets.cpp
  ui/formwidgets.h

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham


D10073: [PATCH 1/4] Add JavaScript Event Object handling

2018-02-08 Thread Andre Heinecke
aheinecke added inline comments.

INLINE COMMENTS

> aacid wrote in kjs_field.cpp:222
> You really want ot use the verison with the page so refreshPixmaps happens

Indeed I want that now. :-)

This required an ugly const cast though as the kjs_field API works with a non 
const Page pointer. Maybe that could / should be changed?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10073

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham


D10073: [PATCH 1/4] Add JavaScript Event Object handling

2018-02-08 Thread Andre Heinecke
aheinecke updated this revision to Diff 26760.
aheinecke marked an inline comment as done.
aheinecke added a comment.


  Carried the source / target page through to have it available when the 
kjs_fields are created.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10073?vs=25874=26760

REVISION DETAIL
  https://phabricator.kde.org/D10073

AFFECTED FILES
  CMakeLists.txt
  core/script/event.cpp
  core/script/event_p.h
  core/script/executor_kjs.cpp
  core/script/executor_kjs_p.h
  core/script/kjs_event.cpp
  core/script/kjs_event_p.h
  core/script/kjs_field.cpp
  core/scripter.cpp
  core/scripter.h

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham


D10048: [PATCH 2/4] Communicate calculate text change to formwidgets

2018-02-08 Thread Andre Heinecke
aheinecke added a comment.


  In https://phabricator.kde.org/D10048#202711, @aacid wrote:
  
  > In https://phabricator.kde.org/D10048#202336, @aheinecke wrote:
  >
  > > Could you attach a sample PDF where this is working?
  >
  >
  > https://www.revenue.wi.gov/dorforms/2016-Form1f.pdf
  
  
  Thanks. Still with current master this does not work for me as in the video. 
When I zoom in and out it works but not automatically through the 
refresh-pixmaps in the field setter. With current master its: F5698356: 
refresh-pixmaps.gif  Maybe that one is 
optimized out somehow? I'll try to fix this with this change, too.
  
  > Well you need the refresh pixmaps for sure, because at least right now when 
hiding the forms the image of the pdf has the wrong value, so that needs fixing.
  >  As for the difference with the pdf i linked, i think i see the difference, 
the ones you linked the all the widgets are  so you need to update the "result" 
widgets values.
  
  Ah, I understand it now better -> refresh pixmaps to update the "rendered" / 
result field values.
  
  > Could you explore getting that value from the core of poppler and not 
setting the value in the ui manually? I mean if you force a pixmap refresh (by 
zooming in/out) the values of the rendered "image" update correctly so 
somewhere something knows the value changed. I'd prefer using that over going 
manually and setting the value "again"
  
  Yes indeed. I think we need something similar to refreshPixmaps for the input 
widgets too, some kind of "refreshWidgets" that then updates the widgets with 
the values from the poppler fields.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10048

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham


[okular] [Bug 207748] LTR languages searches text backwards

2018-02-08 Thread Fahad Al-Saidi
https://bugs.kde.org/show_bug.cgi?id=207748

--- Comment #19 from Fahad Al-Saidi  ---
I think the problem form QT interface for poppler. please see this bug 

https://bugs.freedesktop.org/show_bug.cgi?id=105015

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-08 Thread Attila
https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #18 from Attila  ---
Created attachment 110426
  --> https://bugs.kde.org/attachment.cgi?id=110426=edit
File generated by Okular from Cups server

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-08 Thread Attila
https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #17 from Attila  ---
Created attachment 110425
  --> https://bugs.kde.org/attachment.cgi?id=110425=edit
PPD file HPM880 from Cups server

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-08 Thread Attila
https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #16 from Attila  ---
Created attachment 110424
  --> https://bugs.kde.org/attachment.cgi?id=110424=edit
error_log from cups server

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

2018-02-08 Thread Attila
https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #15 from Attila  ---
(In reply to Michael Weghorn from comment #14)
> Thanks for the additional information.
> 
> (In reply to Attila from comment #11)
> > - The printer is served by a Cups server. Is that the reason, why you said
> > no "real" CUPS filters are processed?
> 
> I suppose that the information that the printers are served by a CUPS server
> on another machine is relevant for the problem. (The files I saw so far from
> the local machine look "reasonable" to me at first sight.)
> 
> Also, getting the CUPS error_log (with debugging enabled) and the PPD of the
> printer from the machine where the CUPS server is running will probably be
> of help to further analyse the issue. What kind of operating system is that
> machine running and what version of CUPS is in use there?

Here the error_log, print file and PPD as requested. These files are all from
the Cups server.

-- 
You are receiving this mail because:
You are the assignee for the bug.