[okular] [Bug 389953] okular ignores paper size when printing

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #34 from Michael Weghorn  ---
(In reply to Attila from comment #33)
> 
> Have you got an idea where to report the bug, if we close it here?
> What product or component?

I'm not sure. The last information sounds like it might be related to
cups-browsed, which is maintained as part of "cups-filters". The GitHub page
is: https://github.com/OpenPrinting/cups-filters
I'm not sure though. However, I think we can leave this bug open here until
there's no more ideas on what to look at.

In order to find out whether it's a cups-browsed problem, the following might
help:


> > * Does the problem also happen when you print as another user?
> 
> Yes, it does.

1) Do you have another computer in addition to host a on which you could try?

> > $ sudo grep -r orientation-requested /var/
> 
> Here the result:
> 
> ...
> /var/cache/cups/cups-browsed-options-HP9500DN:orientation-requested-
> default=no-value
> /var/cache/cups/cups-browsed-options-EPSON7900:orientation-requested-
> default=no-value
> /var/cache/cups/cups-browsed-options-HPM880:orientation-requested-default=no-
> value
> ...
> 
> Interesting again, that the file
> /var/cache/cups/cups-browsed-options-HPM880Test (my Test printer) doesn't
> contain "orientation-requested".
> 
> When I print to the printer HPM880 the file
> /var/cache/cups/cups-browsed-options-HPM880 is being written again, so it
> has no effect to delete the line "orientation-requested-default=no-value".
> It was my first thought to delete the line
> "orientation-requested-default=no-value". This information must come from
> somewhere else.

2) Can you try to delete the file again after stopping cups-browsed?

i.e.
$ sudo systemctl stop cups-browsed.service
$ sudo rm /var/cache/cups/cups-browsed-options-tofile-hp 
$ sudo systemctl start cups-browsed.service

And then print again.

3) Set up the printer without using cups-browsed:

* temporarily stop cups-browsed: 'sudo systemctl stop cups-browsed.service'
* verify the printer is no longer shown when running 'lpstat -v'
* set up the printer like this: 'sudo lpadmin -p HPM880 -v
ipp:///printers/HPM880 -E'
  (where '' is the hostname or IP address of host B)
* print to the printer
  * from Okular (and check result)
  * using 'echo hello | lp -d HPM880' and attaching the error_log from host A
here
* ('sudo lpadmin -x HPM880' and 'sudo cupsenable cups-browsed' will bring back
the original setup.)

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Can I work on an issue that is the basis of a GSoC project?

[Dileep Sankhla]

Thank you so much. Do you also mean I can send the proposal to the same
project while working on the same issue during this pre-application
duration and may also have sent a patch for the review?



‌

On Wed, Feb 14, 2018 at 2:42 AM, Oliver Sander 
wrote:

> Hi Dileep,
>
> > Can I work on the issue beforehand?
>
> I'd say: Sure you can!  If you are too quick and you solve the gsoc
> project way
> before gsoc is over, then there are plenty of further interesting
> annotation-related
> things to work on.  So start right away if you feel like it.
>
> Best,
> Oliver
>
> >
> > Thanks and Regards
> > Dileep
> >
> > ‌
>
>

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 59 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/59/
 Project:
Applications okular stable-kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 14 Feb 2018 00:55:44 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.parttest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report88%
(22/25)48%
(129/271)48%
(129/271)31%
(12048/39224)19%
(5271/27409)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(5/5)100%
(5/5)47%
(866/1834)26%
(356/1361)autotests93%
(13/14)93%
(13/14)70%
(1607/2309)32%
(940/2963)conf6%
(1/17)6%
(1/17)7%
(53/805)0%
(1/272)conf.autotests100%
(1/1)100%
(1/1)100%
(17/17)50%
(7/14)core81%
(39/48)81%
(39/48)46%
(4282/9357)32%
(2000/6303)core.script0%
(0/9)0%
(0/9)0%
(0/494)0%
(0/230)generators.comicbook29%
(2/7)29%
(2/7)3%
(10/397)0%
(0/430)generators.dvi2%
(1/46)2%
(1/46)0%
(10/3571)0%
(1/2423)generators.epub100%
(3/3)100%
(3/3)54%
(180/334)43%
(78/183)generators.fax17%
(1/6)17%
(1/6)2%
(7/432)0%
(0/585)generators.fictionbook40%
(2/5)40%
(2/5)1%
(7/529)0%
(0/454)generators.kimgio100%
(1/1)100%
(1/1)60%
(42/70)28%
(5/18)generators.kimgio.tests100%
(1/1)100%
(1/1)100%
(49/49)46%
(24/52)generators.mobipocket40%
(2/5)40%
(2/5)5%
(6/113)0%
(0/120)generators.ooo18%
(2/11)18%
(2/11)1%
(7/1123)0%
(0/736)generators.plucker100%
(1/1)100%
(1/1)4%
(4/98)0%
(0/36)generators.plucker.unpluck0%
(0/6)0%
(0/6)0%
(0/1652)0%
(0/876)generators.poppler60%
(3/5)60%
(3/5)48%
(651/1356)37%
  

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/35/
 Project:
Applications okular kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 14 Feb 2018 00:41:57 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.mainshelltestFailed: TestSuite.parttest

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 58 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/58/
 Project:
Applications okular stable-kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 14 Feb 2018 00:41:44 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.parttest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report88%
(22/25)48%
(129/271)48%
(129/271)31%
(12056/39224)19%
(5274/27409)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(5/5)100%
(5/5)47%
(866/1834)26%
(356/1361)autotests93%
(13/14)93%
(13/14)70%
(1607/2309)32%
(940/2963)conf6%
(1/17)6%
(1/17)7%
(53/805)0%
(1/272)conf.autotests100%
(1/1)100%
(1/1)100%
(17/17)50%
(7/14)core81%
(39/48)81%
(39/48)46%
(4282/9357)32%
(2000/6303)core.script0%
(0/9)0%
(0/9)0%
(0/494)0%
(0/230)generators.comicbook29%
(2/7)29%
(2/7)3%
(10/397)0%
(0/430)generators.dvi2%
(1/46)2%
(1/46)0%
(10/3571)0%
(1/2423)generators.epub100%
(3/3)100%
(3/3)54%
(180/334)43%
(78/183)generators.fax17%
(1/6)17%
(1/6)2%
(7/432)0%
(0/585)generators.fictionbook40%
(2/5)40%
(2/5)1%
(7/529)0%
(0/454)generators.kimgio100%
(1/1)100%
(1/1)60%
(42/70)28%
(5/18)generators.kimgio.tests100%
(1/1)100%
(1/1)100%
(49/49)46%
(24/52)generators.mobipocket40%
(2/5)40%
(2/5)5%
(6/113)0%
(0/120)generators.ooo18%
(2/11)18%
(2/11)1%
(7/1123)0%
(0/736)generators.plucker100%
(1/1)100%
(1/1)4%
(4/98)0%
(0/36)generators.plucker.unpluck0%
(0/6)0%
(0/6)0%
(0/1652)0%
(0/876)generators.poppler60%
(3/5)60%
(3/5)48%
(651/1356)37%
  

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 28 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/28/
 Project:
Applications okular stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Wed, 14 Feb 2018 00:41:44 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 15 test(s)

[okular] [Bug 390355] crash when open Arabic xps file

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=390355

Albert Astals Cid  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://commits.kde.org/oku
   ||lar/42d4710198a76650ff2e117
   ||b5b1a966a3685f376

--- Comment #3 from Albert Astals Cid  ---
Git commit 42d4710198a76650ff2e117b5b1a966a3685f376 by Albert Astals Cid.
Committed on 14/02/2018 at 00:40.
Pushed by aacid into branch 'Applications/17.12'.

XPS: Fix crash opening some files

Yet another QUrl porting mistake, i think this time is the correct one,
at least i can open all the 6 xps files i have

M  +1-1generators/xps/generator_xps.cpp

https://commits.kde.org/okular/42d4710198a76650ff2e117b5b1a966a3685f376

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390293] Improve display of stacked annotations of same color to show which one is on top

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=390293

--- Comment #5 from Henrik Fehlauer  ---
Another idea: Add outline on mouse hover, so the differing shapes make it clear
which item is meant.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390293] Improve display of stacked annotations of same color to show which one is on top

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=390293

Henrik Fehlauer  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |---
 Ever confirmed|0   |1
Summary|PDF save does not save the  |Improve display of stacked
   |content of all sticky   |annotations of same color
   |notes. Some are blank notes |to show which one is on top
   |when I open in other pdf|
   |viewers.|
 Status|RESOLVED|REOPENED

--- Comment #4 from Henrik Fehlauer  ---
Well, the confusion is cleared up, but I'm pretty sure other users might run
into this too. It's a usability problem:

On double-clicking, Okular will open the top-most annotation (which is fine).
However, if you put a popup note (defaulting to yellow) on top of a text
hightlight annotation (defaulting to yellow) or the other way round, you cannot
really see which one is on top.

I would suggest two possible solutions:
- Change colour of popup-note slightly.
- Add outline with different colour to popup note, so in case you highlight
over it you will see that the popup note is below and cannot react to clicks (←
my preferred solution).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 366276] escape key should close full screen view

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=366276

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390293] PDF save does not save the content of all sticky notes. Some are blank notes when I open in other pdf viewers.

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=390293

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|UNCONFIRMED |RESOLVED

--- Comment #3 from Nate Graham  ---
Thanks for confirming!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390293] PDF save does not save the content of all sticky notes. Some are blank notes when I open in other pdf viewers.

[Ryan Kozlowski]

https://bugs.kde.org/show_bug.cgi?id=390293

--- Comment #2 from Ryan Kozlowski  ---
Ok. I was saving with "Save As". The issue is that some of my sticky notes were
overlapping highlighted text, and double-clicking on the sticky notes was
apparently understood as double-clicking on the highlighted text instead, for
which I left no notes. When I moved the stickies, problem was resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 368758] Grayscale option ignored when generating print data for PDF document

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=368758

Michael Weghorn  changed:

   What|Removed |Added

 CC||david.cortes.rivera@gmail.c
   ||om

--- Comment #12 from Michael Weghorn  ---
*** Bug 390409 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390409] Okular fails to print in grayscale

[Michael Weghorn]

https://bugs.kde.org/show_bug.cgi?id=390409

Michael Weghorn  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 CC||m.wegh...@posteo.de
 Status|UNCONFIRMED |RESOLVED

--- Comment #1 from Michael Weghorn  ---
Bug 368758 describes the same issue and how things will change with the
upcoming Qt 5.11 print dialog.

*** This bug has been marked as a duplicate of bug 368758 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390409] New: Okular fails to print in grayscale

[David]

https://bugs.kde.org/show_bug.cgi?id=390409

Bug ID: 390409
   Summary: Okular fails to print in grayscale
   Product: okular
   Version: 1.2.70
  Platform: Debian unstable
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: printing
  Assignee: okular-devel@kde.org
  Reporter: david.cortes.riv...@gmail.com
  Target Milestone: ---

If I print a pdf file with Okular in grayscale (File -> Print -> Options ->
Options -> Color Mode -> Grayscale), the file is printed in color. Other
applications respect the grayscale setting in the printing dialog when printing
the same file.

The bug happens with Okular 1.2.3. Other printing settings within Okular seem
to work though.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390135] PDF render is slow

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=390135

--- Comment #5 from Henrik Fehlauer  ---
Thanks. I tried those exact versions, nothing too unsual so far (Poppler is not
the fastest for image-heavy pages – the blurriness you see might just be an
upscaled pixmap shown from the render cache while rendering the actual page).

Nevertheless, this might be a regression either in Poppler (general regression)
or in Okular (HiDPI regression, or by using some of the new features enabled by
a newer Poppler).

Here is what you could try next:

0. Specify a page, zoom level and what you were doing exactly, so we are
talking about the same thing.

1. Figure out what versions of Okular and Poppler were working "extremely fast"
before you upgraded.

2. Test in non-HiDPI mode: In "kcmshell5 kcm_kscreen", set scaling to 1.0 and
relogin.

3. Open https://phabricator.kde.org/D8379#164630, grep for "QT_SCALE_FACTOR",
watch the accompanying video and let us know if you are experiencing a similar
issue (rerendering instead of using the tile cache for HiDPI).

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Can I work on an issue that is the basis of a GSoC project?

[Oliver Sander]

Hi Dileep,

> Can I work on the issue beforehand?

I'd say: Sure you can!  If you are too quick and you solve the gsoc project way
before gsoc is over, then there are plenty of further interesting 
annotation-related
things to work on.  So start right away if you feel like it.

Best,
Oliver

> 
> Thanks and Regards
> Dileep
> 
> ‌



smime.p7s
Description: S/MIME Cryptographic Signature

[okular] [Bug 390293] PDF save does not save the content of all sticky notes. Some are blank notes when I open in other pdf viewers.

[Henrik Fehlauer]

https://bugs.kde.org/show_bug.cgi?id=390293

Henrik Fehlauer  changed:

   What|Removed |Added

 CC||rk...@lab12.net

--- Comment #1 from Henrik Fehlauer  ---
Okular versions before 1.3 (KDE Applications 17.12) have a slight twist wrt. to
saving: If you just close the PDF after changing an annotation, the changes
will only be visible in Okular. To be able to see those changes in other
viewers, you have to use "Save As". (Starting with version 1.3, Okular only
supports "Save" like a normal text editor and loses the confusing internal
auto-saving.)

Please test whether either by always using "Save As" or by just upgrading to
Okular 1.3 your problems go away. If not, I'm afraid you'd have to provide more
detailed steps to reproduce and perhaps upload some example documents.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 288042] Option to reset forms (PDF)

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=288042

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #6 from Oliver Sander  ---
Hi Ahmad, thanks for posting these patches.  Could you please get an account at

   https://phabricator.kde.org/

and post the patches there?  They are much easier to review that way.

Are your patches related to the patches posted by Gilbert Assaf in Comment 4?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Can I work on an issue that is the basis of a GSoC project?

[Dileep Sankhla]

Hello Okular Developers,

I have been contributing to Okular for the last two weeks and this
application product and its key interesting issues intrigue me the most. I
love Okular from the very beginning of using KDE desktop on my Arch Linux
and realizing the missing key features made me selecting it as my
application of interest.

I was looking at the GSoC '18 Okular project ideas and found one of them on
which I'm willing to work but it also contains a link to the bug report
 and I'm thinking about
working on this bug before the application period starts. I think it will
also help me a lot in understanding the project idea.

Can I work on the issue beforehand?

Thanks and Regards
Dileep

‌

[okular] [Bug 387834] Okular does not display replies to "sticky notes"

[Dileep Sankhla]

https://bugs.kde.org/show_bug.cgi?id=387834

Dileep Sankhla  changed:

   What|Removed |Added

 CC||sankhla.dilee...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10249: Option to exit after printing

[Dileep Sankhla]

dileepsankhla updated this revision to Diff 27086.
dileepsankhla added a comment.


  Updating D10249 : Option to exit after 
printing
  Tried my best to edit the data driven tests by adding appropriate data to the 
table using QTest::newRow function.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10249?vs=26778=27086

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10249

AFFECTED FILES
  autotests/mainshelltest.cpp
  part.cpp
  part.h
  shell/main.cpp
  shell/shell.cpp
  shell/shellutils.cpp
  shell/shellutils.h

To: dileepsankhla, aacid, #okular, ngraham
Cc: ltoscano, ngraham, aacid, #okular, michaelweghorn

[okular] [Bug 288042] Option to reset forms (PDF)

[Ahmad Osama]

https://bugs.kde.org/show_bug.cgi?id=288042

Ahmad Osama  changed:

   What|Removed |Added

 CC||ahmad.osama@gmail.com

--- Comment #5 from Ahmad Osama  ---
Created attachment 110619
  --> https://bugs.kde.org/attachment.cgi?id=110619=edit
The attachment contains a zip file with 3 patches containing the changes to 5
files: part.cpp/pageview.cpp/pageview.h/formwidget.cpp/formwidget.h

These changes are done to add a button to Reset pdf forms when clicked.

Changes are to the following files:

* part.cpp: Just changing the text displayed to the user when the document has
forms
* pageview.cpp/pageview.h: add an action to reset forms just like the Show
Form/Hide form (aToggleForm QAction)
* formwidget.cpp/formwidger.h: add a virtual function 'clearWidgetContents()'
to the parent class (FormWidgetIface) that clears the contents of the widget,
then overriding this function in its children to clear the contents differently
in each widget, ex. clearing the FormLineEditClass (that iherits from
QLineEdit) is done by setting text to an empty string ("").

* the clearWidgetContents() is called when the QAction associated with it is
triggered.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 163493] 'Full screen mode' is better in View menu than Settings menu (usability)

[Simone Gaiarin]

https://bugs.kde.org/show_bug.cgi?id=163493

Simone Gaiarin  changed:

   What|Removed |Added

 CC||simg...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 366276] escape key should close full screen view

[Simone Gaiarin]

https://bugs.kde.org/show_bug.cgi?id=366276

Simone Gaiarin  changed:

   What|Removed |Added

 CC||simg...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

[Attila]

https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #33 from Attila  ---
(In reply to Michael Weghorn from comment #30)
> (In reply to Attila from comment #27)
> > Created attachment 110563 [details]
> > error_log for echo hello...
> 
> This one also contains "orientation-requested=0", so the fact that this is
> set is totally independent of Okular and I tend to say that we should close
> this bug here for that reason...

Have you got an idea where to report the bug, if we close it here?
What product or component?

> 
> Two last thoughts:
> 
> * Does the problem also happen when you print as another user?

Yes, it does.

> 
> * Does any of the following commands return any result?
> 
> $ sudo grep -r orientation-requested /etc/

No result here.

> $ sudo grep -r orientation-requested /var/

Here the result:

...
/var/cache/cups/cups-browsed-options-HP9500DN:orientation-requested-default=no-value
/var/cache/cups/cups-browsed-options-EPSON7900:orientation-requested-default=no-value
/var/cache/cups/cups-browsed-options-HPM880:orientation-requested-default=no-value
...

Interesting again, that the file
/var/cache/cups/cups-browsed-options-HPM880Test (my Test printer) doesn't
contain "orientation-requested".

When I print to the printer HPM880 the file
/var/cache/cups/cups-browsed-options-HPM880 is being written again, so it has
no effect to delete the line "orientation-requested-default=no-value". It was
my first thought to delete the line "orientation-requested-default=no-value".
This information must come from somewhere else.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 389953] okular ignores paper size when printing

[Attila]

https://bugs.kde.org/show_bug.cgi?id=389953

--- Comment #32 from Attila  ---
Created attachment 110608
  --> https://bugs.kde.org/attachment.cgi?id=110608=edit
error_log LogLevel debug2

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10455: Add RTL support for search, copy & paste in pdf

[Fahad Al-Saidi]

fahadalsaidi retitled this revision from "add rtl support to textpage" to "Add 
RTL support for search, copy & paste in pdf".
fahadalsaidi edited the summary of this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10455

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: ngraham, michaelweghorn, aacid

D10455: add rtl support to textpage

[Fahad Al-Saidi]

fahadalsaidi updated this revision to Diff 27043.
fahadalsaidi edited the summary of this revision.
fahadalsaidi added a comment.


  add autotest for searching in Arabic

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10455?vs=27038=27043

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10455

AFFECTED FILES
  autotests/data/arabic-search-test.pdf
  autotests/searchtest.cpp
  core/textpage.cpp

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: ngraham, michaelweghorn, aacid

[okular] [Bug 390357] auto tests fails

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=390357

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|WAITINGFORINFO  |INVALID
 Status|NEEDSINFO   |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390357] auto tests fails

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=390357

--- Comment #6 from Fahad Al-Saidi  ---
Ok, I found the problem, I have to set 
Set LD_LIBRARY_PATH 
Set QT_PLUGIN_PATH
Set XDG_DATA_DIRS

in qtcreator in order to run & debug the test correctly. Please close this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390357] auto tests fails

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=390357

--- Comment #5 from Fahad Al-Saidi  ---
(In reply to Albert Astals Cid from comment #4)
> So you're hitting a qFatal? What is the output of the command? I guess that
> would be a good hint of what your problem is

sorry, which command you mean? if this:
grep KDESRCDIR build/autotests/CMakeFiles/parttest.dir/DependInfo.cmake

the result is:
"KDESRCDIR=\"/home/ita/kde/src/kde/kdegraphics/okular/autotests/\""

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390357] auto tests fails

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=390357

--- Comment #4 from Albert Astals Cid  ---
So you're hitting a qFatal? What is the output of the command? I guess that
would be a good hint of what your problem is

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 390357] auto tests fails

[Fahad Al-Saidi]

https://bugs.kde.org/show_bug.cgi?id=390357

--- Comment #3 from Fahad Al-Saidi  ---
sorry, the problem is not from cmake. When I debug it, okular crash when open
the doc, here it the debug:


Thread 3 (Thread 0x7fffdbd71700 (LWP 376)):
#0  0x75af474d in poll () at ../sysdeps/unix/syscall-template.S:84
No locals.
#1  0x70ef438c in ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
No symbol table info available.
#2  0x70ef449c in g_main_context_iteration () from
/lib/x86_64-linux-gnu/libglib-2.0.so.0
No symbol table info available.
#3  0x7641b6af in
QEventDispatcherGlib::processEvents(QFlags) ()
from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
No symbol table info available.
#4  0x763c3e2a in
QEventLoop::exec(QFlags) () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
No symbol table info available.
#5  0x761ec8f4 in QThread::exec() () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
No symbol table info available.
#6  0x7fffefbf5315 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5DBus.so.5
No symbol table info available.
#7  0x761f1709 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
No symbol table info available.
#8  0x757e36ba in start_thread (arg=0x7fffdbd71700) at
pthread_create.c:333
__res = 
pd = 0x7fffdbd71700
now = 
unwind_buf = {cancel_jmp_buf = {{jmp_buf = {140736881694464,
4209299068300874597, 0, 140737488347247, 140736881695168, 140737488347432,
-4209220105802558619, -4209311152409226395}, mask_was_saved = 0}}, priv = {pad
= {0x0, 0x0, 0x0, 0x0}, data = {prev = 0x0, cleanup = 0x0, canceltype = 0}}}
not_first_call = 
pagesize_m1 = 
sp = 
freesize = 
__PRETTY_FUNCTION__ = "start_thread"
#9  0x75b0041d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109
No locals.

Thread 2 (Thread 0x7fffe3764700 (LWP 375)):
#0  0x75af474d in poll () at ../sysdeps/unix/syscall-template.S:84
No locals.
#1  0x7fffec9fec62 in ?? () from /usr/lib/x86_64-linux-gnu/libxcb.so.1
No symbol table info available.
#2  0x7fffeca008d7 in xcb_wait_for_event () from
/usr/lib/x86_64-linux-gnu/libxcb.so.1
No symbol table info available.
#3  0x7fffe5cbb1f9 in ?? () from
/usr/lib/x86_64-linux-gnu/libQt5XcbQpa.so.5
No symbol table info available.
#4  0x761f1709 in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Core.so.5
No symbol table info available.
#5  0x757e36ba in start_thread (arg=0x7fffe3764700) at
pthread_create.c:333
__res = 
pd = 0x7fffe3764700
now = 
unwind_buf = {cancel_jmp_buf = {{jmp_buf = {140737009567488,
4209299068300874597, 0, 140737488346191, 140737009568192, 140737488346376,
-4209271500991835291, -4209311152409226395}, mask_was_saved = 0}}, priv = {pad
= {0x0, 0x0, 0x0, 0x0}, data = {prev = 0x0, cleanup = 0x0, canceltype = 0}}}
not_first_call = 
pagesize_m1 = 
sp = 
freesize = 
__PRETTY_FUNCTION__ = "start_thread"
#6  0x75b0041d in clone () at
../sysdeps/unix/sysv/linux/x86_64/clone.S:109
No locals.

Thread 1 (Thread 0x77f138c0 (LWP 367)):
#0  0x75a2e428 in __GI_raise (sig=sig@entry=6) at
../sysdeps/unix/sysv/linux/raise.c:54
resultvar = 0
pid = 367
selftid = 367
#1  0x75a3002a in __GI_abort () at abort.c:89
save_stage = 2
act = {__sigaction_handler = {sa_handler = 0x0, sa_sigaction = 0x0},
sa_mask = {__val = {140737323982638, 7608672, 140737329489568, 140737351871088,
3, 7167536, 0, 140737325494784, 140737353169072, 4294967295, 140737353171408,
140737351870832, 70, 0, 3454050420342969856, 280375465082880}}, sa_flags =
327790, sa_restorer = 0x5006e}
sigs = {__val = {32, 0 }}
#2  0x761d9c71 in QMessageLogger::fatal(char const*, ...) const () from
/usr/lib/x86_64-linux-gnu/libQt5Core.so.5
No symbol table info available.
#3  0x77ba9bab in ?? () from /usr/lib/x86_64-linux-gnu/libQt5Test.so.5
No symbol table info available.
#4  
No locals.
#5  0x00841f0f in ?? ()
No symbol table info available.
#6  0x76bac84a in QPagedPaintDevice::pageLayout() const () from
/usr/lib/x86_64-linux-gnu/libQt5Gui.so.5
No symbol table info available.
#7  0x74310fa1 in QPrinter::orientation() const () from
/usr/lib/x86_64-linux-gnu/libQt5PrintSupport.so.5
No symbol table info available.
#8  0x7fffdb361c97 in ?? () from
/usr/lib/x86_64-linux-gnu/qt5/plugins/okular/generators/okularGenerator_poppler.so
No symbol table info available.
#9  0x778a2f6a in Okular::Document::openDocument (this=0x7fffd8b0,
docFile=..., url=..., _mime=..., password=...) at
/home/ita/kde/src/kde/kdegraphics/okular/core/document.cpp:2488
db = {d = 0x76883570}
mime = {d = {d = 0x6a85c0}}
filedata = {d = 0x764af200 }
isstdin = false
triedMimeFromFileContent = false
offer = {m_metaData = {d = 0x6e39e0, o = 

[okular] [Bug 390355] crash when open Arabic xps file

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=390355

Oliver Sander  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED
 CC||oliver.san...@tu-dresden.de

--- Comment #2 from Oliver Sander  ---
Backtrace (first example file):

#0  0x7fffce24cfc8 in readFileOrDirectoryParts (entry=0x0, pathOfFile=0x0)
at /home/sander/okular-local-poppler/generators/xps/generator_xps.cpp:504
#1  0x7fffce2545b9 in XpsPage::XpsPage (this=0x55d957e0,
file=0x55d7c4d0, fileName=...)
at /home/sander/okular-local-poppler/generators/xps/generator_xps.cpp:1389
#2  0x7fffce259ac1 in XpsDocument::XpsDocument (this=0x55d955b0,
file=0x55d7c4d0, fileName=...)
at /home/sander/okular-local-poppler/generators/xps/generator_xps.cpp:1782
#3  0x7fffce25b921 in XpsFile::loadDocument (this=0x55d7c4d0,
filename=...)
at /home/sander/okular-local-poppler/generators/xps/generator_xps.cpp:1954
#4  0x7fffce25cd03 in XpsGenerator::loadDocument (this=0x55d866d0,
fileName=..., pagesVector=...)
at /home/sander/okular-local-poppler/generators/xps/generator_xps.cpp:2082
#5  0x7fffd6cfa75f in Okular::Generator::loadDocumentWithPassword
(this=0x55d866d0, fileName=..., pagesVector=...)
at /home/sander/okular-local-poppler/core/generator.cpp:212
#6  0x7fffd6cb6c6e in Okular::DocumentPrivate::openDocumentInternal
(this=0x558a1ba0, offer=..., isstdin=false, 
docFile=..., filedata=..., password=...) at
/home/sander/okular-local-poppler/core/document.cpp:872
#7  0x7fffd6cbfb94 in Okular::Document::openDocument (this=0x558a6260,
docFile=..., url=..., _mime=..., password=...)
at /home/sander/okular-local-poppler/core/document.cpp:2355
#8  0x7fffd704eb84 in Okular::Part::doOpenFile (this=0x55876890,
mimeA=..., fileNameToOpenA=..., 
isCompressedFile=0x7fffd557) at
/home/sander/okular-local-poppler/part.cpp:1383
#9  0x7fffd704f8cd in Okular::Part::openFile (this=0x55876890) at
/home/sander/okular-local-poppler/part.cpp:1515
#10 0x77b99336 in ?? () from /usr/lib/x86_64-linux-gnu/libKF5Parts.so.5
#11 0x77b9a1c1 in KParts::ReadOnlyPart::openUrl(QUrl const&) () from
/usr/lib/x86_64-linux-gnu/libKF5Parts.so.5
#12 0x7fffd7050cf3 in Okular::Part::openUrl (this=0x55876890, _url=...,
swapInsteadOfOpening=false)
at /home/sander/okular-local-poppler/part.cpp:1689
#13 0x7fffd7050b4e in Okular::Part::openUrl (this=0x55876890, url=...)
at /home/sander/okular-local-poppler/part.cpp:1653
#14 0x55567eb9 in Shell::openUrl (this=0x55854b20, url=...,
serializedOptions=...)
at /home/sander/okular-local-poppler/shell/shell.cpp:280
#15 0x55567993 in Shell::openDocument (this=0x55854b20, url=...,
serializedOptions=...)
at /home/sander/okular-local-poppler/shell/shell.cpp:221
#16 0x55564dc1 in Okular::main (paths=..., serializedOptions=...)
---Type  to continue, or q  to quit---
at /home/sander/okular-local-poppler/shell/okular_main.cpp:170
#17 0x555615ec in main (argc=2, argv=0x7fffdee8) at
/home/sander/okular-local-poppler/shell/main.cpp:70

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10048: [PATCH 2/4] Add refresh widgets if underlying field changes

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> aheinecke wrote in document.cpp:1153
> Sure this would be nice but as I understand it this would mean making 
> FormFieldText (or the general FormField) a QObject. As this is public API i 
> shied away from such a solution.
> 
> Should I change the patch to make FormFieldText a QObject with a textChanged 
> signal?

API break is not a problem since i already had to break it recently.

But on the other hand it will probably open a can of works since all the other 
document signals about forms should probably be formfield signals too, so i'd 
say i'm leaning towards ntot changing this.

> aheinecke wrote in document.h:1200
> Ok. But if we make the FormField a QObject we won't need it anymore :-)
> 
> Can you answer my question if making FormField a QObject would be ok? That 
> would probably give us the best flexibility for future changes so I would 
> like to do that. :-)

I'm prety sure i answered that, but the answer is not there, i wonder if i was 
using two different windows to answer and that made one content get lost?

Anyhow,will answer below.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10048

To: aheinecke, #okular
Cc: aacid, michaelweghorn, ngraham

[okular] [Bug 390357] auto tests fails

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=390357

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO
 Status|UNCONFIRMED |NEEDSINFO

--- Comment #1 from Albert Astals Cid  ---
Works fine for me and for CI, this must be a problem with your local setup.

What is the result of 
grep KDESRCDIR build/autotests/CMakeFiles/parttest.dir/DependInfo.cmake
?

-- 
You are receiving this mail because:
You are the assignee for the bug.

D10455: add rtl support to textpage

[Fahad Al-Saidi]

fahadalsaidi added a comment.


  @aacid  I want to write autotest but there is a bug #390357 in cmake test. I 
will try make autotest smiliar to test311232() but there is a problem, the pdf 
file doesn't load probably and it give me in an empty m_generator. please have 
a look on it.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10455

To: fahadalsaidi, #okular, aacid, ltoscano
Cc: ngraham, michaelweghorn, aacid