D12250: Install okularpart with the rest of kparts

apol updated this revision to Diff 32353. apol added a comment. The shell needs to know where the plugin is REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12250?vs=32348=32353 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12250 AFFECTED

[okular] [Bug 393206] Form data saved by Okular isn't readable by Adobe Acrobat

https://bugs.kde.org/show_bug.cgi?id=393206 --- Comment #2 from Yuri --- I am using poppler-0.57.0 Pdf document: https://www.irs.gov/pub/irs-pdf/f1040.pdf Steps to reproduce: 1. Open the pdf in Okular 2. Fill any field, ex. Last Name 3. Choose the menu item: File/Save 4. Open

D12250: Install okularpart with the rest of kparts

apol updated this revision to Diff 32348. apol added a comment. And another REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12250?vs=32347=32348 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12250 AFFECTED FILES CMakeLists.txt

D12250: Install okularpart with the rest of kparts

apol updated this revision to Diff 32347. apol added a comment. There's more desktop files pointing to okularpart REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12250?vs=32319=32347 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12250

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 86 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/86/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Mon, 16 Apr 2018 22:58:22 + Build duration: 3 min 53 sec and counting JUnit

KDE CI: Applications okular stable-kf5-qt5 SUSEQt5.9 - Build # 85 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20SUSEQt5.9/85/ Project: Applications okular stable-kf5-qt5 SUSEQt5.9 Date of build: Mon, 16 Apr 2018 22:39:40 + Build duration: 18 min and counting JUnit Tests

KDE CI: Applications okular stable-kf5-qt5 FreeBSDQt5.9 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FreeBSDQt5.9/55/ Project: Applications okular stable-kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 16 Apr 2018 22:39:40 + Build duration: 9 min 33 sec and counting

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 68 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/68/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 16 Apr 2018 22:40:10 + Build duration: 7 min 46 sec and counting JUnit Tests

[okular] [Bug 307304] Javascript in forms not working correctly

https://bugs.kde.org/show_bug.cgi?id=307304 Albert Astals Cid changed: What|Removed |Added Status|NEEDSINFO |CONFIRMED

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

This revision was automatically updated to reflect the committed changes. Closed by commit R223:6a2ed4f3144b: [Okular] Bug 387282: Highlighting of search results lost when rotating page (authored by ahmadosama, committed by aacid). CHANGED PRIOR TO COMMIT

[okular] [Bug 387282] Highlighting of search results and text selection lost when rotating page

https://bugs.kde.org/show_bug.cgi?id=387282 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Latest

D11901: [Okular] Bug 387282: Highlighting of search results lost when rotating page

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Looks like it works, i'll commit in a minute (with a small improvement from my side). I'd still like to know why m_rects and m_highlights need different transformation matrices.

[okular] [Bug 393206] Form data saved by Okular isn't readable by Adobe Acrobat

https://bugs.kde.org/show_bug.cgi?id=393206 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO

[okular] [Bug 393206] New: Form data saved by Okular isn't readable by Adobe Acrobat

https://bugs.kde.org/show_bug.cgi?id=393206 Bug ID: 393206 Summary: Form data saved by Okular isn't readable by Adobe Acrobat Product: okular Version: 1.3.3 Platform: Other OS: FreeBSD Status:

D11596: Add support for dynamic visibility

aacid added inline comments. INLINE COMMENTS > generator_pdf.cpp:459 > +} > +link = new Okular::ScriptAction( Okular::JavaScript, > scripts.join( QLatin1Char( '\n' ) ) ); > +} I understand why you're going through javascript for this, it kind of makes it a bit

D10792: Raise annotation window when clicking on annotation

aacid added inline comments. INLINE COMMENTS > annotwindow.cpp:316 > +raise(); > +return true; > +} I think this should be return false; otherwise i don't get the blinking cursor when clicking on the text field of an already open annotation. Can you double check?

D12177: Make some frameworks optional so okular can be built on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R223:c325b342f316: Make some frameworks optional so okular can be built on Android (authored by apol, committed by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12177?vs=32318=32334#toc

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.9 - Build # 67 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.9/67/ Project: Applications okular kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 16 Apr 2018 20:41:49 + Build duration: 12 min and counting JUnit Tests

D12177: Make some frameworks optional so okular can be built on Android

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. I'll push it, i've fixed the removal of the #if 0 in scripter.cpp REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 To: apol, #okular, aacid Cc:

D12250: Install okularpart with the rest of kparts

aacid added a comment. I honestly don't see the need to install stuff in a non standard folder. Why would this be a good idea? Because "We have a directory with all kparts" it's not true, in my install only khtml and ktexteditor install into /usr/lib/qt/plugins/kf5/parts/ while

[okular] [Bug 351849] Margins often cut when printing

https://bugs.kde.org/show_bug.cgi?id=351849 Michael Weghorn changed: What|Removed |Added Resolution|--- |WAITINGFORINFO

D12250: Install okularpart with the rest of kparts

apol updated this revision to Diff 32319. apol added a comment. Unsure why it worked for me, point to the library like katepart does REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12250?vs=32300=32319 BRANCH installprefix REVISION DETAIL

D12177: Make some frameworks optional so okular can be built on Android

apol updated this revision to Diff 32318. apol added a comment. Oops REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32317=32318 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 AFFECTED FILES CMakeLists.txt

D12177: Make some frameworks optional so okular can be built on Android

apol updated this revision to Diff 32317. apol added a comment. Unsure why it works on my system, adopt the same way to point to the path katepart uses REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32303=32317 BRANCH master REVISION DETAIL

D12250: Install okularpart with the rest of kparts

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. This doesn't seem to work statx(AT_FDCWD, "./okularpart.so", AT_STATX_SYNC_AS_STAT, STATX_ALL, 0x7ffec9b97970) = -1 ENOENT (No such file or directory) statx(AT_FDCWD,

D12177: Make some frameworks optional so okular can be built on Android

apol updated this revision to Diff 32303. apol added a comment. Shouldn't comment the include... REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32302=32303 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 AFFECTED FILES

D12177: Make some frameworks optional so okular can be built on Android

apol updated this revision to Diff 32302. apol added a comment. Typo REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32296=32302 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 AFFECTED FILES CMakeLists.txt

D12177: Make some frameworks optional so okular can be built on Android

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. HAVE_KWALLET is never defined REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12177 To: apol, #okular, aacid Cc: aacid, michaelweghorn, ngraham

D12250: Install okularpart with the rest of kparts

apol created this revision. apol added reviewers: Okular, aacid. Restricted Application added a project: Okular. apol requested review of this revision. REVISION SUMMARY We have a directory with all kparts, okular should integrate there TEST PLAN Uninstalled, installed with the patch

D12177: Make some frameworks optional so okular can be built on Android

apol updated this revision to Diff 32296. apol added a comment. Address Albert's concern REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12177?vs=32072=32296 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12177 AFFECTED FILES

[okular] [Bug 387424] Layers and Reviews categories use the same icon ("draw-freehand")

https://bugs.kde.org/show_bug.cgi?id=387424 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

D12177: Make some frameworks optional so okular can be built on Android

aacid requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12177 To: apol, #okular, aacid Cc: aacid, michaelweghorn, ngraham