D19123: Added option to search for whole words only

aacid added a comment. Not sure if i'm reading the tests code wrong, but shouldn't QTest::newRow("albert test") << (QVector() << QStringLiteral("it") << QStringLiteral(" should find this afind")) << QStringLiteral("find") << TEST_NEXT_AND_PREV; pass? REPOSITORY R223 Okular

[okular] [Bug 403914] Crash when closing okular trying to show file accessed via sftp

https://bugs.kde.org/show_bug.cgi?id=403914 Albert Astals Cid changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO

[okular] [Bug 403914] Crash when closing okular trying to show file accessed via sftp

https://bugs.kde.org/show_bug.cgi?id=403914 --- Comment #2 from Erik Quaeghebeur --- (In reply to Albert Astals Cid from comment #1) > can you reproduce this crash? No, currently not (on 1.6.3). Feel free to close. -- You are receiving this mail because: You are the assignee for the bug.

D18179: PDF: Implement scaling options for non-rasterized printing

aacid added inline comments. INLINE COMMENTS > fileprinter.h:58 > + * > + * @since 1.7 > + */ the since will need to be 1.8 (and all the other 1.7 you added) > fileprinter.h:61 > +enum ScaleMode { > +None = 0, > +FitToPrintArea = 1 Make this no Scale or

[okular] [Bug 403914] Crash when closing okular trying to show file accessed via sftp

https://bugs.kde.org/show_bug.cgi?id=403914 Albert Astals Cid changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution|---

D18179: PDF: Implement scaling options for non-rasterized printing

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All options work perfectly in my testing, both with and without rasterized printing enabled. If @aacid is good with the code, I think this could land. REPOSITORY R223 Okular BRANCH

D18179: PDF: Implement scaling options for non-rasterized printing

ngraham added a comment. Never mind, removing the dependency made it work. Stupid Arc. :( Testing now... REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: aacid, fvogt, okular-devel, joaonetto, tfella, ngraham,

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn added a comment. In D10974#442825 , @ngraham wrote: > Do you really not have commit access yet? You should apply. :) https://techbase.kde.org/Contribute/Get_a_Contributor_Account > > Meanwhile, I'll land this for you.

D18179: PDF: Implement scaling options for non-rasterized printing

michaelweghorn removed a dependency: D10974: Add option to ignore print margins for non-PDF generators. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18179 To: michaelweghorn, #okular, ngraham, sander Cc: aacid, fvogt, okular-devel, joaonetto, tfella, ngraham,

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn removed a dependent revision: D18179: PDF: Implement scaling options for non-rasterized printing. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10974 To: michaelweghorn, #okular, ngraham Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid,

D18179: PDF: Implement scaling options for non-rasterized printing

ngraham added a comment. This patch no longer applies cleanly to master: Switched to branch 'master' Your branch is up to date with 'origin/master'. Already up to date. Deleted branch arcpatch-D18179 (was 8bf1a9117). INFO Base commit is not in local repository; trying

D10974: Add option to ignore print margins for non-PDF generators

This revision was automatically updated to reflect the committed changes. Closed by commit R223:8bf1a911751b: Add option to ignore print margins for non-PDF generators (authored by michaelweghorn, committed by ngraham). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D10974: Add option to ignore print margins for non-PDF generators

ngraham added a comment. Do you really not have commit access yet? You should apply. :) https://techbase.kde.org/Contribute/Get_a_Contributor_Account Meanwhile, I'll land this for you. REPOSITORY R223 Okular BRANCH michaelweghorn/UPDATE_D10974 REVISION DETAIL

D10974: Add option to ignore print margins for non-PDF generators

michaelweghorn added a comment. In D10974#442598 , @aacid wrote: > If someone wants to test it and approve it and Michael says he'll fix any bug that arises from here i'm happy enough I promise that I'll try to fix any issues arising