[okular] [Bug 407256] Please change search result display color

[Thomas Bingel]

https://bugs.kde.org/show_bug.cgi?id=407256

Thomas Bingel  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Ever confirmed|0   |1
 Resolution|DUPLICATE   |---

--- Comment #3 from Thomas Bingel  ---
To define it as a duplicate does not resolve this annoying issue that has
existed for quite some time now. I find this extremely lazy to do such a thing

Please fix this issue finally

I propose to use light purple to mark found search terms.
And since we are at the Find function, please also include a count of all found
terms in document

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.

D20832: Fix some clazy warning

[Laurent Montel]

mlaurent added a comment.


  Ok albert send me an email in private :)
  he will look at it in several days :)
  tha,ks :)
  
  (I didn't have internet access before to see his email :)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D20832

To: mlaurent, aacid
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D20832: Fix some clazy warning

[Laurent Montel]

mlaurent added a comment.


  new ping :)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D20832

To: mlaurent, aacid
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

[okular] [Bug 388952] Allow independent settings in multiple open instances of okular

[Mebus]

https://bugs.kde.org/show_bug.cgi?id=388952

Mebus  changed:

   What|Removed |Added

 CC||mebus.in...@mail.ru

--- Comment #1 from Mebus  ---
Tabs in Okular a great, but:

The same problem occurs with tabs. I doesn't let me choose per tab if I want to
view it continuous or not. This especially annoying when view lecture slides
and eBooks at the same time in Okular.

My current Okular version is 1.6.2.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 407256] Please change search result display color

[João Netto]

https://bugs.kde.org/show_bug.cgi?id=407256

João Netto  changed:

   What|Removed |Added

 CC||joaonetto...@gmail.com

--- Comment #2 from João Netto  ---
(In reply to David Hurka from comment #1)
> https://phabricator.kde.org/D18238 (why not continue this?)

>From what I've seen, the main reason is that other readers don't do that. Also,
it became a little bit clustered ( This could be easily fixed by moving it into
settings)

One of the main reasons people use KDE is customization, so maybe having this
option would be acceptable, and even better.

Of course there's other solutions, like getting the system background color,
I've thinkered with that but I couldn't get the system color.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 237014] Find tool when text has been highlighted

[David Hurka]

https://bugs.kde.org/show_bug.cgi?id=237014

David Hurka  changed:

   What|Removed |Added

 CC||bing...@gmail.com

--- Comment #8 from David Hurka  ---
*** Bug 407256 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 407256] Please change search result display color

[David Hurka]

https://bugs.kde.org/show_bug.cgi?id=407256

David Hurka  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|REPORTED|RESOLVED

--- Comment #1 from David Hurka  ---
Several people complained about this. All we got so far, is a black border.

A discussion about this is in Bug 384267.

Also look at:
https://phabricator.kde.org/D18238 (why not continue this?)
https://phabricator.kde.org/D7662
https://phabricator.kde.org/search/query/Boo2YVUCQ.00/#R

*** This bug has been marked as a duplicate of bug 237014 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

D20760: Okular Annotation: add support for line ending style for Straight Line tool

[Tobias Deiminger]

tobiasdeiminger added a comment.


  >> At least squares and diamonds are incorrect, too.
  > 
  > Ok, so at least we're consistent in doing wrong :) I'll fix it.
  
  @sander Could you verify poppler MR 269 
 along with 
D20760 ? (sorry, can't do it myself since 
my Okular dev environment broke on last KF5 dependency bump, need to fix that 
first).

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D20760

To: knambiar, #okular, #vdg, sander, ngraham
Cc: pino, sander, davidhurka, tobiasdeiminger, ngraham, okular-devel, 
joaonetto, tfella, darcyshen, aacid

D20760: Okular Annotation: add support for line ending style for Straight Line tool

[Pino Toscano]

pino added inline comments.

INLINE COMMENTS

> annotationwidgets.cpp:549-558
> +m_termStyleCombo->addItem( QStringLiteral(u"\u25A1") + i18n( " Square" ) 
> );
> +m_termStyleCombo->addItem( QStringLiteral(u"\u25CB") + i18n( " Circle" ) 
> );
> +m_termStyleCombo->addItem( QStringLiteral(u"\u25C7") + i18n( " Diamond" 
> ) );
> +m_termStyleCombo->addItem( QStringLiteral(u"\u2192") + i18n( " Open 
> Arrow" ) );
> +m_termStyleCombo->addItem( QStringLiteral(u"\u21FE") + i18n( " Closed 
> Arrow" ) );
> +m_termStyleCombo->addItem( i18n( " None" ) );
> +m_termStyleCombo->addItem( QStringLiteral(u"\u22A3") + i18n( " Butt" ) );

I think this does not play well with translations: there is nothing that says 
what for the leading spaces are, so translators can easily not have them in the 
translations, resulting in symbol and first word attached together.
There is also the issue that some of the strings are no easy to get, for 
example "Butt" (yes, without context), or "-/ Slash".

My proposal is the following:

- create a QIconEngine that draws a specific character/string as icon; this 
also makes sure all the symbols and texts are properly aligned
- leave the strings as simple strings with no spaces nor other parts, adding 
contexts to them

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D20760

To: knambiar, #okular, #vdg, sander, ngraham
Cc: pino, sander, davidhurka, tobiasdeiminger, ngraham, okular-devel, 
joaonetto, tfella, darcyshen, aacid