[Okular-devel] [Bug 312188] Crashes every time trying to open some of the specific pdf docs.

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312188

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Albert Astals Cid  ---
You forgot to attach the file that makes it crash

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 312138] Unfolded table of contents folds in upon reloading of document

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312138

Albert Astals Cid  changed:

   What|Removed |Added

   Keywords||junior-jobs

--- Comment #4 from Albert Astals Cid  ---
Marking this as a junior job, it should be pretty easy to store the whole tree
of the TOC when we trigger the reload and check if the tree is the same after
it has happened. Interested people in implementing the junior job please
contact the okular-devel@kde.org mailing list if you decide to have a look at
this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 312238] okular crash when load a malformed epub

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312238

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |UPSTREAM

--- Comment #1 from Albert Astals Cid  ---
You are right, this is a bug in libepub and it has actually been fixed in
0.2.2, you may want to complain to your distro so they update the version they
ship.

Thanks for caring about okular and creating this bug report :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] [Bug 312138] Unfolded table of contents folds in upon reloading of document

[Albert Astals Cid]

El Divendres, 28 de desembre de 2012, a les 01:48:55, Jaydeep Solanki va 
escriure:
> I would like to give it a try, please point me to the source.

You know where the source is ;-)

Have you tried searching for where the code that is responsible of this before 
asking?

> & in the case where the toc is updated/changed, I guess that part should
> remain folded & the rest should restore to it's previous state. What's your
> opinion on this ??

Let's go the easy way for now "a) Keep the toc view in its present state if 
the toc hasn't changed at all.  Otherwise fold it completely"

> btw is this for the reload action only, or is it about to store it &
> restore when the document is opened again?

Reload only.

Cheers,
  Albert

> 
> -Jaydeep
> 
> On Thu, Dec 27, 2012 at 2:35 AM, Albert Astals Cid  wrote:
> > https://bugs.kde.org/show_bug.cgi?id=312138
> > 
> > Albert Astals Cid  changed:
> >What|Removed |Added
> > 
> > --
> > --> 
> >Keywords||junior-jobs
> > 
> > --- Comment #4 from Albert Astals Cid  ---
> > Marking this as a junior job, it should be pretty easy to store the whole
> > tree
> > of the TOC when we trigger the reload and check if the tree is the same
> > after
> > it has happened. Interested people in implementing the junior job please
> > contact the okular-devel@kde.org mailing list if you decide to have a
> > look at
> > this.
> > 
> > --
> > You are receiving this mail because:
> > You are the assignee for the bug.
> > ___
> > Okular-devel mailing list
> > Okular-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/okular-devel
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 311825] The icon of the mouse don't change

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=311825

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #2 from Albert Astals Cid  ---
Angelo i do not understand what you mean, can you please attach a few
screenshots to make it easier to understand for us?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] [Bug 312138] Unfolded table of contents folds in upon reloading of document

[Albert Astals Cid]

El Dissabte, 29 de desembre de 2012, a les 04:47:08, Jaydeep Solanki va 
escriure:
> All the libraries that Okular generators use, do all of them generate text
> in the correct order ?
> By correct order I mean, following the layout (eg. two column, three
> column).
> As far as I have noticed poppler genereates in the correct order.

I don't understand your question.

Cheers,
  Albert

> 
> On Fri, Dec 28, 2012 at 5:57 AM, Albert Astals Cid  wrote:
> > El Divendres, 28 de desembre de 2012, a les 01:48:55, Jaydeep Solanki va
> > 
> > escriure:
> > > I would like to give it a try, please point me to the source.
> > 
> > You know where the source is ;-)
> > 
> > Have you tried searching for where the code that is responsible of this
> > before
> > asking?
> :
> :D  you got me..
> :
> > > & in the case where the toc is updated/changed, I guess that part should
> > > remain folded & the rest should restore to it's previous state. What's
> > 
> > your
> > 
> > > opinion on this ??
> > 
> > Let's go the easy way for now "a) Keep the toc view in its present state
> > if
> > the toc hasn't changed at all.  Otherwise fold it completely"
> > 
> > > btw is this for the reload action only, or is it about to store it &
> > > restore when the document is opened again?
> > 
> > Reload only.
> > 
> > Cheers,
> > 
> >   Albert
> >   
> > > -Jaydeep
> > > 
> > > On Thu, Dec 27, 2012 at 2:35 AM, Albert Astals Cid 
> > 
> > wrote:
> > > > https://bugs.kde.org/show_bug.cgi?id=312138
> > > > 
> > > > Albert Astals Cid  changed:
> > > >What|Removed |Added
> > 
> > --
> > 
> > > > -->
> > > > 
> > > >Keywords||junior-jobs
> > > > 
> > > > --- Comment #4 from Albert Astals Cid  ---
> > > > Marking this as a junior job, it should be pretty easy to store the
> > 
> > whole
> > 
> > > > tree
> > > > of the TOC when we trigger the reload and check if the tree is the
> > > > same
> > > > after
> > > > it has happened. Interested people in implementing the junior job
> > 
> > please
> > 
> > > > contact the okular-devel@kde.org mailing list if you decide to have a
> > > > look at
> > > > this.
> > > > 
> > > > --
> > > > You are receiving this mail because:
> > > > You are the assignee for the bug.
> > > > ___
> > > > Okular-devel mailing list
> > > > Okular-devel@kde.org
> > > > https://mail.kde.org/mailman/listinfo/okular-devel
> > 
> > ___
> > Okular-devel mailing list
> > Okular-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/okular-devel
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107994/#review24157
---


Why did you add an "id"? What is that "id" supposed to mean?

- Albert Astals Cid


On Dec. 28, 2012, 11:15 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107994/
> ---
> 
> (Updated Dec. 28, 2012, 11:15 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> This fix will preserve the state of the Table Of Content (toc) on document 
> reload, but if the toc is edited/changed, then it will be restored to default 
> (i.e. all nodes will be folded)
> 
> 
> This addresses bug 312138.
> http://bugs.kde.org/show_bug.cgi?id=312138
> 
> 
> Diffs
> -
> 
>   part.h 0c57560 
>   part.cpp 1922128 
>   ui/toc.h eeeff98 
>   ui/toc.cpp 4c84b62 
>   ui/tocmodel.h a857dc0 
>   ui/tocmodel.cpp 39add80 
> 
> Diff: http://git.reviewboard.kde.org/r/107994/diff/
> 
> 
> Testing
> ---
> 
> Checked. Works fine with me.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] [Bug 312138] Unfolded table of contents folds in upon reloading of document

[Albert Astals Cid]

El Dissabte, 29 de desembre de 2012, a les 06:28:09, Jaydeep Solanki va 
escriure:
> On Sat, Dec 29, 2012 at 5:25 AM, Albert Astals Cid  wrote:
> > El Dissabte, 29 de desembre de 2012, a les 04:47:08, Jaydeep Solanki va
> > 
> > escriure:
> > > All the libraries that Okular generators use, do all of them generate
> > 
> > text
> > 
> > > in the correct order ?
> > > By correct order I mean, following the layout (eg. two column, three
> > > column).
> > > As far as I have noticed poppler genereates in the correct order.
> > 
> > I don't understand your question.
> 
> As you might be knowing that Poppler::Page::textList() generates text in
> the correct order (i.e. left to right). Now poppler not only generates it
> in the correct order but it also considers the layout, for example in a two
> column document, it follows the column layout while indexing the text.
> [image: Inline image 2]
> 
> just of example consider the image above, see the selection, poppler
> doesn't generate textList() in that order, it generates the textList() as
> shown in the below image,
> 
> [image: Inline image 3]
> So my question is do all the libraries that the generators of okular use,
> generate text in the proper order considering the layout ?

What does this have to do with "Unfolded table of contents folds in upon 
reloading of document"?

Or you forgot to create a new thread and you indeed speaking about something 
different?

Albert

> 
> > Cheers,
> > 
> >   Albert
> >   
> > > On Fri, Dec 28, 2012 at 5:57 AM, Albert Astals Cid 
> > 
> > wrote:
> > > > El Divendres, 28 de desembre de 2012, a les 01:48:55, Jaydeep Solanki
> > 
> > va
> > 
> > > > escriure:
> > > > > I would like to give it a try, please point me to the source.
> > > > 
> > > > You know where the source is ;-)
> > > > 
> > > > Have you tried searching for where the code that is responsible of
> > > > this
> > > > before
> > > > asking?
> > > :
> > > :D  you got me..
> > > :
> > > > > & in the case where the toc is updated/changed, I guess that part
> > 
> > should
> > 
> > > > > remain folded & the rest should restore to it's previous state.
> > 
> > What's
> > 
> > > > your
> > > > 
> > > > > opinion on this ??
> > > > 
> > > > Let's go the easy way for now "a) Keep the toc view in its present
> > 
> > state
> > 
> > > > if
> > > > the toc hasn't changed at all.  Otherwise fold it completely"
> > > > 
> > > > > btw is this for the reload action only, or is it about to store it &
> > > > > restore when the document is opened again?
> > > > 
> > > > Reload only.
> > > > 
> > > > Cheers,
> > > > 
> > > >   Albert
> > > >   
> > > > > -Jaydeep
> > > > > 
> > > > > On Thu, Dec 27, 2012 at 2:35 AM, Albert Astals Cid 
> > > > 
> > > > wrote:
> > > > > > https://bugs.kde.org/show_bug.cgi?id=312138
> > > > > > 
> > > > > > Albert Astals Cid  changed:
> > > > > >What|Removed |Added
> > 
> > --
> > 
> > > > > > -->
> > > > > > 
> > > > > >Keywords||junior-jobs
> > > > > > 
> > > > > > --- Comment #4 from Albert Astals Cid  ---
> > > > > > Marking this as a junior job, it should be pretty easy to store
> > > > > > the
> > > > 
> > > > whole
> > > > 
> > > > > > tree
> > > > > > of the TOC when we trigger the reload and check if the tree is the
> > > > > > same
> > > > > > after
> > > > > > it has happened. Interested people in implementing the junior job
> > > > 
> > > > please
> > > > 
> > > > > > contact the okular-devel@kde.org mailing list if you decide to
> > 
> > have a
> > 
> > > > > > look at
> > > > > > this.
> > > > > > 
> > > > > > --
> > > > > > You are receiving this mail because:
> > > > > > You are the assignee for the bug.
> > > > > > ___
> > > > > > Okular-devel mailing list
> > > > > > Okular-devel@kde.org
> > > > > > https://mail.kde.org/mailman/listinfo/okular-devel
> > > > 
> > > > ___
> > > > Okular-devel mailing list
> > > > Okular-devel@kde.org
> > > > https://mail.kde.org/mailman/listinfo/okular-devel
> > 
> > ___
> > Okular-devel mailing list
> > Okular-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/okular-devel
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 309734] Okular crashes on exit when print preview was shown on attached PDF

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=309734

Albert Astals Cid  changed:

   What|Removed |Added

 CC||drpjkur...@gmail.com

--- Comment #2 from Albert Astals Cid  ---
*** Bug 312329 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 312329] Okular crash

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312329

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |DUPLICATE

--- Comment #1 from Albert Astals Cid  ---


*** This bug has been marked as a duplicate of bug 309734 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Regarding okular generators

[Albert Astals Cid]

El Dissabte, 29 de desembre de 2012, a les 22:56:12, Jaydeep Solanki va 
escriure:
> As you might be knowing that Poppler::Page::textList() generates text in
> the correct order (i.e. left to right). Now poppler not only generates it
> in the correct order but it also considers the layout, for example in a two
> column document, it follows the column layout while indexing the text.
> [image: Inline image 2]
> 
> just of example consider the image above, see the selection, poppler
> doesn't generate textList() in that order, it generates the textList() as
> shown in the below image,
> 
> [image: Inline image 3]
> So my question is do all the libraries that the generators of okular use,
> generate text in the proper order considering the layout ?

That doesn't matter, Textpage algorithms "should" correctly arrange text in 
columns (as correctly as the algorithm in there works).

Have you found any particular problem?

Albert
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

[Albert Astals Cid]

> On Dec. 28, 2012, 11:56 p.m., Albert Astals Cid wrote:
> > Why did you add an "id"? What is that "id" supposed to mean?
> 
> Jaydeep Solanki wrote:
> because when the display name of two nodes are same, okular won't know 
> which one to expand & will end up expanding the wrong one at times. So id 
> gives a unique identity to each node, to avoid ambiguity.

Right, i see the problem.

Could you try storing QModelIndexes instead of the "id" you just have created? 
QModelIndex should work fine since it already has the parent structure, etc, so 
it should be "doable".

The "problem" i see with the current "id" thing is that are adding more memory 
usage for something that doesn't seem to be necessary.

Also you need to delete/clear m_oldTocModel and m_expandedList after the reload 
is done, otherwise we are leaking memory (in the first case) or using more 
memory than needed (in the second case)

There's also a few minor "style" issue i'll comment in a moment.


- Albert


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107994/#review24157
---


On Dec. 28, 2012, 11:15 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107994/
> ---
> 
> (Updated Dec. 28, 2012, 11:15 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> This fix will preserve the state of the Table Of Content (toc) on document 
> reload, but if the toc is edited/changed, then it will be restored to default 
> (i.e. all nodes will be folded)
> 
> 
> This addresses bug 312138.
> http://bugs.kde.org/show_bug.cgi?id=312138
> 
> 
> Diffs
> -
> 
>   part.h 0c57560 
>   part.cpp 1922128 
>   ui/toc.h eeeff98 
>   ui/toc.cpp 4c84b62 
>   ui/tocmodel.h a857dc0 
>   ui/tocmodel.cpp 39add80 
> 
> Diff: http://git.reviewboard.kde.org/r/107994/diff/
> 
> 
> Testing
> ---
> 
> Checked. Works fine with me.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107994/#review24201
---



ui/toc.h
<http://git.reviewboard.kde.org/r/107994/#comment18544>

Make the function be const and the parameter be const &



ui/tocmodel.h
<http://git.reviewboard.kde.org/r/107994/#comment18545>

const for the function too



ui/tocmodel.h
<http://git.reviewboard.kde.org/r/107994/#comment18546>

make the modelindexes be const &


- Albert Astals Cid


On Dec. 28, 2012, 11:15 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107994/
> ---
> 
> (Updated Dec. 28, 2012, 11:15 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> This fix will preserve the state of the Table Of Content (toc) on document 
> reload, but if the toc is edited/changed, then it will be restored to default 
> (i.e. all nodes will be folded)
> 
> 
> This addresses bug 312138.
> http://bugs.kde.org/show_bug.cgi?id=312138
> 
> 
> Diffs
> -
> 
>   part.h 0c57560 
>   part.cpp 1922128 
>   ui/toc.h eeeff98 
>   ui/toc.cpp 4c84b62 
>   ui/tocmodel.h a857dc0 
>   ui/tocmodel.cpp 39add80 
> 
> Diff: http://git.reviewboard.kde.org/r/107994/diff/
> 
> 
> Testing
> ---
> 
> Checked. Works fine with me.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Regarding okular generators

[Albert Astals Cid]

El Diumenge, 30 de desembre de 2012, a les 00:30:41, Jaydeep Solanki va 
escriure:
> I'm aware about Textpage algorithms that regardless of the generator, makes
> text selection work properly in column layout.
> I'm not asking it for okular, I'm asking for personal use, as I was trying
> out Poppler, I made a small app that currently can open pdf files, while I
> was working on the text selection in column layout, I thought that if all
> the libs generate text in the correct order then there is no need for
> coding the algorithm to arrange text. In future I'm planning to add support
> for other formats, so I need to know if the algorithm is needed.

So you are writing an Okular clone? What is the plan for your program that 
Okular does not support?

Cheers,
  Albert

> 
> Jaydeep
> 
> On Sat, Dec 29, 2012 at 11:22 PM, Albert Astals Cid  wrote:
> > El Dissabte, 29 de desembre de 2012, a les 22:56:12, Jaydeep Solanki va
> > 
> > escriure:
> > > As you might be knowing that Poppler::Page::textList() generates text in
> > > the correct order (i.e. left to right). Now poppler not only generates
> > > it
> > > in the correct order but it also considers the layout, for example in a
> > 
> > two
> > 
> > > column document, it follows the column layout while indexing the text.
> > > [image: Inline image 2]
> > > 
> > > just of example consider the image above, see the selection, poppler
> > > doesn't generate textList() in that order, it generates the textList()
> > > as
> > > shown in the below image,
> > > 
> > > [image: Inline image 3]
> > > So my question is do all the libraries that the generators of okular
> > > use,
> > > generate text in the proper order considering the layout ?
> > 
> > That doesn't matter, Textpage algorithms "should" correctly arrange text
> > in
> > columns (as correctly as the algorithm in there works).
> > 
> > Have you found any particular problem?
> > 
> > Albert
> > ___
> > Okular-devel mailing list
> > Okular-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/okular-devel
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Regarding okular generators

[Albert Astals Cid]

El Diumenge, 30 de desembre de 2012, a les 00:30:41, Jaydeep Solanki va 
escriure:
> I'm aware about Textpage algorithms that regardless of the generator, makes
> text selection work properly in column layout.
> I'm not asking it for okular, I'm asking for personal use, as I was trying
> out Poppler, I made a small app that currently can open pdf files, while I
> was working on the text selection in column layout, I thought that if all
> the libs generate text in the correct order then there is no need for
> coding the algorithm to arrange text. In future I'm planning to add support
> for other formats, so I need to know if the algorithm is needed.

The thing is, why write the column sorting algorithm in each and every of the 
libraries if you can have it just in one place?

Cheers,
  Albert

> 
> Jaydeep
> 
> On Sat, Dec 29, 2012 at 11:22 PM, Albert Astals Cid  wrote:
> > El Dissabte, 29 de desembre de 2012, a les 22:56:12, Jaydeep Solanki va
> > 
> > escriure:
> > > As you might be knowing that Poppler::Page::textList() generates text in
> > > the correct order (i.e. left to right). Now poppler not only generates
> > > it
> > > in the correct order but it also considers the layout, for example in a
> > 
> > two
> > 
> > > column document, it follows the column layout while indexing the text.
> > > [image: Inline image 2]
> > > 
> > > just of example consider the image above, see the selection, poppler
> > > doesn't generate textList() in that order, it generates the textList()
> > > as
> > > shown in the below image,
> > > 
> > > [image: Inline image 3]
> > > So my question is do all the libraries that the generators of okular
> > > use,
> > > generate text in the proper order considering the layout ?
> > 
> > That doesn't matter, Textpage algorithms "should" correctly arrange text
> > in
> > columns (as correctly as the algorithm in there works).
> > 
> > Have you found any particular problem?
> > 
> > Albert
> > ___
> > Okular-devel mailing list
> > Okular-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/okular-devel
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Regarding okular generators

[Albert Astals Cid]

El Diumenge, 30 de desembre de 2012, a les 01:30:49, Jaydeep Solanki va 
escriure:
> On Sun, Dec 30, 2012 at 12:50 AM, Albert Astals Cid  wrote:
> > El Diumenge, 30 de desembre de 2012, a les 00:30:41, Jaydeep Solanki va
> > 
> > escriure:
> > > I'm aware about Textpage algorithms that regardless of the generator,
> > 
> > makes
> > 
> > > text selection work properly in column layout.
> > > I'm not asking it for okular, I'm asking for personal use, as I was
> > 
> > trying
> > 
> > > out Poppler, I made a small app that currently can open pdf files, while
> > 
> > I
> > 
> > > was working on the text selection in column layout, I thought that if
> > > all
> > > the libs generate text in the correct order then there is no need for
> > > coding the algorithm to arrange text. In future I'm planning to add
> > 
> > support
> > 
> > > for other formats, so I need to know if the algorithm is needed.
> > 
> > The thing is, why write the column sorting algorithm in each and every of
> > the
> > libraries if you can have it just in one place?
> 
> yes you are absolutely correct, but I was thinking to omit the algorithm
> completely. Because if all the libs generate text in proper order then that
> can be used for helping the selection, instead of an algorithm.
> I have found that OCRopus is used in Okular, I didn't confirm, but found it
> somewhere written on internet. (correct me if I'm wrong).

You are wrong, don't trust the internet ;-)

Cheers,
  Albert

> OCRopus uses image processing which uses a large amount of computation
> resources.
> So the core reason to omit the algorithm is to save large computation.
> 
> > Cheers,
> > 
> >   Albert
> >   
> > > Jaydeep
> > > 
> > > On Sat, Dec 29, 2012 at 11:22 PM, Albert Astals Cid 
> > 
> > wrote:
> > > > El Dissabte, 29 de desembre de 2012, a les 22:56:12, Jaydeep Solanki
> > > > va
> > > > 
> > > > escriure:
> > > > > As you might be knowing that Poppler::Page::textList() generates
> > 
> > text in
> > 
> > > > > the correct order (i.e. left to right). Now poppler not only
> > 
> > generates
> > 
> > > > > it
> > > > > in the correct order but it also considers the layout, for example
> > 
> > in a
> > 
> > > > two
> > > > 
> > > > > column document, it follows the column layout while indexing the
> > 
> > text.
> > 
> > > > > [image: Inline image 2]
> > > > > 
> > > > > just of example consider the image above, see the selection, poppler
> > > > > doesn't generate textList() in that order, it generates the
> > 
> > textList()
> > 
> > > > > as
> > > > > shown in the below image,
> > > > > 
> > > > > [image: Inline image 3]
> > > > > So my question is do all the libraries that the generators of okular
> > > > > use,
> > > > > generate text in the proper order considering the layout ?
> > > > 
> > > > That doesn't matter, Textpage algorithms "should" correctly arrange
> > 
> > text
> > 
> > > > in
> > > > columns (as correctly as the algorithm in there works).
> > > > 
> > > > Have you found any particular problem?
> > > > 
> > > > Albert
> > > > ___
> > > > Okular-devel mailing list
> > > > Okular-devel@kde.org
> > > > https://mail.kde.org/mailman/listinfo/okular-devel
> > 
> > ___
> > Okular-devel mailing list
> > Okular-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/okular-devel
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 312188] Crashes every time trying to open some of the specific pdf docs.

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312188

--- Comment #3 from Albert Astals Cid  ---
Can you attach a backtrace of the crash (as given by drkonqui)?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107994/#review24264
---


Can you please put the whole diff not just the new part? reviewboard does not 
support series of patches.

- Albert Astals Cid


On Dec. 29, 2012, 9:54 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107994/
> ---
> 
> (Updated Dec. 29, 2012, 9:54 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> This fix will preserve the state of the Table Of Content (toc) on document 
> reload, but if the toc is edited/changed, then it will be restored to default 
> (i.e. all nodes will be folded)
> 
> 
> This addresses bug 312138.
> http://bugs.kde.org/show_bug.cgi?id=312138
> 
> 
> Diffs
> -
> 
>   part.cpp 1922128 
>   ui/toc.h eeeff98 
>   ui/toc.cpp 4c84b62 
>   ui/tocmodel.h a857dc0 
>   ui/tocmodel.cpp 39add80 
> 
> Diff: http://git.reviewboard.kde.org/r/107994/diff/
> 
> 
> Testing
> ---
> 
> Checked. Works fine with me.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 312188] Crashes every time trying to open some of the specific pdf docs.

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312188

--- Comment #5 from Albert Astals Cid  ---
Interesting, you should be getting a dialog saying "This crashed blablabla",
well, if you don't get that, just do

  gdb okular pathtomyfile
  run
"make it crash"
  bt

And paste the result of the bt command in here, you may need to install the gdb
command. Also i will need to know which poppler version you are using.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 312188] Crashes every time trying to open some of the specific pdf docs.

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312188

--- Comment #7 from Albert Astals Cid  ---
You forgot to do the "bt" command after making it crash, yes if you install the
packages it suggests it will be better, but there is no need

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107994/#review24291
---



part.cpp
<http://git.reviewboard.kde.org/r/107994/#comment18592>

This is still a memory leak, you need to delete it, since in clone() you 
new'ed it


- Albert Astals Cid


On Dec. 30, 2012, 4:32 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107994/
> ---
> 
> (Updated Dec. 30, 2012, 4:32 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> This fix will preserve the state of the Table Of Content (toc) on document 
> reload, but if the toc is edited/changed, then it will be restored to default 
> (i.e. all nodes will be folded)
> 
> 
> This addresses bug 312138.
> http://bugs.kde.org/show_bug.cgi?id=312138
> 
> 
> Diffs
> -
> 
>   part.h 0c57560 
>   part.cpp 1922128 
>   ui/toc.h eeeff98 
>   ui/toc.cpp 4c84b62 
>   ui/tocmodel.h a857dc0 
>   ui/tocmodel.cpp 39add80 
> 
> Diff: http://git.reviewboard.kde.org/r/107994/diff/
> 
> 
> Testing
> ---
> 
> Checked. Works fine with me.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

[Albert Astals Cid]

> On Dec. 28, 2012, 11:56 p.m., Albert Astals Cid wrote:
> > Why did you add an "id"? What is that "id" supposed to mean?
> 
> Jaydeep Solanki wrote:
> because when the display name of two nodes are same, okular won't know 
> which one to expand & will end up expanding the wrong one at times. So id 
> gives a unique identity to each node, to avoid ambiguity.
> 
> Albert Astals Cid wrote:
> Right, i see the problem.
> 
> Could you try storing QModelIndexes instead of the "id" you just have 
> created? QModelIndex should work fine since it already has the parent 
> structure, etc, so it should be "doable".
> 
> The "problem" i see with the current "id" thing is that are adding more 
> memory usage for something that doesn't seem to be necessary.
> 
> Also you need to delete/clear m_oldTocModel and m_expandedList after the 
> reload is done, otherwise we are leaking memory (in the first case) or using 
> more memory than needed (in the second case)
> 
> There's also a few minor "style" issue i'll comment in a moment.
> 
> Jaydeep Solanki wrote:
> there's one problem in using QMOdelIndex, when returning QModelindex from 
> the model (tocmodel::data(..)), it returns a QVariant object, & when we want 
> to compare the QModelIndexes, we cannot cast QVariant to QModelIndex.
> & even if we succeed in that, the comparision with the QModelIndex of the 
> cloned model & the actual model will result false always, because AFAIK 
> QModelIndex contains the address of the memory location too.
>

It's not data() what you need to return but index() if you want a QModelIndex


- Albert


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107994/#review24157
---


On Dec. 30, 2012, 4:32 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107994/
> ---
> 
> (Updated Dec. 30, 2012, 4:32 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> This fix will preserve the state of the Table Of Content (toc) on document 
> reload, but if the toc is edited/changed, then it will be restored to default 
> (i.e. all nodes will be folded)
> 
> 
> This addresses bug 312138.
> http://bugs.kde.org/show_bug.cgi?id=312138
> 
> 
> Diffs
> -
> 
>   part.h 0c57560 
>   part.cpp 1922128 
>   ui/toc.h eeeff98 
>   ui/toc.cpp 4c84b62 
>   ui/tocmodel.h a857dc0 
>   ui/tocmodel.cpp 39add80 
> 
> Diff: http://git.reviewboard.kde.org/r/107994/diff/
> 
> 
> Testing
> ---
> 
> Checked. Works fine with me.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Properties dialog: switch to QFormLayout and showing icon for mime type

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107357/#review24306
---


I was just going to apply the diff but realized with the new code we get "label 
buddies" and that makes the _ appear in almost all the labels of the first 
column that makes no sense as you can't use Alt+key to focus on the buddy since 
the buddy is also a label that can't hold focus. Can you please try to make 
those not appear?

- Albert Astals Cid


On Nov. 17, 2012, 7:51 p.m., Thomas Fischer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107357/
> ---
> 
> (Updated Nov. 17, 2012, 7:51 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> This patch changes the properties dialog to use QFormLayout instead of a 
> two-column QGridLayout. This should make the dialog more compatible with 
> other user interfaces.
> For the mime type row, instead of just showing the mime type's name, a small 
> QLabel is used to show the mime type's icon.
> 
> Maybe it would be a good idea to not only show the mime type's name, but also 
> the description (KMimeType::comment(..)). Example: "PDF Document 
> (application/pdf)"
> 
> 
> Diffs
> -
> 
>   ui/propertiesdialog.cpp 2ef8220 
> 
> Diff: http://git.reviewboard.kde.org/r/107357/diff/
> 
> 
> Testing
> ---
> 
> 
> Screenshots
> ---
> 
> QFormLayout and mime type icon
>   http://git.reviewboard.kde.org/r/107357/s/835/
> 
> 
> Thanks,
> 
> Thomas Fischer
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Settings separation: observer.h install and compilation correction on Windows

[Albert Astals Cid]

> On Nov. 1, 2012, 4:36 p.m., Albert Astals Cid wrote:
> > conf/settings.kcfgc, line 7
> > <http://git.reviewboard.kde.org/r/107047/diff/2/?file=92392#file92392line7>
> >
> > SettingsCore is part of libokularcore, so using OKULAR_EXPORT is fine, 
> > no?
> 
> Bogdan Cristea wrote:
> settings_core.h exposes methods found in okularcore library, while 
> settings.h exposes methods found in okularpart library. In Windows, when the 
> second library is build, settings_core.h should import its symbols, while 
> settings.h should export them. For Linux there is no problem since all 
> library symbols are exported by default.
> 
> Albert Astals Cid wrote:
> Oh sorry, this is for settings.kcfgc, not for settings_core.kcfgc
> 
> Still, we are not installing settings.h so can't we just drop the 
> visibility? I.e. other classes of the part like part.h have no visibility 
> definition, no?

Bogdan?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107047/#review21327
---


On Oct. 26, 2012, 7:57 a.m., Bogdan Cristea wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107047/
> ---
> 
> (Updated Oct. 26, 2012, 7:57 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> This patch is related to settings separation for the frontend and the 
> backend. It proposes the installation of core/observer.h and corrects 
> compilation of okular on Windows (using KDE on windows):
> - after separation, settings.h and settings_core.h need to use different 
> precompiler switches for exporting/importing symbols
> - add definitions needed to activate these switches on Windows
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 063778f 
>   active/components/CMakeLists.txt 19b759e 
>   conf/settings.kcfgc 5e2ec95 
>   okular_part_export.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107047/diff/
> 
> 
> Testing
> ---
> 
> yes
> 
> 
> Thanks,
> 
> Bogdan Cristea
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 164759] No GUI to configure the anti-aliasing vector graphics

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=164759

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/1d914e6bf547d173851582cb
   ||a53c5372d960b6ff

--- Comment #6 from Albert Astals Cid  ---
Git commit 1d914e6bf547d173851582cba53c5372d960b6ff by Albert Astals Cid, on
behalf of Jaydeep Solanki.
Committed on 31/12/2012 at 12:15.
Pushed by aacid into branch 'master'.

GUI to configure the Text/Graphics Anti-alias and Text hinting
REVIEW: 106660
GUI:

M  +31   -1conf/dlgperformancebase.ui
M  +3-3conf/okular_core.kcfg

http://commits.kde.org/okular/1d914e6bf547d173851582cba53c5372d960b6ff

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 164759] No GUI to configure the anti-aliasing vector graphics

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=164759

Albert Astals Cid  changed:

   What|Removed |Added

   Version Fixed In||4.11.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Add undo/redo support for annotations

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107442/#review24314
---



core/annotations.cpp
<http://git.reviewboard.kde.org/r/107442/#comment18665>

You don't need the if, delete 0 is a valid delete that does nothing



core/document.h
<http://git.reviewboard.kde.org/r/107442/#comment18664>

const & for the QStrings



core/document.h
<http://git.reviewboard.kde.org/r/107442/#comment18662>

const



core/document.h
<http://git.reviewboard.kde.org/r/107442/#comment18663>

const



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/107442/#comment18660>

If you change the .rc action names to edit_undo and edit_redo you won't 
need these addAction calls (see how it works for KStandardAction::Copy for 
example)


- Albert Astals Cid


On Dec. 31, 2012, 3:12 a.m., Jon Mease wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107442/
> ---
> 
> (Updated Dec. 31, 2012, 3:12 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> This patch is a first cut at adding undo/redo support to Okular.  This patch 
> is not yet complete, however it is far enough along that I would like to 
> begin incorporating feedback from the community.
> 
> Functionality:
> The following actions can be undone and redone: creation and removal of 
> annotations, editing arbitrary annotation properties, relocating annotations 
> with Ctrl+drag, and editing the text contents of an annotation.
> 
> This patch does not yet include support for undoing and redoing editing 
> actions on forms.  I plan to implement this form undo functionality before 
> the functionality of this patch is included in Okular.
> 
> Known Issue:
> When editing an annotation's properties in a .dvi file the annotation is 
> altered and the action can be undone as expected.  However, when editing an 
> annotation's properties in a .pdf file the image of the original annotation 
> is not removed from the document when the altered annotation appears.  I 
> would appreciate any possible leads on this issue.  
>   
> 
> 
> This addresses bug 177501.
> http://bugs.kde.org/show_bug.cgi?id=177501
> 
> 
> Diffs
> -
> 
>   core/annotations.h 72abdff 
>   core/annotations.cpp 49ab5bd 
>   core/document.h 1d825e1 
>   core/document.cpp 00e290d 
>   core/document_p.h 4a20561 
>   core/page.cpp 4df58e0 
>   generators/poppler/annots.cpp b7fb9f7 
>   part.rc 39c1571 
>   ui/annotationpropertiesdialog.cpp 4b02258 
>   ui/annotwindow.h f7df9f6 
>   ui/annotwindow.cpp c1bafb9 
>   ui/pageview.cpp 811a169 
> 
> Diff: http://git.reviewboard.kde.org/r/107442/diff/
> 
> 
> Testing
> ---
> 
> I have tested the undoing and redoing of the specified annotation actions 
> using .dvi and .pdf documents.  The only known issue is the one described 
> above when using .pdf files. 
> 
> 
> Thanks,
> 
> Jon Mease
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107994/#review24320
---


Does this actually work? I just gave it a try with the document attached to the 
bug and after doing the touch to the file, the reload happens and the TOC gets 
closed.

- Albert Astals Cid


On Dec. 30, 2012, 11:09 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107994/
> ---
> 
> (Updated Dec. 30, 2012, 11:09 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> This fix will preserve the state of the Table Of Content (toc) on document 
> reload, but if the toc is edited/changed, then it will be restored to default 
> (i.e. all nodes will be folded)
> 
> 
> This addresses bug 312138.
> http://bugs.kde.org/show_bug.cgi?id=312138
> 
> 
> Diffs
> -
> 
>   part.h 0c57560 
>   part.cpp 1922128 
>   ui/toc.h eeeff98 
>   ui/toc.cpp 4c84b62 
>   ui/tocmodel.h a857dc0 
>   ui/tocmodel.cpp 39add80 
> 
> Diff: http://git.reviewboard.kde.org/r/107994/diff/
> 
> 
> Testing
> ---
> 
> Checked. Works fine with me.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107994/#review24512
---



part.cpp
<http://git.reviewboard.kde.org/r/107994/#comment18816>

Do we really need this collapse here?


- Albert Astals Cid


On Dec. 31, 2012, 2 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107994/
> ---
> 
> (Updated Dec. 31, 2012, 2 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> This fix will preserve the state of the Table Of Content (toc) on document 
> reload, but if the toc is edited/changed, then it will be restored to default 
> (i.e. all nodes will be folded)
> 
> 
> This addresses bug 312138.
> http://bugs.kde.org/show_bug.cgi?id=312138
> 
> 
> Diffs
> -
> 
>   part.h 0c57560 
>   part.cpp 1922128 
>   ui/toc.h eeeff98 
>   ui/toc.cpp 4c84b62 
>   ui/tocmodel.h a857dc0 
>   ui/tocmodel.cpp 39add80 
> 
> Diff: http://git.reviewboard.kde.org/r/107994/diff/
> 
> 
> Testing
> ---
> 
> Checked. Works fine with me.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

[Albert Astals Cid]

> On Jan. 2, 2013, 9:46 p.m., Albert Astals Cid wrote:
> > part.cpp, line 1622
> > <http://git.reviewboard.kde.org/r/107994/diff/5/?file=103405#file103405line1622>
> >
> > Do we really need this collapse here?
> 
> Jaydeep Solanki wrote:
> yes I added that because suppose an "Open" tag attribute is there in the 
> toc on a specific node, so okular will expand that node, but if the user had 
> closed that node before reload then this will keep it closed after reload, 
> otherwise along with m_oldTocExpandedIndexes, that node will also get 
> expanded.

But have you tried that really works? Because the "Open" tag attribute will get 
executed after this code, so adding the collapse all won't do anything, no?
Which file you used to test that?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107994/#review24512
---


On Dec. 31, 2012, 2 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107994/
> ---
> 
> (Updated Dec. 31, 2012, 2 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> This fix will preserve the state of the Table Of Content (toc) on document 
> reload, but if the toc is edited/changed, then it will be restored to default 
> (i.e. all nodes will be folded)
> 
> 
> This addresses bug 312138.
> http://bugs.kde.org/show_bug.cgi?id=312138
> 
> 
> Diffs
> -
> 
>   part.h 0c57560 
>   part.cpp 1922128 
>   ui/toc.h eeeff98 
>   ui/toc.cpp 4c84b62 
>   ui/tocmodel.h a857dc0 
>   ui/tocmodel.cpp 39add80 
> 
> Diff: http://git.reviewboard.kde.org/r/107994/diff/
> 
> 
> Testing
> ---
> 
> Checked. Works fine with me.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

[Albert Astals Cid]

> On Jan. 2, 2013, 9:46 p.m., Albert Astals Cid wrote:
> > part.cpp, line 1622
> > <http://git.reviewboard.kde.org/r/107994/diff/5/?file=103405#file103405line1622>
> >
> > Do we really need this collapse here?
> 
> Jaydeep Solanki wrote:
> yes I added that because suppose an "Open" tag attribute is there in the 
> toc on a specific node, so okular will expand that node, but if the user had 
> closed that node before reload then this will keep it closed after reload, 
> otherwise along with m_oldTocExpandedIndexes, that node will also get 
> expanded.
> 
> Albert Astals Cid wrote:
> But have you tried that really works? Because the "Open" tag attribute 
> will get executed after this code, so adding the collapse all won't do 
> anything, no?
> Which file you used to test that?
> 
> Jaydeep Solanki wrote:
> No the "Open" tag will get executed before this code.
> TOCModel::fill(..) expands the nodes with the open tags, which will 
> obviously get called first because without filling the new model, how can it 
> be compared with the old one.
> 
>

TOCModel::fill calls expand with Qt::QueuedConnection meaning it will not get 
executed *until* the event loop comes back, so unless you can prove it works 
(again, have you tried it) I am thinking it is executed afterwards


- Albert


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107994/#review24512
---


On Dec. 31, 2012, 2 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107994/
> ---
> 
> (Updated Dec. 31, 2012, 2 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> This fix will preserve the state of the Table Of Content (toc) on document 
> reload, but if the toc is edited/changed, then it will be restored to default 
> (i.e. all nodes will be folded)
> 
> 
> This addresses bug 312138.
> http://bugs.kde.org/show_bug.cgi?id=312138
> 
> 
> Diffs
> -
> 
>   part.h 0c57560 
>   part.cpp 1922128 
>   ui/toc.h eeeff98 
>   ui/toc.cpp 4c84b62 
>   ui/tocmodel.h a857dc0 
>   ui/tocmodel.cpp 39add80 
> 
> Diff: http://git.reviewboard.kde.org/r/107994/diff/
> 
> 
> Testing
> ---
> 
> Checked. Works fine with me.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Don't show in GNOME menus

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108105/#review24544
---


Good joke!

- Albert Astals Cid


On Jan. 3, 2013, 5:45 a.m., Jeremy Bicha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108105/
> ---
> 
> (Updated Jan. 3, 2013, 5:45 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> GNOME uses Evince
> 
> 
> Diffs
> -
> 
>   shell/okular.desktop 56ddee4afec4f5145c2d70bdb76fa40f5d5319d2 
> 
> Diff: http://git.reviewboard.kde.org/r/108105/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jeremy Bicha
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

[Albert Astals Cid]

> On Jan. 2, 2013, 9:46 p.m., Albert Astals Cid wrote:
> > part.cpp, line 1622
> > <http://git.reviewboard.kde.org/r/107994/diff/5/?file=103405#file103405line1622>
> >
> > Do we really need this collapse here?
> 
> Jaydeep Solanki wrote:
> yes I added that because suppose an "Open" tag attribute is there in the 
> toc on a specific node, so okular will expand that node, but if the user had 
> closed that node before reload then this will keep it closed after reload, 
> otherwise along with m_oldTocExpandedIndexes, that node will also get 
> expanded.
> 
> Albert Astals Cid wrote:
> But have you tried that really works? Because the "Open" tag attribute 
> will get executed after this code, so adding the collapse all won't do 
> anything, no?
> Which file you used to test that?
> 
> Jaydeep Solanki wrote:
> No the "Open" tag will get executed before this code.
> TOCModel::fill(..) expands the nodes with the open tags, which will 
> obviously get called first because without filling the new model, how can it 
> be compared with the old one.
> 
>
> 
> Albert Astals Cid wrote:
> TOCModel::fill calls expand with Qt::QueuedConnection meaning it will not 
> get executed *until* the event loop comes back, so unless you can prove it 
> works (again, have you tried it) I am thinking it is executed afterwards
> 
> Jaydeep Solanki wrote:
> yes, you are correct, it get's executed afterwards, here's the link to 
> the file I used to test http://goo.gl/BtfBX
> 
> So what do you suggest, because this can be really annoying that a user 
> closes everything & then when he reloads, everything explodes out !!

Try moving the members that we "remember" that we are reopening the document to 
toc or tocmodel, this way you may have enough information in ::fill to know it 
is indeed the same TOC and that you don't need to call the expand notes for the 
ones marked as "Open".

Am i making any sense?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107994/#review24512
---


On Dec. 31, 2012, 2 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107994/
> ---
> 
> (Updated Dec. 31, 2012, 2 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> This fix will preserve the state of the Table Of Content (toc) on document 
> reload, but if the toc is edited/changed, then it will be restored to default 
> (i.e. all nodes will be folded)
> 
> 
> This addresses bug 312138.
> http://bugs.kde.org/show_bug.cgi?id=312138
> 
> 
> Diffs
> -
> 
>   part.h 0c57560 
>   part.cpp 1922128 
>   ui/toc.h eeeff98 
>   ui/toc.cpp 4c84b62 
>   ui/tocmodel.h a857dc0 
>   ui/tocmodel.cpp 39add80 
> 
> Diff: http://git.reviewboard.kde.org/r/107994/diff/
> 
> 
> Testing
> ---
> 
> Checked. Works fine with me.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 312681] pdf files generated from google-chrome are not opened

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312681

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Albert Astals Cid  ---
Works like a charm here, which poppler version do you have? Which error do you
get?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Bug 312681] pdf files generated from google-chrome are not opened

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312681

--- Comment #4 from Albert Astals Cid  ---
attach gdb and give us a backtrace?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 312771] When zooming in using Ctrl+Mousewheel zoom in to the cursor position

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312771

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |DUPLICATE

--- Comment #1 from Albert Astals Cid  ---


*** This bug has been marked as a duplicate of bug 159408 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 159408] centre-point for zooming of pdf files (via +) should be in zone of the mouse-cursor

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=159408

Albert Astals Cid  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #3 from Albert Astals Cid  ---
*** Bug 312771 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 259001] printing particular pdf document with shadow characters

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=259001

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #4 from Albert Astals Cid  ---
4 months and no answer, closing as invalid.

If you can still reproduce please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 281855] Incorrect printing

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=281855

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #4 from Albert Astals Cid  ---
4 months and no answer, closing as invalid.

If you can still reproduce please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 285175] Okular crash when opening and printing a file

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=285175

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #3 from Albert Astals Cid  ---
4 months and no answer, closing as invalid.

If you can still reproduce please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 251813] Just keep scrolling

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=251813

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #8 from Albert Astals Cid  ---
4 months and no answer, closing as invalid.

If you can still reproduce please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 235560] pressed downarrow from my keyboard -> crash

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=235560

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #3 from Albert Astals Cid  ---
4 months and no answer, closing as invalid.

If you can still reproduce please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 267035] Okular Crashes while scrolling

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=267035

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #4 from Albert Astals Cid  ---
4 months and no answer, closing as invalid.

If you can still reproduce please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 305761] okular and strigi aren't actually optional

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=305761

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |INVALID

--- Comment #4 from Albert Astals Cid  ---
4 months and no answer, closing as invalid.

If you can still reproduce please reopen the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 312782] Okular crashes when opening a specific pdf in norwegian.

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312782

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |UPSTREAM

--- Comment #1 from Albert Astals Cid  ---
Hi Bjørn, the crash happens in poppler, the library that Okular uses to deal
with PDF files. The crash is fixed if you upgrade to poppler >= 0.20.5 (i
understand you are using 0.20.4 as provided by Ubuntu 12.10)

Even with poppler >= 0.20.5 we do not crash but don't render anything at all
since the PDF file is severely broken, none of the PDF renderers i have around
does much with it (Adobe Reader on Linux hangs while trying to render it)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 312826] PDF printed truncated

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312826

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |FIXED

--- Comment #2 from Albert Astals Cid  ---
I am not sure i understand the problem here.

Are you saying that if you get the pdf you attached to this bug and print it
(to paper or to pdf?) the "lundi 07 janvier 2013" line on the bottom of page 1
disappears?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 312826] PDF printed truncated

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312826

Albert Astals Cid  changed:

   What|Removed |Added

Version|unspecified |0.15.4

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 312826] PDF printed truncated

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312826

--- Comment #5 from Albert Astals Cid  ---
>From which PDF file does
http://imageshack.us/a/img16/2690/img20130107181230.jpg come from?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 312826] PDF printed truncated

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312826

Albert Astals Cid  changed:

   What|Removed |Added

 Resolution|FIXED   |WAITINGFORINFO

--- Comment #7 from Albert Astals Cid  ---
Interesting so you say that printing the same PDF file with different margins
(changing the margins in the properties page of the Okular printing dialog)
give you the broken and the working printouts?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request: Unfolded toc remains unfolded on reload unless the file is changed

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107994/#review25011
---



ui/tocmodel.cpp
<http://git.reviewboard.kde.org/r/107994/#comment19165>

Not sure i agree with the "isEmpty()" part. In the pdf with "Open" nodes if 
you close them all and then trigger a reload, it opens them again becasue of 
this isEmpty(), while i think it should keep them all closed. What do you think?


- Albert Astals Cid


On Jan. 7, 2013, 11:10 a.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107994/
> ---
> 
> (Updated Jan. 7, 2013, 11:10 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> This fix will preserve the state of the Table Of Content (toc) on document 
> reload, but if the toc is edited/changed, then it will be restored to default 
> (i.e. all nodes will be folded)
> 
> 
> This addresses bug 312138.
> http://bugs.kde.org/show_bug.cgi?id=312138
> 
> 
> Diffs
> -
> 
>   part.cpp 1922128 
>   ui/toc.h eeeff98 
>   ui/toc.cpp 4c84b62 
>   ui/tocmodel.h a857dc0 
>   ui/tocmodel.cpp 39add80 
> 
> Diff: http://git.reviewboard.kde.org/r/107994/diff/
> 
> 
> Testing
> ---
> 
> Checked. Works fine with me.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 312826] PDF printed truncated

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312826

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |UNCONFIRMED
 Resolution|WAITINGFORINFO  |---

--- Comment #9 from Albert Astals Cid  ---
I'm not sure there's much we can do here, it seems your printer gets confused
with small printer margings. I'm setting this bug back to unconfirmed from
needsinfo since i got all the info i needed but i'm unsure this is our bug.

Sorry i can't be of much more help and thanks for caring about Okular and
reporting this bug, also glad that you can print the document with the default
margins.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 312138] Unfolded table of contents folds in upon reloading of document

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312138

Albert Astals Cid  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/7c99477f9466f5c716499119
   ||5236cdb12d0edba8

--- Comment #5 from Albert Astals Cid  ---
Git commit 7c99477f9466f5c7164991195236cdb12d0edba8 by Albert Astals Cid, on
behalf of Jaydeep Solanki.
Committed on 09/01/2013 at 23:31.
Pushed by aacid into branch 'master'.

Preserve TOC folding status on document dirty reload

REVIEW: 107994

M  +3-0part.cpp
M  +26   -0ui/toc.cpp
M  +5-0ui/toc.h
M  +79   -7ui/tocmodel.cpp
M  +4-0ui/tocmodel.h

http://commits.kde.org/okular/7c99477f9466f5c7164991195236cdb12d0edba8

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 312138] Unfolded table of contents folds in upon reloading of document

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=312138

Albert Astals Cid  changed:

   What|Removed |Added

   Version Fixed In||4.11

--- Comment #6 from Albert Astals Cid  ---
Jaydeep has implemented the basic functionality, i.e. if the toc is exactly the
same, the shape is preserved, otherwise you loose it. If you want something
more advanced feel free to open a new bug

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313041] Cannot print using distant cups server

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313041

Albert Astals Cid  changed:

   What|Removed |Added

 Status|CONFIRMED   |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Albert Astals Cid  ---
Have you actually read the detailed error? And if you have could you say if you
have lpr installed? Because to me that seems kind of important if i read that
detailed error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313041] Cannot print using distant cups server

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313041

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |UNCONFIRMED
 Resolution|WAITINGFORINFO  |---
 Ever confirmed|1   |0

--- Comment #3 from Albert Astals Cid  ---
Okular does not work like most of KDE apps for printing, Okular has [almost]
always needed lpr or lp to be installed for printing to work. 

I have no clue if lpr can be used to print on a distant server or not. If it
can, well it's archs fault for not allowing you to install lpr without the
cupsdaemon, if it can not, you are welcome to make Okular print without lpr.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 107994: Unfolded toc remains unfolded on reload unless the file is changed

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107994/#review25408
---


Can you explain why the code is added? Because obviously the current 
description and summary are wrong, and this shows you should not have reused 
this review request and should have created a new one instead.

- Albert Astals Cid


On Jan. 13, 2013, 3:12 a.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107994/
> ---
> 
> (Updated Jan. 13, 2013, 3:12 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> This fix will preserve the state of the Table Of Content (toc) on document 
> reload, but if the toc is edited/changed, then it will be restored to default 
> (i.e. all nodes will be folded)
> 
> 
> This addresses bugs 312138, 313146 and 313147.
> http://bugs.kde.org/show_bug.cgi?id=312138
> http://bugs.kde.org/show_bug.cgi?id=313146
> http://bugs.kde.org/show_bug.cgi?id=313147
> 
> 
> Diffs
> -
> 
>   ui/toc.cpp c1659bd 
>   ui/tocmodel.h 42d6533 
>   ui/tocmodel.cpp 214a218 
> 
> Diff: http://git.reviewboard.kde.org/r/107994/diff/
> 
> 
> Testing
> ---
> 
> Checked. Works fine with me.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313177] regression: post it (annotation) is rotated on pdfs with landscape

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313177

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Albert Astals Cid  ---
Please attach the pdf file you are using to reproduce the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313066] Okular crashed trying to print a "file to pdf"

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313066

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |UPSTREAM

--- Comment #1 from Albert Astals Cid  ---
The top part of the backtrace

#7 0x7f200c460566 in QFactoryLoader::instance (this=,
key=...) at plugin/qfactoryloader.cpp:276
#8 0x7f200cf1ad32 in QIcon::addFile (this=0x59548b8, fileName=...,
size=..., mode=QIcon::Normal, state=QIcon::Off) at image/qicon.cpp:843 

is the same than described at https://bugs.kde.org/show_bug.cgi?id=298091 and
in it the ?? point to libdbusmenu-qt.so.2 ( that is
https://launchpad.net/libdbusmenu-qt )

That code is outside the scope of Okular. I'd suggest you to go there and file
a bug about it, but if you don't really have a way to reproduce the crash it's
going to be very hard that anyone actually can fix anything.

Sorry that my answer is not that much satisfactory and thanks a lot for caring
about Okular and reporting this bug :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313146] Crash when I close Okular after reloading a document without table of contents

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313146

Albert Astals Cid  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/0413d538574202034b04e072
   ||60702c5e49afe64e

--- Comment #1 from Albert Astals Cid  ---
Git commit 0413d538574202034b04e07260702c5e49afe64e by Albert Astals Cid.
Committed on 15/01/2013 at 01:16.
Pushed by aacid into branch 'master'.

Delete the oldModel even if the new doc has no toc

M  +0-8ui/toc.cpp
M  +5-1ui/tocmodel.cpp

http://commits.kde.org/okular/0413d538574202034b04e07260702c5e49afe64e

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313147] Table of contents gets cleared during reload (and after reload too, if cancelled by user)

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313147

Albert Astals Cid  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/4fefc60e3518887c5e5b4b7b
   ||1a435545480e55c0

--- Comment #2 from Albert Astals Cid  ---
Git commit 4fefc60e3518887c5e5b4b7b1a435545480e55c0 by Albert Astals Cid.
Committed on 15/01/2013 at 01:17.
Pushed by aacid into branch 'master'.

Do not prepare the toc for reload until we are really reloading

M  +8-3part.cpp

http://commits.kde.org/okular/4fefc60e3518887c5e5b4b7b1a435545480e55c0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 311037] Okular Crashs

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=311037

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #4 from Albert Astals Cid  ---
Can you reproduce the crash all the time? Do you have annotations in the file?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Feature - Open url in browser

[Albert Astals Cid]

El Dimarts, 15 de gener de 2013, a les 06:02:22, Jaydeep Solanki va escriure:
> Hi,
> I would like to implement a feature (Bug
> 281027)
> where the mouse pointer changes to pointing_hand when hovered over a url.
> 
> I guess we have two options:
> i ) during the load time of the document fill in the url info, just like
> SourceReferences.
> ii ) when the mouse is hovered over a some text, check if it's an url, &
> change the mouse cursor

Option 3, do it on right click after text is selected

> Which one do you thing would be better ?

The one that involves less code to maintain but is still usable enough, which 
one of those it is, not sure :D

Maybe you can give a quick try to implement both 1 and 2 (3 seems similar 
enought to 2 in complexity) so you get a feeling of which one will be more 
complex?

Cheers,
  Albert

> 
> Open for suggestions.
> 
> -Jaydeep
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Is there any possibility to have okular run on android?

[Albert Astals Cid]

El Dijous, 17 de gener de 2013, a les 19:21:20, Cloud Han va escriure:
> Will it be a official port? Is it possible to port this powerful tool to
> android? 

It is possible, but it will be hard, you need to get kdelibs running on 
android and then make a different interface since the default one is not touch 
oriented (or use the active one, that'd probably be fine)

kdelibs is "kind of" running in Android since Aleix got KAlgebra running on it 
http://www.proli.net/2012/04/24/kalgebra-on-android/ 

> If I want to that, what basic skill should I have and how can I do
> it ?

You need lots of skills :D It's not a typical newbie job, but if you are 
interested go for it. I'd start getting necessitas (qt on android) and then 
try to get some simple program using kdelibs and then try to run the Okular or 
Okular-active on android

Good luck :-)

Cheers,
  Albert
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] TOC Reload

[Albert Astals Cid]

--- El vie, 18/1/13, Jaydeep Solanki  escribió:
> Hi,
> can you please confirm if the toc reload is working, because it's not
> working with me.

Yes, I broke it, I'll fix it up later, sorry a lot for the huge mistake :-/

Cheers,
  Albert

> Jaydeep


___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] TOC Reload

[Albert Astals Cid]

> --- El vie, 18/1/13, Albert Astals Cid  escribió:
> 
> --- El vie, 18/1/13, Jaydeep Solanki  escribió:
> > Hi,
> > can you please confirm if the toc reload is working, because it's not
> > working with me.
> 
> Yes, I broke it, I'll fix it up later, sorry a lot for the huge mistake 
> :-/

Should be fixed now, could you give it a try?

Thanks,
  Albert

> 
> Cheers,
>   Albert
> 
> > Jaydeep
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Added a few tests

[Albert Astals Cid]

I just added a few unittests to test stuff like the TOC reload to make sure we 
don't break it again.

It'd be cool if next time you work on a bugfix or feature try to add a 
unittest (yes i know it's hard)

Cheers,
  Albert
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 311037] Okular Crashs

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=311037

--- Comment #6 from Albert Astals Cid  ---
Can you reproduce the crash every time? What do you do exactly to make it
crash?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 311037] Okular Crashs

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=311037

--- Comment #8 from Albert Astals Cid  ---
Hmmm, works for me. Could you please do this:
 * Open a terminal
 * Run 
   valgrind okular
(you may need to install valgrind from your distribution repositories)
 * Reproduce the crash (or what you do when you make it crash) and attach to
this bug the output of the "valgrind okular" command

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313601] Okular displays blank pages in Print Preview, blank pages on printer (print failure without crash)

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313601

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Albert Astals Cid  ---
Which poppler version do you have installed?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313700] Okular can't read synctex files from utf8(non-ascii) directories

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313700

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #1 from Albert Astals Cid  ---
Can you please exactly say how step 2 is done?
Also a sample document for trying would help :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313700] Okular can't read synctex files from utf8(non-ascii) directories

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313700

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||4.10.0
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/00cbba3ecec708cb147e9901
   ||12bb3074778eca65

--- Comment #4 from Albert Astals Cid  ---
Git commit 00cbba3ecec708cb147e990112bb3074778eca65 by Albert Astals Cid.
Committed on 23/01/2013 at 00:02.
Pushed by aacid into branch 'KDE/4.10'.

Propertly encode the filename
FIXED-IN: 4.10.0

M  +1-1generators/poppler/generator_pdf.cpp

http://commits.kde.org/okular/00cbba3ecec708cb147e990112bb3074778eca65

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313775] Okular inverse search does not work.

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313775

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #1 from Albert Astals Cid  ---
Works fine here, are you sure you are in the browse mode and not in the text
selection mode?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313845] PDF exported from Inkscape shows a blank page

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313845

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |INVALID

--- Comment #2 from Albert Astals Cid  ---
Shows fine here, though it takes a bit too much to display (How much time have
you waited?).

Anyway we don't handle rendering of pdf files directly, it is done through the
poppler library. If you feel like it is too slow please open a but against
poppler at https://bugs.freedesktop.org/

Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313845] PDF exported from Inkscape shows a blank page

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313845

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |INVALID

--- Comment #5 from Albert Astals Cid  ---
I'm the okular maintaner, you are not, trust me, i know what I’m speaking
about.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Option for exporting annotations

[Albert Astals Cid]

El Dissabte, 26 de gener de 2013, a les 16:00:33, Bogdan Cristea va escriure:
> Hi
> 
> Is there an option allowing to export the annotations from a PDF file ? I
> need to provide reviews for some articles so I need to export as text only
> the annotations (with the page number if possible).

No, there's no text export option for annotations, you can probably look at 
the xml file and do some stuff to get the data though.

Cheers,
  Albert

> 
> regards
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313984] Okular crashed after changing the colour of some highlighted text

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313984

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Albert Astals Cid  ---
I can not reproduce this.

Can you please install the fedora rpm packages with debug symbols for kdelibs
and for qt? And then try again? It should give us a better crash backtrace.

Also try running from the terminal to see if anything special is printed there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313986] various lines are displayed at one line

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313986

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Albert Astals Cid  ---
Please attach a file to reproduce this problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 108614: Open url in browser

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108614/#review26271
---



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/108614/#comment20004>

Would this detect 

hellohttp://foo.comlala

As a link?

Also did you create the regex yourself or it comes from somewhere?



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/108614/#comment20001>

declare the url as const



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/108614/#comment20002>

comparing a QString against 0 is bad



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/108614/#comment20003>

Why did you decide that icon name?



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/108614/#comment20005>

I'd prefer if you used "new KRun(url)" here, it's supposed to be more KDE 
integrated


- Albert Astals Cid


On Jan. 27, 2013, 2:25 p.m., Jaydeep Solanki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108614/
> ---
> 
> (Updated Jan. 27, 2013, 2:25 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> When selected text is right clicked, it checks for a url, if found, a QAction 
> is added to open the url in the default browser.
> 
> 
> This addresses bug 281027.
> http://bugs.kde.org/show_bug.cgi?id=281027
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp 60a273d 
> 
> Diff: http://git.reviewboard.kde.org/r/108614/diff/
> 
> 
> Testing
> ---
> 
> just check if the icon appears properly, because I have an issue with the 
> icon.
> 
> 
> Thanks,
> 
> Jaydeep Solanki
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313984] Okular crashed after changing the colour of some highlighted text

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313984

--- Comment #6 from Albert Astals Cid  ---
This is interesting but still doesn't give me enough info.

Could you try this? Install valgrind if you don't have it installed and run

valgrind okular

in a terminal, it will run very slowly. Then do whatever you do to make okular
crash and paste here the output of the valgrind command.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313984] Okular crashed after changing the colour of some highlighted text

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313984

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |CONFIRMED
 Resolution|WAITINGFORINFO  |---
 Ever confirmed|0   |1

--- Comment #9 from Albert Astals Cid  ---
Ok, i can reproduce now, thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313601] Okular displays blank pages in Print Preview, blank pages on printer (print failure without crash)

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313601

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 Resolution|WAITINGFORINFO  |WORKSFORME

--- Comment #4 from Albert Astals Cid  ---
Works fine for me in 0.20.4, please reopen the bug if you still can reproduce
after updating to a newer version.

Thanks for caring about Okular :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 314128] Cannot open PDF with Formular

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=314128

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||aa...@kde.org
 Resolution|--- |UPSTREAM

--- Comment #1 from Albert Astals Cid  ---
https://bugs.freedesktop.org/show_bug.cgi?id=14265

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Okular 0.15.4: Default save location

[Albert Astals Cid]

El Dimecres, 30 de gener de 2013, a les 18:42:25, Marius Hofert va escriure:
> Hi,
> 
> I use Okular 0.15.4 on Ubuntu 12.10. I use "review" mode a lot for
> annotating .pdf files. When choosing to save the changes (File -> Save
> As...), the folder where I last saved to is suggested. This is quite often
> not what I want. I suggest to change it to the folder the currently opened
> file resides (or at least to provide a setting to choose this folder).

Do you have any study on the fact that your suggestion is a better solution?

Cheers,
  Albert

> 
> Cheers,
> 
> Marius
> ___
> Okular-devel mailing list
> Okular-devel@kde.org
> https://mail.kde.org/mailman/listinfo/okular-devel
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 314153] selection of rotated text results in reversed order

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=314153

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||aa...@kde.org
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Albert Astals Cid  ---
1) is not an easy step to reproduce. Please provide an URL or even better
attach a file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Error when loading pdf document with latest sources from master

[Albert Astals Cid]

El Diumenge, 3 de febrer de 2013, a les 21:50:26, Bogdan Cristea va escriure:
> The loaded document has a black background and I get the following error in
> terminal:
> Clash for annotations with ID: 0
> 
> The pdf is generated with Google-Chrome by printing to file a web page.

I think you forgot to attach the file or give the url.

Cheers,
  Albert
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] How to "fix" review/annotation setting?

[Albert Astals Cid]

El Divendres, 1 de febrer de 2013, a les 00:07:22, Marius Hofert va escriure:
> > El Dijous, 1 de novembre de 2012, a les 22:38:31, Marius Hofert va 
escriure:
> > > Hi,
> > > 
> > > I am a very happy Okular 0.15.2 user (KDE 4.9.2; under Ubuntu 12.10). I
> > > recently started using the "review" option for annotations. I typically
> > > mostly use the black underlining (press 8). It is quite annoying having
> > > to
> > > activate (by pressing 8) the underlining tool with each sentence one has
> > > to
> > > underline.
> > 
> > Double click on it.
> > 
> > Cheers,
> > 
> >   Albert
> 
> Hi Albert,
> 
> Well, that's certainly not satisfying, pressing a key is by far faster than
> using the mouse. Also, you'd have to move the mouse back for creating the
> next annotation. And this with every piece of annotation you create...
> 
> Programmatically, I don't see any reason not to adopt my suggestion and
> create a setting which switches on a certain review (like "underlining")
> until it is switched off (the button hit again, for example). This is
> "standard" in any kind of software I am aware of (take, for example, gimp
> and select a drawing tool... you wouldn't like having to select the brush
> with any line you draw, right?)

You are not drawing.

I would not object to a patch where double pressing 8 does the same as double 
clicking on the tool.

Cheers,
  Albert

> 
> Cheers,
> 
> Marius
> 
> > > I was wondering if it is possible to activate it via 8, but then keep it
> > > fixed for further underlining operations. By pressing a different tool
> > > (such as '4' for yellow highlighting, it could then be deactivated.
> > > 
> > > Cheers,
> > > 
> > > Marius
> 
> ___
> Okular-devel mailing list
> Okular-devel@kde.org
> https://mail.kde.org/mailman/listinfo/okular-devel
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] regarding bug 281027

[Albert Astals Cid]

El Dijous, 31 de gener de 2013, a les 17:44:24, Jaydeep Solanki va escriure:
> Hi Albert,
> I'm sorry to say, but my exams are approaching so will it be okay if I
> delay the fix a bit ??

No worries, that is not a bug but a feature so can only go out with 4.11 in 6 
months, so no hurry :-)

Cheers,
  Albert

> 
> Regards,
> Jaydeep
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 314456] Crash while opening a .chm file.

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=314456

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #1 from Albert Astals Cid  ---
Your report looks confusing, first you seem to complain that it does not open
properly when using the notifications thingie (which would not be an okular
bug) but then you attach a crash report.

What does one thing have to do with the other?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Error when loading pdf document with latest sources from master

[Albert Astals Cid]

El Dilluns, 4 de febrer de 2013, a les 21:57:51, Bogdan Cristea va escriure:
> It should work with any pdf file generated with Google Chrome.

Works fine here, which poppler version are you using?

Cheers,
  Albert

> 
> On Mon, Feb 4, 2013 at 8:33 PM, Albert Astals Cid  wrote:
> > El Diumenge, 3 de febrer de 2013, a les 21:50:26, Bogdan Cristea va
> > 
> > escriure:
> > > The loaded document has a black background and I get the following error
> > 
> > in
> > 
> > > terminal:
> > > Clash for annotations with ID: 0
> > > 
> > > The pdf is generated with Google-Chrome by printing to file a web page.
> > 
> > I think you forgot to attach the file or give the url.
> > 
> > Cheers,
> > 
> >   Albert
> > 
> > ___
> > Okular-devel mailing list
> > Okular-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/okular-devel
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 314153] selection of rotated text results in reversed order

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=314153

Albert Astals Cid  changed:

   What|Removed |Added

 Status|NEEDSINFO   |CONFIRMED
 Resolution|WAITINGFORINFO  |---
 Ever confirmed|0   |1

--- Comment #3 from Albert Astals Cid  ---
Right, not easy to fix though, don't hold your breath on this one,

Sorry about that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] subscribe + want to Contribute

[Albert Astals Cid]

El Dilluns, 4 de febrer de 2013, a les 13:26:14, Yash Shah va escriure:
> Hi Sir,

Hi

>  I am 2nd year B.Tech Student from DA-IICT, India. I am very new to
> KDE organisation and searched couple of projects under active
> development. I found Okular interesting to me. I want to get started on
> this project. please help me.

To be honest at the moment i can't think of any "real newbie" tasks, but there 
are millions of bugs and wish reports in bugzilla, feel free to have a look at 
them and take any you want.

You may also find us at the #okular channel at irc.freenode.net IRC server.

Welcome!

Cheers,
  Albert

> Thank you,
> Yash Shah
> 
> ___
> Okular-devel mailing list
> Okular-devel@kde.org
> https://mail.kde.org/mailman/listinfo/okular-devel
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 289468] PDF Form entry not displaying

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=289468

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #4 from Albert Astals Cid  ---
I don't see any "Books Books Books" if i open the file in acrobat reader, can
you please post a screenshot?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 314251] Keybindings for notes don't work after closing the search bar

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=314251

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||aa...@kde.org
 Ever confirmed|0   |1

--- Comment #1 from Albert Astals Cid  ---
Note, you have to close it pressing the [x], doing CTRL+F doesn't reproduce the
problem

That's because closing the bar gives the focus to the page number edit field,
so pressing 1 is actually writing an 1 in there, just press tab a few times (or
even better shift+tab once) to get the focus back to the listview.

I agree that it makes more sense that the focus goes back to the listview
instead that at the pagenumber edit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 314251] Keybindings for notes don't work after closing the search bar

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=314251

Albert Astals Cid  changed:

   What|Removed |Added

   Keywords||junior-jobs
   Severity|normal  |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] subscribe + want to Contribute

[Albert Astals Cid]

El Dimarts, 5 de febrer de 2013, a les 20:53:31, Albert Astals Cid va 
escriure:
> El Dilluns, 4 de febrer de 2013, a les 13:26:14, Yash Shah va escriure:
> > Hi Sir,
> 
> Hi
> 
> >  I am 2nd year B.Tech Student from DA-IICT, India. I am very new to
> > 
> > KDE organisation and searched couple of projects under active
> > development. I found Okular interesting to me. I want to get started on
> > this project. please help me.
> 
> To be honest at the moment i can't think of any "real newbie" tasks, but
> there are millions of bugs and wish reports in bugzilla, feel free to have
> a look at them and take any you want.

Actually, do you think you could have a look at 
https://bugs.kde.org/show_bug.cgi?id=314251 ?

Cheers,
  Albert

> 
> You may also find us at the #okular channel at irc.freenode.net IRC server.
> 
> Welcome!
> 
> Cheers,
>   Albert
> 
> > Thank you,
> > Yash Shah
> > 
> > ___
> > Okular-devel mailing list
> > Okular-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/okular-devel
> 
> ___
> Okular-devel mailing list
> Okular-devel@kde.org
> https://mail.kde.org/mailman/listinfo/okular-devel
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 314076] Open pdf, read, quit okular

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=314076

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #1 from Albert Astals Cid  ---
Hi, when you say "opened several okular ( ~8 to 10 ) then start to close one
after zoom in zoom out." what do you mean exactly, how do you open the several
okular?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 314536] Okular crashes when trying to open one PDF file

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=314536

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #2 from Albert Astals Cid  ---
With no document this is very hard to fix.

Which poppler version are you using?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Error when loading pdf document with latest sources from master

[Albert Astals Cid]

El Dimecres, 6 de febrer de 2013, a les 09:31:32, Bogdan Cristea va escriure:
> libpoppler version 0.18.0-2.6.1 x86_64 from openSUSE 12.2 repository

That's ultra old, is there any change you can try with something newer?

Albert

> 
> On Tue, Feb 5, 2013 at 8:09 PM, Albert Astals Cid  wrote:
> > El Dilluns, 4 de febrer de 2013, a les 21:57:51, Bogdan Cristea va
> > 
> > escriure:
> > > It should work with any pdf file generated with Google Chrome.
> > 
> > Works fine here, which poppler version are you using?
> > 
> > Cheers,
> > 
> >   Albert
> >   
> > > On Mon, Feb 4, 2013 at 8:33 PM, Albert Astals Cid  wrote:
> > > > El Diumenge, 3 de febrer de 2013, a les 21:50:26, Bogdan Cristea va
> > > > 
> > > > escriure:
> > > > > The loaded document has a black background and I get the following
> > 
> > error
> > 
> > > > in
> > > > 
> > > > > terminal:
> > > > > Clash for annotations with ID: 0
> > > > > 
> > > > > The pdf is generated with Google-Chrome by printing to file a web
> > 
> > page.
> > 
> > > > I think you forgot to attach the file or give the url.
> > > > 
> > > > Cheers,
> > > > 
> > > >   Albert
> > > > 
> > > > ___
> > > > Okular-devel mailing list
> > > > Okular-devel@kde.org
> > > > https://mail.kde.org/mailman/listinfo/okular-devel
> > 
> > ___
> > Okular-devel mailing list
> > Okular-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/okular-devel
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 314536] Okular crashes when trying to open one PDF file

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=314536

--- Comment #4 from Albert Astals Cid  ---
Well, as said without the pdf fixing the crash is very hard. How you make it
available it's up to you i guess.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 313984] Okular crashed after changing the colour of some highlighted text

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=313984

Albert Astals Cid  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
   Version Fixed In||4.10.1
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/kdel
   ||ibs/f3f6b9c7d533c3c03ceb47b
   ||9de753c74c4e082b9

--- Comment #10 from Albert Astals Cid  ---
Git commit f3f6b9c7d533c3c03ceb47b9de753c74c4e082b9 by Albert Astals Cid.
Committed on 07/02/2013 at 00:08.
Pushed by aacid into branch 'KDE/4.10'.

Fix two bugs in kcolorbutton+tests

Selecting+cancel does not really cancel
Selecting in recent colors crashes
REVIEW: 108637
FIXED-IN: 4.10.1

M  +1-2kdeui/colors/kcolorbutton.cpp
M  +1-0kdeui/tests/CMakeLists.txt
A  +119  -0kdeui/tests/kcolorbuttontest.cpp [License: LGPL (v2+)]
A  +40   -0kdeui/tests/kcolorbuttontest.h [License: LGPL (v2+)]

http://commits.kde.org/kdelibs/f3f6b9c7d533c3c03ceb47b9de753c74c4e082b9

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel