D10313: Option to exit after printing

dileepsankhla created this revision. dileepsankhla added a reviewer: aacid. dileepsankhla added a project: Okular. dileepsankhla requested review of this revision. REVISION SUMMARY When running okular with the parameter --print to directly open the print mode, it doesn't exit after

D10249: Option to exit after printing

dileepsankhla added a comment. @ngraham Can you please review my patch? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10249 To: dileepsankhla, aacid, #okular, ngraham Cc: ngraham, aacid, #okular, michaelweghorn

D10249: Option to exit after printing

dileepsankhla updated this revision to Diff 26453. dileepsankhla added a comment. - # Enter a commit message. 1. Updating https://phabricator.kde.org/D10249: Option to exit after printing # 2. Enter a brief description of the changes included in this update. 3. The first line is used

D10249: Option to exit after printing

dileepsankhla added a comment. @aacid Agree that only one exit call is required but what about the exit status - EXIT_SUCCESS or EXIT_FAILURE? The issue description talked about the command line batch processing. For that purpose, should I set a bool "isError" when failing condition is

D10249: Option to exit after printing

dileepsankhla added a reviewer: ngraham. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10249 To: dileepsankhla, aacid, #okular, ngraham Cc: ngraham, aacid, #okular, michaelweghorn

D10249: Option to exit after printing

dileepsankhla edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10249 To: dileepsankhla, aacid, #okular Cc: ngraham, aacid, #okular, michaelweghorn

D10249: Option to exit after printing

dileepsankhla added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10249 To: dileepsankhla, aacid, #okular Cc: ngraham, aacid, #okular, michaelweghorn

D10249: Option to exit after printing

dileepsankhla created this revision. dileepsankhla added a reviewer: aacid. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. dileepsankhla requested review of this revision. REVISION SUMMARY When running okular with the parameter --print to

[okular] [Bug 318998] Add option to exit after printing

https://bugs.kde.org/show_bug.cgi?id=318998 --- Comment #25 from Dileep Sankhla <sankhla.dilee...@gmail.com> --- Thank you. One more thing, should it opens the print dialog and then exit on printing or should it be non-GUI that simply prints and exits? If the latter case, should it

Need enlightenment on bug 318998; Add option to exit after printing

Hello, I'm working on a bug in okular https://bugs.kde.org/show_bug.cgi?id=318998 and I'm unable to develop the clear understanding of the bug. Here is my question: 1. What does the issue actually mean - adding an option to automatically exit with the exit code and message after acknowledging the

[okular] [Bug 318998] Add option to exit after printing

https://bugs.kde.org/show_bug.cgi?id=318998 Dileep Sankhla <sankhla.dilee...@gmail.com> changed: What|Removed |Added CC||sankhla

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla added a comment. Thank you so much. I'm checking it out. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla, #okular, ngraham Cc: ngraham, #okular, michaelweghorn, aacid

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla added a comment. Sure :) REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla, #okular, ngraham Cc: ngraham, #okular, michaelweghorn, aacid

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla added a comment. In https://phabricator.kde.org/D10209#198608, @ngraham wrote: > Lovely. Tested it out and it works as expected. Fix the BUG: string and I'll land this. Thank you so much. Fixed it. REPOSITORY R223 Okular BRANCH master REVISION DETAIL

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla edited the summary of this revision. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla, #okular, ngraham Cc: ngraham, #okular, michaelweghorn, aacid

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla, #okular Cc: ngraham, #okular, michaelweghorn, aacid

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla added a comment. BUG: 384381 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10209 To: dileepsankhla, #okular Cc: ngraham, #okular, michaelweghorn, aacid

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla added a comment. In https://phabricator.kde.org/D10209#198568, @ngraham wrote: > Thanks for the patch! Can you indicate your testing, and perhaps provide a screenshot that shows this working? > > Also, the title of the revision is really better suited to being in the

D10209: Use correct arrow cursor for Annotations' close buttons

dileepsankhla retitled this revision from "Added setCursor() call in the CloseButton constructor" to "Use correct arrow cursor for Annotations' close buttons". dileepsankhla edited the summary of this revision. dileepsankhla edited the test plan for this revision. REPOSITORY R223 Okular

D10209: Added setCursor() call in the CloseButton constructor

dileepsankhla created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. dileepsankhla requested review of this revision. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D10209 AFFECTED FILES

<    1   2