[konqueror] [Bug 247817] okular doesn't display correctly the pdf pages in a site

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=247817

Christoph Cullmann  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |UNMAINTAINED

--- Comment #10 from Christoph Cullmann  ---
Dear user,

KHTML (and KJS) was a long time more or less unmaintained and got removed in
KF6.

Please migrate to use a QWebEngine based HTML component.

We will do no further fixes or improvements to the KF5 branches of these
components beside important security fixes.

For security issues, please see:

https://kde.org/info/security/

Sorry that we did not fix this issue during the life-time of KHTML.

Greetings
Christoph Cullmann

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[okular] [Bug 460092] Kate crashed when editing

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=460092

Christoph Cullmann  changed:

   What|Removed |Added

Product|kate|okular
   Assignee|kwrite-bugs-n...@kde.org|okular-devel@kde.org
  Component|general |general
 CC||cullm...@kde.org

--- Comment #1 from Christoph Cullmann  ---
This looks more like a crash during preview in Okular part.
(or in the Wayland stack due to that)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 427953] Unique instance and open in tabs ignored

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=427953

--- Comment #5 from Christoph Cullmann  ---
Yes, there is no working dbus there.
Kate uses QtSingleApplication for that on Windows, but that is hacky, too.
I could try to improve the error message by checking better if some dbus
session bus is around at all.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 407869] Okular KParts plugin steals space key events from shell

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=407869

Christoph Cullmann  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/util
   ||ities/kate/commit/40ec82802
   ||66a89052612cef289a24caf1726
   ||90bd
 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #10 from Christoph Cullmann  ---
Git commit 40ec8280266a89052612cef289a24caf172690bd by Christoph Cullmann, on
behalf of Christoph Roick.
Committed on 29/05/2021 at 12:11.
Pushed by cullmann into branch 'master'.

Work around conflicting shortcuts in preview plugin

Do not let shortcuts issued within a preview widget
propagate to the application's shortcut event handler.
Instead handle the event while it's still a ShortcutOverride
event to prevent the detection of seemingly ambiguous
shortcuts.
Also do not let actions defined inside the preview KPart
capture shortcuts that are handled on the application level.
Related: bug 386265

M  +26   -0addons/preview/kpartview.cpp
M  +4-0addons/preview/kpartview.h

https://invent.kde.org/utilities/kate/commit/40ec8280266a89052612cef289a24caf172690bd

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 431298] Okular_Nightly_win64 not working from 1 Dec

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=431298

--- Comment #2 from Christoph Cullmann  ---
Yes, as no 21.04 build was there that worked since then.
(if I didn't miss that)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 433027] crash while opening .ott file with preview enabled

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=433027

Christoph Cullmann  changed:

   What|Removed |Added

   Assignee|kwrite-bugs-n...@kde.org|okular-devel@kde.org
Product|kate|okular
 CC||cullm...@kde.org
  Component|general |ODT backend

--- Comment #1 from Christoph Cullmann  ---
Hmm, this looks more like a crash inside Okular (or there inside the KoPart).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 426358] Okular_Nightly_win64 not working from 22 jul

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=426358

--- Comment #6 from Christoph Cullmann  ---
I scheduled a new build

https://binary-factory.kde.org/job/Okular_Nightly_win64/509/

=> did succeed

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 426358] Okular_Nightly_win64 not working from 22 jul

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=426358

Christoph Cullmann  changed:

   What|Removed |Added

  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/commit/25984bb2
   ||bba893c903176d47ce4698f90f1
   ||b9f88
 Resolution|--- |FIXED
 Status|REPORTED|RESOLVED

--- Comment #4 from Christoph Cullmann  ---
Git commit 25984bb2bba893c903176d47ce4698f90f1b9f88 by Christoph Cullmann.
Committed on 10/09/2020 at 18:51.
Pushed by cullmann into branch 'master'.

add missing export to class

M  +1-1core/annotations.h

https://invent.kde.org/graphics/okular/commit/25984bb2bba893c903176d47ce4698f90f1b9f88

-- 
You are receiving this mail because:
You are the assignee for the bug.

T10243: Some KDE applications could use better icons

[Christoph Cullmann]

cullmann added a comment.


  Hi, just to avoid any wasted work:
  
  For KWrite, one can think about altering the icon, not sure if that is 
needed, thought.
  For Kate, we have a new icon, we don't alter that again nor do I want to have 
an altered version in Breeze.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: cullmann
Cc: tosta, johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, azyx, dmenig, 
manueljlin, Orage, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, 
skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

[okular] [Bug 423712] Download URL of Windows installer isn't stable

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=423712

Christoph Cullmann  changed:

   What|Removed |Added

 CC||vonr...@kde.org

--- Comment #2 from Christoph Cullmann  ---
> Christoph when you upload the binary to the Windows Store, do you put it 
> somewhere else? Or is the Windows Store url accessible from the outside?

I normally only upload the needed appx variant to the store.

Not sure if that is accessible via a stable url without the store.

We can ask Hannah.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 422856] Fails to open PDFs when name contains hash ('#')

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=422856

--- Comment #2 from Christoph Cullmann  ---
Hmm, no direct idea why this fails :/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 422500] Okular does not open djvu files with non-ASCII names on Windows

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=422500

Christoph Cullmann  changed:

   What|Removed |Added

   Assignee|okular-devel@kde.org|cullm...@kde.org

--- Comment #2 from Christoph Cullmann  ---
I can take a look at that.
I assume the ddjvu_document_create_by_filename isn't working like intended on
Windows.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 419431] Images pasted into PDF document using Adobe Acrobat Reader DC do not display properly on screen.

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=419431

--- Comment #6 from Christoph Cullmann  ---
My system is a Windows 10 inside some VirtualBox.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 419431] Images pasted into PDF document using Adobe Acrobat Reader DC do not display properly on screen.

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=419431

--- Comment #5 from Christoph Cullmann  ---
Hi, I stored the PDF from this bug and opened it with the current Okular
version from the store. I get there no such artifacts, looks more or less like
in the internal preview of e.g. Microsoft Edge.

My Okular install says:

Okular
Version 1.9.2

Using Poppler 0.85.0

KDE Frameworks 5.67.0
Qt 5.14.0 (built against 5.14.0)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 414073] Print Preview for PDF will crash the current Okular window

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=414073

--- Comment #8 from Christoph Cullmann  ---
Ok, print preview doesn't really hang infinite either, after 2-3 minutes for my
large document I get a dialog with "Could not load print preview part". After
closing that, Okular is usable again.

Not that this is the perfect workflow one would expect, but perhaps this helps
a bit to trace back the issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 414073] Print Preview for PDF will crash the current Okular window

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=414073

--- Comment #7 from Christoph Cullmann  ---
Ok, I must re-consider: actually printing (to one note) does just take "long"
here, aka one minute for my test document that has ~200 pages. But Okular
recovers after that time and stays usable afterwards.

Not sure if the preview dialog does that same, will let it run a bit longer ;=)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 414073] Print Preview for PDF will crash the current Okular window

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=414073

--- Comment #6 from Christoph Cullmann  ---
Actually printing (at least to my only available "one note" printer) hangs,
too.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 414073] Print Preview for PDF will crash the current Okular window

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=414073

Christoph Cullmann  changed:

   What|Removed |Added

 Status|REOPENED|CONFIRMED

--- Comment #5 from Christoph Cullmann  ---
Yes, this still happens.

I uploaded today the 19.12.2 version to the store, but this will not fix this
issue.

It either hangs infinite or crashes, will need to investigate.

e.g. Kate that uses the same Qt version doesn't hang on that action, should be
no issue in Qt itself.

-- 
You are receiving this mail because:
You are the assignee for the bug.

T10243: Some KDE applications could use better icons

[Christoph Cullmann]

cullmann closed subtask T12594: New Kate icon as Resolved.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: cullmann
Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, manueljlin, Orage, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, 
skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Christoph Cullmann]

cullmann added a comment.


  I assume that is because the desktop file we install doesn't have preference 
about the system wide one, or do you have only a master kate install without 
any system wide?

TASK DETAIL
  https://phabricator.kde.org/T10243

To: cullmann
Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, manueljlin, Orage, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, 
skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Christoph Cullmann]

cullmann added a comment.


  In T10243#218612 , @filipf wrote:
  
  > Are you sure this is the best decision though? Icon themes will just theme 
the new icon again, it will only have a short-term effect.
  
  
  But than at least they theme the new one. Otherwise I will manually need to 
ping all themes around to update theirs, or?
  And what is with themes no longer maintained? There Kate will be stuck with 
the themed old icon forever ;=)
  
  In T10243#218613 , @ngraham wrote:
  
  > Meanwhile I'm not actually seeing the new icon after updating the app from 
current git master. It should really be added to the Breeze icon theme.
  
  
  Hmm, that is a bug then.
  Thought the question is: Where is it missing? In the menus or in the 
application? For me the application uses it, e.g. in about, not sure if the 
system will prefer the new .desktop file thought.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: cullmann
Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, mglb, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, manueljlin, Orage, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, 
skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Christoph Cullmann]

cullmann added a comment.


  In T10243#218606 , @ngraham wrote:
  
  > It's quite lovely! Much more aesthetically attractive than the current 
icon. However I fear that the recognizability as being a text editor has been 
lost; nothing about the icon connotes that it's for a text editor, which is 
compounded by the fact that the name "Kate" doesn't suggest that either. 
"KWrite" does though.
  >
  > This is not a huge deal as many other apps have the same thing going on. 
But it's something to consider.
  
  
  Yes, that was done by intention.
  First we tried some variants involving "text" in any kind, but that is just 
like the old icons that look somehow some either a mime-type icon or a generic 
"something".
  If you look around, close to none of the currently relevant text editors have 
icons that have anything to do with "text" ;) (I look on you Atom, but same for 
Sublime and Co.)
  
  > The icon should be submitted to the Breeze icon theme rather than renaming 
it in the code and changing the name you refer to it with. That breaks all 
3rd-party icon themes (which I guess was the point, but is not so nice :) ).
  
  I am not that sure of that.
  Actually, I would like to have this as default for any icon theme now and not 
the other way around being waiting for any and all theme to try to catch-up.
  Actually, I was first very confused why my icon was never used before I 
remembered: ahhh, icon themes :P

TASK DETAIL
  https://phabricator.kde.org/T10243

To: cullmann
Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, mglb, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, manueljlin, Orage, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, 
skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Christoph Cullmann]

cullmann added a comment.


  Hi, after some longer feedback loop with Tyson Tan, Kate got a initial new 
icon.
  
  It is a icon variant of the mascot Tyson created for us some years ago (and 
the mascot will likely get a refresh to fit the new style, too).
  
  Initial commit here 
https://invent.kde.org/kde/kate/commit/4dfae551c33ebcd326d4c5c07d92bc1d8a561705
  
  To ensure the icon is used at all, I at the moment just renamed it.
  This can be changed later again if needed.
  And if there is feedback for fine-tuning this is appreciated.
  (the important aspect is "fine-tuning", not redo)

TASK DETAIL
  https://phabricator.kde.org/T10243

To: cullmann
Cc: johanneszarl, Leon0402, IohannesPetros, alex-l, starbuck, cullmann, 
IlyaBizyaev, arrowd, abetts, stikonas, knauss, mglb, filipf, mludwig, aacid, 
lesliezhai, elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, 
#kde_games, #ark, #kde_pim, #discover_software_store, #yakuake, #kate, #okular, 
#gwenview, #konsole, #kde_applications, #vdg, ngraham, manueljlin, Orage, 
cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, GB_2, crozbo, firef, alexeymin, 
skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

[okular] [Bug 412930] Okular does not claim the ability to open .djvu files on Windows even though it can

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=412930

Christoph Cullmann  changed:

   What|Removed |Added

 Status|REPORTED|RESOLVED
  Latest Commit||https://commits.kde.org/cra
   ||ft-blueprints-kde/e5984a1a1
   ||fc815ec3c6230a501c9c7b61d57
   ||0c58
 Resolution|--- |FIXED

--- Comment #5 from Christoph Cullmann  ---
Git commit e5984a1a1fc815ec3c6230a501c9c7b61d570c58 by Christoph Cullmann.
Committed on 15/10/2019 at 18:35.
Pushed by cullmann into branch 'master'.

enable .djvu support

M  +1-1kde/applications/okular/okular.py

https://commits.kde.org/craft-blueprints-kde/e5984a1a1fc815ec3c6230a501c9c7b61d570c58

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 412930] Okular does not claim the ability to open .djvu files on Windows even though it can

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=412930

--- Comment #2 from Christoph Cullmann  ---
Hmm, does opening the file work?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 412281] Okular 1.8.1 in Windows 10 Home Edition does not remember changed configurations

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=412281

Christoph Cullmann  changed:

   What|Removed |Added

 CC||cullm...@kde.org

--- Comment #1 from Christoph Cullmann  ---
Hmm, I just tried that with the current version from the store. Seems to work
for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 412413] rar and 7zip compressed comic books don't work

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=412413

--- Comment #3 from Christoph Cullmann  ---
I assume the issue is just that the programs are not installed (aka unrar or
unarchiver). Does it work if you install these command line tools on Windows?

-- 
You are receiving this mail because:
You are the assignee for the bug.

T10243: Some KDE applications could use better icons

[Christoph Cullmann]

cullmann added a comment.


  Hmm, that looks more like a mail application ;=)
  As Tyson is already working on something, but at the moment has not much 
time, I would tend to just keep Kate's icon as is and look at the final stuff 
Tyson provides first.
  Otherwise I think that is a bit unfair.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: cullmann
Cc: IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, ognarb, arrowd, 
abetts, stikonas, knauss, mglb, filipf, mludwig, aacid, lesliezhai, 
elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, #kde_games, #ark, 
#kde_pim, #discover_software_store, #yakuake, #kate, #okular, #gwenview, 
#konsole, #kde_applications, #vdg, ngraham, cblack, konkinartem, ian, jguidon, 
hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, GB_2, 
crozbo, firef, alexeymin, skadinna, genaxxx, aaronhoneycutt, jriddell, 
mbohlender

T10243: Some KDE applications could use better icons

[Christoph Cullmann]

cullmann added a comment.


  In T10243#201347 , @filipf wrote:
  
  > In T10243#201303 , @ngraham 
wrote:
  >
  > > Yeah, an app's icon is a part of its branding. It //should// look 
distinctive, not generic. Ideally it communicates both its purpose ("I'm a text 
editor!") as well as its identity ("I'm Kate!"). I think the problem with some 
of these icons is that they only do the former, not the latter. I don't think 
there is a conflict here, though!
  >
  >
  > This seems like the crux of the issue to me, I don't think it's that much 
about the flat vs. skeuo debate.
  >
  > Some icons listed here are distinguishable, still do a decent job in terms 
of branding, and would maybe only benefit from a little tweaking (e.g. 
Gwenview). But others such as the Okular, Konsole, Kate, KWrite, Yakuake, and 
the previous version of the Kolf icon look somewhat generic to me.
  
  
  Yes, KWrite, ok, that is just some "non-SDI" Kate, I could live with it 
having just the same icon or the icon with some emblem like Kate.
  But Kate's icon is just maximal generic, could be any editor.
  The current draft of Tyson looks more like a simplified miniature version of 
the woodpecker mascot.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: cullmann
Cc: IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, ognarb, arrowd, 
abetts, stikonas, knauss, mglb, filipf, mludwig, aacid, lesliezhai, 
elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, #kde_games, #ark, 
#kde_pim, #discover_software_store, #yakuake, #kate, #okular, #gwenview, 
#konsole, #kde_applications, #vdg, ngraham, cblack, konkinartem, ian, jguidon, 
hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, GB_2, 
crozbo, firef, alexeymin, skadinna, genaxxx, aaronhoneycutt, jriddell, 
mbohlender

T10243: Some KDE applications could use better icons

[Christoph Cullmann]

cullmann added a comment.


  In T10243#201341 , @alex-l wrote:
  
  > Here there is an example of brand artwork using that diagonal shape for 
Konsole:
  >
  > F7377581: immagine.png 
  >
  > Edit: to be honest I think this is both distinctive and descriptive:
  >
  > F7378079: immagine.png 
  
  
  Yes, I think even the icon alone is recognizable enough.

TASK DETAIL
  https://phabricator.kde.org/T10243

To: cullmann
Cc: IohannesPetros, alex-l, starbuck, cullmann, IlyaBizyaev, ognarb, arrowd, 
abetts, stikonas, knauss, mglb, filipf, mludwig, aacid, lesliezhai, 
elvisangelaccio, kossebau, trickyricky26, ndavis, yurchor, #kde_games, #ark, 
#kde_pim, #discover_software_store, #yakuake, #kate, #okular, #gwenview, 
#konsole, #kde_applications, #vdg, ngraham, cblack, konkinartem, ian, jguidon, 
hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, GB_2, 
crozbo, firef, alexeymin, skadinna, genaxxx, aaronhoneycutt, jriddell, 
mbohlender

T10243: Some KDE applications could use better icons

[Christoph Cullmann]

cullmann added a comment.


  Actually, that is exactly what I want to have: an arbitrary logo that is 
distinguishable.
  It does Kate a big disservice that we have no icon like Atom/Sublime/Vim/... 
  A generic "text" icon is nice for a mime-type.
  Users will easily detect where to start Atom, but not where to start Kate, as 
it could just be any other "editor".

TASK DETAIL
  https://phabricator.kde.org/T10243

To: cullmann
Cc: alex-l, starbuck, cullmann, IlyaBizyaev, ognarb, arrowd, abetts, stikonas, 
knauss, mglb, filipf, mludwig, aacid, lesliezhai, elvisangelaccio, kossebau, 
trickyricky26, ndavis, yurchor, #kde_games, #ark, #kde_pim, 
#discover_software_store, #yakuake, #kate, #okular, #gwenview, #konsole, 
#kde_applications, #vdg, ngraham, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, crozbo, firef, alexeymin, skadinna, genaxxx, 
aaronhoneycutt, jriddell, mbohlender

T10243: Some KDE applications could use better icons

[Christoph Cullmann]

cullmann added a comment.


  For Kate, I am in contact with Tyson to have the icon updated (and to get 
some refreshed matching mascot).

TASK DETAIL
  https://phabricator.kde.org/T10243

To: cullmann
Cc: cullmann, IlyaBizyaev, ognarb, arrowd, abetts, stikonas, knauss, mglb, 
filipf, mludwig, aacid, lesliezhai, elvisangelaccio, kossebau, trickyricky26, 
ndavis, yurchor, #kde_games, #ark, #kde_pim, #discover_software_store, 
#yakuake, #kate, #okular, #gwenview, #konsole, #kde_applications, #vdg, 
ngraham, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, crozbo, firef, 
alexeymin, skadinna, genaxxx, aaronhoneycutt, jriddell, mbohlender

D10415: Fix realDpi function for Mac

[Christoph Cullmann]

cullmann added a comment.


  > I think they are not exactly the same. physicalDotsPerInchY() would give 
twice difference in the resolution depending on whether one uses the native or 
HiDPI mode. But logicalDpiX()/logicalDpiY() would return the same value in both 
cases.
  
  No, I meant: if the logical variant works for us here, the physical variant 
should work fine, too.
  That they not give you the same results in all cases is clear, given they are 
logical vs. physical.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10415

To: sbragin, #okular, rjvbb
Cc: rjvbb, cullmann, aacid, kde-mac, ltoscano, #okular, michaelweghorn, ngraham

D10415: Fix realDpi function for Mac

[Christoph Cullmann]

cullmann added a comment.


  I would go for the Qt functions, as their results are consistent with what Qt 
itself will later use anyways.
  My only nitpick is why one goes over QScreen and not just asks the widget.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10415

To: sbragin, #okular, rjvbb
Cc: rjvbb, cullmann, aacid, kde-mac, ltoscano, #okular, michaelweghorn, ngraham

D10415: Fix realDpi function for Mac

[Christoph Cullmann]

cullmann added a comment.


  In our company we use the logicalDpiX()/logicalDpiY() on the widget we paint 
to, that works on macOS, too.
  
  I assume the physicalDotsPerInchY() should work the same.
  
  Sidenote: do we need to go over QScreen? We just use the function of the 
widget in question which is there via QPaintDevice.
  Which here would be just widgetOnScreen->physicalDpi

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D10415

To: sbragin, #okular
Cc: cullmann, aacid, kde-mac, ltoscano, #okular, michaelweghorn, ngraham

[okular] [Bug 362856] [Frameworks] Wrong render resolution, possibly caused by Plasma 5 "Scale Display"

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=362856

Christoph Cullmann <cullm...@kde.org> changed:

   What|Removed |Added

 CC||cullm...@kde.org

--- Comment #21 from Christoph Cullmann <cullm...@kde.org> ---
I did take a look, IMHO the problem (beside the missing 

   // These attributes must be set before a Q(Gui)Application is constructed.
+QCoreApplication::setAttribute(Qt::AA_EnableHighDpiScaling);
+QCoreApplication::setAttribute(Qt::AA_UseHighDpiPixmaps);

calls) is that the generators render the stuff in a QImage but that has not set
the right scale factor nor dimensions.

During writing our company PDF helper viewer
(https://github.com/AbsInt/FirstAid), I run into the same issue with libpoppler
and altered our rendering code to:

/**
 * we render in too high resolution and then set the right ratio
 */
cachedPage = new QImage(page->renderToImage(resX() *
devicePixelRatio(), resY() * devicePixelRatio(), -1, -1, -1, -1,
Poppler::Page::Rotate0));
cachedPage->setDevicePixelRatio(devicePixelRatio());

This did the trick, unfortunately Okular is more complex than our toy program
therefore I am not that sure where to adjust that :/

-- 
You are receiving this mail because:
You are the assignee for the bug.