D7949: Allow to print pdf doc directly into a QPrinter

2018-08-24 Thread Henrik Fehlauer
rkflx resigned from this revision. This revision now requires review to proceed. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7949 To: sander, #okular Cc: okular-devel, asturmlechner, cfeck, ltoscano, rkflx, michaelweghorn, ngraham, aacid

D6695: Fix text labels in sidebar occasionally rendering cut off

2018-08-24 Thread Henrik Fehlauer
rkflx abandoned this revision. Herald added a subscriber: okular-devel. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D6695 To: rkflx, #okular Cc: okular-devel, dhaumann, aacid, ngraham

D6696: Elide cut off text in sidebar header, remove restricted max width

2018-08-24 Thread Henrik Fehlauer
rkflx abandoned this revision. Herald added a subscriber: okular-devel. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D6696 To: rkflx, #okular, sander, pino Cc: okular-devel, ngraham, pino, sander, aacid

D7962: Implement several new print scaling options

2018-07-22 Thread Henrik Fehlauer
rkflx added inline comments. INLINE COMMENTS > generator_pdf.cpp:80-89 > + bool isVisible = (printBackend() == QPrinterBackend || > m_forceRaster->isChecked()); > + m_scaleMode->setVisible ( isVisible ); > + m_scaleTo->setVisible ( isVisible ); > + if (

D10974: Add option to ignore print margins

2018-07-10 Thread Henrik Fehlauer
rkflx added a comment. FWIW, earlier in D7962 there was this suggestion: In D7962#150260 , @rkflx wrote: > > Scale mode: fit-to-page vs. shrink-to-page vs. none > > Scale to: printable area vs. full

D7949: Allow to print pdf doc directly into a QPrinter

2018-07-10 Thread Henrik Fehlauer
rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. Thanks, accepting the Diff from my side (obviously I cannot speak for the Okular project). In D7949#290074 , @sander wrote: > That is

D7949: Allow to print pdf doc directly into a QPrinter

2018-07-07 Thread Henrik Fehlauer
rkflx added a comment. Thanks for the update. Still found some minor things, otherwise LGTM. --- > Unlike for CUPS printing, Qt printing prints on the entire page and does not scale to the printable area yet. This is only because it is the easiest way. I plan to implement a few

D10932: [Okular] Option to reset forms

2018-04-25 Thread Henrik Fehlauer
rkflx added a comment. In D10932#252571 , @aacid wrote: > In D10932#248618 , @rkflx wrote: > > > FWIW, Foxit Reader does have a Reset Form button, which upon clicking shows a dialog asking "This

D10932: [Okular] Option to reset forms

2018-04-18 Thread Henrik Fehlauer
rkflx added a comment. FWIW, Foxit Reader does have a Reset Form button, which upon clicking shows a dialog asking "This option will reset all form fields to their default values. You may lose some data. Are you sure?". Let me know if you have specific example documents I should test

D10797: Add asterisk when an annotation is associated to non-empty popup

2018-04-10 Thread Henrik Fehlauer
rkflx added a comment. In D10797#241905 , @rkflx wrote: > There is a second way `arc diff` can recognize the revision […] (IIRC – if not, `arc which` will tell you the real reason). Hm, I guess that was wishful thinking from my side.

D10797: Add asterisk when an annotation is associated to non-empty popup

2018-04-07 Thread Henrik Fehlauer
rkflx added a comment. In D10797#241886 , @simgunz wrote: > My doubt is: when you want to review a "review" what do you do exactly (I never did it). You download a patch and apply it manually to your code (probably arc does this with some

D10797: Add asterisk when an annotation is associated to non-empty popup

2018-04-07 Thread Henrik Fehlauer
rkflx added a comment. (OT) Won't comment on the patch, but in the light of T7116: Streamlined onboarding of new contributors it might be worth figuring out if there are any improvements we could do to https://community.kde.org/Infrastructure/Phabricator,

D8980: Fix rubber band selection drawing contents misaligned with scaling

2018-03-24 Thread Henrik Fehlauer
rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. Thanks David, I can confirm this stops the text from moving upon selection with the rectangle tool ([Ctrl] + [3]) for integer scaling factors. Code LGTM. For the inline selection tool

[okular] [Bug 381328] Okular crashes when editing forms in a PDF that's located inside an archive

2018-03-08 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=381328 --- Comment #10 from Henrik Fehlauer <rk...@lab12.net> --- (OT) > since Henrik didn't seem to want to answer my question What? I always try to answer questions in the best way possible. In fact, I specified where my way of accessing the zip

[okular] [Bug 381328] Okular crashes when editing forms in a PDF that's located inside an archive

2018-03-07 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=381328 --- Comment #8 from Henrik Fehlauer <rk...@lab12.net> --- Just tried it again on a standard Plasma installation with Okular 1.3.2: - okular zip:/home/user/form_english.zip/form_english.pdf - Entered text into the form - Closed Okular (chose to d

[okular] [Bug 391363] okular crashes when refreshing deleted document

2018-03-03 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=391363 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- C

[okular] [Bug 381328] Okular crashes when editing forms in a PDF that's located inside an archive

2018-03-03 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=381328 --- Comment #5 from Henrik Fehlauer <rk...@lab12.net> --- Would "protocol" be a more appropriate terminology? Regardless, let's focus on the crash in this bug. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 390135] PDF render is slow

2018-03-02 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=390135 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Resolution|--- |WORK

[okular] [Bug 390971] Delayed content rendering during scrolling on a hidpi screen

2018-02-24 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=390971 --- Comment #5 from Henrik Fehlauer <rk...@lab12.net> --- Thanks, I guess we'd need someone with such a high resolution display to try to reproduce. There's one more thing you could try: Does this also happen when you use the same screen, b

[okular] [Bug 390971] Delayed content rendering during scrolling on a hidpi screen

2018-02-24 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=390971 --- Comment #3 from Henrik Fehlauer <rk...@lab12.net> --- Hmh, cannot reproduce. I tried exactly the versions of Okular and Poppler as well as the settings you mentioned, but there is absolutely no difference at all between HiDPI and normal s

[okular] [Bug 390971] Delayed content rendering during scrolling on a hidpi screen

2018-02-24 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=390971 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- C

[okular] [Bug 390293] Improve display of stacked annotations of same color to show which one is on top

2018-02-13 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=390293 --- Comment #5 from Henrik Fehlauer <rk...@lab12.net> --- Another idea: Add outline on mouse hover, so the differing shapes make it clear which item is meant. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 390293] Improve display of stacked annotations of same color to show which one is on top

2018-02-13 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=390293 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Resolution|WORKSFORME |--- Ever confi

[okular] [Bug 390135] PDF render is slow

2018-02-13 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=390135 --- Comment #5 from Henrik Fehlauer <rk...@lab12.net> --- Thanks. I tried those exact versions, nothing too unsual so far (Poppler is not the fastest for image-heavy pages – the blurriness you see might just be an upscaled pixmap shown from the

[okular] [Bug 390293] PDF save does not save the content of all sticky notes. Some are blank notes when I open in other pdf viewers.

2018-02-13 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=390293 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- C

[okular] [Bug 390135] PDF render is slow

2018-02-10 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=390135 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- C

D9328: Add support for cancellable image rendering and text extraction

2018-01-31 Thread Henrik Fehlauer
rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. Yay, `make test` looks much better now. (I still get some failures, but those are also present without the patch – no time to bisect right now though, sorry. Let's see what the CI says.)

D9328: Add support for cancellable image rendering and text extraction

2018-01-30 Thread Henrik Fehlauer
rkflx added a comment. In https://phabricator.kde.org/D9328#197788, @aacid wrote: > In https://phabricator.kde.org/D9328#196555, @rkflx wrote: > > > >> 5. `ASSERT: "page()" in file okular/core/generator_p.cpp, line 129` > > > Ok, i found how to reproduce too and this should be

D9328: Add support for cancellable image rendering and text extraction

2018-01-26 Thread Henrik Fehlauer
rkflx requested changes to this revision. rkflx added a comment. This revision now requires changes to proceed. >> 5. `ASSERT: "page()" in file okular/core/generator_p.cpp, line 129` (Happened two times already, but not everytime.) > > You got this one changing the size of the sidebar?

D9328: Add support for cancellable image rendering and text extraction

2018-01-25 Thread Henrik Fehlauer
rkflx added inline comments. INLINE COMMENTS > rkflx wrote in generator_pdf.cpp:1177 > `const` Any reason you changed it everywhere but here? REPOSITORY R223 Okular BRANCH cancellable (branched from master) REVISION DETAIL https://phabricator.kde.org/D9328 To: aacid, ervin Cc: rkflx,

D9328: Add support for cancellable image rendering and text extraction

2018-01-25 Thread Henrik Fehlauer
rkflx added a comment. Better, but not perfect yet ;) > There's no autotests in https://phabricator.kde.org/D8379, no? Seems I mixed it up with https://phabricator.kde.org/D8642, sorry. > 2. OOM killed when changing sidebar size. I suspect there are multiple issues

[okular] [Bug 389411] New: Okular and X unresponsive when resizing Okular's sidebar

2018-01-25 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=389411 Bug ID: 389411 Summary: Okular and X unresponsive when resizing Okular's sidebar Product: okular Version: 1.3.1 Platform: Other OS: Linux Status:

D8980: Fix rubber band selection drawing contents misaligned with scaling

2018-01-18 Thread Henrik Fehlauer
rkflx added a comment. @davidedmundson Could you confirm/refute Anthony's concern? (I might be willing to try the patch afterwards.) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8980 To: davidedmundson, aacid Cc: rkflx, anthonyfieroni, #okular,

[okular] [Bug 389142] Save as does not work - it says "... try to save it in another ...", but annotations are not saved

2018-01-18 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=389142 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- C

D9937: synctex: Use Windows ANSI versions of the PathFind... methods

2018-01-18 Thread Henrik Fehlauer
rkflx added a comment. Thanks for the Diff. I cannot try your patch on Windows, but if it works for you and fixes the problem I guess this is fine. One minor thing: Could you add the patch file to `core/synctex/patches/series`? (`quilt` would do this automatically, but adding it

D9328: Add support for cancellable image rendering and text extraction

2018-01-18 Thread Henrik Fehlauer
rkflx added a comment. First things first: The patch marks an impressive improvement in (perceived) drawing performance for slow-rendering PDFs, I'm glad your hard work payed off. See below for some minor comments regarding the code, but obviously I lack Okular/Poppler knowledge to

[okular] [Bug 155563] Automatic text selection in Okular

2018-01-10 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=155563 --- Comment #5 from Henrik Fehlauer <rk...@lab12.net> --- @michaelweghorn: Ahh, sorry. I definitely noticed that, but somehow it's still on my list of things to review. I'll try to get back to you once I find the time. -- You are receiving thi

[okular] [Bug 220218] Separate icons by default for the rectangle and text selection tools

2018-01-09 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=220218 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Resolution|--- |WONTFIX

[okular] [Bug 388747] Using cursor pointer rather than rectangle to select text

2018-01-09 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=388747 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab

[okular] [Bug 306886] Merge selection and browse tool functionality

2018-01-09 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=306886 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- C

[okular] [Bug 155563] Automatic text selection in Okular

2018-01-09 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=155563 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab

D9692: Improve dialog when PDF wants to open in presentation mode

2018-01-07 Thread Henrik Fehlauer
rkflx added a comment. I think so. Thanks for all the tweaks, BTW. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D9692 To: ngraham, #okular, aacid, rkflx Cc: rkflx, michaelweghorn, gassaf, ngraham, aacid

D9692: Improve dialog when PDF wants to open in presentation mode

2018-01-06 Thread Henrik Fehlauer
rkflx added a comment. What is Normal Mode to the user, anyway? It's not bad, but does not click with me immediately, TBH. How about Deny Request? That would correspond nicely with the title. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D9692

D9692: Improve dialog when PDF wants to open in presentation mode

2018-01-06 Thread Henrik Fehlauer
rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. Thanks, Nate! @aacid Are you okay with this change? REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D9692 To: ngraham, #okular, aacid, rkflx Cc:

D9692: Improve dialog when PDF wants to open in presentation mode

2018-01-06 Thread Henrik Fehlauer
rkflx added a comment. That's even better. Just update the Diff, I'll check / approve and then we'll see what Albert says. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9692 To: ngraham, #okular, aacid, rkflx Cc: rkflx, michaelweghorn, gassaf, ngraham, aacid

D9692: Improve dialog when PDF wants to open in presentation mode

2018-01-06 Thread Henrik Fehlauer
rkflx added a comment. Sounds great. Maybe "View Mode" in the title? ("Mode" is not really meaningful in itself.) Also: Title Case in title, I guess? Do you think Albert should approve this? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9692 To: ngraham,

D9692: Improve dialog when PDF wants to open in presentation mode

2018-01-06 Thread Henrik Fehlauer
rkflx added a comment. In https://phabricator.kde.org/D9692#187034, @ngraham wrote: > How about this? > F5625111: enter presentation mode.png It's is an innovative idea, but unless there are any other existing examples putting the

D9692: Improve dialog when PDF wants to open in presentation mode

2018-01-06 Thread Henrik Fehlauer
rkflx added a comment. (Helps saving inline comments before pressing "Submit"). INLINE COMMENTS > part.cpp:1630 > const QString caption = i18n( "Presentation Mode" ); > -const KGuiItem yesItem = KGuiItem( i18n( "Allow" ), > QStringLiteral("dialog-ok"), i18n( "Allow

D9692: Improve dialog when PDF wants to open in presentation mode

2018-01-06 Thread Henrik Fehlauer
rkflx added a comment. Yep. Take your time with rephrasing, it's 18.04 material anyway. Also, it should probably stay being a question (because it's not a warning or information either), hence the question mark icon. REPOSITORY R223 Okular REVISION DETAIL

D9692: Improve dialog when PDF wants to open in presentation mode

2018-01-06 Thread Henrik Fehlauer
rkflx added a comment. Now we have "Presentation Mode" (title), "Presentation Mode" (first sentence), "Presentation Mode" (second sentence), "Presentation Mode" (button). I find it a bit annoying to read ;) Can we do something about it, e.g. removing the second sentence? Any other idea?

D9692: Improve message displayed when PDF wants to open in presentation mode

2018-01-05 Thread Henrik Fehlauer
rkflx requested changes to this revision. rkflx added a comment. This revision now requires changes to proceed. You should open a 48h bugfixing service ;) Example PDF (via https://tex.stackexchange.com/a/219791): F5623940: presentation_mode.pdf

[okular] [Bug 372917] Saving annotations to pdf stopped working

2018-01-04 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=372917 --- Comment #10 from Henrik Fehlauer <rk...@lab12.net> --- For Okular 1.3 (KDE Applications 17.12), saving annotations now always saves to the PDF, using the XML file (which results in the behaviour you see regarding dependence on filename, but no

[okular] [Bug 388458] Wrong size of rectangles around annotation icons (e.g. popup note) for PDF documents

2018-01-03 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=388458 --- Comment #3 from Henrik Fehlauer <rk...@lab12.net> --- > widgets are huge, while PDF page looks the same In general Okular should display documents based on the physical dimensions as specified in the PDF, e.g. for 100% zoom of an A5-sized

D9578: Improve error message when parttest fails due to missing pdflatex

2018-01-02 Thread Henrik Fehlauer
This revision was automatically updated to reflect the committed changes. Closed by commit R223:7c837113eb35: Improve error message when parttest fails due to missing pdflatex (authored by rkflx). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D9579: Fix testSaveAsUndoStackAnnotations autotest

2018-01-02 Thread Henrik Fehlauer
This revision was automatically updated to reflect the committed changes. Closed by commit R223:454a53ff72d0: Fix testSaveAsUndoStackAnnotations autotest (authored by rkflx). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9579?vs=24518=24620 REVISION DETAIL

[okular] [Bug 388458] Wrong size of rectangles around annotation icons (e.g. popup note) for PDF documents

2018-01-02 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=388458 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- C

[okular] [Bug 338742] Annotations incompatible with gzip

2018-01-02 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=338742 --- Comment #5 from Henrik Fehlauer <rk...@lab12.net> --- Patch: https://phabricator.kde.org/D9580 -- You are receiving this mail because: You are the assignee for the bug.

D9580: Fix saving annotations to gzipped files

2018-01-02 Thread Henrik Fehlauer
rkflx added a comment. In https://phabricator.kde.org/D9580#185022, @aacid wrote: > Do you think you could add an autotest so this doesn't regress in the future? I can try, but probably won't happen in time for 17.12.1 (sorry). REPOSITORY R223 Okular REVISION DETAIL

[okular] [Bug 291176] Documentation wish: add that document archive must have ".okular" extension

2017-12-31 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=291176 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Resolution|--- |FIXED

D9577: Document ".okular" filename extension

2017-12-31 Thread Henrik Fehlauer
This revision was automatically updated to reflect the committed changes. Closed by commit R223:9f0aa37906c9: Document .okular filename extension (authored by rkflx). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9577?vs=24516=24538 REVISION DETAIL

D9578: Improve error message when parttest fails due to missing pdflatex

2017-12-31 Thread Henrik Fehlauer
rkflx added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9578 To: rkflx, aacid, #okular Cc: #okular, michaelweghorn, gassaf, ngraham, aacid

D9580: Fix saving annotations to gzipped files

2017-12-31 Thread Henrik Fehlauer
rkflx added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9580 To: rkflx, aacid, #okular Cc: #okular, michaelweghorn, gassaf, ngraham, aacid

D9579: Fix testSaveAsUndoStackAnnotations autotest

2017-12-31 Thread Henrik Fehlauer
rkflx added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9579 To: rkflx, aacid, #okular Cc: #okular, michaelweghorn, gassaf, ngraham, aacid

D9577: Document ".okular" filename extension

2017-12-31 Thread Henrik Fehlauer
rkflx retitled this revision from "Document ".okular" extension" to "Document ".okular" filename extension". rkflx edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9577 To: rkflx, lueck Cc: #okular, michaelweghorn, gassaf, ngraham,

[okular] [Bug 332835] Feature request: Insert text and replace text annotation

2017-12-14 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=332835 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- C

D8838: Don't request pixmaps twice when opening okular

2017-12-14 Thread Henrik Fehlauer
rkflx added a comment. In https://phabricator.kde.org/D8838#179480, @aacid wrote: > With https://phabricator.kde.org/D9328 we can probably just discard this one Sounds lovely, cannot wait to test. I'm currently backlogged a bit on Okular related things, so it may take a while to

[okular] [Bug 387247] okular [12.17beta] crash upon highlighting text in pdfs

2017-12-05 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=387247 --- Comment #20 from Henrik Fehlauer <rk...@lab12.net> --- Robby: Thanks again for testing the Beta and RC releases. You were the only one reporting this serious bug with the new annotation saving feature, even though it will affect almost eve

[okular] [Bug 387247] okular [12.17beta] crash upon highlighting text in pdfs

2017-12-05 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=387247 --- Comment #17 from Henrik Fehlauer <rk...@lab12.net> --- For both documents, I can now reproduce the crash pretty reliably: - Add highlighting annotation. - Save document. (← This is an essential prerequisite.) - Scroll to a new page to t

D9043: Use a distinct and more appropriate icon for Layers

2017-12-02 Thread Henrik Fehlauer
rkflx added a comment. How about `format-list-ordered` or `format-list-unordered`? Those retain at least some of the layering semantics. F5523082: format-list.png REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D9043 To:

[okular] [Bug 387466] The option to print multiple pages on one sheet (n-up) is rather hidden

2017-12-01 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=387466 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Resolution|--- |WORK

[okular] [Bug 383915] Okular crashes with a segfault on reload for some synctex files

2017-11-30 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=383915 --- Comment #20 from Henrik Fehlauer <rk...@lab12.net> --- Thanks for testing, your collection sounds impressive! You should run your script regularly and report any new problems ;) As for Okular, we (as in whoever contributes this) should extend

[okular] [Bug 387247] okular [12.17beta] crash upon highlighting text in pdfs

2017-11-30 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=387247 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Ever confirmed|0 |1

[okular] [Bug 387466] The option to print multiple pages on one sheet (n-up) is rather hidden

2017-11-30 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=387466 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- C

[okular] [Bug 338742] Annotations incompatible with gzip

2017-11-30 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=338742 --- Comment #4 from Henrik Fehlauer <rk...@lab12.net> --- Huh? I see no issues with your comment, it was just a data point. Those things can be very useful to speed up bug triaging, actually. The rest are just insights I had gathered in the last

[okular] [Bug 383915] Okular crashes with a segfault on reload for some synctex files

2017-11-30 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=383915 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Latest Commit|https://commits.kde.org/oku |https://commits.kde.o

[okular] [Bug 387247] okular [12.17beta] crash upon highlighting text in pdfs

2017-11-29 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=387247 --- Comment #8 from Henrik Fehlauer <rk...@lab12.net> --- Sorry to say, still cannot reproduce the crash (and I tried _very_ hard). Looking at the backtrace and your hardware, I got another idea. Please run the following two commands and p

[okular] [Bug 141289] Allow navigation panel on the bottom instead of side

2017-11-29 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=141289 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- C

[okular] [Bug 383915] Okular crashes with a segfault on reload for some synctex files

2017-11-29 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=383915 --- Comment #17 from Henrik Fehlauer <rk...@lab12.net> --- ISSUE 1: Parse error in synctex 1.19 upstream code Here is what I did: Tried to make sense of where the actual upstream code is (did not succeed): git svn clone svn://tug.org/texlive

[okular] [Bug 383915] Okular crashes with a segfault on reload for some synctex files

2017-11-29 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=383915 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Status|RESOLVED|REOPENED Reso

[okular] [Bug 387247] okular [12.17beta] crash upon highlighting text in pdfs

2017-11-28 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=387247 --- Comment #4 from Henrik Fehlauer <rk...@lab12.net> --- Thanks for the additional info. Console output looks normal, except for the last line ;) However, I still could not reproduce the crash. More ideas to try: - What does "Highli

D8838: Don't request pixmaps twice when opening okular

2017-11-27 Thread Henrik Fehlauer
rkflx added a comment. > Another option is just pushing the fix for the second problem and not for the first one After testing again, "patch w/o timer" now gives "M-D-T", i.e. the last M is not there anymore. I suspected I could find a window size or map area to break it again (as

[okular] [Bug 338061] Okular modify a PDF content when highlight

2017-11-27 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=338061 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Resolution|WAITINGFORINFO |---

[okular] [Bug 357526] Annotation can not be saved automatically for a specific PDF file.

2017-11-27 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=357526 --- Comment #9 from Henrik Fehlauer <rk...@lab12.net> --- Keyboard shortcuts work just fine for undo (Ctrl + Z). You might also want to look into the "Reviews" sidebar, where all annotations are conveniently listed, no matter how sm

[okular] [Bug 275371] Stamp annotations are drawn by both poppler and Okular

2017-11-26 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=275371 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- C

[okular] [Bug 357526] Annotation can not be saved automatically for a specific PDF file.

2017-11-26 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=357526 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab

[okular] [Bug 381328] Okular crashes when editing forms in a PDF that's located inside an archive

2017-11-26 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=381328 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- C

[okular] [Bug 332136] Enable saving .okular archives as pdf, preserving annotations

2017-11-26 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=332136 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Resolution|--- |FIXED

[okular] [Bug 266680] Show recently/frequently used documents and bookmarks on otherwise empty start screen

2017-11-26 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=266680 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Ever confirmed|0 |1

[okular] [Bug 336381] Directly save bookmarks to PDF

2017-11-26 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=336381 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab

[okular] [Bug 330961] Okular should save bookmarks in .okular file archive

2017-11-26 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=330961 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab12.net --- C

[okular] [Bug 319625] Bookmarks lost for renamed documents, allow to manually specify document path

2017-11-26 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=319625 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab

[okular] [Bug 305412] Enh: ability to save annotations metadata in the same dir the file is

2017-11-26 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=305412 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[okular] [Bug 291176] Documentation wish: add that document archive must have ".okular" extension

2017-11-26 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=291176 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Ever confirmed|0 |1

[okular] [Bug 268575] Okular should display a warning about before annotating

2017-11-26 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=268575 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Resolution|--- |FIXED

[okular] [Bug 228114] Please add ability to save modified okular document archives

2017-11-26 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=228114 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[okular] [Bug 334343] when i open a PDF file an i make an annotation with the highlighter, i close the PDF file and i open again the same PDF all the pages are blank

2017-11-26 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=334343 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Resolution|--- |WAITINGF

[okular] [Bug 338061] Okular modify a PDF content when highlight and crashed when it's removed

2017-11-26 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=338061 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab

[okular] [Bug 372917] Saving annotations to pdf stopped working

2017-11-26 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=372917 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||rk...@lab

[okular] [Bug 344541] Add markdown format support to Okular

2017-11-26 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=344541 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[okular] [Bug 360603] Markdown (.md) support

2017-11-26 Thread Henrik Fehlauer
https://bugs.kde.org/show_bug.cgi?id=360603 Henrik Fehlauer <rk...@lab12.net> changed: What|Removed |Added CC||kdeb...@stazno

  1   2   3   >