On Jan. 24, 2014, 7:32 p.m., Albert Astals Cid wrote:
is it crashing for you without the patch? Because if it is not, you know
that you are creating some qwidget in a bad thread, use gdb and try to find
out where that's happening.
Hello? Anyone in there?
- Albert
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111410/#review48243
---
is it crashing for you without the patch? Because if it is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111410/
---
(Updated Jan. 22, 2014, 8:39 p.m.)
Review request for Okular.
Changes
On Jan. 13, 2014, 10:48 p.m., Albert Astals Cid wrote:
ui/minibar.h, line 130
https://git.reviewboard.kde.org/r/111410/diff/9/?file=233890#file233890line130
I'd appreciate if you did not revert my code.
Sorry, that must have been an accidential change. I must have made the patch
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111410/
---
(Updated Jan. 14, 2014, 10:46 a.m.)
Review request for Okular.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111410/#review47351
---
ui/minibar.h
On Oct. 15, 2013, 12:33 a.m., Albert Astals Cid wrote:
generators/poppler/generator_pdf.cpp, line 1538
https://git.reviewboard.kde.org/r/111410/diff/8/?file=185148#file185148line1538
This needs to be made async, this will potentiall freeze the UI for a
while depending on what we
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111410/
---
(Updated Jan. 12, 2014, 10:46 p.m.)
Review request for Okular.
Changes
On Oct. 14, 2013, 10:33 p.m., Albert Astals Cid wrote:
generators/poppler/generator_pdf.cpp, line 1538
https://git.reviewboard.kde.org/r/111410/diff/8/?file=185148#file185148line1538
This needs to be made async, this will potentiall freeze the UI for a
while depending on what we
On Dec. 29, 2013, 8:49 p.m., Albert Astals Cid wrote:
Thomas, did you see my comments? Are you planning to keep working on this?
I had started to work on this a few months ago, hit some issues, got occupied
with other things, forgot about it. Maybe I can resume during the weekend...
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/111410/#review46409
---
Thomas, did you see my comments? Are you planning to keep
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111410/#review41759
---
generators/poppler/generator_pdf.cpp
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111410/#review38896
---
I'm going to be on holiday most of september, so unless
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111410/
---
(Updated Aug. 27, 2013, 8:11 p.m.)
Review request for Okular.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111410/#review38084
---
generators/poppler/generator_pdf.cpp
On Aug. 16, 2013, 10:18 p.m., Albert Astals Cid wrote:
core/generator.h, line 395
http://git.reviewboard.kde.org/r/111410/diff/6/?file=181596#file181596line395
Why are these not const anymore?
Constructing an instance of QProcess to run pdftocairo requires passing a
non-const
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111410/
---
(Updated Aug. 17, 2013, 9:11 p.m.)
Review request for Okular.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111410/
---
(Updated Aug. 16, 2013, 9:17 p.m.)
Review request for Okular.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111410/#review38002
---
core/generator.h
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111410/#review37809
---
So yes, this is going in the right direction, there's lots of
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111410/
---
(Updated July 23, 2013, 9:24 p.m.)
Review request for Okular.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111410/
---
(Updated July 23, 2013, 9:26 p.m.)
Review request for Okular.
Changes
On July 7, 2013, 10:31 p.m., Albert Astals Cid wrote:
The location of the code in pageview.cpp is therefore justified as the
image and text extract code is located in the same class. However, I agree
that pageview.cpp is rather large and should be refactored.
That is not true, the
On July 7, 2013, 10:31 p.m., Albert Astals Cid wrote:
The location of the code in pageview.cpp is therefore justified as the
image and text extract code is located in the same class. However, I agree
that pageview.cpp is rather large and should be refactored.
That is not true, the
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111410/
---
(Updated July 7, 2013, 10:22 p.m.)
Review request for Okular.
Changes
On July 6, 2013, 6:11 p.m., Albert Astals Cid wrote:
Sincerely, i understand you may find this useful, but I am not sure this
makes much sense, it's just feature creep, anyway, even if it does make
sense, it's not in the correct place, why is all this exporting
functionality in
26 matches
Mail list logo
