D10974: PDF: Make the "fit-to-page" print option configurable

michaelweghorn updated this revision to Diff 29095. michaelweghorn added a comment. (Don't) Set margins based on QPrinter::fullPage() This modifies the draft solution as I described in comment https://phabricator.kde.org/D10974#217969 . REPOSITORY R223 Okular CHANGES SINCE LAST

D10974: PDF: Make the "fit-to-page" print option configurable

michaelweghorn added a comment. In D10974#217646 , @aacid wrote: > so you worded point 4 and point 6 (second point 5) differently "the document is not scaled at all now." vs "The document is scaled to the full page size", i would not expect

D10974: PDF: Make the "fit-to-page" print option configurable

aacid added a comment. so you worded point 4 and point 6 (second point 5) differently "the document is not scaled at all now." vs "The document is scaled to the full page size", i would not expect Force Rasterize to cause different behaviour. Is it just that you wrote it differently or

D10974: PDF: Make the "fit-to-page" print option configurable

michaelweghorn added a comment. Once https://phabricator.kde.org/D7962 should make it to Okular, it might make sense to reconsider using the combobox for the scaling options that this adds for the PDF generator case (or how to properly merge the two approaches for the QPrinter and the lpr

D10974: PDF: Make the "fit-to-page" print option configurable

michaelweghorn added a comment. In general, this option is not only relevant for the PDF generator, but (as Albert mentioned on the bug report) for all generators that use FilePrinter. This change currently only addresses the PDF case. I have created a separate class

D10974: PDF: Make the "fit-to-page" print option configurable

michaelweghorn created this revision. michaelweghorn added a reviewer: Okular. Restricted Application added a project: Okular. michaelweghorn requested review of this revision. REVISION SUMMARY This adds a checkbox in the print dialog to make it possible to select whether or not to scale the