D7594: Update to synctex 1.19

bcooksley added a comment. In https://phabricator.kde.org/D7594#145608, @rkflx wrote: > With https://phabricator.kde.org/R223:fcc08449b1c998202e288ad95a167427fa1009bc, Build on CI succeeds again.

D7594: Update to synctex 1.19

rkflx closed this revision. rkflx added a comment. With https://phabricator.kde.org/R223:fcc08449b1c998202e288ad95a167427fa1009bc, Build on CI succeeds again. REPOSITORY R223 Okular REVISION DETAIL

D7594: Update to synctex 1.19

rkflx added a comment. > This broke the Windows build I know, that's why I started setting up a windows machine already yesterday (it has still not finished installing and compiling, though). Basically we need `-lshlwapi`, but I'm not sure if that's enough, so I want to double check.

D7594: Update to synctex 1.19

bcooksley reopened this revision. bcooksley added a comment. This revision is now accepted and ready to land. This broke the Windows build, please see https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.9/11/consoleText REPOSITORY R223 Okular REVISION DETAIL

D7594: Update to synctex 1.19

This revision was automatically updated to reflect the committed changes. Closed by commit R223:bd20e48c3c8c: Update to synctex 1.19 (authored by rkflx). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7594?vs=19133=19459 REVISION DETAIL

D7594: Update to synctex 1.19

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH synctex-update (branched from master) REVISION DETAIL https://phabricator.kde.org/D7594 To: rkflx, #okular, sander, #kile, aacid Cc: mludwig, aacid

D7594: Update to synctex 1.19

rkflx added a comment. Thanks, targeting master matches exactly with my own impact assessment and the FIXED-IN set in the summary. I guess bugs in synctex for particular documents should go upstream, so if you are happy with my integration work, please "accept" it from the Okular side.

D7594: Update to synctex 1.19

aacid added a comment. This looks good to me in a "i've no idea what this does but tests still pass" way. Ideally one would get this into KDE Applications 17.08.x but given it's a big ish change, my suggestion is get it into master for KDE Applications 17.12.0 and this way people that

D7594: Update to synctex 1.19

rkflx updated this revision to Diff 19133. rkflx edited the summary of this revision. rkflx edited the test plan for this revision. rkflx added a comment. Plug multiple leaks and prevent a segfault by adding another patch to the imported synctex code. (The patch seems simple, but the

D7594: Update to synctex 1.19

aacid added a comment. In https://phabricator.kde.org/D7594#141938, @rkflx wrote: > When I run the command you specified, I only get QtTest output. Did you run cmake with `-DECM_ENABLE_SANITIZERS=leak`? address instead of clang, but the output should be the same > Did you

D7594: Update to synctex 1.19

rkflx planned changes to this revision. rkflx added a comment. When I run the command you specified, I only get QtTest output. Did you run cmake with `-DECM_ENABLE_SANITIZERS=leak`? Did you use `clang`? (I'm asking, because the test is leaking for me with both `valgrind` and `liblsan` even

D7594: Update to synctex 1.19

aacid added a comment. Is it possible that a memory leak sneaked in in this code? Without this code if i run ./autotests/editannotationcontentstest i don't get any memory leak but with it i get 5: Direct leak of 131076 byte(s) in 4 object(s) allocated from: 5: #0

D7594: Update to synctex 1.19

rkflx added a reviewer: Kile. rkflx added a subscriber: mludwig. rkflx added a comment. @mludwig As Kile is also providing synctex functionality, maybe you are interested in looking at this patch, too. In my rather simple tests Kile worked fine, but you might be more familiar how it is

D7594: Update to synctex 1.19

rkflx added a comment. Only used bugzilla's quicksearch which omits NEEDSINFO bugs, so I missed this (sorry). There doesn't seem do be any new information though. I'll add a link to this review. When implementing the patch, I had to decide between the version in the texlive svn and

D7594: Update to synctex 1.19

aacid added a comment. How does this relate to https://bugs.kde.org/show_bug.cgi?id=382011 ? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7594 To: rkflx, #okular, sander Cc: aacid

D7594: Update to synctex 1.19

rkflx created this revision. Restricted Application added a project: Okular. REVISION SUMMARY This should prevent crashes when reloading some synctex-enabled pdf files created with newer versions of TeXLive. We also gain bugfixes, features and improved accuracy from the last 6 years of