aacid closed this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7848
To: lexdem, #okular, aacid
Cc: aacid
aacid accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7848
To: lexdem, #okular, aacid
Cc: aacid
lexdem added a comment.
In https://phabricator.kde.org/D7848#146398, @aacid wrote:
> I have to ask, i need your real name to give you proper copyright
attribution and "Lex Dem" doesn't really look like a russian name, could you
please confirm your real name?
Alexey Demennikov.
aacid added a comment.
I have to ask, i need your real name to give you proper copyright attribution
and "Lex Dem" doesn't really look like a russian name, could you please confirm
your real name?
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7848
To: lexdem,
lexdem added a comment.
In https://phabricator.kde.org/D7848#146378, @aacid wrote:
> Did you upload a wrong diff?
Sorry for such a mess. First time commiting
INLINE COMMENTS
> aacid wrote in part.cpp:2206
> Why commented code?
Actually, not sure, if need this lines. Okay, I'll
lexdem updated this revision to Diff 19597.
lexdem added a comment.
Fixed wrong diff
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7848?vs=19595=19597
REVISION DETAIL
https://phabricator.kde.org/D7848
AFFECTED FILES
part.cpp
part.h
To: lexdem,
aacid added a comment.
Did you upload a wrong diff?
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7848
To: lexdem, #okular
Cc: aacid
lexdem updated this revision to Diff 19595.
lexdem added a comment.
Shortened from searching bookmark to just remove with viewport
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7848?vs=19594=19595
REVISION DETAIL
https://phabricator.kde.org/D7848
aacid added inline comments.
INLINE COMMENTS
> part.cpp:2187
> +QUrl bookmarkUrlWithNoHash =
> QUrl(bookmark.url().toString().split('#')[0]);
> +m_document->bookmarkManager()->removeBookmark(
> bookmarkUrlWithNoHash, bookmark );
> +}
Any reason you're not just calling
lexdem updated this revision to Diff 19594.
lexdem added a comment.
Removed commented lines
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7848?vs=19589=19594
REVISION DETAIL
https://phabricator.kde.org/D7848
AFFECTED FILES
part.cpp
part.h
To:
lexdem edited the summary of this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7848
To: lexdem, #okular
Cc: aacid
aacid added a comment.
Please make the summary be correct according
https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages
INLINE COMMENTS
> part.cpp:2206
>
> renameAction->setObjectName(QStringLiteral("OkularPrivateRenameBookmarkActions"));
lexdem updated this revision to Diff 19589.
lexdem added a comment.
removed typo in "rename"
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7848?vs=19586=19589
REVISION DETAIL
https://phabricator.kde.org/D7848
AFFECTED FILES
part.cpp
part.h
To:
lexdem created this revision.
lexdem added a reviewer: Okular.
Restricted Application added a project: Okular.
REVISION SUMMARY
Fix to the bug:357626
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D7848
AFFECTED FILES
part.cpp
part.h
To: lexdem, #okular
Cc: aacid
14 matches
Mail list logo
