D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem added a comment. In https://phabricator.kde.org/D8385#161288, @rkflx wrote: > In https://phabricator.kde.org/D8385#161287, @lexdem wrote: > > > The main conversation happens in #kde-devel, right? Or there is chat in Phabricator too? > > > While Phab has a chat (icon

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

rkflx added a comment. In https://phabricator.kde.org/D8385#161287, @lexdem wrote: > The main conversation happens in #kde-devel, right? Or there is chat in Phabricator too? While Phab has a chat (icon right to the bell icon next to the Phab logo), it is not used as far as I

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem added a comment. In https://phabricator.kde.org/D8385#161286, @rkflx wrote: > I had this already prepared (look at the commit timestamp), and scheduled for tomorrow. But if you want it now, you get it now :) > > Thanks again for the patch, looking forward to more

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

rkflx added a comment. I had this already prepared (look at the commit timestamp), and scheduled for tomorrow. But if you want it now, you get it now :) Thanks again for the patch, looking forward to more contributions. Just ask if you need ideas or help… REPOSITORY R223 Okular

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

This revision was automatically updated to reflect the committed changes. Closed by commit R223:d679b3c9f23d: Set the columns in Overview mode to match the amount of pages if document is… (authored by lexdem, committed by rkflx). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem added a comment. Week already passed? :) I just waiting to continue coding and still didn't ruin the workflow for this commit :) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8385 To: lexdem, #okular, rkflx, ngraham Cc: ltoscano, aacid, rkflx, ngraham

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem added a comment. In https://phabricator.kde.org/D8385#160109, @rkflx wrote: > > So, if there are a lot of products with new features, they're bundled to some new version? Like from 16.12 to 17.04 . Is this also controlled by any kind of CI, to bundle them? Sorry, if I ask too

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

rkflx added a comment. > So, if there are a lot of products with new features, they're bundled to some new version? Like from 16.12 to 17.04 . Is this also controlled by any kind of CI, to bundle them? Sorry, if I ask too much, I'm just curious about the whole process :) You can look

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

ngraham accepted this revision. ngraham added a comment. +1 here too. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8385 To: lexdem, #okular, rkflx, ngraham Cc: ltoscano, aacid, rkflx, ngraham

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem added a comment. Thank you, I will wait for this :) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8385 To: lexdem, #okular, rkflx Cc: ltoscano, aacid, rkflx, ngraham

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. Great, thank you. From my side this LGTM. As mentioned above, we'll wait a week for more comments and then commit on your behalf. REPOSITORY R223 Okular REVISION DETAIL

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8385 To: lexdem, #okular Cc: ltoscano, aacid, rkflx, ngraham

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem added a comment. Yep, sorry. Fixed REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8385 To: lexdem, #okular Cc: ltoscano, aacid, rkflx, ngraham

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

rkflx added a comment. Sorry, you missed one more thing: Your summary still says > User toggles the checkbox which he cannot anymore… REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8385 To: lexdem, #okular Cc: ltoscano, aacid, rkflx, ngraham

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem added a comment. In https://phabricator.kde.org/D8385#158072, @rkflx wrote: > In https://phabricator.kde.org/D8385#158066, @lexdem wrote: > > > @ngraham , changed to the "FEATURE" > > > You changed it to `**FEATURE**`, but the tooling handling this

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8385 To: lexdem, #okular Cc: ltoscano, aacid, rkflx, ngraham

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

rkflx added a comment. In https://phabricator.kde.org/D8385#158066, @lexdem wrote: > @ngraham , changed to the "FEATURE" You changed it to `**FEATURE**`, but the tooling handling this is

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem added a comment. @ltoscano , Thanks, got it. So, if there are a lot of products with `new features`, they're bundled to some new version? Like from 16.12 to 17.04 . Is this also controlled by any kind of CI, to bundle them? Sorry, if I ask too much, I'm just curious about the whole

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem added a comment. @rkflx , Thanks, that was exactly what I wanted to know about the processes in landing of patches here, in Phabricator :) @ngraham , changed to the "FEATURE" REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8385 To: lexdem, #okular Cc:

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8385 To: lexdem, #okular Cc: ltoscano, aacid, rkflx, ngraham

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

ngraham added a comment. Oh I see, https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages says that it's used to aid whoever compiles the release notes, and should be used for actual new features. Anyone know if this is still the case? REPOSITORY

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

ngraham added a comment. @rkflx, what's the difference between FEATURE: and BUG:? @lexdem, once you've made the above changes to the Summary, I will be happy to formally approve this. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8385 To: lexdem, #okular Cc:

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

rkflx added a comment. @lexdem Please change your summary from This is a patch for the following request: 355283 to FEATURE: 355283 so the bugzilla entry will automatically get closed on commit

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

ltoscano added a comment. The distro process is specific to each distribution, so out of scope here. Hera are the release schedules for some of the software developed by KDE, but not all of them (you won't find here Krita, Partitionmanager, etc): https://community.kde.org/Schedules

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

rkflx added a comment. In https://phabricator.kde.org/D8385#157981, @lexdem wrote: > P.P.S Could anyone link me to documentation of whole phabricator-distro process? I mean, which stages should pass the patch to be included in next update of Arch\Ubuntu? I'm not aware of any

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem updated this revision to Diff 21091. lexdem added a comment. Ok, i got you. Let it be just this small :'D P.S. about zoom. I will try to implement that ASAP. P.P.S Could anyone link me to documentation of whole phabricator-distro process? I mean, which stages should pass the patch

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

ngraham added a comment. I'm fine with the new auto-reduction in columns feature going in and not being user-configurable. Perhaps this should be split into two patches: we can use this one for the above feature (minus to UI to turn it on and off), and a new one for a new "Auto" mode,

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

rkflx added a subscriber: aacid. rkflx added a comment. > If I correctly understand you, you want the whole pages to be as small as possible, when you scale down the document and all of them could be visible in the viewport. That's right, e.g. in Continuous mode and fully zoomed out,

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem added a comment. In https://phabricator.kde.org/D8385#157503, @rkflx wrote: > Here is another idea which should accommodate the use case of the bug reporter (not sure how difficult this would be to implement, though): > > In the Overview columns combobox, introduce an Auto

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

rkflx added a comment. Here is another idea which should accommodate the use case of the bug reporter (not sure how difficult this would be to implement, though): In the Overview columns combobox, introduce an Auto mode, which depending on zoom level and window size dynamically adapts

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem added a comment. In https://phabricator.kde.org/D8385#157468, @ngraham wrote: > 1. The word "less" should be replaced with "fewer" in all the places where you've used it. Less is used for an indeterminate quantity (e.g. less rice, less water, less bad). Fewer is used for anything

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem updated this revision to Diff 21027. lexdem added a comment. Renamed all occurrences of word "less" REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8385?vs=21022=21027 REVISION DETAIL https://phabricator.kde.org/D8385 AFFECTED FILES

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

ngraham added a comment. 1. The word "less" should be replaced with "fewer" in all the places where you've used it. Less is used for an indeterminate quantity (e.g. less rice, less water, less bad). Fewer is used for anything you can count (e.g. fewer columns, fewer people, fewer lines of

D8385: Set the columns in "Overview" mode to match the amount of pages if document is small

lexdem created this revision. lexdem added a reviewer: Okular. lexdem added a project: Okular. REVISION SUMMARY This is a patch for the following request: 355283 The principle is simple. User toggles the checkbox, which enables overriding the default columns for Overview mode, if the