KDE CI: Applications okular kf5-qt5 WindowsMSVCQt5.9 - Build # 65 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20WindowsMSVCQt5.9/65/ Project: Applications okular kf5-qt5 WindowsMSVCQt5.9 Date of build: Fri, 17 Nov 2017 06:54:10 + Build duration: 1 hr 58 min and counting JUnit

[okular] [Bug 387030] New: Overview page mode orders pages from right to left.

https://bugs.kde.org/show_bug.cgi?id=387030 Bug ID: 387030 Summary: Overview page mode orders pages from right to left. Product: okular Version: 1.2.1 Platform: Fedora RPMs OS: Linux Status: UNCONFIRMED

D8863: Workaround to build with older Qt

aacid created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. REVISION SUMMARY As explained in the comment we can do with using an older Qt since what this adds is really a small nicety in a corner case Give warnings when

D8863: Give warnings when the file is modified externally

ngraham added inline comments. INLINE COMMENTS > part.cpp:1720 > +res = KMessageBox::warningYesNo( widget(), > + i18n( "You have unsaved > modifications and the file has been modified externally since it was > opened.Unfortunately that

D8863: Give warnings when the file is modified externally

aacid updated this revision to Diff 22515. aacid added a comment. actual diff REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8863?vs=22514=22515 BRANCH file_modified_externally REVISION DETAIL https://phabricator.kde.org/D8863 AFFECTED FILES

D8863: Give warnings when the file is modified externally

aacid added subscribers: ltoscano, rkflx. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8863 To: aacid Cc: rkflx, ltoscano, #okular, ngraham, aacid

[okular] [Bug 387030] Overview page mode orders pages from right to left.

https://bugs.kde.org/show_bug.cgi?id=387030 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |NEEDSINFO

D8863: Give warnings when the file is modified externally

aacid retitled this revision from "Workaround to build with older Qt" to "Give warnings when the file is modified externally". aacid edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8863 To: aacid Cc: #okular, ngraham, aacid

D8863: Give warnings when the file is modified externally

aacid added inline comments. INLINE COMMENTS > ngraham wrote in part.cpp:1720 > How about this? > > "There are unsaved changes, but the file has been modified by another program > since it was opened.Which version would you like to keep?" > > [choices would then be "Keep Okular version" and

D8863: Give warnings when the file is modified externally

aacid added inline comments. INLINE COMMENTS > ngraham wrote in part.cpp:1720 > With "Keep Okular version", could we make it save over the file again using > the copy in memory--including the current state of the user's annotations and > forms? > > If not, then how about this? > > "There are

D8863: Give warnings when the file is modified externally

ngraham added inline comments. INLINE COMMENTS > aacid wrote in part.cpp:1720 > I dont' like this wording, seems like it will let you not lose your changes > if you say "keep okular version". All you can do is "hopefully" still see > what is rendered, but doing much will probably also break