[okular] [Bug 398326] Letter ž is displayed as š instead

https://bugs.kde.org/show_bug.cgi?id=398326 --- Comment #6 from David Hurka --- For me, NotoSans-Regular and NotoSans-Bold are used. When I change /usr/share/fonts/truetype/noto/NotoSans-Regular.ttf to Ubuntu-Regular, it looks equally wrong. When I change it to Tahoma-Regular, it looks correct

[okular] [Bug 398326] Letter ž is displayed as š instead

https://bugs.kde.org/show_bug.cgi?id=398326 David Hurka changed: What|Removed |Added CC||david.hu...@mailbox.org --- Comment #1 from

[okular] [Bug 398326] Letter ž is displayed as š instead

https://bugs.kde.org/show_bug.cgi?id=398326 --- Comment #4 from David Hurka --- Well, I’ve just installed Tahoma and now it’s displayed fine. My Okular action “About Backends” doesn’t work, but in aptitude I have libpoppler 0.41. -- You are receiving this mail because: You are the assignee

D16345: Create new "Zoom to 100%" action

davidhurka added a comment. I think, this action should be in the menu, under “Zoom in” and “Zoom out”. That’s the way I learn about available actions, when I customize my toolbars. I think, “Zoom in” and “Zoom out” are more related than “Zoom in” and “Reset zoom*, so I wouldn’t expect

[okular] [Bug 400189] File > Properties window's initial size is too small for .djvu files

https://bugs.kde.org/show_bug.cgi?id=400189 --- Comment #1 from David Hurka --- I only tried the PDF way. I can’t reproduce that on my system. The properties window can not be resized down until it’s too small for all text lines. When I force it to be smaller (titlebar -> rightclick -> s

[okular] [Bug 400890] Touching file moves the view port

https://bugs.kde.org/show_bug.cgi?id=400890 --- Comment #1 from David Hurka --- Reproduced with: Okular Version: 5.1.2 Operating System: KDE neon 5.13 KDE Plasma Version: 5.14.0 Qt Version: 5.11.1 KDE Frameworks Version: 5.50.0 Happens only with continuous mode on; but with different zooms

Re: "Save copy as" option

On 2018-10-11 03:51 aa...@kde.org wrote: > El dimecres, 10 d’octubre de 2018, a les 21:11:26 CEST, Dominique Delande va escriure: > > Unfortunately, the directory where I would like to save the file is > > often much more than one click away, if it is far from my homedir. > > Then just add it

Re: Brainstorm idea - OCR integration

Hi, I had this idea many times already, because some PDFs have bitmap-only passages or are completely bitmap-only. Selection and the search function don't work there. The search function in Okular should be able to compensate typos, because OCR will probably introduce some typos. The OCR

[okular] [Bug 342003] Trim margins confuses ordering of zoom steps while zooming out

https://bugs.kde.org/show_bug.cgi?id=342003 --- Comment #6 from David Hurka --- Small hint if difficult to reproduce: The trimmed margins must be large enough. If this is not the case in your PDF, try to use "trim to selection" instead of "trim margins" -- You are receivi

[okular] [Bug 141289] Allow navigation panel on the bottom instead of side

https://bugs.kde.org/show_bug.cgi?id=141289 David Hurka changed: What|Removed |Added See Also||https://bugs.kde.org/show_b

[okular] [Bug 399467] Huge symbolic icons in navigation panel look out of place

https://bugs.kde.org/show_bug.cgi?id=399467 David Hurka changed: What|Removed |Added See Also||https://bugs.kde.org/show_b

[okular] [Bug 141289] Allow navigation panel on the bottom instead of side

https://bugs.kde.org/show_bug.cgi?id=141289 --- Comment #11 from David Hurka --- How about using dock panels for Thumbnails, Bookmarks, etc.? The dock panel stack would have a tab bar at the bottom, and if no dock panel is shown, they can be activated using toolbar buttons. This way it would

[okular] [Bug 399488] New: Move page bar to main toolbar by default

https://bugs.kde.org/show_bug.cgi?id=399488 Bug ID: 399488 Summary: Move page bar to main toolbar by default Product: okular Version: unspecified Platform: unspecified OS: unspecified Status: REPORTED

[okular] [Bug 398929] Feature Request re Bottom Scroll Bar and Scaling

https://bugs.kde.org/show_bug.cgi?id=398929 --- Comment #1 from David Hurka --- Don't worry, other people are as clumsy as you. I can't reproduce this behavior with Okular 1.5.1. But it sounds familar to me. Which mouse button and which mode (browse, zoom, selection) do you use? Does your

[okular] [Bug 401098] Printing stops at first hyperlink, incomplete pages.

https://bugs.kde.org/show_bug.cgi?id=401098 --- Comment #1 from David Hurka --- Reproduced on my machine. Apparently, Okular doesn't like itself... Okular Version: 1.5.2 Operating System: KDE neon 5.13 KDE Plasma Version: 5.14.0 Qt Version: 5.11.1 KDE Frameworks Version: 5.50.0 -- You

[okular] [Bug 403445] New: Explain purpose of filter text boxes in side panels

https://bugs.kde.org/show_bug.cgi?id=403445 Bug ID: 403445 Summary: Explain purpose of filter text boxes in side panels Product: okular Version: 1.6.1 Platform: Other OS: Linux Status: REPORTED Severity:

[okular] [Bug 403486] Folded navigation bar

https://bugs.kde.org/show_bug.cgi?id=403486 --- Comment #5 from David Hurka --- I see the problem, but an option to show/hide it at opening new documents would not do it for me. When I open an email attachment, I usually do not need the side bars. But when I open a microcontroller datasheet, I

[okular] [Bug 403486] Folded navigation bar

https://bugs.kde.org/show_bug.cgi?id=403486 --- Comment #8 from David Hurka --- Created attachment 117615 --> https://bugs.kde.org/attachment.cgi?id=117615=edit Words used by David -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 403486] Folded navigation bar

https://bugs.kde.org/show_bug.cgi?id=403486 --- Comment #9 from David Hurka --- Maybe I understood you wrong, so I will try to clarify. I thought you are talking about showing/hiding the Thumbnails/Contents Panel when opening a new document, provided the Navigation Bar is already shown

D18238: Implements a new button on findbar that allows users to choose the color that highlights the text

davidhurka added a comment. In D18238#394075 , @ngraham wrote: > I'm not really sold either. No other app has this setting. It seems like one of the major reasons why we have a color scheme and color chooser system is precisely so individual

[okular] [Bug 402110] New: Table Selection should not pollute clipboard history

https://bugs.kde.org/show_bug.cgi?id=402110 Bug ID: 402110 Summary: Table Selection should not pollute clipboard history Product: okular Version: unspecified Platform: Other OS: unspecified Status: REPORTED

[okular] [Bug 169516] RFE: add configuration setting for default zoom

https://bugs.kde.org/show_bug.cgi?id=169516 --- Comment #52 from David Hurka --- I would like it if the zoom is not remembered per document, because I usually read datasheets, zoom into one small detail, and close the datasheet. The next time I open it, I always have to zoom out. Dolphin has

[okular] [Bug 401944] Copy listings created in Latex not copied properly

https://bugs.kde.org/show_bug.cgi?id=401944 --- Comment #1 from David Hurka --- I'm sure this is not an okular bug, because it also happens with pdftotext. pdftotext related to poppler, so it might be a poppler bug. $ pdftotext /tmp/OkularBug.pdf $ cat /tmp/OkularBug.txt Listing 1: Skript um

[okular] [Bug 401329] Order of Next and Previous buttons while searching in Okular should be reversed

https://bugs.kde.org/show_bug.cgi?id=401329 --- Comment #1 from David Hurka --- This layout is the same as in most other KDE applications, and I think it's fine. I personally can't imagine whether another order is easier to understand. A simple test might be invoking okular with "o

[okular] [Bug 401268] Freehand lines rendered ugly as you write and look good only after you finish

https://bugs.kde.org/show_bug.cgi?id=401268 --- Comment #1 from David Hurka --- With my okular, the width is correct while drawing. It's just not antialiased, and it flashes once when the line is finished. Okular Version: 1.5.2 Operating System: KDE neon 5.13 KDE Plasma Version: 5.14.0 Qt

[okular] [Bug 401269] Shape recognition for the freehand line tool

https://bugs.kde.org/show_bug.cgi?id=401269 --- Comment #1 from David Hurka --- There was KGestures once (or still is?), which used libstroke. gschem still uses libstroke. It claims, that it can detect when you are trying to draw an 'E' as gesture, but even struggles at detecting a 'D'. I had

[okular] [Bug 401329] Order of Next and Previous buttons while searching in Okular should be reversed

https://bugs.kde.org/show_bug.cgi?id=401329 --- Comment #5 from David Hurka --- (In reply to Nate Graham from comment #2) > Not all KDE apps use this layout; Konsole for example has Previous before > Next. Not really, the buttons change when you deselect "Search Backwards". K

[okular] [Bug 401441] Post-suspend Okular shows a blank screen, not the slide

https://bugs.kde.org/show_bug.cgi?id=401441 --- Comment #1 from David Hurka --- When I try to suspend, my computer reboots instead... When I lock and unlock the screen, Okular behaves as expected. As you use the word "slide" and mention the popping-up menu: Do you mean "Pr

[okular] [Bug 398605] Closing the 'find' toolbar should clear search field

https://bugs.kde.org/show_bug.cgi?id=398605 David Hurka changed: What|Removed |Added CC||david.hu...@mailbox.org --- Comment #1 from

D18744: Add action in Edit menu to select the text on current page

davidhurka added a comment. In D18744#438675 , @shubham wrote: > Do not delete area Interestingly, setPageTextSelection() deletes area (without making it nullptr). Shouldn’t this side effect be documented (in another patch)? INLINE

[okular] [Bug 404803] please restore old behaviour for storing PDF annotations in separate file

https://bugs.kde.org/show_bug.cgi?id=404803 --- Comment #5 from David Hurka --- This dates back to... long ago? There are basically these commits (and probably others) which introduced this message (KMessageWidget *Okular::Part::m_migrationMessage): commit

D19183: Use logically correct icon for direction arrows

davidhurka added a comment. In D19183#420861 , @aacid wrote: > Isn't this broken when using a RTL layout? Yes, now that you say it... The test for layoutDirection() should be removed. REPOSITORY R223 Okular BRANCH icon REVISION

D19123: [WIP]Added option to search for whole words only

davidhurka added a comment. In D19123#414714 , @joaonetto wrote: > This works properly for most cases, but still, it has some limitations. > If searching for r on a text, and the text contains R$, the R will be found. > Every word that

D19183: Use logically correct icon for direction arrows

davidhurka added a comment. Up and down arrows are equivalent to arrow key behavior, both in the view area and the PageNumberEdit. It also fits better to documents with RTL page layout (mangas) (if there are such documents). It’s just irritating next to the PageNumberEdit, where “Up”

D19542: [WIP] Make pop-up note text visible whatever background color is

davidhurka added a comment. In D19542#425756 , @yurchor wrote: > Do you mean that the attached test case (text.pdf) works for you (the text in annotation window for the right blue pop-up note is visible)? No, but the functionality is

D19542: [WIP] Make pop-up note text visible whatever background color is

davidhurka added a comment. Erm, my Okular 1.6.2 already does this, just with another threshold. Below value() = 129, the text (and the header) become white, above value() = 128, they become black. While searching for the code, I just found ui/drawingtoolactions.cpp:48, which does

D19542: [WIP] Make pop-up note text visible whatever background color is

davidhurka added a comment. After reading some Wikipedia, I can say: - Checkmarks use luma (NTSC) - Your approach uses luma (sRGB) - QColor::lightness() uses lightness (HSL-bi-hexcone) QColor::lightness() would not solve the problem, it would put white #ff text on yellow

D19539: Replace some iterator loops by range-based for

davidhurka added a comment. Isn’t `auto` a bit confusing as item type? A beginner like me wouldn’t understand that. Example (pageview.cpp:1194): `page` is an item of `pageSet`, which is `QVector< Okular::Page * >`. If I don’t know that: `PageViewItem * item = new PageViewItem( page

D18816: Accept and ignore event

davidhurka added a comment. You have little conversation output, and I have little understanding of QEvent. But lets start to explain why the event should not be propagated to another widget, although there was no annotation or the mouseMode is not TextSelect? Alternatively: Which

[okular] [Bug 405542] freehand line changes to panning after 1 stroke

https://bugs.kde.org/show_bug.cgi?id=405542 --- Comment #3 from David Hurka --- (In reply to Oliver Sander from comment #2) > Anyone for replacing double clicks by single clicks here? In general, me. But currently, every stroke becomes a new annotation. -- You are receiving this mail beca

D18744: Add action in Edit menu to select the text on current page

davidhurka added a comment. In D18744#413768 , @aacid wrote: > Do not use Alt+Letter for a shortcut, it's bad. Because Alt is used for Access Keys (Mnemonics), right? In D18744#413776 ,

[okular] [Bug 403943] Entries in table of contents should be normalized (whitespace stripped)

https://bugs.kde.org/show_bug.cgi?id=403943 --- Comment #4 from David Hurka --- (In reply to Albert Astals Cid from comment #3) > Adobe Reader [...] Ah, that is why PDFs are deployed with such excessive whitespace in the TOC. Then Okular should probably not silently remove the whitesp

D18744: Select entire page on mouse double click event

davidhurka added a comment. In D18744#405851 , @ngraham wrote: > However I wonder if maybe triple-click might be better though? Triple-click is used for "select everything" in word processors, so perhaps we could take advantage of some

[okular] [Bug 403975] New: Background color for text selection in the document should be configurabe, instead of relying on system color scheme

https://bugs.kde.org/show_bug.cgi?id=403975 Bug ID: 403975 Summary: Background color for text selection in the document should be configurabe, instead of relying on system color scheme Product: okular Version:

[okular] [Bug 403943] Entries in table of contents should be normalized (whitespace stripped)

https://bugs.kde.org/show_bug.cgi?id=403943 --- Comment #2 from David Hurka --- I see that this makes it easier to read a document (sometimes). It makes sense to preserve the true contents of a document (e. g. to test some LaTeX output), but it would be nice to have this as option, similar

[okular] [Bug 403755] Highlight does not work on rotated pages

https://bugs.kde.org/show_bug.cgi?id=403755 --- Comment #1 from David Hurka --- Wow... Confirmed with: Okular 1.6.1 KDE Neon 5.14 (Ubuntu 18.04) KDE Frameworks 5.54 Qt 5.11.2 Poppler 0.62 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 403782] Okular trying to save a PDF to an URL location

https://bugs.kde.org/show_bug.cgi?id=403782 --- Comment #5 from David Hurka --- avlas' use case is (similar to) 1. clicking a PDF link in a web browser -> opens in Okular 2. wanting to keep the PDF file 3. clicking Save As (because Save obiously doesn't work) Then avlas wants Save As to sugg

[okular] [Bug 403782] Okular trying to save a PDF to an URL location

https://bugs.kde.org/show_bug.cgi?id=403782 --- Comment #6 from David Hurka --- I thought a bit about this. (In reply to David Hurka from comment #5) > Better would be > [_] If document URL is non-writable [...] This could be confusing, if URLs randomly appear to be non-writable. Also,

D18623: Add a new RenderMode in the accessibility settings: Use System Colors

davidhurka added a comment. In D18623#402834 , @emateli wrote: > Perhaps this patch might not be it, but Okular does actually need a "Night Mode" or "Reading Mode" of sorts, in similar fashion to many epub/pdf readers like @filipf suggests.

[okular] [Bug 403943] New: Entries in table of contents should be normalized (whitespace stripped)

https://bugs.kde.org/show_bug.cgi?id=403943 Bug ID: 403943 Summary: Entries in table of contents should be normalized (whitespace stripped) Product: okular Version: 1.6.1 Platform: unspecified OS:

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

https://bugs.kde.org/show_bug.cgi?id=384267 --- Comment #14 from David Hurka --- (In reply to Albert Astals Cid from comment #1) > No, that solution doesn't work, because people that use dark themes (where > selection is usually a white-ish color) would not see the selection when > rea

D21195: [RFC] Create a Change Colors menu (with toolbar button)

davidhurka marked 2 inline comments as done. davidhurka added a comment. I have added CheckableActionMenu, which cuts the default action connection between the KActionMenu itself and the toolbar button. Now it is possible to make the toolbar button checkable, but not the submenu. But

D21195: [RFC] Create a Change Colors menu (with toolbar button)

davidhurka updated this revision to Diff 58133. davidhurka marked an inline comment as done. davidhurka added a comment. - Toolbar button finally shows the intended menu - Add icon for Configure... action - Corrected action-slot connections - Named enable/disable action "Change Colors"

D21195: [RFC] Create a Change Colors menu (with toolbar button)

davidhurka updated this revision to Diff 58129. davidhurka added a comment. Removed checkbox from submenu, but toolbar button invents other menu structure REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21195?vs=58102=58129 BRANCH

D21195: [RFC] Create a Change Colors menu (with toolbar button)

davidhurka marked an inline comment as done. davidhurka added a comment. I have figured out, what was going on in the QToolButton. KActionMenu::createWidget() added itself as default action. Then, CheckableActionMenu::createWidget() adds another action as default action. Then, the

[okular] [Bug 407884] Previous/Next Bookmark don’t work like their section title suggests if triggered from Contents side panel context menu

https://bugs.kde.org/show_bug.cgi?id=407884 David Hurka changed: What|Removed |Added Summary|Previous/Next Bookmark |Previous/Next Bookmark |don’t

[okular] [Bug 402017] Cannot save PDF when loaded file has been deleted

https://bugs.kde.org/show_bug.cgi?id=402017 --- Comment #5 from David Hurka --- Just discovered a class FileKeeper, which should do this. Added in commit 6531398b919e58def8c6ba4711d20ea517147189, eleven years ago. Just grep for #ifdef OKULAR_KEEP_FILE_OPEN -- You are receiving this mail

[okular] [Bug 407884] Previous/Next Bookmark don’t work correctly if triggered from Contents side panel context menu

https://bugs.kde.org/show_bug.cgi?id=407884 --- Comment #2 from David Hurka --- So it’s intended that they don’t do what the menu says, but do what the menu would say if invoked another way? -- You are receiving this mail because: You are the assignee for the bug.

D18358: Add buttons to collapse and expand all elements

davidhurka added inline comments. INLINE COMMENTS > side_reviews.cpp:156 > +connect(expandAll, ::triggered, this, ::slotExpandAll); > +QAction * collapseAll = toolBar->addAction( QIcon::fromTheme( > QStringLiteral("collapse-all") ), i18n( "Collapse all elements" ) ); > +

D21376: RFC: In annotations list show highlighted text

davidhurka added a comment. In D21376#469822 , @davidhurka wrote: > Your code: Wouldn’t static_cast<>() be better than a C-style cast? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21376 To: jangmarker,

D21364: Indicate annotation color in annotation list

davidhurka added a comment. Why do you move EditAnnotToolDialog to GuiUtils? / How does the annotation tool bar (shown with F6) get its icons? I’m not familar with the annotation implementation, but if you move this function arround, I would expect it as virtual function in Annotation,

D21364: Indicate annotation color in annotation list

davidhurka added a comment. In D21364#469241 , @jangmarker wrote: > Now it looks like this: > > F6844521: image.png Looks ok, but if someone makes PageViewAnnotator::makeToolPixmap() return a

D21376: RFC: In annotations list show highlighted text

davidhurka edited reviewers, added: aacid; removed: davidhurka. davidhurka added a comment. You are not touching “Highlight with Comment”-style texts, which is probably good. (And would fit in another commit anyway.) There was a discussion about this in D10797

D21376: RFC: In annotations list show highlighted text

davidhurka added inline comments. INLINE COMMENTS > guiutils.cpp:130 > +ret = hasComment ? i18n( "Underline with Comment" ) : > + text.isEmpty() ? i18n( "Underline" ) : i18n( > "Underline: %1", text); > break; i18nc could be

D21281: [RFC] Write a bit Documentation for Part and PageView

davidhurka added a comment. Giving up for today, there are so many functions of the format open*(url). You can now look at my changes and comments and so on. If some of my questions contratict themselves (like questions normally do...), feel free to ask. ;) I will make a list

D21281: [RFC] Write a bit Documentation for Part and PageView

davidhurka added a comment. If you say “at this low level”, would being more abstract make more sense? The documentation of e. g. showMenu() is really low level now, and people are lazy and break it up. If it just explains when it should be called, it should work fine for some time,

D21281: [RFC] Write a bit Documentation for Part and PageView

davidhurka updated this revision to Diff 58664. davidhurka added a comment. Did exactly this (and some more) - Improve code documentation of updateViewActions() and showMenu() - Document random member functions of Part, including showMenu() - Document more random member functions of

[okular] [Bug 407731] can't open amazon invoices

https://bugs.kde.org/show_bug.cgi?id=407731 --- Comment #13 from David Hurka --- The firefox nssdb is used to verify that the digital signatures are "cryptografically valid", whatever *exactly* that means, I guess? -- You are receiving this mail because: You are the assignee for the bug.

D21281: [RFC] Write a bit Documentation for Part and PageView

davidhurka added a comment. I’m complaining a lot about the source code. Don’t understand that as arrogant demand to fix it, just tell me to do it. Anyway, the code works, so no need to change it? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21281 To:

D21271: [WIP] Improve documentation of TextEntity stuff

davidhurka marked an inline comment as done. davidhurka added inline comments. INLINE COMMENTS > aacid wrote in textpage_p.h:32 > Ah, you're trying to export already existing functions :D > > Didn't realize that. > > Why do you want to export them? Yes their are interesting, but where would >

D21281: [WIP] Write Documentation for Okular::Part

davidhurka retitled this revision from "[RFC] Write Documentation for Okular::Part" to "[WIP] Write Documentation for Okular::Part". davidhurka edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21281 To: davidhurka, #okular Cc: ognarb,

[okular] [Bug 408222] Okular is bad in displaying of scanned PDF ! Please fix this !

https://bugs.kde.org/show_bug.cgi?id=408222 --- Comment #3 from David Hurka --- Created attachment 120507 --> https://bugs.kde.org/attachment.cgi?id=120507=edit Page 188 in Okular A friend just told me that this is readable. However, how does it look different in Evince? It uses the s

D21266: [WIP] Improve documentation of area classes

davidhurka marked 10 inline comments as done. davidhurka added a comment. I will remove page sizes from member documentations and describe the coordinate system with a more abstract reference rectangle. Page sizes and zoom and so on will just be an application of the normalized

D21266: [WIP] Improve documentation of area classes

davidhurka marked 4 inline comments as done. davidhurka added inline comments. INLINE COMMENTS > aacid wrote in area.h:108 > i don't know, you may want to ask Peter, but it was 6 years ago, i doubt he > remembers. > > What's your problem with it being static? It would make sense to make it

D21271: [WIP] Improve documentation of TextEntity stuff

davidhurka marked 4 inline comments as done. davidhurka added inline comments. INLINE COMMENTS > aacid wrote in textpage.cpp:1880 > pagesSizeMetric defines what pagesize means for your generator. Ok, if it is documented directly in Generator, it should be sufficient. Maybe I was looking at

D21281: [RFC] Write Documentation for Okular::Part

davidhurka marked 6 inline comments as done. davidhurka added a comment. Sometimes I’m working on PageView, but I move it out of this patch because it’s less related than I thought. And this is enough stuff for a single patch for now... INLINE COMMENTS > davidhurka wrote in part.cpp:1746 >

D21266: [WIP] Improve documentation of area classes

davidhurka updated this revision to Diff 59149. davidhurka marked an inline comment as done. davidhurka edited the summary of this revision. davidhurka added a comment. Removed references to pages from methods. Now they refer to a reference area, and the description of the normalized

[okular] [Bug 408222] Okular is bad in displaying of scanned PDF ! Please fix this !

https://bugs.kde.org/show_bug.cgi?id=408222 --- Comment #10 from David Hurka --- Created attachment 120580 --> https://bugs.kde.org/attachment.cgi?id=120580=edit Pixels Using Albert’s screenshot, one could say that Evince and Okular draw slightly different. Indeed, where the arrow poi

D15580: New annotation toolbar

davidhurka added a comment. In D15580#473824 , @ngraham wrote: > Sticky-by-default would probably be okay as long as we can make it //very// clear how to un-select the tool. Probably implementing multiple methods would be good (hit esc key,

[okular] [Bug 408273] Scaling mode "Print original size" is confusing

https://bugs.kde.org/show_bug.cgi?id=408273 --- Comment #1 from David Hurka --- See also the discussion about these new scaling options. (Pointing to one comment explaining the issue.) https://phabricator.kde.org/D7962#339567 -- You are receiving this mail because: You are the assignee

D15580: New annotation toolbar

davidhurka added a comment. In D15580#474457 , @simgunz wrote: > In D15580#474436 , @simgunz wrote: > > > > Or: Why is this still PageViewToolBar? It is not anymore in the PageView? > > > >

D10859: Improve layout of annotation configuraton dialogs

davidhurka added a comment. In D10859#472322 , @simgunz wrote: > For Highlighter and Geometrical shape I moved the annotation type to the top, before the color/size settings. What do you think? Makes sense, most important setting first.

D10859: Improve layout of annotation configuration dialogs

davidhurka added a comment. In D10859#472473 , @simgunz wrote: > Not only straight line, but also freehand line, geometrical shape and polygon (with the same meaning). I agree with you, but on the other hand in drawing software like Krita or

[okular] [Bug 407438] Text hinting causes failure to render some texts

https://bugs.kde.org/show_bug.cgi?id=407438 --- Comment #2 from David Hurka --- (In reply to Lukas Jelinek from comment #0) > EXPECTED RESULT > All text are rendered as with text hinting disabled. May I ask how the hinting works for the rendered texts? I enabled hinting in my Okular, an

[okular] [Bug 334297] Highlighter of the review tool does not work correct in rotated views of the pdf document

https://bugs.kde.org/show_bug.cgi?id=334297 --- Comment #4 from David Hurka --- (In reply to David Hurka from comment #3) > Seems like Okular passes the wrong RegularAreaRect to the highlighter tool, > a RegularAreaRect that somehow got the page rotation applied. Experimented

D21266: [WIP] Improve documentation of area classes

davidhurka added a comment. Turns out that the coordinate system of RegularAreaRect, as it is used by TextPage::textArea(TextSelection), is //not// independent of the page display. textArea() transforms the whole RegularAreaRect with the current totalRotation() of the Page. REPOSITORY

D21266: [WIP] Improve documentation of area classes

davidhurka added a comment. Turns out that nothing is independent of page rotation, just discovered PagePrivate::rotateAt(Okular::Rotation), which transforms everything what is known to rotateAt(). Turns out that two facts turned out which let me wonder about the limited purpose of the

D21622: Use a more conventional dropdown menu style instead of press-and-hold

davidhurka added a comment. In D21622#475197 , @ngraham wrote: > clicking on the arrow on the right side of the button will open the pop-up and allow choosing another tool, which is a more common method of implementing the feature. How

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

davidhurka added a comment. In D21635#475541 , @ngraham wrote: > The current keyboard shortcuts aren't a problem if we don't re-arrange the items in the Selection Mode toolbar button. Is it important to have a 3-4-5 order in that button

Re: Your comments to [Bug 408222]

probably others can provide some information where I am speculating, unless you can. :) > Am 04.06.2019 22:20 schrieb David Hurka: > > Could have these reasons: > > a) Both have a slightly different alignment of the scanned image, > > resulting in > > different samplin

D21281: [RFC] Write a bit Documentation for Part and PageView

davidhurka updated this revision to Diff 58857. davidhurka added a comment. - Add structure to open*(url) methods documentation, shown in Detailed Description of Part - Make showMenu() documentation more generic. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

[okular] [Bug 332117] Feature request: more flexibility in inline notes

https://bugs.kde.org/show_bug.cgi?id=332117 --- Comment #8 from David Hurka --- Is this fixed with the new “Typewriter” annotation tool now? These are Typewriter annotations: (In reply to avlas from comment #0) > - transparent background (but not necessarily text as well, as opacity d

D21416: Add icons for line annotation arrow styles to combo box

davidhurka added a comment. The UI looks good and I understand the code. :) For dark color themes: maybe the color of the adjacent text would be good as foreground color for the icons. Don’t know, but maybe QGuiApplication::pallete().color(QPalette::WindowText)? REPOSITORY R223

D21281: [RFC] Write a bit Documentation for Part and PageView

davidhurka added a comment. Got an overview of open-a-document methods in the Detailed Description of Part. Helped me a lot, can it stay there? I made some method descriptions a bit more robust to future changes (I think) by making them more abstact and focusing a bit more on the

D10859: Improve layout of annotation configuraton dialogs

davidhurka added a comment. Just tried this. Maybe you can bring back the section headings, which were group box labels before? Straight Line got many options recently. Not working buddys (probably a problem with PixmapPreviewSelector): Popup-Note -> Icon (Alt + i) Stamp -> Stamp

D15580: New annotation toolbar

davidhurka added a comment. In D15580#473733 , @ngraham wrote: > >> - I can't figure out what Pin Annotation actually does > > > > If checked the current annotation tool is kept selected after use (as double-click does in the current

D10859: Improve layout of annotation configuration dialogs

davidhurka added inline comments. INLINE COMMENTS > simgunz wrote in dlgannotationsbase.ui:71 > I have not understood the reason. This message is only displayed in the > configuration dialog. In any case we could change it for me. In D10859#472832 ,

D21416: Add icons for line annotation arrow styles to combo box

davidhurka added a comment. In D21416#472772 , @tobiasdeiminger wrote: > In D21416#471897 , @tobiasdeiminger wrote: > > > In D21416#471795 , @davidhurka

D21281: [RFC] Write Documentation for Okular::Part

davidhurka retitled this revision from "[RFC] Write a bit Documentation for Part and PageView" to "[RFC] Write Documentation for Okular::Part". davidhurka edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21281 To: davidhurka, #okular

[okular] [Bug 408272] The default scaling method should be "Fit to Full Page"

https://bugs.kde.org/show_bug.cgi?id=408272 --- Comment #8 from David Hurka --- (In reply to Nate Graham from comment #4) > - Make the scaling combobox more visible and prominent so it's easier to > notice and change Additionally to that, could there be a graphic next to the combobox to e

  1   2   3   4   5   6   7   8   9   10   >