rkflx created this revision.
Restricted Application added a project: Okular.
REVISION SUMMARY
For some combinations of font and font size, text labels in the sidebar
are rendered incorrectly, i.e. the right and left border is cut off.
This is a problem internal to the text label and not rela
rkflx edited the test plan for this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D6695
To: rkflx, #okular
Cc: aacid
rkflx created this revision.
Restricted Application added a project: Okular.
REVISION SUMMARY
In some languages the sidebar container header is wider than the
minimum container width and therefore cut off. By removing the
explicitly set minimum width, the QVBoxLayout is now allowed to
actu
rkflx added a comment.
Thanks for looking at my patch, but I'm not sure I'm understanding you
completely here (you didn't state a reason for your preference). How would this
fix the header text being cut off and the (seemingly) arbitrary max width
restriction? Hardcoding any fixed widths (ev
rkflx planned changes to this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D6696
To: rkflx, #okular, aacid
Cc: aacid
rkflx planned changes to this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D6695
To: rkflx, #okular
Cc: aacid
rkflx added a comment.
I guess this discussion is more about behaviour than about
implementation. Should we artificially restrict min and max widths? IMHO
no, and the HIG doesn't talk about it either.
As for the potential change in min width (see screenshots above for most
extreme
rkflx added a comment.
> setMaximumWidth( 600 * QGuiApplication::devicePixelRatio )
Suprisingly, this is not needed at all. The scaling is already working in
HiDPI mode, still restricted to 600px*scalefactor though. I'll modify my
argument to concern ultrawide screens so it still stand
rkflx updated this revision to Diff 1.
rkflx added a comment.
> use elided text and set a non-eliding default
Updated patch accordingly.
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6696?vs=16687&id=1
BRANCH
arcpatch-D6696 (branched from ma
rkflx retitled this revision from "Fix cut off text in sidebar header, remove
restricted max width" to "Elide cut off text in sidebar header, remove
restricted max width".
rkflx edited the summary of this revision.
rkflx edited the test plan for this revision.
rkflx added a dependency: D7164: KSq
rkflx added a comment.
> stupidly unusable
I find it really hard to translate this kind of comment into actionable
feedback I can improve upon, because this neither details an actual problem,
nor does it suggest an alternative size.
Instead, let me expand on the properties of my pro
rkflx added a comment.
Thanks for the screenshot, now I know you are talking about the max width of
the thumbnail sidebar for vertical documents. I guess you are fine with
removing the min width.
As said above, I think users are perfectly capable to decide for themselves
which width the
rkflx added reviewers: sander, pino.
rkflx added a subscriber: pino.
rkflx added a comment.
@pino: `arc cover` and `git blame` printed your name. If you find the time,
I'd be happy if you could take a look at my patch.
@sander: Do you happen to know other reviewers who have an interest in
13 matches
Mail list logo
