D7949: Allow to print pdf doc directly into a QPrinter

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. Please move as a Merge Request in https://invent.kde.org/kde/okular We have pre-commit CI and lots of checks including clazy and clang-tidy there so it's a much better place for

D7949: Allow to print pdf doc directly into a QPrinter

sander added a comment. > There's a GitHub project at https://github.com/giddie/poppler-cairo-backend , but from how I read the related bug report, upstream integration is very unlikely. What I meant was rather https://stackoverflow.com/questions/1639895/cairo-and-qt-integration . REPO

D7949: Allow to print pdf doc directly into a QPrinter

michaelweghorn added a comment. Thanks for the explanation! In D7949#387980 , @sander wrote: > I found the Cairo-to-Qt-backend quite interesting, but I haven't heard from that for a while. There's a GitHub project at https://github.co

D7949: Allow to print pdf doc directly into a QPrinter

sander added a comment. The quality of the Arthur backend really depends on what you use it for. For example, I personally mostly use Okular for scientific articles and presentations, and Arthur works almost perfectly for that. But for other types of documents, however, the situation may b

D7949: Allow to print pdf doc directly into a QPrinter

michaelweghorn added a comment. I find the approach interesting at least. However, I currently don't know enough of the different Poppler backends to really assess the situation properly. My thought was that it might possibly make sense to add an experimental option to enable this and https

D7949: Allow to print pdf doc directly into a QPrinter

aacid added a comment. In D7949#384226 , @ngraham wrote: > I'm still interested! Anything that improves Okular's printing reliability is a good idea in my book. :) Don't want to bash anyone but printing with the poppler Arthur backend is f

D7949: Allow to print pdf doc directly into a QPrinter

yurchor added a comment. In D7949#384226 , @ngraham wrote: > I'm still interested! Anything that improves Okular's printing reliability is a good idea in my book. :) +1 if it counts. REPOSITORY R223 Okular REVISION DETAIL https://pha

D7949: Allow to print pdf doc directly into a QPrinter

ngraham added a comment. I'm still interested! Anything that improves Okular's printing reliability is a good idea in my book. :) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7949 To: sander, #okular Cc: okular-devel, asturmlechner, cfeck, ltoscano, rkflx, michael

D7949: Allow to print pdf doc directly into a QPrinter

sander added a comment. > Where are we at with this? What are the blockers to landing it? Partly: I am still unsure how much interest there actually is for this patch. If you like it and you would like to see it in Okular, please speak up. REPOSITORY R223 Okular REVISION DETAIL htt

D7949: Allow to print pdf doc directly into a QPrinter

sander updated this revision to Diff 48405. sander added a comment. Rebased to current master, and connected the code to the new print scaling modes. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7949?vs=37522&id=48405 REVISION DETAIL https://phabricato

D7949: Allow to print pdf doc directly into a QPrinter

ngraham removed a dependent revision: D7962: Implement several new print scaling options. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7949 To: sander, #okular Cc: okular-devel, asturmlechner, cfeck, ltoscano, rkflx, michaelweghorn, ngraham, aacid, darcyshen

D7949: Allow to print pdf doc directly into a QPrinter

ngraham added a dependent revision: D7962: Implement several new print scaling options. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7949 To: sander, #okular Cc: okular-devel, asturmlechner, cfeck, ltoscano, rkflx, michaelweghorn, ngraham, aacid, darcyshen

D7949: Allow to print pdf doc directly into a QPrinter

ngraham added a comment. Where are we at with this? What are the blockers to landing it? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7949 To: sander, #okular Cc: okular-devel, asturmlechner, cfeck, ltoscano, rkflx, michaelweghorn, ngraham, aacid

D7949: Allow to print pdf doc directly into a QPrinter

rkflx resigned from this revision. This revision now requires review to proceed. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7949 To: sander, #okular Cc: okular-devel, asturmlechner, cfeck, ltoscano, rkflx, michaelweghorn, ngraham, aacid

D7949: Allow to print pdf doc directly into a QPrinter

sander added a comment. > Also, would it make sense to have an (additional?) experimental option to enable the Arthur backend in general, i.e. for showing the content on screen (as a separate change), so people who really want to experiment can do so even more? That is https://git.revie

D7949: Allow to print pdf doc directly into a QPrinter

michaelweghorn added inline comments. INLINE COMMENTS > sander wrote in generator_pdf.cpp:1349 > The idea was the following: New conditional are introduced that surround > existing code. For nice identation all of that would have to be reformated, > which makes for a patch full of whitespace c

D7949: Allow to print pdf doc directly into a QPrinter

michaelweghorn added a comment. In D7949#295165 , @sander wrote: > The patch should not influence the behavior of rasterized printing. The code used QPrinter with the poppler splash backend before, and it should still do that. I might be

D7949: Allow to print pdf doc directly into a QPrinter

sander added a comment. The patch should not influence the behavior of rasterized printing. The code used QPrinter with the poppler splash backend before, and it should still do that. Thanks for all the heads up given in this thread, but since Albert was so much opposed to this patch a

D7949: Allow to print pdf doc directly into a QPrinter

michaelweghorn added a comment. In general, I really like the idea of providing this new option. Two notes after having a quick look (besides the two comments directly on the code): - Depending on what the use case for the option is (Will users who want to use this experimental feat

D7949: Allow to print pdf doc directly into a QPrinter

rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. Thanks, accepting the Diff from my side (obviously I cannot speak for the Okular project). In D7949#290074 , @sander wrote: > That is https:

D7949: Allow to print pdf doc directly into a QPrinter

sander marked 3 inline comments as done. sander added a comment. >>Unlike for CUPS printing, Qt printing prints on the entire page and does not scale to the printable area yet. This is only because it is the easiest way. I > >plan to implement a few standard scaling methods in a subsequent p

D7949: Allow to print pdf doc directly into a QPrinter

sander updated this revision to Diff 37522. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7949?vs=37521&id=37522 REVISION DETAIL https://phabricator.kde.org/D7949 AFFECTED FILES generators/poppler/generator_pdf.cpp To: sander, #okular Cc: okular-devel, a

D7949: Allow to print pdf doc directly into a QPrinter

sander updated this revision to Diff 37521. sander added a comment. Restricted Application added a subscriber: okular-devel. Applied Henrik's suggestions REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7949?vs=37025&id=37521 REVISION DETAIL https://phabric

D7949: Allow to print pdf doc directly into a QPrinter

rkflx added a comment. Thanks for the update. Still found some minor things, otherwise LGTM. --- > Unlike for CUPS printing, Qt printing prints on the entire page and does not scale to the printable area yet. This is only because it is the easiest way. I plan to implement a few stan

D7949: Allow to print pdf doc directly into a QPrinter

sander added a comment. I just uploaded a new version of the diff that fixes all remaining issues. Also, I implemented type 3 support in the Arthur backend, and it is already in poppler 0.64. That was the last blocker that prevented me from being able to use the Arthur backend in my daily wo

D7949: Allow to print pdf doc directly into a QPrinter

sander marked 12 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D7949 To: sander, #okular Cc: cfeck, ltoscano, rkflx, michaelweghorn, ngraham, aacid

D7949: Allow to print pdf doc directly into a QPrinter

sander updated this revision to Diff 37025. sander added a comment. Implemented all suggestions concerning i18n and capitalization. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7949?vs=20606&id=37025 REVISION DETAIL https://phabricator.kde.org/D7949 AFFECTED FILES generators/

D7949: Allow to print pdf doc directly into a QPrinter

sander added a comment. Albert's main objection against this patch was that the Arthur backend is too bad to make the QPrinter approach worthwhile. Arthur has improved a bit since this patch was originally posted. It is still far from being perfect, but whether it is 'too bad' now depends

D7949: Allow to print pdf doc directly into a QPrinter

ngraham added a comment. What's the status of this patch? REVISION DETAIL https://phabricator.kde.org/D7949 To: sander, #okular Cc: cfeck, ltoscano, rkflx, michaelweghorn, ngraham, aacid

D7949: Allow to print pdf doc directly into a QPrinter

michaelweghorn added a comment. In https://phabricator.kde.org/D7949#154764, @sander wrote: > > Background: [...] and we plan to have some features implemented in the print dialog (for Qt/Okular). > > Can I learn more about this somewhere? Sorry for the late reply. We are work

D7949: Allow to print pdf doc directly into a QPrinter

rkflx added a comment. > Implement all of Henrik's suggestions. Had a final look, looks mostly good to me now – thanks. See below for some minor nits. (Could not mark my old inline comments as done, I guess the original author has to do that…). > I implemented a longer "What's this"

D7949: Allow to print pdf doc directly into a QPrinter

sander added a comment. Without having looked at the code, here is a hypothesis of how Kate can print to a pdf file and have the text remain selectable. The Arthur font drawing code uses the QPainter::drawGlyphRun method to paint individual glyphs/letters. That method only receives a posit

D7949: Allow to print pdf doc directly into a QPrinter

sander added a comment. > However when printing from Kate for example, the text is still selectable, so it seems to me like there might possibly be some way to maintain text when > printing in Qt. (?) That's interesting, but I don't currently have an idea how that is done. Somebody wou

D7949: Allow to print pdf doc directly into a QPrinter

michaelweghorn added a comment. In https://phabricator.kde.org/D7949#154351, @sander wrote: > > large filesize (5x), because of letters being vectors instead of fonts > > Yeah, I know about this one. There's nothing really do be done about this on the Okular side, this is Qt's doi

D7949: Allow to print pdf doc directly into a QPrinter

sander added a comment. Hi, thanks again for the review. I just updated the patch to include most of your suggestions. >> I tagged this option as 'experimental' in the GUI. > Having it only in the tooltip is definitely not enough, this should be directly in the combobox. The tooltip

D7949: Allow to print pdf doc directly into a QPrinter

sander updated this revision to Diff 20606. sander added a comment. Implement all of Henrik's suggestions. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7949?vs=19817&id=20606 REVISION DETAIL https://phabricator.kde.org/D7949 AFFECTED FILES generators/poppler/generator_pdf.cpp

D7949: Allow to print pdf doc directly into a QPrinter

sander added a comment. Hi guys, thanks for all the feedback. I'll look into it, but the next 10 days will be busy. There are two more Arthur patches submitted and awaiting review. (nice arxiv paper you are using for testing, btw. :-) ) REPOSITORY R223 Okular REVISION DETAIL http

D7949: Allow to print pdf doc directly into a QPrinter

ltoscano added a comment. In https://phabricator.kde.org/D7949#150283, @ngraham wrote: > Yes, your work here is much appreciated. > > Since this fixes grayscale printing, can you mark it with "BUG: 368758"? As long as it fixes the issue only (if I understand it correctly) with

D7949: Allow to print pdf doc directly into a QPrinter

ngraham added a comment. Yes, your work here is much appreciated. Since this fixes grayscale printing, can you mark it with "BUG: 368758"? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7949 To: sander, #okular Cc: rkflx, michaelweghorn, ngraham, aacid

D7949: Allow to print pdf doc directly into a QPrinter

rkflx added a comment. Great work, Oliver. If you want to spend your time on Arthur and make users happy that way, I'm all for it. Idea: Add a task (or multiple tasks) to the Okular workboard to track all printing and/or Arthur related work (otherwise it's difficult for reviewers to get

D7949: Allow to print pdf doc directly into a QPrinter

aacid added a comment. In https://phabricator.kde.org/D7949#148405, @sander wrote: > > Using QPrinter may be "official Qt", but that doens't mean better. > > That depends on how you look at it. The patch gives you fast printing without conversion to postscript. It is completely plat

D7949: Allow to print pdf doc directly into a QPrinter

sander added a comment. > Using QPrinter may be "official Qt", but that doens't mean better. That depends on how you look at it. The patch gives you fast printing without conversion to postscript. It is completely platform-agnostic, so there is no fiddling with lpr parameters anymore,

D7949: Allow to print pdf doc directly into a QPrinter

aacid added a comment. Using QPrinter may be "official Qt", but that doens't mean better. you and me know Arthur backend sucks, so i don't see this being of any use to the users. Why not simply finish the pdfprintpdf branch as i've suggested a few times already? REPOSITORY R223 O

D7949: Allow to print pdf doc directly into a QPrinter

sander created this revision. sander added a reviewer: Okular. Restricted Application added a project: Okular. REVISION SUMMARY This is the 'official' Qt way of printing. It avoids the conversion of pdf files to postscript that we do currently, and may fix a certain number of printer settings