Re: [OPEN-ILS-DEV] PATCH: srfsh.c (fprintf - fputs)

2008-03-10 Thread Mike Rylander
On Thu, Feb 28, 2008 at 1:30 AM, Scott McKellar [EMAIL PROTECTED] wrote: This patch replaces several calls to fprintf() or printf() with calls to fputs(), where we don't use conversion specifications. Applied. Since fputs() doesn't have to parse the output text for conversions, it should

Re: [OPEN-ILS-DEV] PATCH: opac.dtd (minor)

2008-03-10 Thread Mike Rylander
On Fri, Feb 29, 2008 at 5:28 PM, Karen Collier [EMAIL PROTECTED] wrote: Attached is a very minor patch to opac.dtd correcting a typo in bookbag as well as making some of the language more PINES neutral. Thanks, Karen, and welcome the code contributor family! (And, of course, thanks for all

Re: [OPEN-ILS-DEV] PATCH: osrf_prefork.c (latent bugs)

2008-03-10 Thread Mike Rylander
On Mon, Mar 3, 2008 at 12:15 AM, Scott McKellar [EMAIL PROTECTED] wrote: 1. Pedantic: I changed child_dead from an int to a sig_atomic_t, since we set it from a signal handler. 2. In check_children() and prefork_child_wait(), we prepare an input buffer for a read() by calling the

Re: [OPEN-ILS-DEV] PATCH: socket_bundle.c (latent bugs)

2008-03-10 Thread Mike Rylander
On Sat, Mar 1, 2008 at 5:38 PM, Scott McKellar [EMAIL PROTECTED] wrote: 1. In socket_open_unix_server() and socket_open_unix_client(), I added checks to make sure that the path parameter doesn't point to aomething too big to fit into the receiving buffer of the struct sockaddr_un. 2. In

Re: [OPEN-ILS-DEV] PATCH: utils.c (performance of file_to_string())

2008-03-10 Thread Mike Rylander
On Sun, Mar 9, 2008 at 11:56 AM, Scott McKellar [EMAIL PROTECTED] wrote: This patch changes the file_to_string function to use fread() instead of fgets(). Since we're loading the entire file into memory, there's no reason to load it one line at a time. Applied. I compared both versions

Re: [OPEN-ILS-DEV] check out problem

2008-03-10 Thread Bill Erickson
Jeff Edminster wrote: I’ve managed to load bibs, items, and borrowers. I can search and place holds on items without a problem. When I attempt to do a check out, however, I get the following error: Check Out Failed #3 { desc:null, ilsevent:1609, pid:4425, servertime:Mon Mar 10