Re: Reset eh timer if cmd is really making progress

2010-02-02 Thread Mike Christie
On 02/02/2010 03:39 AM, Ulrich Windl wrote: On 1 Feb 2010 at 11:52, Mike Christie wrote: [...] I was not sure though if I should check if any cmds to the target made progress or if any cmds to the same disk. It could be that just one disk went bad, so we might want to check per disk. However, t

Re: Reset eh timer if cmd is really making progress

2010-02-02 Thread Ulrich Windl
On 1 Feb 2010 at 11:52, Mike Christie wrote: [...] > I was not sure though if I should check if any cmds to the target made > progress or if any cmds to the same disk. It could be that just one disk > went bad, so we might want to check per disk. However, this could be the > first IO to the dis

Re: Reset eh timer if cmd is really making progress

2010-02-01 Thread Erez Zilber
On Tue, Feb 2, 2010 at 6:47 AM, Mike Christie wrote: > On 02/01/2010 01:21 PM, Mike Christie wrote: >> >> On 02/01/2010 11:52 AM, Mike Christie wrote: >>> >>> On 02/01/2010 05:14 AM, Erez Zilber wrote: When iscsi_eh_cmd_timed_out gets called, we can ask scsi-ml to give us more time

Re: Reset eh timer if cmd is really making progress

2010-02-01 Thread Mike Christie
On 02/01/2010 01:21 PM, Mike Christie wrote: On 02/01/2010 11:52 AM, Mike Christie wrote: On 02/01/2010 05:14 AM, Erez Zilber wrote: When iscsi_eh_cmd_timed_out gets called, we can ask scsi-ml to give us more time if the cmd is making progress (i.e. if there was some data transfer since the las

Re: Reset eh timer if cmd is really making progress

2010-02-01 Thread Mike Christie
On 02/01/2010 11:52 AM, Mike Christie wrote: On 02/01/2010 05:14 AM, Erez Zilber wrote: When iscsi_eh_cmd_timed_out gets called, we can ask scsi-ml to give us more time if the cmd is making progress (i.e. if there was some data transfer since the last timeout). The problem is that task->last_xf

Re: Reset eh timer if cmd is really making progress

2010-02-01 Thread Mike Christie
On 02/01/2010 05:14 AM, Erez Zilber wrote: When iscsi_eh_cmd_timed_out gets called, we can ask scsi-ml to give us more time if the cmd is making progress (i.e. if there was some data transfer since the last timeout). The problem is that task->last_xfer& task->last_timeout are set to the value o

Reset eh timer if cmd is really making progress

2010-02-01 Thread Erez Zilber
When iscsi_eh_cmd_timed_out gets called, we can ask scsi-ml to give us more time if the cmd is making progress (i.e. if there was some data transfer since the last timeout). The problem is that task->last_xfer & task->last_timeout are set to the value of 'jiffies' when allocating the task. If the