Re: Antw: [PATCH] open-iscsi-ldflags.patch

2011-08-29 Thread Ulrich Windl
Foo Bar cr...@haquarter.de schrieb am 26.08.2011 um 18:39 in Nachricht 352302b3-b77c-49cc-bc79-7c13ef684158@ea4g2000vbb.googlegroups. com: While patching it: Shouldn't -O2 -fno-inline be part of $(OPTFLAGS)? Hi Craig! So why add $(LDFLAGS) to $(OPTFLAGS)? Ulrich I guess so - here

Re: Antw: Re: [patch] iscsiadm cli help update

2011-08-29 Thread Ulrich Windl
Hi! Your patch looks much better, but I still see a maintenance problem in CMD_LINE_* and opt_help[]: It's a bit tricky to keep them in sync. I wonder if #define CMD_LINE_OPTION_PORTAL 0 or maybe better #define CLI_HELP_INDEX_PORTAL 0 and #define CLI_HELP_CHAR_PORTAL'p' /*

Re: Antw: Re: [patch] iscsiadm cli help update

2011-08-29 Thread Ulrich Windl
Ich schrieb am 29.08.2011 um 10:29 in Nachricht 4e5b69f102a17...@gwsmtp1.uni-regensburg.de: [...] Also the comment Calling tgetent again frees the buffer allocated by it. seems to to apply to ncurses as it ignored the buffer altogether (according Oops: Meant to write seems not to

[PATCH] libiscsi: uninline some functions

2011-08-29 Thread Jörn Engel
Hello Mike! I'm currently preparing a janitorial patch series and noticed that this one already collides with some of your changes. Can I leave it to you to fix up the collision and send on? Or maybe just run git grep ^inline drivers/scsi/*iscsi* and remove the inline from every line. Jörn --

open-iscsi 2.0.872 + 2.6.38 kernel build conflict

2011-08-29 Thread levail
Is there a version of 2.0.872 building on a 2.6.38 kernel? I need it bacuse I need to boot my 2.6.38 system (ubuntu 11.04 32 bit) with root on iSCSI. The 2.0.871 iscsid does not recconect the root device once started and I read on the net that 2.0.872 works. The kernel modules of the 2.0.872

Re: [PATCH] libiscsi: uninline some functions

2011-08-29 Thread Jörn Engel
On Fri, 26 August 2011 13:17:46 -0500, Mike Christie wrote: I can do that. I have been slowly removing the inlines. Will just do a group removal, and queue up for the next feature window. Cool! I'll leave these to you then. Jörn -- The story so far: In the beginning the Universe was

Re: Antw: Re: [patch] iscsiadm cli help update

2011-08-29 Thread Vivek S
Removed ordering constrains between #defines and structure elements. Removed calculating tab width and defaulting to 8. Hope this will do :-) On Mon, Aug 29, 2011 at 2:26 PM, Ulrich Windl ulrich.wi...@rz.uni-regensburg.de wrote: Ich schrieb am 29.08.2011 um 10:29 in Nachricht

Re: open-iscsi 2.0.872 + 2.6.38 kernel build conflict

2011-08-29 Thread Mike Christie
On 08/27/2011 09:54 AM, lev...@avia.kfkipark.hu wrote: Is there a version of 2.0.872 building on a 2.6.38 kernel? I need it bacuse I need to boot my 2.6.38 system (ubuntu 11.04 32 bit) with root on iSCSI. The 2.0.871 iscsid does not recconect the root device once started and I read on the net