Re: [PATCH RFC V1 2/3] SCSI/libiscsi: Reduce locking contention in fast path

2013-10-23 Thread Mike Christie
On 10/23/2013 11:07 AM, Mike Christie wrote: On 10/23/2013 06:16 AM, Shlomo Pongratz wrote: -Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Monday, October 21, 2013 7:06 PM To: Or Gerlitz Cc: open-iscsi@googlegroups.com; Roi Dayan; Shlomo Pongratz Subject:

Re: [PATCH RFC V1 2/3] SCSI/libiscsi: Reduce locking contention in fast path

2013-10-23 Thread Shlomo Pongratz
On 10/23/2013 7:12 PM, Mike Christie wrote: On 10/23/2013 11:07 AM, Mike Christie wrote: On 10/23/2013 06:16 AM, Shlomo Pongratz wrote: -Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Monday, October 21, 2013 7:06 PM To: Or Gerlitz Cc:

Re: [PATCH RFC V1 2/3] SCSI/libiscsi: Reduce locking contention in fast path

2013-10-23 Thread Or Gerlitz
On 23/10/2013 19:12, Mike Christie wrote: On 10/23/2013 11:07 AM, Mike Christie wrote: On 10/23/2013 06:16 AM, Shlomo Pongratz wrote: -Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Monday, October 21, 2013 7:06 PM To: Or Gerlitz Cc:

Re: [PATCH RFC V1 2/3] SCSI/libiscsi: Reduce locking contention in fast path

2013-10-23 Thread Or Gerlitz
On 23/10/2013 19:29, Shlomo Pongratz wrote: O.K. I'll rebase to Jame's misc branch (used to work on his for-next branch). Mike, aren't we expected to rebase against for-next re code that goes to the next kernel? anyway, the be2iscsi patches are on both branches.. so either would be fine

Re: [PATCH RFC V1 2/3] SCSI/libiscsi: Reduce locking contention in fast path

2013-10-23 Thread Mike Christie
On 10/23/2013 11:29 AM, Shlomo Pongratz wrote: On 10/23/2013 7:12 PM, Mike Christie wrote: On 10/23/2013 11:07 AM, Mike Christie wrote: On 10/23/2013 06:16 AM, Shlomo Pongratz wrote: -Original Message- From: Mike Christie [mailto:micha...@cs.wisc.edu] Sent: Monday, October 21, 2013

Re: [PATCH RFC V1 2/3] SCSI/libiscsi: Reduce locking contention in fast path

2013-10-23 Thread Or Gerlitz
On 23/10/2013 19:34, Mike Christie wrote: I am not sure what you are saying. I think when I wrote code in the first comment I meant code and comments. I just want you to change the comments in the above functions so instead of having something like: /** * iscsi_free_task - free a task *

Parallel Discovery?

2013-10-23 Thread The Lee-Man
Hi Mike: I have a configuration where discovery is taking a long time because one of the interfaces is disconnected. Since it is not possible to reliably detect when an interface is connected, I thought the best way to speed up discovery in such cases would be for discovery to take place in

Re: Parallel Discovery?

2013-10-23 Thread Mike Christie
On 10/23/2013 03:14 PM, The Lee-Man wrote: Hi Mike: I have a configuration where discovery is taking a long time because one of the interfaces is disconnected. Since it is not possible to reliably detect when an interface is connected, I thought the best way to speed up discovery in such