Re: [PATCH RFC] iser: support for reporting the current portal (address/port)

2011-01-16 Thread Or Gerlitz
Mike Christie wrote: > I was working on this patch. It seems to work for iser and cxgbi in the > normal case. iscsi_tcp is broken with it (there is debugging stuff in > iscsi_tcp.c so do not look at it for review purposes). Thanks for doing that, I tested it with 2.6.37 -- works just fine, e.g wi

Re: [PATCH 2/3] iscsi: fix iscsi_endpoint leak

2011-01-16 Thread Or Gerlitz
micha...@cs.wisc.edu wrote: > When iscsid restarts it does not know the connection's > endpoint, so it is getting leaked. This fixes the problem > by having the iscsi class force a disconnect before a > new connection is bound. I tested the patch with iser over .37 things work fine on the usual tr

Re: [PATCH RFC] iser: support for reporting the current portal (address/port)

2011-01-16 Thread Mike Christie
On 01/16/2011 02:55 AM, Or Gerlitz wrote: If we want to go simple, maybe we can use the approach of the (iser, cxgbi, etc) transport binding code to make a copy of the remote address in the form of the portal_port/address fields of struct iscsi_conn, e.g not remove these fields as done by your p

Re: [PATCH 2/3] iscsi: fix iscsi_endpoint leak

2011-01-16 Thread Mike Christie
On 01/16/2011 03:22 AM, Or Gerlitz wrote: micha...@cs.wisc.edu wrote: When iscsid restarts it does not know the connection's endpoint, so it is getting leaked. This fixes the problem by having the iscsi class force a disconnect before a new connection is bound. I tested the patch with iser ove