Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread James Bottomley
On Wed, 2015-01-07 at 15:39 -0600, Mike Christie wrote: > On 01/07/2015 10:57 AM, Hannes Reinecke wrote: > > On 01/07/2015 05:25 PM, Sagi Grimberg wrote: > >> Hi everyone, > >> > >> Now that scsi-mq is fully included, we need an iSCSI initiator that > >> would use it to achieve scalable performance

Re: [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread James Bottomley
On Thu, 2015-01-08 at 14:16 -0800, Nicholas A. Bellinger wrote: > On Thu, 2015-01-08 at 08:50 +0100, Bart Van Assche wrote: > > On 01/07/15 22:39, Mike Christie wrote: > > > On 01/07/2015 10:57 AM, Hannes Reinecke wrote: > > >> On 01/07/2015 05:25 PM, Sagi Grimberg wrote: > > >>> Hi everyone, > > >

Re: [Lsf-pc] [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread James Bottomley
On Thu, 2015-01-08 at 14:57 -0800, Nicholas A. Bellinger wrote: > On Thu, 2015-01-08 at 14:29 -0800, James Bottomley wrote: > > On Thu, 2015-01-08 at 14:16 -0800, Nicholas A. Bellinger wrote: > > > On Thu, 2015-01-08 at 08:50 +0100, Bart Van Assche wrote: > > > > On

Re: [Lsf-pc] [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-08 Thread James Bottomley
On Thu, 2015-01-08 at 21:03 -0800, Nicholas A. Bellinger wrote: > On Thu, 2015-01-08 at 15:22 -0800, James Bottomley wrote: > > On Thu, 2015-01-08 at 14:57 -0800, Nicholas A. Bellinger wrote: > > > On Thu, 2015-01-08 at 14:29 -0800, James Bottomley wrote: > > > > On

Re: [Lsf-pc] [LSF/MM TOPIC] iSCSI MQ adoption via MCS discussion

2015-01-09 Thread James Bottomley
On Fri, 2015-01-09 at 19:28 +0100, Hannes Reinecke wrote: [...] > > I think you are assuming we are leaving the iscsi code as it is today. > > > > For the non-MCS mq session per CPU design, we would be allocating and > > binding the session and its resources to specific CPUs. They would only > > b

Re: DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers)

2015-09-17 Thread James Bottomley
On Thu, 2015-09-17 at 08:33 +0300, Michael S. Tsirkin wrote: > On Wed, Sep 16, 2015 at 07:29:17PM -0500, Suman Anna wrote: > > The virtio core uses a static ida named virtio_index_ida for > > assigning index numbers to virtio devices during registration. > > The ida core may allocate some internal

Re: DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers)

2015-09-17 Thread James Bottomley
On Thu, 2015-09-17 at 19:06 +0300, Michael S. Tsirkin wrote: > On Thu, Sep 17, 2015 at 07:15:44AM -0700, James Bottomley wrote: > > On Thu, 2015-09-17 at 08:33 +0300, Michael S. Tsirkin wrote: > > > On Wed, Sep 16, 2015 at 07:29:17PM -0500, Suman Anna wrote: > > > >

Re: DEFINE_IDA causing memory leaks? (was Re: [PATCH 1/2] virtio: fix memory leak of virtio ida cache layers)

2015-09-17 Thread James Bottomley
On Thu, 2015-09-17 at 13:15 -0400, Tejun Heo wrote: > Hello, > > On Thu, Sep 17, 2015 at 09:48:37AM -0700, James Bottomley wrote: > > Well, there's an easy fix for that. We could have ida_remove() actually > > free the bitmap and not cache it if it's the last

Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

2016-02-12 Thread James Bottomley
On Fri, 2016-02-12 at 09:38 -0800, Lee Duncan wrote: > The scsi_transport_iscsi module already uses the ida_simple > routines for managing the target ID, if requested to do > so. This change replaces an ever-increasing atomic integer > that tracks the session ID itself with the ida_simple > family

Re: network namespace, netlink and sysfs changes for iSCSI (Re: [PATCH 0/9] use network namespace for iSCSI control interfaces)

2017-11-14 Thread James Bottomley
On Tue, 2017-11-07 at 10:01 -0800, Chris Leech wrote: > Hello, > > I have this set of changes to the iSCSI control interfaces pending > review, but seeing as it's sysfs and netlink changes there's not a > lot of feedback from linux-scsi. Well, it's a bit unlikely that they understand network name

Re: [PATCH] Check sk before sendpage

2019-07-10 Thread James Bottomley
On Wed, 2019-07-10 at 17:47 +, Lee Duncan wrote: > On 7/10/19 12:30 AM, Yang Bin wrote: > > > From: " Yang Bin " > > > > Before xmit,iscsi may disconnect just now. > > So must check connection sock NULL or not,or kernel will crash for > > accessing NULL pointer. > > > > Signed-off-by: Yang B

Re: [PATCH] scsi: iscsi: Switch to using the new API kobj_to_dev()

2021-03-07 Thread James Bottomley
On Mon, 2021-03-08 at 11:34 +0800, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/scsi/scsi_transport_iscsi.c:930:60-61: WARNING opportunity > for kobj_to_dev(). I have to ask, what is the point of this? container_of is usually pretty safe ... as in it will detect wh

Re: [PATCH 0/3 ver2] iscsi bidi & varlen support

2008-02-18 Thread James Bottomley
On Mon, 2008-02-18 at 17:08 +0200, Boaz Harrosh wrote: > But ... James? is > there any chance these can go into scsi-rc-fixes for the 2.6.25 > kernel? The reason they are so late was mainly because of a fallout > in the merge process and a bug that was introduced because of that, > but they were i

Re: [PATCH] iscsi_tcp - make padbuf non-static

2009-01-14 Thread James Bottomley
On Thu, 2009-01-08 at 15:06 -0600, Mike Christie wrote: > Karen Xie wrote: > > [PATCH] iscsi_tcp - make padbuf non-static > > > > From: Karen Xie > > > > virt_to_page() call should not be used on kernel text and data addresses. > > virt_to_page() is used by sg_init_one(). So change padbuf to be

Re: [PATCH 1/2 2.6.30-rc] cxgb3i -- add a refcnt to track ddp usage

2009-06-24 Thread James Bottomley
On Sat, 2009-06-13 at 14:29 -0700, k...@chelsio.com wrote: > [PATCH 1/2 2.6.30-rc] cxgb3i -- add a refcnt to track ddp usage > > From: Karen Xie > > The iscsi ddp functionality could be used by multiple iscsi entities, > add a refcnt to keep track of it, so we would not release it pre-maturely.

Re: [PATCH 2.6.30-rc] cxgb3i -- fixed connection error when vlan is enabled

2009-06-27 Thread James Bottomley
On Sat, 2009-06-27 at 12:52 -0500, Mike Christie wrote: > On 06/26/2009 05:17 PM, k...@chelsio.com wrote: > > [PATCH 2.6.30-rc] cxgb3i -- fixed connection error when vlan is enabled > > > > From: Karen Xie > > > > There is a bug when VLAN is configured on the cxgb3 interface, the iscsi > > conn. w

Re: [PATCH 1/5] BNX2I - Add 5771E device support to bnx2i driver

2009-12-10 Thread James Bottomley
On Wed, 2009-12-09 at 20:45 -0600, Mike Christie wrote: > Reviewed-by: Mike Christie But not by checkpatch: ERROR: trailing whitespace #23: FILE: drivers/scsi/bnx2i/bnx2i_init.c:90: +^I^Iprintk(KERN_ALERT "bnx2i: unknown device, 0x%x\n", $ total: 1 errors, 0 warnings, 13 lines checked I've fix

Re: [PATCH 0/8] Added bug fixes and several features for BNX2I

2011-01-07 Thread James Bottomley
On Wed, 2011-01-05 at 12:44 -0800, Eddie Wai wrote: > Hello, > > This patch set contains two fixes and added various features as titled. > The two fixes are: > 1 - connection cleanup fix which fixes a chip panic issue > 2 - nopout LUN field fix which fixes nopout timeouts So the immediate que

Re: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-15 Thread James Bottomley
On Mon, 2011-03-14 at 20:09 -0700, Greg KH wrote: > On Mon, Mar 14, 2011 at 10:26:05PM -0400, James Bottomley wrote: > > On Sat, 2011-03-12 at 23:23 +0300, Vasiliy Kulikov wrote: > > > > Vasiliy Kulikov (20): > > > > mach-ux500: mbox-db5500: world-writable sysf

Re: [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-15 Thread James Bottomley
On Sat, 2011-03-12 at 23:23 +0300, Vasiliy Kulikov wrote: > > Vasiliy Kulikov (20): > > mach-ux500: mbox-db5500: world-writable sysfs fifo file > > leds: lp5521: world-writable sysfs engine* files > > leds: lp5523: world-writable engine* sysfs files > > misc: ep93xx_pwm: world-writable sysfs fi

Re: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-15 Thread James Bottomley
On Tue, 2011-03-15 at 07:18 -0700, Greg KH wrote: > On Tue, Mar 15, 2011 at 07:50:28AM -0400, James Bottomley wrote: > > On Mon, 2011-03-14 at 20:09 -0700, Greg KH wrote: > > > There are no capability checks on sysfs files right now, so these all > > > need to be fixed.

Re: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-15 Thread James Bottomley
On Tue, 2011-03-15 at 19:08 +0300, Vasiliy Kulikov wrote: > On Tue, Mar 15, 2011 at 07:50 -0400, James Bottomley wrote: > > 1. Did anyone actually check for capabilities before assuming world > > writeable files were wrong? > > I didn't check all these fi

Re: [PATCH 3/4 v2] BNX2I: Changed the nopout_wqe->lun memcpy to use sizeof instead

2011-06-30 Thread James Bottomley
On Fri, 2011-06-24 at 15:20 -0500, Mike Christie wrote: > On 06/23/2011 05:51 PM, Eddie Wai wrote: > > Modified the memcpy of nopout_wqe->lun to use sizeof(struct scsi_lun) > > instead of the hardcoded value 8 as noted by review comments. > > > > Signed-off-by: Eddie Wai > > --- > > drivers/scsi

Re: [PATCH] SCSI: amd_iommu dma_boundary overflow

2013-02-21 Thread James Bottomley
This is a bit tricky, since AMD laid off the team who were maintaining this, but I added to the cc' one of the original maintainers in the hopes they can take a look. James On Tue, 2013-02-19 at 18:30 -0800, Eddie Wai wrote: > Hello, > > For a 64-bit DMA capable PCIe storage HBA running under t

Re: [PATCH 33/38] scsi: transport: add missing put_device call

2013-12-22 Thread James Bottomley
On Thu, 2013-12-19 at 16:06 +0100, Levente Kurusa wrote: > This is required so that we give up the last reference to the device. This isn't true. > Remove the kfree() as well, because the put_device() will result in > iscsi_endpoint_release being called and hence it will be kfree'd. There's no r