>>>>> "Lee" == Lee Duncan writes:
Lee> It looks like Mike and Chris are good with it.
However, it received no formal reviews or acked-bys...
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Googl
>>>>> "Lee" == Lee Duncan writes:
Lee,
Lee> Chris Leech and I are taking over as open-iscsi maintainers.
Do you want me to queue the MAINTAINER update?
Lee> * Removed git repository, since code in tree
Is it your plan to go through the SCSI tree?
--
Marti
ing list and repository for a while,
Lee> now.
Yep. Just wanted to make sure.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop r
se supported kernels have been backing out the lock
Chris> split for while now, thanks to the efforts at IBM where a lab
Chris> setup has the most reliable reproducer I've seen on this issue.
Chris> This patch has been tested there successfully.
Reviews, please!
--
Martin K. Peterse
>>>>> "Chris" == Chris Leech writes:
Chris> There's a rather long standing regression from the commit
Chris> "libiscsi: Reduce locking contention in fast path"
Applied to 4.11/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
Elena Reshetova writes:
> refcount_t type and corresponding API should be used instead of
> atomic_t when the variable is used as a reference counter. This allows
> to avoid accidental refcounter overflows that might lead to
> use-after-free situations.
Applied to 4.12/scsi-queue.
Kyle,
> Use kvzalloc for iscsi_pool in iscsi_pool_init.
Applied to 4.13/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this g
Bhumika,
> Make these const as they are only stored in the type field of a device
> structure, which is const.
Applied to 4.14/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"
Chris,
> Looks good to me, fixes up the code given that the comment there about
> calling iscsi_remove_session wasn't being followed.
Applied these two to 4.14/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscr
Khazhismel,
> Noticed these don't seem to be in 4.14/scsi-queue
Not sure what happened there. I apologize.
They are now in 4.14/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open
Kees,
> In preparation for unconditionally passing the struct timer_list
> pointer to all timer callbacks, switch to using the new timer_setup()
> and from_timer() to pass the timer pointer explicitly.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux En
Arvind,
> Trivial fix to spelling mistakes in 'iscsi_get_host_stats'.
Applied to 4.15/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe f
s
> sd_sync_cache() logic, after issuing the SYNCHRONIZE_CACHE cmd to all
> still existent paths.
Chris and Lee: Please review. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" grou
ng forever on its
> sd_sync_cache() logic, after issuing the SYNCHRONIZE_CACHE cmd to all
> still existent paths.
Applied to 4.16/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi
> Never directly free @dev after calling device_register(), even
> if it returned an error! Always use put_device() to give up the
> reference initialized.
Lee, Chris: Please review!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are s
_CAP_STABLE_WRITES when data digest is enabled
> in iscsi_tcp .slave_configure callback.
Lee, Chris: Please review!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscrib
;
> To fix this, set BDI_CAP_STABLE_WRITES when data digest is enabled
> in iscsi_tcp .slave_configure callback.
Applied to 4.16/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group
nitramfs are just
> running into misrouted responses that this fixes.
Applied to 4.17/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and
Fred,
> This commit addresses NULL pointer dereference in
> iscsi_eh_session_reset. Reference should not be made to
> session->leadconn when session->state is set to ISCSI_STATE_TERMINATE.
Applied to 4.20/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engin
Fred,
> This commit enhances iscsi initiator modules to capture iscsi debug
> messages using linux kernel tracepoint facility:
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the
Bob,
> When a target sends Check Condition, whilst initiator is busy xmiting
> re-queued data, could lead to race between iscsi_complete_task() and
> iscsi_xmit_task() and eventually crashing with the following kernel
> backtrace.
Applied to 5.0/scsi-fixes, thanks!
--
Martin
Vasily,
> James, Martin, noone replied 2 weeks, could you please pick up this
> patch?
No objections from me wrt. to the change. However, I am awaiting a
review from the iSCSI maintainers Lee and Chris.
--
Martin K. Petersen Oracle Linux Engineering
--
You received this m
Vasily,
> In "XFS over network block device" scenario XFS can create IO requests
> with slab-based XFS metadata. During processing such requests
> tcp_sendpage() can merge skb fragments with neighbour slab objects.
Applied to 5.1/scsi-queue, thanks!
--
Martin K. Peterse
Christoph,
> Use the the GPLv2 SPDX tag instead of verbose boilerplate text.
Applied to 5.3/scsi-queue except for patch #24.
Patch #13 used /* */ syntax on some of the .c files. I fixed those up.
--
Martin K. Petersen Oracle Linux Engineering
ple, a client only send msg without calling recvmsg func,
> then it will result in the watchdog soft lockup.
> The details are given as follows,
Lee/Chris/Ulrich: Please review!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to
> succeeded before trying to use the socket.
Applied to 5.5/scsi-queue. But please make sure to send patch
submissions to linux-s...@vger.kernel.org.
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"o
Gabriel,
> A faulty userspace that calls destroy_session() before destroying the
> connections can trigger the failure. This patch prevents the issue by
> refusing to destroy the session if there are outstanding connections.
Ditto. Please send to linux-scsi@vger.
--
Martin K.
Gabriel,
> Although, looks like the MAINTAINERS file doesn't list linux-scsi as
> the target for iscsi patches. Would you take the fix below to address
> that?
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this messa
example, a client only send msg without calling recvmsg func, then
> it will result in the watchdog soft lockup. The details are given as
> follows,
> Signed-off-by: Bo Wu
> Reviewed-by: Zhiqiang Liu
> Reviewed-by: Lee Duncan
I haven't seen a Reviewed-by: from Lee
t I guess that's just
personal taste.
Applied to 5.5/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails f
Gabriel,
> A faulty userspace that calls destroy_session() before destroying the
> connections can trigger the failure. This patch prevents the issue by
> refusing to destroy the session if there are outstanding connections.
Applied to 5.6/scsi-queue, thanks!
--
Martin K.
ely inside the kernel.
> This way, the failover can happen and pending IO can continue even if
> the daemon is dead. Once the daemon comes alive again, it can execute
> recovery procedures if applicable.
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message
ttribute_container_device
> trigger version.
Applied to 5.6/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving email
didn't either.
In any case: Applied to 5.7/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from
Gustavo,
> The current codebase makes use of the zero-length array language
> extension to the C90 standard, but the preferred mechanism to declare
> variable-length types such as these ones is a flexible array
> member[1][2], introduced in C99:
Applied to 5.7/scsi-queue, thanks.
eration
> is queued and before it is performed. This change allow other
> operations to run in other sessions in the meantime, removing one of
> the major iSCSI bottlenecks for us.
Applied to 5.7/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received thi
open-iscsi tries to
> reopen every connection, but on different initiators, we'd like to
> know which connections have failed.
Applied to 5.7/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Googl
wubo,
> Fix an error count for active session if the total_cmds is invalid on
> the function iscsi_session_setup(). decrement the number of active
> sessions before the func return.
Applied to 5.7/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You rece
tely mangled. Please
use git send-email to submit patches in the future! Thanks!
Applied to 5.7/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this gr
ad_workqueue("iscsi_eh");
> + iscsi_eh_timer_workq = alloc_workqueue("%s",
> + WQ_SYSFS | __WQ_LEGACY | WQ_MEM_RECLAIM | WQ_UNBOUND,
> + 2, "iscsi_eh");
> if (!iscsi_eh_timer_workq) {
> err = -ENOME
nn = iscsi_conn_lookup(ev->u.stop_conn.sid,
> ev->u.stop_conn.cid);
> if (conn)
> - transport->stop_conn(conn, ev->u.stop_conn.flag);
> + iscsi_if_stop_conn(conn, ev->u.stop_conn.flag);
> else
> err = -EINVAL;
>
Gabriel,
> iscsi suffers from a deadlock in case a management command submitted
> via the netlink socket sleeps on an allocation while holding the
> rx_queue_mutex,
This does not apply to 5.8/scsi-queue. Please resubmit.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
csi: iscsi: Fix deadlock on recovery path during GFP_IO reclaim
https://git.kernel.org/mkp/scsi/c/7e7cd796f277
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from
o 2, because "cpumask" of
> ordered workqueue isn't allowed to change.
>
> [...]
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: iscsi: Register sysfs for iscsi workqueue
https://git.kernel.org/mkp/scsi/c/3ce419662dd4
--
Martin K. Petersen Oracle Linux Engineeri
://git.kernel.org/mkp/scsi/c/0267ffce562c
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to open-iscsi+unsu
'cpumask' can be modified when max_active = 1.
>
> This patch change back max_active to 1 so as to keep the same behaviour as
> before.
Applied to 5.8/scsi-fixes, thanks!
[1/2] scsi: iscsi: Change iSCSI workqueue max_active back to 1
https://git.kernel.org/mkp/scsi/c/1a982
thread_workqueue(), added WQ_SYSFS and drop
> __WQ_ORDERED_EXPLICIT since __WQ_ORDERED_EXPLICIT workqueue isn't allowed to
> change "cpumask".
Applied to 5.9/scsi-queue, thanks!
[1/1] scsi: iscsi: Register sysfs for workqueue iscsi_destroy
https://git.kernel.org/mkp/scsi/c/91
https://git.kernel.org/mkp/scsi/c/68e12e5f6135
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to ope
t;= 1 && !PageSlab(sg_page(sg)" part is to
> make sure the page can be sent to network layer's zero copy path. This
> part is exactly what sendpage_ok() does.
>
> This patch uses use sendpage_ok() in iscsi_tcp_segment_map() to replace
> the original open coded checks
t;[SCSI] iscsi_tcp: use iscsi_conn_get_addr_param
> libiscsi function") introduced getpeername() within the session spinlock.
>
> [...]
Applied to 5.9/scsi-fixes, thanks!
[1/1] scsi: iscsi: iscsi_tcp: Avoid holding spinlock while calling getpeername()
https://git.kernel.org/mkp/scsi/c
Mauro,
> Some identifiers have different names between their prototypes and the
> kernel-doc markup.
Applied to 5.11/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-i
t; when the pointer is actually in the process of being set.
>
> [...]
Applied to 5.10/scsi-fixes, thanks!
[1/1] scsi: libiscsi: Fix NOP race condition
https://git.kernel.org/mkp/scsi/c/fe0a8a95e713
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message be
scsi: iscsi: fix inappropriate use of put_device
https://git.kernel.org/mkp/scsi/c/6dc1c7ab6f04
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and
Zhen,
> Fix some spelling mistakes in comments:
> pathes ==> paths
> Resouce ==> Resource
> retreived ==> retrieved
> keep-alives ==> keep-alive
> recevied ==> received
> busses ==> buses
> interruped ==> interrupted
Applied to 5.14/scsi-staging
=> interrupted
Applied to 5.14/scsi-queue, thanks!
[1/1] scsi: Fix spelling mistakes in header files
https://git.kernel.org/mkp/scsi/c/40d6b939e4df
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-isc
> days.
In the context of electronics and computing "busses" still appears to be
widely in use. In any case, whether to use one or the other is up to the
author of the code in question. I only merged fixed for what was obvious
typos.
Thanks!
--
Martin K. Petersen Oracle Linu
visible in sysfs. Found in code review.
>
>
Applied to 5.15/scsi-fixes, thanks!
[1/1] scsi: iscsi: Adjuest iface sysfs attr detection
https://git.kernel.org/mkp/scsi/c/4e2855082925
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are s
in iscsi_session_setup() to prevent reinit by mistake,
> also in case we can handle multiple conns in the future.
Applied to 5.16/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-is
it.kernel.org/mkp/scsi/c/e018f03d6ccb
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to open-iscsi+unsubscr.
Wenchao,
> We found a NULL pointer dereference in iscsi_sw_tcp_conn_get_param(),
> the root reason is we did sysfs addition wrong.
Applied to 5.18/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the
i: Add iscsi_cls_conn to sysfs after been initialized
https://git.kernel.org/mkp/scsi/c/7dae459f5e56
[3/3] scsi:libiscsi: teradown iscsi_cls_conn gracefully
https://git.kernel.org/mkp/scsi/c/8709c323091b
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message be
Wenchao,
> iscsi_cls_conn is alloced by kzalloc(), the whole iscsi_cls_conn is
> zero filled already including the dd_data. So it is unnecessary to
> call memset again.
Applied to 5.18/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received thi
i-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to open-iscsi+unsubscr...@googlegroups.com.
e an issue at run time.
>
>
Applied to 5.19/scsi-queue, thanks!
[1/1] scsi: iscsi: fix harmless double shift bug
https://git.kernel.org/mkp/scsi/c/565138ac5f8a
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Goo
keliu,
> Use ida_alloc()/ida_free() instead of deprecated
> ida_simple_get()/ida_simple_remove() .
Applied to 5.20/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi
3fd3a52ca672
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to open-iscsi+unsubscr...@googlegroups.com.
To v
ks!
[1/1] scsi: iscsi: prefer xmit of DataOut before new cmd
https://git.kernel.org/mkp/scsi/c/65080c51fde4
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from t
si: fix possible memory leak when device_register failed
https://git.kernel.org/mkp/scsi/c/f014165faa7b
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group
Wenchao,
> There are two iscsi_set_param() functions individually defined in
> libiscsi.c and scsi_transport_iscsi.c which is confused.
Applied to 6.2/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed
Wenchao,
> Following scenario would make scsi_device's iodone_cnt mismatch with
> iorequest_cnt even if there is no request on this device any more.
Applied to 6.2/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message beca
scsi-queue, thanks!
[1/1] scsi:iscsi: rename iscsi_set_param to iscsi_if_set_param
https://git.kernel.org/mkp/scsi/c/0c26a2d7c980
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" gro
#x27;s iorequest_cnt if dispatch failed
https://git.kernel.org/mkp/scsi/c/cfee29ffb45b
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop re
Wenchao,
> I found an issue that kernel would send ISCSI_KEVENT_UNBIND_SESSION
> for multiple times which should be fixed.
Applied to 6.2/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google
YueHaibing,
> This is not used anymore, so can be removed.
Applied to 6.6/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this g
Lin,
> The current NETLINK_ISCSI netlink parsing loop checks every nlmsg to
> make sure the length is bigger than the sizeof(struct iscsi_uevent)
> and then calls iscsi_if_recv_msg(...).
Applied to 6.6/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Lin,
> The function iscsi_if_set_param and iscsi_if_set_host_param converts
> nlattr payload to type char* and then call C string handling functions
> like sscanf and kstrdup.
Applied to 6.6/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You rece
On Tue, 25 Jul 2023 22:15:31 +0800, YueHaibing wrote:
> This is not used anymore, so can be removed.
>
>
Applied to 6.6/scsi-queue, thanks!
[1/1] scsi: iscsi: Remove unused extern declaration iscsi_lookup_iface()
https://git.kernel.org/mkp/scsi/c/a615e93d6cfe
--
Martin K.
msg_len < sizeof(*nlh) + sizeof(*ev) ||
> skb->len < nlh->nlmsg_len) {
> break;
> }
> ...
> err = iscsi_if_recv_msg(skb, nlh, &group);
>
> [...]
Applied to 6.6/scsi-queue, thanks!
[1/2] scsi: iscsi: Add length check for nlattr payload
ht
> and hostbyte, driverbyte, statusbyte, and sense data for specific SCSI
> Command. Two new error injection is defined to make abort command or
> reset LUN failed.
Please review patches 7 through 10. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message be
ging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to open-iscsi+unsubscr...@googlegroups.com.
T
o_lld_bus const
https://git.kernel.org/mkp/scsi/c/ac0dd0f33adb
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from i
7;s kind of unfriendly to not send a check condition...
Mike> I think we should implement handling in the iscsi layer for it. I
Mike> can make a patch if you have not already.
It would be awfully nice to get it turned into an ILLEGAL
REQUEST/0x20/0x0.
--
Martin K. Petersen Oracle Linux Eng
reporting.
The WRITE SAME problem was that the target returns an iSCSI-specific
error code rather than a check condition with ILLEGAL REQUEST. You were
going to talk to MS.
However, if somebody sends me the relevant INQUIRY strings for the MS
target I'll add it to the WRITE SAME quirk li
t good strings and revs to match on. Obviously setting no_write_same
for all iSCSI targets is a no-go.
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group a
roduct/version info:
Just sent out a proposed patch.
--
Martin K. Petersen Oracle Linux Engineering
--
You received this message because you are subscribed to the Google Groups
"open-iscsi" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to o
> I think the last use of this list was removed by
> commit 23d6fefbb3f6 ("scsi: iscsi: Fix in-kernel conn failure
> handling").
>
> Build tested only.
Applied to 6.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
--
You received thi
86 matches
Mail list logo
