Re: [PATCH 1/4] libiscsi: Check TMF state before sending PDU

2009-09-10 Thread Mike Christie
On 08/13/2009 02:58 AM, Hannes Reinecke wrote: Before we're trying to send a PDU we have to check whether a TMF is active. If so and if the PDU will be affected by the TMF we should allow only Data-out PDUs to be sent, or, if fast_abort is set, no PDUs at all. Hey, I updated this patch with

Re: [PATCH 1/4] libiscsi: Check TMF state before sending PDU

2009-08-17 Thread Hannes Reinecke
Mike Christie wrote: I think something got dropped by accident when you redid your patchset. There is a missing memset(hdr, 0, sizeof(*hdr)); for iscsi_eh_device_reset. Oh, correct. Will be redoing the patch. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage

Re: [PATCH 1/4] libiscsi: Check TMF state before sending PDU

2009-08-15 Thread Mike Christie
On 08/14/2009 01:23 AM, Hannes Reinecke wrote: Mike Christie wrote: Hannes Reinecke wrote: Before we're trying to send a PDU we have to check whether a TMF is active. If so and if the PDU will be affected by the TMF we should allow only Data-out PDUs to be sent, or, if fast_abort is set, no

Re: [PATCH 1/4] libiscsi: Check TMF state before sending PDU

2009-08-15 Thread Mike Christie
I think something got dropped by accident when you redid your patchset. There is a missing memset(hdr, 0, sizeof(*hdr)); for iscsi_eh_device_reset. On 08/13/2009 02:58 AM, Hannes Reinecke wrote: @@ -2050,6 +2135,7 @@ int iscsi_eh_abort(struct scsi_cmnd *sc)

Re: [PATCH 1/4] libiscsi: Check TMF state before sending PDU

2009-08-14 Thread Hannes Reinecke
Mike Christie wrote: Hannes Reinecke wrote: Before we're trying to send a PDU we have to check whether a TMF is active. If so and if the PDU will be affected by the TMF we should allow only Data-out PDUs to be sent, or, if fast_abort is set, no PDUs at all. You sort of changed the

[PATCH 1/4] libiscsi: Check TMF state before sending PDU

2009-08-13 Thread Hannes Reinecke
Before we're trying to send a PDU we have to check whether a TMF is active. If so and if the PDU will be affected by the TMF we should allow only Data-out PDUs to be sent, or, if fast_abort is set, no PDUs at all. Signed-off-by: Mike Christie micha...@cs.wisc.edu Signed-off-by: Hannes Reinecke