Re: Incorporating uIP to the open-iscsi initiator package

2011-05-09 Thread Mike Christie

On 05/09/2011 12:58 PM, Eddie Wai wrote:

Resending to a bigger audience.

Hello,

There has been a lot of talks in the past about incorporating uIP into
the vanilla open-iscsi package (or so we called making uIP upstream)
instead of just having it be distro specific.  Our plan is to break
this effort down into a few steps and I like to hear your opinion about
it.

uIP is coded as a multi-threaded binary while open-iscsi is still
single threaded.  Ideally and ultimately, we would want uIP and
open-iscsi to run as a single binary in an multi-threaded environment.
However, I think we should approach that goal one step at a time as
follows:

(a) Upstream as 2 separate binaries first so uIP can still run the same
way (multi-threaded) while open-iscsi can still run the same way as a
single threaded binary.

(b) Convert uIP to run as a static library.  Use a wrapper for uIP so
it can still run as separate binaries.  At this time, other vendors can
participate in customizing uIP for their own needs.

(c) Unified the two to run as a single binary.  This would require a lot
of integration between uIP and open-iscsi (ex: socket communication,
common logging, stdout, etc.).  We can foresee there will be many timing
issues arise.  This will be the final step toward unification.

As indicated in (a) above, we would like to see if we can upstream the
latest uIP that we have as-is which contains various fixes in addition
to features like IPv6 NDP, Static/DHCPv6, logrotate, etc.  Then we would
proceed to update the code as we progress through the steps described
above.

This also means that the corresponding uip patches in the distros are
also to be incorporated in the package by default.

Please let us know if this approach is acceptable so we can move on with
the integration.



Overall I am ok with this.

Hannes, do you guys have any concerns over the licensing in the uip code?

--
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/open-iscsi?hl=en.



Incorporating uIP to the open-iscsi initiator package

2011-05-09 Thread Eddie Wai
Resending to a bigger audience.

Hello,

There has been a lot of talks in the past about incorporating uIP into
the vanilla open-iscsi package (or so we called making uIP upstream)
instead of just having it be distro specific.  Our plan is to break
this effort down into a few steps and I like to hear your opinion about
it.

uIP is coded as a multi-threaded binary while open-iscsi is still
single threaded.  Ideally and ultimately, we would want uIP and
open-iscsi to run as a single binary in an multi-threaded environment.
However, I think we should approach that goal one step at a time as
follows:

(a) Upstream as 2 separate binaries first so uIP can still run the same
way (multi-threaded) while open-iscsi can still run the same way as a
single threaded binary.

(b) Convert uIP to run as a static library.  Use a wrapper for uIP so
it can still run as separate binaries.  At this time, other vendors can
participate in customizing uIP for their own needs.

(c) Unified the two to run as a single binary.  This would require a lot
of integration between uIP and open-iscsi (ex: socket communication,
common logging, stdout, etc.).  We can foresee there will be many timing
issues arise.  This will be the final step toward unification.

As indicated in (a) above, we would like to see if we can upstream the
latest uIP that we have as-is which contains various fixes in addition
to features like IPv6 NDP, Static/DHCPv6, logrotate, etc.  Then we would
proceed to update the code as we progress through the steps described
above.

This also means that the corresponding uip patches in the distros are
also to be incorporated in the package by default.

Please let us know if this approach is acceptable so we can move on with
the integration.

Thanks,
Eddie


-- 
You received this message because you are subscribed to the Google Groups 
"open-iscsi" group.
To post to this group, send email to open-iscsi@googlegroups.com.
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/open-iscsi?hl=en.