Re: [PATCH 2/2] open-iscsi: kernel/Makefile: Better Makefile output when compiling with new Kernels
Mike Christie wrote: > Boaz Harrosh wrote: >> In case we are compiling against a newer kernel then what the out-of-tree >> is expecting, Output to the user that use of in-tree modules are recommended. >> >> This will still fail the compilation. because we don't want to compile in >> that >> case. But the user can see that this is an acceptable situation and he can >> proceed. >> >> [Mike we could: return with @exit 0 and let the Makefile attempt a >> compilation, >> but I think it is better this way?] >> >> Signed-off-by: Boaz Harrosh >> --- >> kernel/Makefile |5 + >> 1 files changed, 5 insertions(+), 0 deletions(-) >> >> diff --git a/kernel/Makefile b/kernel/Makefile >> index b29cfed..9bfd5db 100644 >> --- a/kernel/Makefile >> +++ b/kernel/Makefile >> @@ -101,6 +101,11 @@ linux_2_6_28: $(unpatch_code) >> >> linux_2_6_29: $(unpatch_code) >> >> +linux_2_6_%: $(unpatch_code) >> +@echo "Compiling against:" $@ >> +@echo "With new Kernels, use iscsi modules that came with the Kernel" >> +@exit 1 >> + > > This actually catches distro kernels. > Yes it does, Drop it for now, I'll look into it. Boaz --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---
Re: [PATCH 2/2] open-iscsi: kernel/Makefile: Better Makefile output when compiling with new Kernels
Boaz Harrosh wrote: > > In case we are compiling against a newer kernel then what the out-of-tree > is expecting, Output to the user that use of in-tree modules are recommended. > > This will still fail the compilation. because we don't want to compile in that > case. But the user can see that this is an acceptable situation and he can > proceed. > > [Mike we could: return with @exit 0 and let the Makefile attempt a > compilation, > but I think it is better this way?] > > Signed-off-by: Boaz Harrosh > --- > kernel/Makefile |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/kernel/Makefile b/kernel/Makefile > index b29cfed..9bfd5db 100644 > --- a/kernel/Makefile > +++ b/kernel/Makefile > @@ -101,6 +101,11 @@ linux_2_6_28: $(unpatch_code) > > linux_2_6_29: $(unpatch_code) > > +linux_2_6_%: $(unpatch_code) > + @echo "Compiling against:" $@ > + @echo "With new Kernels, use iscsi modules that came with the Kernel" > + @exit 1 > + This actually catches distro kernels. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---
